[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)

2023-10-15 Thread Enrico Tröger via Github-comments
> I NAK'd the theme but I don't want to block any Adwaita-replacement so please > go for it. Alright. https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme provides users with instructions on how to change the theme and there are also alternatives linked. I guess this is all an

[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 704aaa1e622b4d41ecf8a53109b64aaa574a50c2 Add Prof-Gnome Windows specific patch -- View it on GitHub: https://github.com/geany/geany/pull/3129/files/18886248cb10c53e2a140d213e613c93a73aa011..704aaa1e622b4d41ecf8a53109b64aaa574a50c2 You are receiving this because you are

[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)

2023-10-15 Thread Enrico Tröger via Github-comments
Sorry for being late, I just thought this might be also good for the dark variant of the theme? Currently it uses the large statusbar. ![Screenshot_2023-10-15_10-15-16](https://github.com/geany/geany-osx/assets/617017/254a6d28-ce42-4602-b20b-e92826cc4f9f) -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-14 Thread Enrico Tröger via Github-comments
@ntrel @elextr I tested and it works great. Apart from the little remark on the docs, I'm fine with this. About the section comment in the docs, this is no big deal, we can also leave as it is. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)

2023-10-14 Thread Enrico Tröger via Github-comments
Yesterday I noticed that the GeanyLua plugin also uses Scintilla 5.x API and so the version requirement bump is more than justified I think. Adding conditionals in mutiple plugins only for a hypothetical backwards compability seems not very reasonable. -- Reply to this email directly or view

[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-14 Thread Enrico Tröger via Github-comments
FTR: the used theme on the screenshot is Inkpot. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1281#issuecomment-1762742754 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)

2023-10-14 Thread Enrico Tröger via Github-comments
@elextr just for you, the classic last minute Windows fix. This was removed as part of https://github.com/geany/geany/pull/3465 a few months ago. I was very sure I tested this properly but it turned out that the explicit link to `libiconv` is necessary for building on Windows. However it is

[Github-comments] [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)

2023-10-14 Thread Enrico Tröger via Github-comments
This was removed in e465a2b456e7c0aba6aefc1c4b406b8089386d1a erroneously but it still needed on Windows/mingw64 builds. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3600 -- Commit Summary -- * Link to libiconv explicitly for

[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)

2023-10-14 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#pullrequestreview-1677927392 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)

2023-10-14 Thread Enrico Tröger via Github-comments
+1 let's merge. Successfully tested on native Windows with Git installed and without, with `.git` vailable and without. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#issuecomment-1762740662 You are receiving this because you are subscribed to

[Github-comments] [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-14 Thread Enrico Tröger via Github-comments
We missed to update `scripts/version-bump` for Meson and so `meson.build` still thought we are about to release Geany 1.38 :smile:. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3599 -- Commit Summary -- * Update meson.build also on

[Github-comments] [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Enrico Tröger via Github-comments
If the Change history feature is enabled in Geany, it might lead to styling issues in the tooltip displaying the diff of the current hunk. So always disable this feature for the tooltip where it is not needed. I dont think we ever need the Change history in the diff tooltip, as the tooltip

[Github-comments] Re: [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-12 Thread Enrico Tröger via Github-comments
Merged #1278 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1278#event-10637128409 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Enrico Tröger via Github-comments
I don't see how it should get better by postponing to 2.1. To me, switching to @techee's version of the Prof-Gnome theme is a big improvement over the default theme. In the mean time, the website FAQ explains how to change the GTK theme on Windows, so users who do not like it, can change it

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Enrico Tröger via Github-comments
> > We'll still need the "unknown" check to support older ctags binaries > > unfortunately. At least we can easily change the PHP tags generation script when needed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#issuecomment-1760373686 You are

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-12 Thread Enrico Tröger via Github-comments
Didn't you like the second commit's message? :D Done and thanks for review. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3594#issuecomment-1760362118 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-12 Thread Enrico Tröger via Github-comments
Merged #3594 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3594#event-10636857656 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: It won't get better. No idea what I'm doing wrong. I managed to scale the display to 60% (after enabling some experimental feature in mutter via gsettings and then changing the scale in some XML file) but it

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
> > Should we maybe better highlight the many ctags changes? > > I don't think it's necessary, the big refactorings weren't user-visible. But > maybe if #3049 gets merged, an "improved support of ctags file format" could > be mentioned so users know they can use these files and there should be

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. b11817519cb0e9d2232958c54ce6c3d37c1ec599 Improve wording for PR3042 item -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/e754f79d16dcac69bcad0da13a0fd2aaf03e6a65..b11817519cb0e9d2232958c54ce6c3d37c1ec599 You are receiving this because you are

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I'll give it another try tomorrow. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1355787792 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then - MINOR="$((MINOR-1))" - PATCH="90" + if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0") ]]; then +

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 Use b4n's simpler version -- View it on GitHub: https://github.com/geany/geany/pull/3594/files/2fa22afbb8e80683afa2ae8b5f35dcd8e8c1299e..15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 3613117b9573798b17f1535cfa9e4b4973f6c4d6 Use b4n's simpler version -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1278/files/ee46cc185c39ac7e5ccbd1df5f078f76627119d8..3613117b9573798b17f1535cfa9e4b4973f6c4d6 You are receiving this because you are

[Github-comments] [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-11 Thread Enrico Tröger via Github-comments
The previous logic failed on 2.0 to make the new version number 1.99.99. This is fixed now even though the code is not perfect or good at all but should work well enough for its purposes. See also https://github.com/geany/geany/pull/3594. The additional log information are in pair with Geany

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
JFYI, it's even tested this time (left is the result, right is the input version): ``` 1.38.0 - 1.38.1_git_2023103518_173744b2b 1.37.99 - 1.38_git_2023103518_173744b2b 2.0.0 - 2.0.1 1.99.99 - 2.0_git_2023103518_173744b2b 2.1.89 - 2.1.90 2.0.99 - 2.1 2.2.0 - 2.2.1 2.89.99 - 2.90 ```

[Github-comments] [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
The previous logic failed on 2.0 to make the new version number 1.99.99. This is fixed now even though the code is not perfect or good at all but should work well enough for its purposes. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3594

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I totally don't mind how we create the screenshots. I just don't want to do it 10 times and do not want to install a dozen VMs :). Trying X11 might get better results. Within Gnome, I didn't find any way to

[Github-comments] [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)

2023-10-11 Thread Enrico Tröger via Github-comments
Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API. Is this OK? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1277 -- Commit Summary -- * Add missing style mappings for new and updated

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
> Thanks for updating the docs - I made a few tweaks. Thank you, applied them all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1757863336 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. e754f79d16dcac69bcad0da13a0fd2aaf03e6a65 Update NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/6601ca02e3e589f1dc76ad89893cbf929420fe50..e754f79d16dcac69bcad0da13a0fd2aaf03e6a65 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 6601ca02e3e589f1dc76ad89893cbf929420fe50 Apply geany.txt suggestions from code review -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/02238c4c91b84fc5acd1907dcc6e015490f0fc2e..6601ca02e3e589f1dc76ad89893cbf929420fe50 You are receiving this because

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I booted up a Debian Bookworm VM from the live ISO image without any modifications to the theme. The only thing changed was to reduce the font size, otherwise everything would be even bigger. There was

[Github-comments] Re: [geany/geany] Update URLs to use https consistenly (PR #3583)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #3583 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3583#event-10617025585 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #3568 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3568#event-10616848196 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Builders: Use "posix" variant of the mingw64 cross compiler (PR #11)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #11 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/11#event-10616757861 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #10 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/10#event-10616745507 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#pullrequestreview-1670757655 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-11 Thread Enrico Tröger via Github-comments
Tested and works fine. Maybe we could squash some of the commits? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1757385379 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-11 Thread Enrico Tröger via Github-comments
As said earlier, I also vote for disabling the feature by default. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3591#issuecomment-1757381211 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-11 Thread Enrico Tröger via Github-comments
"Change history" docs will be added in https://github.com/geany/geany/pull/3593. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3551#issuecomment-1757377893 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
Add NEWS for 2.0, update documentation screenshots and add docs for the Change history feature. Remarks for the NEWS items: - I left out names for Jiří and Thomas as you count as core developers for long Id say. This doesnt mean your work is less appreciated :heart: - I skipped many smaller or

[Github-comments] Re: [geany/geany] Bump GTK version requirement to 3.24 (PR #3580)

2023-10-08 Thread Enrico Tröger via Github-comments
Awesome, thanks! I'd vote for early merge to have as much testing via master as possible. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3580#issuecomment-1752091164 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update URLs to use https consistenly (PR #3583)

2023-10-08 Thread Enrico Tröger via Github-comments
I stumbled upon some http-URL by accident and thought "let's change it'. Then got surprised how many there still are :(. Interestingly, I left out the most user visible one: https://github.com/geany/geany/blob/master/src/about.c#L453 This would cause a fuzzy translation in each language file.

[Github-comments] [geany/geany] Update URLs to use https consistenly (PR #3583)

2023-10-08 Thread Enrico Tröger via Github-comments
Most URLs just needed to prefixed with https. Some other URLs were outdated or broken and got updated to the recent location. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3583 -- Commit Summary -- * Update URLs to use https consistenly

[Github-comments] Re: [geany/geany] Bump GTK version requirement to 3.24 (PR #3580)

2023-10-08 Thread Enrico Tröger via Github-comments
@techee I just found another place to update, seems like we have forgotten it already the last time (:smile:): https://github.com/geany/geany/blob/master/doc/geany.txt?plain=1#L106 -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-08 Thread Enrico Tröger via Github-comments
If nobody stops me, I would like to merge this and the infrastructure PR to fix the CI (and do this for G-P as well afterwards). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3568#issuecomment-1752015990 You are receiving this because you are

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-08 Thread Enrico Tröger via Github-comments
Long story short about the translation strings: this is safe to merge, it will *NOT* add new untranslated strings. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1752015443 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-08 Thread Enrico Tröger via Github-comments
> > How do you think so? AFAIK the lookup is made solely on the string itself. > > Either it matches or not. > > Oh, I thought it was possible to have the same string at different places in > the program with differing translations? If not by file/line how is that > done? (translation newby

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-08 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -3973,8 +3973,8 @@ On Windows 7 and above you most likely will find it at: ``C:\users\UserName\Roaming\geany`` -Tools menu items - +Configuration files menu While this section is currently mainly about the `Configuration files`

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-08 Thread Enrico Tröger via Github-comments
> Don't strings have file/line in their lookup, so "Templates" and "Files" menu > items would likely show untranslated until updated? How do you think so? AFAIK the lookup is made solely on the string itself. Either it matches or not. Before further speculating, just test it. Check out the

[Github-comments] Re: [geany/geany] Bump GTK version requirement to 3.24 (PR #3580)

2023-10-08 Thread Enrico Tröger via Github-comments
But why splitting? IMO it causes only extra work and we want to remove the workarounds anyway if they are not necessary any more. Sure there is some risk of breakage but in this case this is probably tolerable especially since we will probably use and test Geany in the next days even more than

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-08 Thread Enrico Tröger via Github-comments
After having used the change history for a few days now, I also think it might be better disabled by default so users should enable it explicitly if desired. @kugel- More importantly, we should document it. At the very least there should be a few lines describing the feature at

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-05 Thread Enrico Tröger via Github-comments
Maybe you could open a new issue to discuss how we can rework the CI infrastructure, if you like. IMO this is out of scope of this PR. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3568#issuecomment-1749672450 You are receiving this because you are

[Github-comments] [geany/geany-plugins] Pre-release version bump (PR #1274)

2023-10-05 Thread Enrico Tröger via Github-comments
G-P pendant to https://github.com/geany/geany/pull/3569. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1274 -- Commit Summary -- * Pre-release version bump -- File Changes -- M NEWS (2) M build/geany-plugins.nsi (6)

[Github-comments] Re: [geany/geany] RFC: Pre-release version bump to 2.0 (PR #3569)

2023-10-05 Thread Enrico Tröger via Github-comments
Merged #3569 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3569#event-10568542023 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] RFC: Pre-release version bump to 2.0 (PR #3569)

2023-10-05 Thread Enrico Tröger via Github-comments
> stable", I'm kind of neutral here. But in the spirit of linux kernel > numbering "when the number behind the dot gets too big, let's bump the major > version", it's a good move.) I didn't know this is the Linux kernel numbering scheme but it's pragmatic :). Actually, I happened to confused

[Github-comments] Re: [geany/geany] Add feature: copy filename / copy filepath to clipboard (#868)

2023-10-05 Thread Enrico Tröger via Github-comments
What exactly do you request? I don't understand the sentence fully. If it is about changing the website, maybe it is better to open a new issue in the Geany-Plugins repository (https://github.com/geany/geany-plugins). -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-04 Thread Enrico Tröger via Github-comments
How should we fix it in Geany? An external library which we include in our build (Scintilla) uses features a special compiler toolchain does not support. It's not a problem with our code that we could fix. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/infrastructure] Builders: Use "posix" variant of the mingw64 cross compiler (PR #11)

2023-10-04 Thread Enrico Tröger via Github-comments
We could make these changes on the Geany side, I put it here explicitly to ensure we use the same compiler variant for Geany *and* G-P. Alternatively, we could end up in compiling Geany with the -posix variant and G-P with the -win32 variant which may work or may not. Or we had to duplicate the

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-04 Thread Enrico Tröger via Github-comments
Yes, it builds fine on native Windows as there the compiler from MSYS2 is used. Sorry forgot to mention this, all the build problems are specific to the used cross compiler toolchain used in the CI builds. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Use ISO 8601 date format by default (yyyy-mm-dd) (PR #3570)

2023-10-03 Thread Enrico Tröger via Github-comments
LGBI. Maybe updating the translation files is not necessary at all. It would happen with the next string freeze automatically. For the upcoming release it's too late, I think :(. I didn't check the GIT history and I don't remember but there is a certain probability that it was me introducing

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-03 Thread Enrico Tröger via Github-comments
I'm fine with merge. The failed Windows CI build is handled seperately. Only one minor thing, I guess we should bump plugin API version because `GeanyIndentPrefs` and Scintilla itself are part of the plugin API. -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] RFC: Pre-release version bump to 2.0 (PR #3569)

2023-10-03 Thread Enrico Tröger via Github-comments
Since we are going towards the next release and we were thinking about a magic 2.0 version number already for some time, maybe the time is now to just do it :). Any objections? @elextr @kugel- @techee @b4n @frlan You can view, comment on, or merge this pull request online at:

[Github-comments] Re: [geany/geany] Bump Geany ABI to mitigate Scintilla 5.1.5 changes (PR #3541)

2023-10-03 Thread Enrico Tröger via Github-comments
Agreed. Let's merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3541#issuecomment-1744980801 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-03 Thread Enrico Tröger via Github-comments
@kugel- @elextr should we include the patch from https://groups.google.com/g/scintilla-interest/c/_tiE_nSaiG4/m/v0e8lzTjAQAJ here? I'd say yes because the next Scintilla release might be after the upcoming Geany release and the issue might also affect Geany users. -- Reply to this email

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-03 Thread Enrico Tröger via Github-comments
@eht16 pushed 2 commits. 354c7ba4e66803f16d9e0452b7829d47cb742587 CI: Copy used C++ runtime library into the GTK bundle b18c76edc9eb10a5c0097d4231c387885e2f266f CI: Log compiler and library versions in build output -- View it on GitHub:

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-03 Thread Enrico Tröger via Github-comments
The build failures are not because the used compiler is too old but it's missing features: https://sourceforge.net/p/mingw-w64/bugs/959/ https://github.com/geany/geany/pull/3568 changes the used cross compiler toolchain to its "posix" variant which has all necessary C++ features and so the

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-03 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 30372ece08c0d4986b36afcb1652b2cc3f26689f CI: Log compiler and library versions in build output -- View it on GitHub: https://github.com/geany/geany/pull/3568/files/23a07d7d3c7c65c630dc2700a62584376a25a9bb..30372ece08c0d4986b36afcb1652b2cc3f26689f You are receiving this

[Github-comments] [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-03 Thread Enrico Tröger via Github-comments
This is the partner PR to https://github.com/geany/infrastructure/pull/11: the latest Scintilla version doesnt compile in the Mingw64 cross compiler CI job. This is because the used cross compiler toolchain doesnt support C++ features like std:future. See

[Github-comments] [geany/infrastructure] Builders: Use "posix" variant of the mingw64 cross compiler (PR #11)

2023-10-03 Thread Enrico Tröger via Github-comments
The mingw64 cross compiler lacks support at least for std:future feature in C++ (https://sourceforge.net/p/mingw-w64/bugs/959/). Debian offers a posix variant which implements it. https://sourceforge.net/p/mingw-w64/bugs/959/ describes the problem.

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-01 Thread Enrico Tröger via Github-comments
> > Is gcc 10 fine in general? > > On an old machine (note to self: upgrade it) linux `g++ (Ubuntu > 9.4.0-1ubuntu1~20.04.2) 9.4.0` works here (this PR builds and runs fine). > > I really don't know what is wrong with the mingw build at this point. Me neither.

[Github-comments] Re: [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-10-01 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. f8e81de9c6b829c4b9657f66a37b8d0fca6e43b4 Builders: Ensure /etc/mtab is available on Docker mingw64 image build -- View it on GitHub: https://github.com/geany/infrastructure/pull/10/files/52a5e88a710a7c3f504f6a4982113f617deb3bc4..f8e81de9c6b829c4b9657f66a37b8d0fca6e43b4

[Github-comments] Re: [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-10-01 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 52a5e88a710a7c3f504f6a4982113f617deb3bc4 Builders: Ensure /etc/mtab is available on Docker mingw64 image build -- View it on GitHub: https://github.com/geany/infrastructure/pull/10/files/74e457a668ecedc6b776f051114720686f9f7fdb..52a5e88a710a7c3f504f6a4982113f617deb3bc4

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-09-27 Thread Enrico Tröger via Github-comments
> @eht16 what version of g++/libstdc++ is used for windows, nowhere does the > version get printed in configure or build, g? In https://github.com/geany/geany/actions/runs/6322193707/job/17167381804?pr=3551#step:9:23 we show basic build environment information. Adding the gcc/g++ version

[Github-comments] Re: [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-09-26 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 74e457a668ecedc6b776f051114720686f9f7fdb Temporarily enable PR pipelines -- View it on GitHub: https://github.com/geany/infrastructure/pull/10/files/ea90fbb49f148e3e7086e93f49b1f7d99437de76..74e457a668ecedc6b776f051114720686f9f7fdb You are receiving this because you are

[Github-comments] [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-09-26 Thread Enrico Tröger via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/infrastructure/pull/10 -- Commit Summary -- * Builders: Ensure /etc/mtab is available on Docker mingw64 image build -- File Changes -- M builders/Dockerfile.mingw64 (2) -- Patch Links --

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-09-26 Thread Enrico Tröger via Github-comments
> @eht16 do you know what's wrong with the Windows CI? No :(. I can succesfully build the image with normal Docker on a native Linux system. Either something changed on how the Gitlab runners are implemented or something in `pacman` changed, still unsure what is causing this. So far I didn't

[Github-comments] Re: [geany/geany] Long filenames in the window frame are unidentifiable in Cinnamon (Issue #3564)

2023-09-26 Thread Enrico Tröger via Github-comments
I don't know if I got all of the discussion here. I find the OP confusing as on the screenshot there is Geany and Pluma but the text refers to different distributions. Anyway and apart of personal preferences about this feature, the next release of Geany will contain the setting @elextr

[Github-comments] Re: [geany/geany] Update Scintilla to version 5.3.6 (PR #3551)

2023-09-17 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -21,6 +21,7 @@ fstring=string_1 fcharacter=character ftriple=string_2 ftripledouble=string_2 +attribute=identifier_1ö `ö` :) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] TODO tasks need the autorefresh button when opening a file to be visible 1.38 kubuntu 22.04, plasma 5.24 (Issue #1254)

2023-09-17 Thread Enrico Tröger via Github-comments
Closed #1254 as completed via #1257. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1254#event-10391068948 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-09-17 Thread Enrico Tröger via Github-comments
Merged #1257 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1257#event-10391068900 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Scope: Define GETTEXT_PACKAGE macro for recent cppcheck versions (PR #1264)

2023-09-17 Thread Enrico Tröger via Github-comments
Merged #1264 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1264#event-10391068465 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use gtk_show_uri_on_window() in utils_open_browser() by default (PR #3178)

2023-09-17 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3178#pullrequestreview-1630059824 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use gtk_show_uri_on_window() in utils_open_browser() by default (PR #3178)

2023-09-17 Thread Enrico Tröger via Github-comments
Tested and works fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3178#issuecomment-1722434483 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-07 Thread Enrico Tröger via Github-comments
Closed #1260. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#event-10028761519 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-07 Thread Enrico Tröger via Github-comments
I suggest to simply close this PR and focus on #1242 which has the same changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#issuecomment-1668582270 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rectangular selection mode initialization inserts garbage characters (Issue #3539)

2023-08-07 Thread Enrico Tröger via Github-comments
Can you reproduce this with Scite? I'm not sure but it could be a Scintilla issue (if this is an issue at all?). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3539#issuecomment-1668578154 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-06 Thread Enrico Tröger via Github-comments
I don't get it. Currently, there is no Devhelp in GIT master. So, strictly the *.po files should be updated to remove the previous translations. But since you are already about to re-add the plugin, updating the translation files would be done best after your changes from #1242 have been

[Github-comments] Re: [geany/geany-plugins] Update POTFILES.in (PR #1263)

2023-08-06 Thread Enrico Tröger via Github-comments
Closed #1263. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1263#event-10018007397 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-05 Thread Enrico Tröger via Github-comments
Are these changes intended? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#issuecomment-113325 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-08-05 Thread Enrico Tröger via Github-comments
I'd like to merge this in a few days if there are no objections or further remarks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1257#issuecomment-113074 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update POTFILES.in (PR #1263)

2023-08-05 Thread Enrico Tröger via Github-comments
Do we need this PR at all? It seems the requested changes are also handled in #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1263#issuecomment-112679 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update use of Python to default to and/or use Python 3 (#2615)

2023-08-05 Thread Enrico Tröger via Github-comments
Not even three later, we finally managed to finish all open tasks. Python 2 R.I.P. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2615#issuecomment-108173 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update use of Python to default to and/or use Python 3 (#2615)

2023-08-05 Thread Enrico Tröger via Github-comments
Closed #2615 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2615#event-10016090976 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Generate PHP global tags in ctags format (PR #3512)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3512 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3512#event-10016084237 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update NSIS filetype keywords (PR #3487)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3487 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3487#event-10016081995 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3486 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3486#event-10016081263 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Markdown: "matching" underscores have priority over code block (#1439)

2023-08-05 Thread Enrico Tröger via Github-comments
Since we already use Scintilla 5.1.5 where this bug is fixed, I'll close this issue. Just re-open if you disagree. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1439#issuecomment-104481 You are receiving this because you are subscribed to this

<    1   2   3   4   5   6   7   8   9   10   >