Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread elextr
> And in any case, relying on the marker not creating conflicts is IMO too > optimistic for anything but user calling the feature and having a chance to > see if it's wrong. Yes, I noticed that there is only one toggle comment marker, not one per filetype as I first thought. Given the increasi

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread Colomban Wendling
Agreed. My point was that it's perfectly OK to have whatever marker one on wants, and it shouldn't break the feature here. If it's not convenient for the user is not our problem, it's the user's; but if we let the user select a marker, it should not break anything (or we should forbid it). An

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread elextr
> Well, IMO that's one possible usage of it (admittedly, the expected one), but > it doesn't strike me as "wrong" to use it some other way. Well, its the usage for which the feature is designed, if it is used in unintended ways and doesn't work that is not a bug. And since the feature expects

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread Colomban Wendling
> > How so? > > You basically said it in the following sentence, the feature is for toggling > blocks of code on/off during development without worrying about internal > comments, its not for setting/unsetting comments for permanent use, which is > why I made the note about users misunderstandi

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread elextr
> How so? You basically said it in the following sentence, the feature is for toggling blocks of code on/off during development without worrying about internal comments, its not for setting/unsetting comments for permanent use, which is why I made the note about users misunderstanding the featu

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread Colomban Wendling
> But basically if the toggle comment character is set to space the whole > toggle comment feature is broken everywhere, not just here. How so? It works fine when triggered, and leads to inserting what looks like a regular comment. Using a marker that is not usually used allows to use the toggle

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-08 Thread elextr
Well the toggle comment feature will only toggle comments with the comment marker in them, hence so long as its not space (as you identified) it will leave existing comments alone and simply comment all the uncommented lines, which is what we want. IIRC the discussions at the time, toggle com

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-07 Thread Colomban Wendling
OK, I confirm this *if the comment marker is set to a single space ` `*. The default is ` ~`, in which case the issue doesn't appear. However, there indeed is a bug here; it looks like we're using the *toggle comment* feature, which has the side effect of possibly *un*commenting lines, which i

[Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-07 Thread Ian Kenney
Geany version: 1.36 Attempting to create a `snippets.conf` by Tools -> Configuration Files -> snippets.conf brings up a file with comments that are all inverted. ``` Geany's snippets configuration file # # use \n or %newline% for a new line (it will be replaced by the used EOL char(s) - LF, CR/