OK, I've just merged this PR so we are finally done with it. @Skif-off thanks
for your contribution and for your patience!
> @techee sure, that'd be fine as well (although it'd probably get forgotten
> for a decade or two until somebody notices it from scratch again)
@b4n I'm going to do it
Merged #1752 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#event-9017870545
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
@techee sure, that'd be fine as well (although it'd probably get forgotten for
a decade or two until somebody notices it from scratch again)
--
Reply to this email directly or view it on
@Skif-off pushed 1 commit.
44611e609c173549450d5d8dd75104ed95ac809f As in 5298f51
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/54324efdee3621f0b47b0840b70a73136a97333f..44611e609c173549450d5d8dd75104ed95ac809f
You are receiving this because you are subscribed to this
@techee commented on this pull request.
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
I'd suggest that we address this in a separate PR (@b4n what do you think?).
This PR works well as it is and I can prepare a PR for the global and local
variables afterwards - it should be
@Skif-off commented on this pull request.
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
I just wanted to add minimal guaranteed working AutoIt support and don't know
all the ins and outs of how Geany works.
And didn't want to bloat the list of symbols (maybe in the future if
@techee commented on this pull request.
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
Plus we want to have all the enabled tags covered by unit tests - I haven't
checked if the provided unit test contains local and global tags.
--
Reply to this email directly or view it on
@techee commented on this pull request.
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
Yes, that would be nice I think (I didn't mention this because I thought they
were disabled for some language-specific reason).
If you decide to enable local variables, please map them to
@b4n commented on this pull request.
Apart from the comment, and assuming the parsers and lexers are upstream's,
LGTM (esp. if @techee likes it as well :))
> + {'g', tm_tag_undef_t},
+ {'l', tm_tag_undef_t},
Don't we want to see at least global variables? And even local ones would
> Done.
Thanks. The PR looks good to go from my perspective.
> To be honest, I don't see the difference between TRUE and FALSE :)
You won't in this case because the language itself supports only one level of
nesting. The change is more for us so we know which languages support scope
> But if scopes are supported, then it should be mentioned inside
> `tm_parser_has_full_scope()`.
Done.
To be honest, I don't see the difference between `TRUE` and `FALSE` :)
--
@Skif-off pushed 1 commit.
e7225418b69f70d55119ef4f979ab1c767f92f99 Add TM_PARSER_AUTOIT to
tm_parser_has_full_scope()
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/8ff16fed4d1c19d11fb51bb8e43dda4b8987d8d8..e7225418b69f70d55119ef4f979ab1c767f92f99
You are receiving this
> It seems the language does not support such constructs.
OK, I mentioned this because I noticed the use of `nestingLevel...()` and
`CORK` stuff in the parser which are used for scopes.
> Any part of code can be placed inside the #Region ... #EndRegion, but #Region
> ... #EndRegion is not a
> by just having a look at the parser (and not knowing the language), it seems
> that the parser supports scopes (i.e. nesting one tag inside other tag).
> ...
> it seems that you can nest one function inside another
It seems the language does not support such constructs.
Any part of code can
@Skif-off pushed 1 commit.
c598c9ead6fd919d8ef7e68840e717adef8d917f Improve some comments in
filetypes.autoit
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/b7ccf84891f4653528acf60398da7326713b6f18..c598c9ead6fd919d8ef7e68840e717adef8d917f
You are receiving this because
Maybe a question - by just having a look at the parser (and not knowing the
language), it seems that the parser supports scopes (i.e. nesting one tag
inside other tag). The provided unit test only shows some simple script without
this. But if scopes are supported, then it should be mentioned
@b4n @techee are you both happy to merge?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1483726755
You are receiving this because you are subscribed to this thread.
Message ID:
@Skif-off pushed 1 commit.
b7ccf84891f4653528acf60398da7326713b6f18 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/aaaed345031a08c1bcd774e7078a45d2b960..b7ccf84891f4653528acf60398da7326713b6f18
You are
> @elextr , @techee , thanks! Now works fine.
Great!
We forgot to update the documentation with the pretty-printing script though -
I created #3353. @elextr Does it look OK to you?
--
Reply to this email directly or view it on GitHub:
@elextr , @techee , thanks! Now works fine.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1358966314
You are receiving this because you are subscribed to this thread.
Message ID:
@Skif-off pushed 1 commit.
aaaed345031a08c1bcd774e7078a45d2b960 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/d136e5189be1f69bb00a9a760d1857ba01e60b41..aaaed345031a08c1bcd774e7078a45d2b960
You are
Just process your reference tags file with
[this](https://github.com/geany/geany/blob/master/scripts/print-tags.py) so it
will match the test file that is also processed that way.
--
Reply to this email directly or view it on GitHub:
No `simple.html.tags` was changed
[here](https://github.com/geany/geany/commit/aba66f07cca62b28d33534ec88c686b600fe2533#diff-40f1bf07e75d4cf91cce257030fa3b92f7b66a5aae59339cd871f44dc4e8ea32)
to match the new format.
--
Reply to this email directly or view it on GitHub:
@elextr , interesting, `simple.html.tags`, for example, contents the same
characters, but without error...
I will check manually, maybe just disable testing.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1358937866
You are receiving
@Skif-off
[this](https://github.com/geany/geany/commit/ad304cf79afbf4dd8080417abbdd27e904b521a9)
gotcha, the tag file format is pretty printed before `diff`ing.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1358917007
You are
@techee , yes, I figured it out, I found your commits in upstream: I replaced
`tm_tag_member_t` with `tm_tag_undef_t` and updated the `simple.au3.tags` file.
but again I got an
[error](https://github.com/geany/geany/actions/runs/3733542779/jobs/6334467745)
(but no details now).
--
Reply to
> (process:10108): Tagmanager-WARNING **: 12:59:46.979: Not all tag types
> mapped to symbol tree groups for AutoIt
It means that each `tm_tag_...` from
```
static TMParserMapEntry map_AUTOIT[] = {
{'f', tm_tag_function_t},
{'r', tm_tag_other_t},
{'g', tm_tag_member_t},
@Skif-off pushed 1 commit.
d136e5189be1f69bb00a9a760d1857ba01e60b41 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/695a7af6b169dcaf0ea9441303344e60224fb9dc..d136e5189be1f69bb00a9a760d1857ba01e60b41
You are
@Skif-off pushed 1 commit.
695a7af6b169dcaf0ea9441303344e60224fb9dc Return back
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/bc4d65dd1a3d84da7e69f02701bfc3134a85fdb8..695a7af6b169dcaf0ea9441303344e60224fb9dc
You are receiving this because you are subscribed to this
@Skif-off pushed 1 commit.
bc4d65dd1a3d84da7e69f02701bfc3134a85fdb8 Test with 'tm_tag_undef_t'
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/51901737a23dc410bcf01bf9140f234b83edab44..bc4d65dd1a3d84da7e69f02701bfc3134a85fdb8
You are receiving this because you are
I took a quick look the list of commits and replaced `tm_tag_member_t` with
`tm_tag_undef_t` (I tried to remember why I used `tm_tag_member_t` but
couldn't): fail.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1357624098
You are
@Skif-off pushed 1 commit.
51901737a23dc410bcf01bf9140f234b83edab44 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/1bf4df7b9f1ee6adf9e11b622f47c4732432d4f9..51901737a23dc410bcf01bf9140f234b83edab44
You are
Then something has probably changed in all the big changes in TM recently,
@techee?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#issuecomment-1356716058
You are receiving this because you are subscribed to this thread.
Message ID:
Parser and lexer are current versions from upstreams (and both have not been
updated for a long time). I'm sorry, right now I don't understand what the
problem is :)
ctags/parsers/autoit.c:
```c
static roleDefinition AutoItIncludeRoles [] = {
{ true, "system", "system include" },
@Skif-off pushed 1 commit.
1bf4df7b9f1ee6adf9e11b622f47c4732432d4f9 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/6b6034ce7009cfa4f4506456f613a49302591dd8..1bf4df7b9f1ee6adf9e11b622f47c4732432d4f9
You are
@Skif-off pushed 1 commit.
6b6034ce7009cfa4f4506456f613a49302591dd8 TMP, will be squashed later
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/b0502bf24a83fc474177a9ecc5b0dbdae2035dfa..6b6034ce7009cfa4f4506456f613a49302591dd8
You are receiving this because you are
> (process:10108): Tagmanager-WARNING **: 12:59:46.979: Not all tag types
> mapped to symbol tree groups for AutoIt
https://github.com/geany/geany/blob/bb45e3b7485e27f29bf652968b9094da322d0bc7/src/tagmanager/tm_parser.c#L1351
Tagmanager and ctags are out of sync for autoit, did your updated
@Skif-off pushed 1 commit.
b0502bf24a83fc474177a9ecc5b0dbdae2035dfa Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/e2881605d6b93a1b59580080f47d4ce1c48bcaa4..b0502bf24a83fc474177a9ecc5b0dbdae2035dfa
You are
[/jobs/6309415770](https://github.com/geany/geany/actions/runs/3720132501/jobs/6309415770):
What does
> (process:10108): Tagmanager-WARNING **: 12:59:46.979: Not all tag types
> mapped to symbol tree groups for AutoIt
mean?
Maybe just drop the test when Meson is used?
--
Reply to this email
@Skif-off pushed 1 commit.
e2881605d6b93a1b59580080f47d4ce1c48bcaa4 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/458af8ec125c90a5e37a7298ecfe71994f0adbf7..e2881605d6b93a1b59580080f47d4ce1c48bcaa4
You are
@Skif-off pushed 1 commit.
458af8ec125c90a5e37a7298ecfe71994f0adbf7 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/9d138427b276ab049261f967afaf05e90422912d..458af8ec125c90a5e37a7298ecfe71994f0adbf7
You are
@Skif-off pushed 1 commit.
9d138427b276ab049261f967afaf05e90422912d Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/a14388d2044647c1d397d953c1836f0beb2c6401..9d138427b276ab049261f967afaf05e90422912d
You are
@Skif-off pushed 1 commit.
a14388d2044647c1d397d953c1836f0beb2c6401 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/3c784cbd593a40695cc689594d032669b33b432a..a14388d2044647c1d397d953c1836f0beb2c6401
You are
@Skif-off pushed 1 commit.
7ef0ef6b80f15632610f4c6fed60c2c548c67ca4 FIX build
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/a368f098fd44324102035bed439a5991b24cbe73..7ef0ef6b80f15632610f4c6fed60c2c548c67ca4
You are receiving this because you are subscribed to this
@Skif-off pushed 1 commit.
a368f098fd44324102035bed439a5991b24cbe73 Add AutoIt syntax highlighting and
Ctags parser for AutoIt
--
View it on GitHub:
https://github.com/geany/geany/pull/1752/files/f127e406077ae20a05fb60682ad2652f62e00d21..a368f098fd44324102035bed439a5991b24cbe73
You are
45 matches
Mail list logo
