Thanks!
I updated the wiki page https://wiki.geany.org/config/docker-compose to only
provide a custom filetype for Docker-Compose files.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2143939064
You are receiving this because you are
Merged #3757 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#event-13012400300
You are receiving this because you are subscribed to this thread.
Message ID:
Heh, overlapping comments again, great minds and all that ...
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2141445581
You are receiving this because you are subscribed to this thread.
Message ID:
> but the AS doesn't highlight.
Remember its a `sh` lexer, not a Docker lexer. AFAICT its somewhat picky about
context for keywords, beginning of command is good, after that it varies.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2
Alright, thanks for the attempt. It seems the Scintilla Bash lexer highlights
keywords only at the start of a line which is basically fine for real shell
scripts.
I think then it is fine as it is.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#is
> Yes, I'll do that soon.
@eht16 I tried and tested but the AS doesn't highlight.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2141289564
You are receiving this because you are subscribed to this thread.
Message ID:
@andy5995 pushed 1 commit.
e366b21fcc5eea51cc36ac151af2363dcedec8ac Add Dockerfile filedef
--
View it on GitHub:
https://github.com/geany/geany/pull/3757/files/63474cc70c093122c09c2c1706d63065d4f1305a..e366b21fcc5eea51cc36ac151af2363dcedec8ac
You are receiving this because you are subscribed to
Yes, I'll do that soon.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2136861333
You are receiving this because you are subscribed to this thread.
Message ID:
One last remark: could we add `AS` to the keywords? It's not strictly a
directive on its own but is part of the `FROM` directive, e.g. `FROM
debian:bullseye-slim AS builder` and without the highlighting looks a bit
broken.
--
Reply to this email directly or view it on GitHub:
https://github.co
If there are no objections, I would merge this next weekend and update the Wiki
accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2120677402
You are receiving this because you are subscribed to this thread.
Message ID:
> Do we need to adjust anything for the Meson build system?
No, this is in data/meson.build:
`install_subdir('filedefs', install_dir: cdata.get('GEANY_DATA_DIR'),
exclude_files: 'filetypes.python.in')`
I think this is done now.
--
Reply to this email directly or view it on GitHub:
https:/
@andy5995 pushed 1 commit.
63474cc70c093122c09c2c1706d63065d4f1305a Add Dockerfile filedef
--
View it on GitHub:
https://github.com/geany/geany/pull/3757/files/f684daf36e9b31a91fdd115b4026f8de35412188..63474cc70c093122c09c2c1706d63065d4f1305a
You are receiving this because you are subscribed to
@andy5995 pushed 1 commit.
f684daf36e9b31a91fdd115b4026f8de35412188 Update
data/filedefs/filetypes.Dockerfile.conf
--
View it on GitHub:
https://github.com/geany/geany/pull/3757/files/b21ed0baba253cb40c6a2e239c1812c833c16a66..f684daf36e9b31a91fdd115b4026f8de35412188
You are receiving this beca
Nice.
I think we could add this new filetype and then update the wiki page to have it
only a seperate docker-compose filetype and a reference to the GIT version of
this Docker filetype. I'm happy to do this after merge.
Regarding the `extension=` setting: what do you think about using lower cas
@eht16 commented on this pull request.
> @@ -0,0 +1,14 @@
+[styling=Sh]
+
+[keywords]
+primary=ADD ARG CMD COPY ENTRYPOINT ENV EXPOSE FROM HEALTHCHECK LABEL
MAINTAINER ONBUILD RUN SHELL STOPSIGNAL USER VOLUME WORKDIR
+
+[lexer_properties=C]
```suggestion
[lexer_properties=Sh]
```
Or am I missi
> @dolik-rce thanks, if only we got more reviews by third parties things would
> proceed faster. I don't know how many people consult the wiki to find out
> configurations etc. Given the number of projects where the _only_ docs are
> the wiki I would have thought many dedicated open sourcers wou
@dolik-rce thanks, if only we got more reviews by third parties things would
proceed faster. I don't know how many people consult the wiki to find out
configurations etc. Given the number of projects where the _only_ docs are the
wiki I would have thought many dedicated open sourcers would cons
Hi, Docker user here.
I have tested both filetype definitions, the one from this PR and the one from
wiki. As far as I can tell, they are not much different. I have noticed only
one visual difference and that is that the configuration from @andy5995 renders
strings in `RUN` commands better (be
Full agree with what @elextr said, these were mostly the words already in my
mouth, I just didn't speak it explicitly.
One addition: after this PR we should *not* have a Docker filetype in Geany and
the wiki page as it is now. In the end, we should decide on one solution.
I think it might be wo
@andy5995 I think the main point of @eht16's reply (putting words in his mouth
:-) was that there are significant differences between the Wiki and your
filetype, including more keywords in the wiki version, using Python not Sh for
syntax etc etc so its unclear which is better and how to combine
> See also the already filetype configuration for Docker and Docker-Compose
> files in the wiki: https://wiki.geany.org/config/docker-compose.
You don't want it included with the Geany distribution then?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/
See also the already filetype configuration for Docker and Docker-Compose files
in the wiki: https://wiki.geany.org/config/docker-compose.
It might be the version in the wiki could be updated for recent Docker features
but it is already working.
--
Reply to this email directly or view it on Gi
@andy5995 pushed 1 commit.
93f5698e7e559c19b02e9b7c8851441341eade37 Add Dockerfile filedef
--
View it on GitHub:
https://github.com/geany/geany/pull/3757/files/9d7ede11029ae7168538e2e70329db98a0cf689f..93f5698e7e559c19b02e9b7c8851441341eade37
You are receiving this because you are subscribed to
https://github.com/dockersamples/genai-chatbot/blob/master/docker-bot/Dockerfile
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-1935857945
Y
24 matches
Mail list logo
