[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-03-07 Thread Jiří Techet via Github-comments
Closed #3411 as completed via #3412. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3411#event-8683212698 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
> Does it matter that the enum > [here](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/ctags/parsers/asciidoc.c#L43) > does not go to level 5? This is probably "correct" but extremely ugly. Those `K_CHAPTER` up to `K_LEVEL4SECTION` aren't used anywhere in the

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
Yeah, we also don't have the kind mapped here (`tm_tag_undef_t` means unmapped): https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/src/tagmanager/tm_parser.c#L837 I'll prepare a patch. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
Or is [this](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/src/tagmanager/tm_parser.c#L840) the culprit in T-T-T-(takes brave pills)-Tagmanager ;-) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
> while the current ctags parser supports level 5 sections (i.e. 6 =), see except that as the OP said, it doesn't, or it does and Geany doesn't, but anyway level 5 doesn't show in the symbols. Does it matter that the enum

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
> No its named right, its the count of the number of characters the same, it > needs one subtracted because C is 0 based indexing, but having 0 characters > the same is hard to detect as markup :-) Yep, I got this one wrong. > Although >

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
> The n_same variable in the parser is named confusingly because it's always > the number of = +1 and this 1 is then subtracted No its named right, its the count of the number of characters the same, it needs one subtracted because C is 0 based indexing, but having 0 characters the same is

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-23 Thread Jiří Techet via Github-comments
> @techee something changed when it was upstreamed, the parser accepts level 5 > [here](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/ctags/parsers/asciidoc.c#L379) > and it has a letter >

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-23 Thread elextr via Github-comments
@techee something changed when it was upstreamed, the parser accepts level 5 [here](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/ctags/parsers/asciidoc.c#L379) and it has a letter