Alright, I made the suggested changes:
1. I made GtkFileChooserNative configurable, by default enabled on macOS and
Windows, disabled on Linux.
2. I went through all GtkFileChooser occurrences in Geany and added the native
variant
3. Not sure if intentional or if it's some left-over but
@techee pushed 1 commit.
2d8d4f2edacbfc82743a4d020d9c22bc6526b92b Use GTK_RESPONSE_ACCEPT which is also
used by GtkFileChooserNative
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/4dff3767b9f80719dab3d1a83443be52cd377fa8..2d8d4f2edacbfc82743a4d020d9c22bc6526b92b
You are
@techee pushed 3 commits.
91fb8850281979356cdc38b5ea2b97e1b7132461 Use GtkFileChooserNative depending on
user configuration
ee8f885acf554c494b00f0f3a80a3c17676838ca Remove usage of windows-native
dialogs from ui_utils.c and win32.c/h
4dff3767b9f80719dab3d1a83443be52cd377fa8 Use
> Maybe one more question - should the open dialog show hidden files by
> default? [...]
> I'm not sure if it's possible on Windows too though (on the other hand
> Windows hidden files aren't so important I think because it's not those
> beginning with `.` like `.gitignore` that typical
If there's an option for it, sure (I didn't understand that was something you
would be happy about). And I don't mind the default on non-Linux either,
whatever people like best on those platforms.
It would be nice to have this available on Linux as well (**but off by
default**) for the
> To me it seems fine to use those dialogs since it seems to work well and if
> it goes the same for "Save As" and maybe "Open Folder". Making it
> configurable is a good idea, I don't mind about the default.
Good to hear. I'll try to prepare the patches (after finishing the boring task
of
The native file dialog on Windows 7 works very well after some testing.
Non-ASCII path and file names seem to work well, too.
I don't know how to set up "automounted remote
> Yes, but I think the problem wasn't the dialogs themselves (apart from the
> fact they were some "old" open dialogs), but rather the fact they were
> implemented using Windows API that nobody understood well.
And #3209 crash.
But one thing positive they did was that they automounted remote
> I didn't even know it was possible to rename a file using the Open dialog -
> how does one do that?
OK, I guess you meant the Save as dialog where the Rename button is the added
widget, which, indeed, won't be present in the native dialogs.
--
Reply to this email directly or view it on
> Didn't we have native dialogs a while ago, at least on Windows? So this
> brings that back, basically?
Yes, but I think the problem wasn't the dialogs themselves (apart from the fact
they were some "old" open dialogs), but rather the fact they were implemented
using Windows API that nobody
> @techee you said in the OP "where the GTK dialogs don't offer the best user
> experience.". Can you expand on that and why " using native dialogs under
> Windows and macOS is more important IMO."?
It's pretty much this:
https://github.com/geany/geany-osx/issues/14#issuecomment-1988461271.
Since I can't try either of the native dialogs, the reason I (politely) asked
what the advantages of the native dialogs are is because as they are hard coded
at compile time (AFAICT) users on Windows and Macos are gonna be stuck with
them. So its important to know what the advantages are vs
Didn't we have native dialogs a while ago, at least on Windows? So this brings
that back, basically?
> To me at least this isn't the most important thing and using native dialogs
> under Windows and macOS is more important IMO.
You hard-coded the native dialogs. As they don't offer all the
@rdipardo @techee thanks for testing, so apart from the inconsistent theming
issue it seems to work.
@techee you said in the OP "where the GTK dialogs don't offer the best user
experience.". Can you expand on that and why " using native dialogs under
Windows and macOS is more important IMO."?
File filters work both on Windows and macOS:
https://github.com/geany/geany/assets/713965/03616e82-594b-4921-be10-ce999eb38167;>
--
Reply to this email directly or view it on
@techee pushed 1 commit.
2bf55c0d6657fa0a80ffd573316c47308d9ba581 Use filters with GtkFileChooserNative
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/d1d16fa03df309916acf577a2df2a97cf7d419d9..2bf55c0d6657fa0a80ffd573316c47308d9ba581
You are receiving this because you are
> No need to build yourself, a full installer with the changes can be
downloaded from
the CI builds: https://github.com/geany/geany/actions/runs/8869590862
Nice, I didn't know about that.
The screenshot below comes from Windows 11, Geany on the left, Notepad++ on the
right. The only difference
> Windows 10/11 feedback would be great
So far so good on a stock Win 10 (22H2) VM with native dark mode active (i.e.
`AppsUseLightTheme` == `0`):1.
https://github.com/geany/geany/assets/59004801/ef76157a-d5ae-4111-b147-ce6a4ce91945;>
> Also I presume the native dialogs are themed by the
>Somebody who has Windows 11 and can build Geany with this needs to
>test as well.
No need to build yourself, a full installer with the changes can be
downloaded from
the CI builds: https://github.com/geany/geany/actions/runs/8869590862
Windows 10/11 feedback would be great, I can only test on
Also I presume the native dialogs are themed by the platform, not by GTK
themes, so they may look totally different to the rest of Geany. @techee for
Macos and whoever tests on Windows 11 need to try.
--
Reply to this email directly or view it on GitHub:
Somebody who has Windows 11 and can build Geany with this needs to test as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081771567
You are receiving this because you are subscribed to this thread.
Message ID:
I'm curious though as I only use Linux, it won't change anything for me :D.
But I'll give it a try on Windows, this will take a few days though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081658681
You are receiving this because
22 matches
Mail list logo
