On Thu, Oct 15, 2020 at 1:01 PM Amar Tumballi wrote:
> Thanks for taking time on this, and sending this note Xavi!
>
> Some comments inline!
>
> On Thu, Oct 15, 2020 at 4:03 PM Xavi Hernandez
> wrote:
>
>> Hi all,
>>
>> after the recent switch to GitHub, I've seen that reviews that require
>> mu
0 6:16:06 PM
Subject: Re: [Gluster-devel] Pull Request review workflow
If everyone agrees, I'll prepare a PR with the changes in rfc.sh and
documentation to implement this change.
Xavi
On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N < ravishan...@redhat.com > wrote:
On 15/10/20 4:3
If everyone agrees, I'll prepare a PR with the changes in rfc.sh and
documentation to implement this change.
Xavi
On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N
wrote:
>
> On 15/10/20 4:36 pm, Sheetal Pamecha wrote:
>
>
> +1
> Just a note to the maintainers who are merging PRs to have patience a
Hi Ravi,
On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N
wrote:
>
> On 15/10/20 4:36 pm, Sheetal Pamecha wrote:
>
>
> +1
> Just a note to the maintainers who are merging PRs to have patience and
> check the commit message when there are more than 1 commits in PR.
>
> Makes sense.
>
>
>>
>> Another
On 15/10/20 4:36 pm, Sheetal Pamecha wrote:
+1
Just a note to the maintainers who are merging PRs to have patience
and check the commit message when there are more than 1 commits in PR.
Makes sense.
Another thing to consider is that rfc.sh script always does a
rebase befor
Regards,
Sheetal Pamecha
On Thu, Oct 15, 2020 at 4:31 PM Amar Tumballi wrote:
> Thanks for taking time on this, and sending this note Xavi!
>
> Some comments inline!
>
> On Thu, Oct 15, 2020 at 4:03 PM Xavi Hernandez
> wrote:
>
>> Hi all,
>>
>> after the recent switch to GitHub, I've seen that
+1 for this. I too face the issue with losing old changes once a new commit
is pushed.
Regards,
Sheetal Pamecha
On Thu, Oct 15, 2020 at 4:03 PM Xavi Hernandez
wrote:
> Hi all,
>
> after the recent switch to GitHub, I've seen that reviews that require
> multiple iterations are hard to follow us
Thanks for taking time on this, and sending this note Xavi!
Some comments inline!
On Thu, Oct 15, 2020 at 4:03 PM Xavi Hernandez
wrote:
> Hi all,
>
> after the recent switch to GitHub, I've seen that reviews that require
> multiple iterations are hard to follow using the old workflow we were us
Hi all,
after the recent switch to GitHub, I've seen that reviews that require
multiple iterations are hard to follow using the old workflow we were using
in Gerrit.
Till now we basically amended the commit and pushed it again. Gerrit had a
feature to calculate diffs between versions of the patch
