Re: mpz_combit

2012-12-27 Thread Niels Möller
[ A late reply, regarding combit and friends ] Torbjorn Granlund t...@gmplib.org writes: I thought we had discussed this. The change is fine, optimising the common case is a great thing in general. Checked in a whiel ago. Did you consider analogous changes for the sibling functions, clrbit

Re: mpz_combit

2012-12-27 Thread bodrato
Ciao, Il Gio, 27 Dicembre 2012 12:12 pm, Niels ha scritto: Torbjorn Granlund t...@gmplib.org writes: I thought we had discussed this. The change is fine, optimising the common case is a great thing in general. Unfortunately, the common case is not tested by our testsuite!

Re: mpz_combit

2012-12-27 Thread Torbjorn Granlund
bodr...@mail.dm.unipi.it writes: Ciao, Il Gio, 27 Dicembre 2012 12:12 pm, Niels ha scritto: Torbjorn Granlund t...@gmplib.org writes: I thought we had discussed this. The change is fine, optimising the common case is a great thing in general. Unfortunately, the common case

Re: mpz_combit

2012-12-27 Thread bodrato
Ciao, Il Gio, 27 Dicembre 2012 10:39 pm, Torbjorn Granlund ha scritto: bodr...@mail.dm.unipi.it writes: Unfortunately, the common case is not tested by our testsuite! http://hydra.nixos.org/build/3594794/download/1/coverage/mpz/combit.c.gcov.html Only check-mini-gmp stress-tests it

Re: mpz_combit

2012-12-27 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: I have moved from meta files in the distribution/repo towards web in recent years. What purpose would moving in the other direction serve? It would make it a bit easier for other developers to 1. Locate the files. 2. Update the files. And I usually

Re: mpz_combit

2012-12-27 Thread Niels Möller
bodr...@mail.dm.unipi.it writes: About mpz_combit code, may I suggest replacing the two lines MPN_NORMALIZE (dp, dsize); ASSERT (dsize 0); with MPN_NORMALIZE_NOT_ZERO (dp, dsize); ? Conciseness is nice. Is that equivalent? I had some impression that the latter is