Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 19:17:02 CEST John Ralls wrote: > > On Aug 31, 2017, at 9:11 AM, Geert Janssens > > wrote:> > > On donderdag 31 augustus 2017 16:17:20 CEST Aaron Laws wrote: > >> On Thu, Aug 31, 2017 at 9:51 AM, Geert Janssens > >> >> > >> wrote: > >>> I meant to add still, if we w

Re: Gtk3 master

2017-08-31 Thread John Ralls
> On Aug 31, 2017, at 9:11 AM, Geert Janssens > wrote: > > On donderdag 31 augustus 2017 16:17:20 CEST Aaron Laws wrote: >> On Thu, Aug 31, 2017 at 9:51 AM, Geert Janssens >> wrote: >>> I meant to add still, if we want to keep guile 1.8 support, the >>> FIND_PACKAGE(GUILE_EXECUTABLE...) rules

Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 16:17:20 CEST Aaron Laws wrote: > On Thu, Aug 31, 2017 at 9:51 AM, Geert Janssens > wrote: > > I meant to add still, if we want to keep guile 1.8 support, the > > FIND_PACKAGE(GUILE_EXECUTABLE...) rules should move up inside the > > branches of > > the GUILE2 vs GUILE

Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 17:01:10 CEST Robert Fewell wrote: > Copied your changes locally and was able to build OK. > Bob > > On 31 August 2017 at 15:17, Geert Janssens > > wrote: > > On donderdag 31 augustus 2017 16:01:19 CEST Robert Fewell wrote: > > > It builds with "guile2.0" removed on

Re: Gtk3 master

2017-08-31 Thread Robert Fewell
Copied your changes locally and was able to build OK. Bob On 31 August 2017 at 15:17, Geert Janssens wrote: > On donderdag 31 augustus 2017 16:01:19 CEST Robert Fewell wrote: > > It builds with "guile2.0" removed on that line, also output of which > guile > > is /usr/bin/guile and that version i

Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 16:01:19 CEST Robert Fewell wrote: > It builds with "guile2.0" removed on that line, also output of which guile > is /usr/bin/guile and that version is 1.8.8. I do not have version 2 > installed. > Bob > Thanks for detailing this. It turns out the FIND_PROGRAM invocat

Re: Gtk3 master

2017-08-31 Thread Aaron Laws
On Thu, Aug 31, 2017 at 9:51 AM, Geert Janssens wrote: > I meant to add still, if we want to keep guile 1.8 support, the > FIND_PACKAGE(GUILE_EXECUTABLE...) rules should move up inside the > branches of > the GUILE2 vs GUILE1 test. > For GUILE2 it can remain > FIND_PROGRAM (GUILE_EXECUTABLE guile

Re: Gtk3 master

2017-08-31 Thread Robert Fewell
It builds with "guile2.0" removed on that line, also output of which guile is /usr/bin/guile and that version is 1.8.8. I do not have version 2 installed. Bob On 31 August 2017 at 13:44, Aaron Laws wrote: > On Thu, Aug 31, 2017 at 8:28 AM, Robert Fewell <14ubo...@gmail.com> wrote: > >> Just trie

Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 14:28:33 CEST Robert Fewell wrote: > Just tried to build from master after all the recent changes and it failed > on guile, currently I am running 1.8 and in the log file I see "Using > guile-1.8.x" but it then logs "The guile executable was not found, but is > require

Re: Gtk3 master

2017-08-31 Thread Geert Janssens
On donderdag 31 augustus 2017 14:28:33 CEST Robert Fewell wrote: > Just tried to build from master after all the recent changes and it failed > on guile, currently I am running 1.8 and in the log file I see "Using > guile-1.8.x" but it then logs "The guile executable was not found, but is > require

Re: Gtk3 master

2017-08-31 Thread Aaron Laws
On Thu, Aug 31, 2017 at 8:44 AM, Aaron Laws wrote: > On Thu, Aug 31, 2017 at 8:28 AM, Robert Fewell <14ubo...@gmail.com> wrote: > >> Just tried to build from master after all the recent changes and it failed >> on guile, currently I am running 1.8 and in the log file I see "Using >> guile-1.8.x"

Re: Gtk3 master

2017-08-31 Thread Aaron Laws
On Thu, Aug 31, 2017 at 8:28 AM, Robert Fewell <14ubo...@gmail.com> wrote: > Just tried to build from master after all the recent changes and it failed > on guile, currently I am running 1.8 and in the log file I see "Using > guile-1.8.x" but it then logs "The guile executable was not found, but i

Gtk3 master

2017-08-31 Thread Robert Fewell
Just tried to build from master after all the recent changes and it failed on guile, currently I am running 1.8 and in the log file I see "Using guile-1.8.x" but it then logs "The guile executable was not found, but is required. Please set GUILE_EXECUTABLE." Looking at CMakeLists.txt, I can build i