Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-25 Thread Daniel Harding
[resending to the list, because I realized my original reply went only to Andrew] Andrew Sackville-West wrote on 24 Dec 2007 9:12 PM: On Mon, Dec 24, 2007 at 03:04:00PM +0430, Daniel Harding wrote: Andrew Sackville-West wrote: On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-25 Thread Derek Atkins
Quoting Daniel Harding [EMAIL PROTECTED]: Found a build problem, at least on Windows. The Makefile attempts to create links to several .scm files from the build directory to the source directory. Because Windows filesystems do not support links, it simply does a copy instead. But, because

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-24 Thread Andrew Sackville-West
On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew Sackville-West wrote: Well 16690 breaks make check. meanwhile I discovered that src/engine/iso-currencies-to-c isn't getting run. At least it looks that way because its supposed to update iso-4217-currencies.c and it doesn't. That doesn't

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-24 Thread Andrew Sackville-West
On Mon, Dec 24, 2007 at 03:04:00PM +0430, Daniel Harding wrote: Andrew Sackville-West wrote: On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew Sackville-West wrote: Well 16690 breaks make check. meanwhile I discovered that src/engine/iso-currencies-to-c isn't getting run. At least it

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-24 Thread Derek Atkins
Andrew Sackville-West [EMAIL PROTECTED] writes: But interestingly, Derek reverted 16619 and that causes make check to succeed. Seems odd to me that adjusting a currency would cause 16619 to cause a test to break. So maybe there is more going on here than meets the eye. Somehow, the two

Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257

2007-12-23 Thread Derek Atkins
Andrew Sackville-West [EMAIL PROTECTED] writes: On Fri, Dec 21, 2007 at 01:53:39PM -0500, Andrew Sackville-West wrote: Author: andrewsw Date: 2007-12-21 13:53:38 -0500 (Fri, 21 Dec 2007) New Revision: 16690 Trac: http://svn.gnucash.org/trac/changeset/16690 Modified:

Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257

2007-12-23 Thread Andrew Sackville-West
On Sun, Dec 23, 2007 at 08:33:10PM -0500, Derek Atkins wrote: Quoting Andrew Sackville-West [EMAIL PROTECTED]: Well, I honestly don't know. Based on the political situation, I'd say it's highly likely that the old ones are still in circulation, but how many of those are being tracked in

16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-23 Thread Andrew Sackville-West
Well 16690 breaks make check. meanwhile I discovered that src/engine/iso-currencies-to-c isn't getting run. At least it looks that way because its supposed to update iso-4217-currencies.c and it doesn't. That doesn't seem to be the source of the failure but is something to note anyway. I did

Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257

2007-12-21 Thread Andrew Sackville-West
On Fri, Dec 21, 2007 at 01:53:39PM -0500, Andrew Sackville-West wrote: Author: andrewsw Date: 2007-12-21 13:53:38 -0500 (Fri, 21 Dec 2007) New Revision: 16690 Trac: http://svn.gnucash.org/trac/changeset/16690 Modified: gnucash/trunk/src/engine/iso-4217-currencies.scm Log: Daniel