Re: Git commit messages

2020-05-27 Thread jah
There are more conventional conventions [conventional-commits] that might also be considered. Conventional commits uses plain English to classify types of commit, for example: build, ci, chore, docs, feat, fix, perf, refactor, revert, style and test. Example commit message: --- feat: add

Re: Git commit messages

2020-05-27 Thread Schanzenbach, Martin
> On 27. May 2020, at 11:24, Florian Dold wrote: > > On 5/27/20 2:46 PM, Schanzenbach, Martin wrote: >> Here, a message of "fix #1234" is NOT sufficient. >> I have done so myself and have found ~50 in the current log since 0.12.1. >> Those are not useful messages. Having to do to mantis to

Re: Git commit messages

2020-05-27 Thread Florian Dold
On 5/27/20 2:46 PM, Schanzenbach, Martin wrote: > Here, a message of "fix #1234" is NOT sufficient. > I have done so myself and have found ~50 in the current log since 0.12.1. > Those are not useful messages. Having to do to mantis to check the changes > meaning > is quite annoying. Especially if

Re: Git commit messages

2020-05-27 Thread Schanzenbach, Martin
I would like to add something: > On 27. May 2020, at 09:56, Schanzenbach, Martin > wrote: > > B. Any other commit > Please formulate your commit message in a way that makes it understandable > what component was changed, > why it was changed and how. Possibly with an issue number if

Re: Git commit messages

2020-05-27 Thread Schanzenbach, Martin
> On 27. May 2020, at 10:39, Florian Dold wrote: > > On 5/27/20 1:58 PM, Daniel Golle wrote: >> Yes, let's please establish something like that. I've tried my best >> myself, but that's like 0.01% of GNUnet commits -- and of course, >> as was pointed out in a previous debate on that,

Re: Git commit messages

2020-05-27 Thread Florian Dold
On 5/27/20 1:58 PM, Daniel Golle wrote: > Yes, let's please establish something like that. I've tried my best > myself, but that's like 0.01% of GNUnet commits -- and of course, > as was pointed out in a previous debate on that, GNUnet is not the > Linux kernel and experimentation becomes very

Re: Git commit messages

2020-05-27 Thread Daniel Golle
On Wed, May 27, 2020 at 09:56:27AM +0200, Schanzenbach, Martin wrote: > Hi, > > I just finished cleaning up the neglected ChangeLog. We all (mostly me and > grothoff) gravely neglected > to update the file (no change since 0.12.1!) and it was quite a pain to go > through the git logs this >

Git commit messages

2020-05-27 Thread Schanzenbach, Martin
Hi, I just finished cleaning up the neglected ChangeLog. We all (mostly me and grothoff) gravely neglected to update the file (no change since 0.12.1!) and it was quite a pain to go through the git logs this time. In order to prevent this or at least make this easier in the future, it would