Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-03-01 Thread Fred Kiefer
On 01.03.2013 01:58, Jean-Charles BERTIN wrote: On Thu, 2013-02-28 at 14:13 +, David Chisnall wrote: On 27 Feb 2013, at 23:44, Jean-Charles BERTIN wrote: OK I admit I did that too quickly but I have push my changes on github a long time ago... What is the point to make a github account i

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-28 Thread Jean-Charles BERTIN
On Thu, 2013-02-28 at 14:13 +, David Chisnall wrote: > Hi, > > On 27 Feb 2013, at 23:44, Jean-Charles BERTIN wrote: > > > OK I admit I did that too quickly but I have push my changes on github a > > long time ago... > > What is the point to make a github account if nobody reviews the pull >

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-28 Thread David Chisnall
Hi, On 27 Feb 2013, at 23:44, Jean-Charles BERTIN wrote: > OK I admit I did that too quickly but I have push my changes on github a > long time ago... > What is the point to make a github account if nobody reviews the pull > requests? Since I saw no feedbacks from github I decided to push my > p

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-28 Thread Fred Kiefer
On 28.02.2013 00:44, Jean-Charles BERTIN wrote: OK I admit I did that too quickly but I have push my changes on github a long time ago... What is the point to make a github account if nobody reviews the pull requests? Since I saw no feedbacks from github I decided to push my patches on the mailin

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-27 Thread Jean-Charles BERTIN
BTW, I introduced objc_property_clean_abi attribute because I need to know if clang is able to generate the new ABI. I agree that we also need a main switch (ie. prepocessor macro) when compiling libobjc2 to generate the right stuff. We will then be able to generate old ABI even if clang have the o

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-27 Thread Jean-Charles BERTIN
OK I admit I did that too quickly but I have push my changes on github a long time ago... What is the point to make a github account if nobody reviews the pull requests? Since I saw no feedbacks from github I decided to push my patches on the mailing list: I did that by pushing every single git com

Re: [PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-27 Thread David Chisnall
I'm trying to review this, but it's impossible. Most of the changes are unexplained, or the explanations are just wrong. For example, changing the version from 1.7 to 1.8 (that won't happen until 1.7 is released). Resetting the CXX_FLAGS and C_FLAGS in the test is completely wrong, you should

[PATCH 00/13] Patches for handling property attributes correctly in objc.

2013-02-27 Thread Jean-Charles BERTIN
These are my patches to change ABI for property attributes on Objective-C. Actually, the behavior is clearly not the same as MacOS X. So this is my effort to correct this. These patches are strongly correlated with these I pushed on cfe-comm...@cs.uiuc.edu mailing list. Jean-Charles BERTIN (13):