Re: [go-nuts] accept4: too many open files;

2017-11-06 Thread Karan Chaudhary
CMIIW, I doubt if it is explicitly needed to close the request's body in handler, as it seems, close of request's body is handled by stdlib upon completion of handler. Handler, in net/http, is called here: https://github.com/golang/go/blob/master/src/net/http/server.go#L1804 Finish

RE: [go-nuts] accept4: too many open files;

2017-10-18 Thread Eliezer Croitoru
.@pinkfroot.com Sent: Wednesday, October 18, 2017 14:35 To: golang-nuts <golang-nuts@googlegroups.com> Subject: Re: [go-nuts] accept4: too many open files; In the end the fix seemed to be implementing some timeouts. I found a good guide here... https://blog.cloudflare.com/the-complete-guide-t

Re: [go-nuts] accept4: too many open files;

2017-10-18 Thread lee
In the end the fix seemed to be implementing some timeouts. I found a good guide here... https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/ On Tuesday, October 17, 2017 at 10:01:17 PM UTC+1, Tamás Gulácsi wrote: > > Yes. -- You received this message because you are

Re: [go-nuts] accept4: too many open files;

2017-10-17 Thread lee
This is 1.9.1 and I had not thought of switching to http2 although do need to maintain the 1.1 for older clients. The closing of the body could explain it though which I thought was automatic on a return from the handlers? Do I need to explicitly call that in the handlers?? -- You received

Re: [go-nuts] accept4: too many open files;

2017-10-17 Thread Shawn Milochik
What version of Go are you using? Have you tried HTTP/2? The only thing that jumps out at me is that r.Body() is never closed. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it,

[go-nuts] accept4: too many open files;

2017-10-17 Thread lee
I have the following code which was working fine in test but in live I am getting 500 errors reported to the clients with multiple lines of 2017/10/17 15:44:52 http: Accept error: accept tcp [::]:9090: accept4: too many open files; retrying in 1s 2017/10/17 15:44:53 http: Accept error: accept