Re: How does registerForProxyType works

2011-06-15 Thread Joshua Kappon
You need to cause a version change on the object to cause an update EntityProxyChange event. are you changing the version on the object once one of the clients is changing it? On Jun 15, 12:18 am, Aldo Neto tumo...@gmail.com wrote: Hi, Thanks for the hint, but unless I'm doing something wrong

Re: How does registerForProxyType works

2011-06-15 Thread Joshua Kappon
Disregard my last post, it doesn't work with multiple clients, only with one. On Jun 15, 9:37 am, Joshua Kappon shuky.kap...@gmail.com wrote: You need to cause a version change on the object to cause an update EntityProxyChange event. are you changing the version on the object once one of the

Re: How does registerForProxyType works

2011-06-15 Thread J.Ganesan
If you are on Google App Engine Channel API is useful, perhaps. If you are not on Google App Engine, websocket is the way to go for client-to- client communication. J.Ganesan www.DataStoreGwt.com On Jun 15, 2:18 am, Aldo Neto tumo...@gmail.com wrote: Hi, Thanks for the hint, but unless I'm

Re: JClassType source and isGenericType()

2011-06-15 Thread Adolfo Panizo Touzon
JClassType[] typeArgs = type.getImplementedInterfaces()[0].isParameterized().getTypeArgs(); JClassType elementType = typeArgs[0]; Did you try with getTypeArgs(); 2011/6/14 pansen andi.ba...@googlemail.com hi, assuming i'm in a generator and receive a ``JClassType source`` which

Re: JQuery slider alternate

2011-06-15 Thread Deepak Singh
Hi All, Any idea is greatly welcome. On Sat, Jun 11, 2011 at 4:44 PM, Deepak Singh deepaksingh...@gmail.comwrote: Hi All, I am using gwtquery just because of JQuery two way slider component. I need to know that is there any similar kind of component available in GWT/3rd part widgets?

Re: JQuery slider alternate

2011-06-15 Thread Alain Ekambi
Maybe you could just wrap that with a GWT API ? 2011/6/15 Deepak Singh deepaksingh...@gmail.com Hi All, Any idea is greatly welcome. On Sat, Jun 11, 2011 at 4:44 PM, Deepak Singh deepaksingh...@gmail.comwrote: Hi All, I am using gwtquery just because of JQuery two way slider component.

Re: Intercept basic authentication popup

2011-06-15 Thread koma
same prob. Firefox supports something like *mozBackgroundRequest* *Not sure how to set this property for a JSONP call though. Even then, only works for FF, chromium has a ticket openhttp://code.google.com/p/chromium/issues/detail?id=31582, found nothing about IE. * * * * * *I'd like to save my

Re: JQuery slider alternate

2011-06-15 Thread Deepak Singh
I am wrapping it currently with gwtquery and working fine. But i dont want to use JQuery at all. Thus i am looking for similar component in gwt. Any idea ? Thanks On Wed, Jun 15, 2011 at 3:59 PM, Alain Ekambi jazzmatad...@googlemail.comwrote: Maybe you could just wrap that with a GWT API ?

Re: JClassType source and isGenericType()

2011-06-15 Thread lemaiol
How is it defined? is it something like: private FooBar value; or like: private FooBar value; where FooBar is public class FooBar extends FooBar {... If it is the first, the problem is type erasure in Java generics. From the declaration of the field, you cannot read the type. If you use the

Re: Local filesystem access

2011-06-15 Thread gwt_user
Thanks Juan! Does anyone has any other recommendation? Thanks in advance! On Jun 14, 10:01 am, Juan Pablo Gardella gardellajuanpa...@gmail.com wrote: I think you can use gwt4air (use flash) . Juan 2011/6/14 gwt_user csde...@gmail.com Hi, We need to be able to access physical

Re: GWT MVP GIN - problem with nested views and presenters

2011-06-15 Thread ricu
Anybody? Maybe someone has the same architecture without GIN. What is your experience? On 13 lip, 21:16, ricu marko.c...@gmail.com wrote: Hi! We are usingGINin our application which is constructed in MVP style. We tried to follow some best practices described in GWT pages and here in GWT

Re: Pluggable modules

2011-06-15 Thread Daniel G
Hi Berto, Hi Mike, can you give me some more details about your plugin-design? What architecture are you using for the several applications, MVC or MVP? Regards, Daniel On 11 Jun., 20:36, lemaiol lema...@gmail.com wrote: HI Mike, If I got it right, you want a main GWT application (own WAR)

Set-Cookie Being Ignored

2011-06-15 Thread JPJenkins69
I am a GWT noob but am working with someone else who is more advanced than I, and we cannot figure out why a cookie being returned by the server as a Set-Cookie HTTP header is not actually being set in the browser. I wrote a server using Tomcat that has an authentication call. I wrote a dummy

Overriding Css Styles Defined via CssResource ..

2011-06-15 Thread El bassistos
I have made reusable GWT Widget which uses CssResources, where I have marked all the styes as @external so they are not obfuscated. I now want to override some of the styles in plain standard HTML web site. The website is not GWT project so I can't override the styles in a module.gwt.xml file..

Re: Refreshing a celltree

2011-06-15 Thread auto hinnak
I had a similar problem. I wanted to refresh a part of the tree when i add/delete/update new items of the CellTree. To solve this, I used a map in my TreeModel to store the NodeInfo of a tree item (in my case a category). Thats enabled me to acces the DataProvider of a tree item in the Activity

I have 3 places which correspond to different regions,demo at http://demo4gwt.ecardbase.com/

2011-06-15 Thread sugar_xj
the method I Override is the key to implement multiple place -- ActivityManager activityManager = new ActivityManager(cached, eventBus){ @Override public void onPlaceChange(PlaceChangeEvent event) {

Re: Setting initial focus with UiBinder

2011-06-15 Thread Tim Barthel
Thanks Chris, that works. It took me a while to figure out where to put the calls because my app follows the MVP sample app pattern. It still seem like a UiBinder bug and I will submit it as such. On Jun 11, 5:17 pm, Chris McBrien chris.mcbr...@sjrb.ca wrote: Try Googling scheduler

Standalone zip download of GWT Designer

2011-06-15 Thread beluga
Hi - I don't get through the corporate firewall with eclipse updater but I can transfer a zip file if I get hold of it. Does anyone know how to get hold of the GWT Designer standalone zip? Ideally the beta, since I'm struggling with the type not found bug in the current GWT release. Thanks! --

Re: I have 3 places which correspond to different regions,demo at http://demo4gwt.ecardbase.com/

2011-06-15 Thread Thomas Broyer
Ouch! Total misunderstanding! First, a Place is akin to a URL, it represents the current state of your app. Given a Place instance, you should be able to determine which Activity goes into each region (btw, that's the role of ActivityMappers to return an Activity given a Place). You should

Re: Local filesystem access

2011-06-15 Thread Alain Ekambi
If you mean with any other recommendation a solution that does not require a plugin like Flash you can try the HTML5 file API. But the API is still primitive and not cross browser(IE). If you are willing to use Flash you can have a look at this demo:

Sending large nested DTO object over RPC - Browser freezes

2011-06-15 Thread Jonas
In my GWT program I parse a large xml file using JAXB on the server side and then convert these objects into DTO. They contain a lot of strings, doubles, and integers in a nested hierarchy. I'm using ArrayList as collection for the nested objects. The problem is that when I send this over RPC

Re: Sending large nested DTO object over RPC - Browser freezes

2011-06-15 Thread brancoch
You probably can try the com.google.gwt.rpc.RPC module though it has been experimental for awhile. It seems to be a more efficient way of encoding and decoding. To use it it is almost the same as the other RPC: 1- Inherit the module: inherits name='com.google.gwt.rpc.RPC'/ 2- Have you service

Re: Overriding Css Styles Defined via CssResource ..

2011-06-15 Thread Jeff Larsen
The styles from CSS resource are always going to be loaded after any static .css files. They are programatically injected (CssResource#ensureInjected()) One option would be to not use CssResource, but that is probably a bad one. Someone else solved this problem pretty elegantly

Re: Local filesystem access

2011-06-15 Thread Norberto
Maybe you can use an applet to access the file system See this project: http://code.google.com/p/gwtai/ On Jun 14, 10:48 am, gwt_user csde...@gmail.com wrote: Hi, We need to be able to access physical files system from GWT application. Does anyone have any suggestions? Thanks! -- You

Re: Sending large nested DTO object over RPC - Browser freezes

2011-06-15 Thread Paul Stockley
Is this in dev mode or the final compiled JS? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/2rMFOfp5uN0J. To post to this group, send email to

odd problem with events (registering, sending, receiving Order) and place-change

2011-06-15 Thread tanteanni
i just finished my first own example with activities/places and MVP. all works fine but some events aren't send or received properly if i change back to a place (from another place). but on moduleLoad where this place is set as default place all works fine. i think it shouldn't make a

Re: CheckBoxSelectionModel

2011-06-15 Thread Brian Reilly
Look at the CellTable example in the Showcase application: http://gwt.google.com/samples/Showcase/Showcase.html#!CwCellTable The source code is viewable from that page as well. -- Brian 2011/6/14 NANOUS gaied.a...@gmail.com: Bonjour, Comment je peut ajouter un ActionListener à une grid

Re: I have 3 places which correspond to different regions,demo at http://demo4gwt.ecardbase.com/

2011-06-15 Thread sugar_xj
you said (a Place is akin to a URL, it represents the current state of your app.), in my app this url (http://demo4gwt.ecardbase.com/#exam:5--student:4-- menu:admin) represents 3 regions activity's lastPlaceName(with token), current state is exam:5,student:5 and menu:admin is other region's last

Re: FireFox 5.0

2011-06-15 Thread Khun Yee Fung
I got FF5.0 when I updated my Ubuntu development box last week. A mistake somewhere? I rolled it back to FF4.0.1 when the GWT plugin would not run on it. If you don't want to wait until FF5.0 is supported by GWT, you can roll FF back to 4.0.1. To roll back to 4.0.1, 1. Start Synaptic Package

Re: I have 3 places which correspond to different regions,demo at http://demo4gwt.ecardbase.com/

2011-06-15 Thread Thomas Broyer
I'm totally lost as to how your (sample) app is expected to behave. Still, exam:5--student:4--menu:admin represents somewhere, some instance of some Place class that holds this state. You'll have a PlaceTokenizer building this instance from that token. then, when the place is given to any of

Re: When will get Multiple-File-Input(input type=file multiple= /) supported?

2011-06-15 Thread Thomas Broyer
JSNI and JavaScriptObject overlay types FTW! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/lNk39MwjwWgJ. To post to this group, send email to

Re: When will get Multiple-File-Input(input type=file multiple= /) supported?

2011-06-15 Thread Alex Luya
Actually,same thing can be done in uibinder's xml file,but question is how to get selected file list: - private VerticalPanel vPanel; public void onModuleLoad() { VerticalPanel wrapper = new VerticalPanel(); final FileUpload

Re: FireFox 5.0

2011-06-15 Thread Thomas Broyer
…or check your software sources (don't know how they call it in English, but well, your package sources) and make sure you don't have any Firefox-related PPA, such as http://ppa.launchpad.net/mozillateam/firefox-next/ubuntu or http://ppa.launchpad.net/mozillateam/ppa/ubuntu. Or maybe you're

Ang.: Re: Sending large nested DTO object over RPC - Browser freezes

2011-06-15 Thread Jonas
This is hosted mode and on my intel core i3 work laptop. I tried the same code on my home computer and there it was much faster, around 5 seconds instead of 16. But still, far from what I had expected. I'll try and see what the speed is when deployed. -- You received this message because you

Re: How to use a ComplexPanel with an ActivityManager

2011-06-15 Thread Corey
Ok, so when I was having this problem I was just experimenting with the very simple UI that comes with the sample app. I also tried keeping the SimplePanel and having the Activity return a HeaderPanel consisting of a label and an image (the second method mentioned in Ashton's Answer). I thought

Question about new activities on place changes

2011-06-15 Thread Jens
Hi, I just integrating activities and got stuck when it comes to list selections. Hopefully someone with more practically experience can help me. The application has one activity mapper that holds providers (GIN) of activity proxies (code splitting) and creates new, clean activity instances

Re : Re: CellTree SingleSelectionModel

2011-06-15 Thread mkkm...@gmail.com
It works thanks ! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/2zGBIQvEyjIJ. To post to this group, send email to

Re: FireFox 5.0

2011-06-15 Thread Chris Conroy
Given that Mozilla has a very recent track record of making binary incompatible changes leading up to release (even after claiming they were frozen), it doesn't make sense for us to invest any time in supporting FF5 until we have at least some notion of the binary interfaces being stable.

Re: Local filesystem access

2011-06-15 Thread gwt.user
Applet ? What s that ? :) Either you use HTML5 API (really limited) or flash(gwt4air) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: GWT 2.1 MVP Multiple activities clarification help

2011-06-15 Thread ustad
Hi all, I'm new to GWT (and more of an advanced beginner with java at that too) and I just worked through the stockwatcher example as posted on the official google page using the latest gwt 2.3 sdk and plugin using eclipse. So far so good. However, when trying to incorporate an MVP design

Re: Sending large nested DTO object over RPC - Browser freezes

2011-06-15 Thread ciosbel
Try to use this to better inspect RPC serialization/deserialization and round trip timings. http://code.google.com/p/gwt-debug-panel/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: GWT and Maven

2011-06-15 Thread Rob
Hi, You might find this post helpful as well - http://uptick.com.au/content/getting-started-gwt-maven-and-eclipse Cheers Rob On Jun 8, 10:57 pm, SrArcos srar...@gmail.com wrote: Thanks, I'll check my pom.xml comparing it with yours. Thank you very much. I'll tell you On 8 jun, 07:07, Juan

Expenses example appears broken

2011-06-15 Thread Thad
I'm starting my second GWT project, and trying to do things the MVP way this time. HelloMVP is so trivial as to be nearly useless. The Contacts examples doesn't use Activities and Places. So I'm trying to look at samples/Expenses, but it appears broken. I've little maven experience, but when I

Re: Pluggable modules

2011-06-15 Thread kendeng9898
Hi Berto, Waiting for more details. give some simple sample code is appreciate. Since the compilation speed easy development, I've changed to use pyjamas project, a python verion of GWT. But I still interesting in how to do the plugin. The hardest part is how to solved the different

Re: Widget not displayed upon change of place

2011-06-15 Thread Juan Pablo Gardella
Hi Harry Can you resolve the problem? If not, in onStop() or onCancel() you must unregistrer your handlers. Not about display regions. Try put your do the placeChangeEvent like this: Scheduler.get().scheduleDeferred(new ScheduledCommand() { @Override public void execute() {

Re: Ref: Jdoconfig.xml

2011-06-15 Thread Juan Pablo Gardella
Read this tutorial. http://lesca.me/docs/local/gae/appengine/docs/java/datastore/usingjdo.html . I think you have some options checked in GAE eclipse plugin to use jdo. 2011/6/14 sam sanj.kan...@gmail.com Hi All, During the build process a copy of jdo-config.xml is created in the WAR

Re: GWT MVP GIN - problem with nested views and presenters

2011-06-15 Thread Juan Pablo Gardella
The problem is that we get two objects of the sub-widget class becouse this widgets aren't singletons. 2011/6/15 ricu marko.c...@gmail.com Anybody? Maybe someone has the same architecture without GIN. What is your experience? On 13 lip, 21:16, ricu marko.c...@gmail.com wrote: Hi! We

Re: Intercept basic authentication popup

2011-06-15 Thread Juan Pablo Gardella
If you use gwt-rpc, make a default asyncallback like this: public abstract class DefaultAsyncCallbackT implements com.google.gwt.user.client.rpc.AsyncCallbackT { private static final char flag = '0'; @Override public void onFailure(Throwable e) { if (isUnAuthenticatedUser(e)) showLogin(); } }

Re: Question about new activities on place changes

2011-06-15 Thread Juan Pablo Gardella
I think you can use a singleton in client side to manage getEmployesOf(employer). You can cache the last query. 2011/6/15 Jens jens.nehlme...@gmail.com Hi, I just integrating activities and got stuck when it comes to list selections. Hopefully someone with more practically experience can

Re: GWT 2.1 MVP Multiple activities clarification help

2011-06-15 Thread Juan Pablo Gardella
Check this samplehttps://bitbucket.org/gardellajuanpablo/gwt-sample/wiki/Home 2011/6/15 ustad ustadha...@gmail.com Hi all, I'm new to GWT (and more of an advanced beginner with java at that too) and I just worked through the stockwatcher example as posted on the official google page using the

gwt-dev.jar and embedded Tomcat; Conflicts!

2011-06-15 Thread WulfgarPro
Hi, I am using GWT-2.2.0 with NetBeans 7 and Tomcat 7.0.11. In my unit testing I am using embedded Tomcat (see excepts below). public static void startTomcatInstance() throws MalformedURLException, LifecycleException { tomcat = new Tomcat(); tomcat.setBaseDir(.);

Re: GWT 2.1 MVP Multiple activities clarification help

2011-06-15 Thread tanteanni
i didn't read all post, but i ran into similar problems. now i got something that's working for me: i decoupled activities/places and MVP (what thomas suggested in many places). in my case the VP-pairs are controlling/filling display areas and one activity is starting/ controlling them.

[gwt-contrib] RE:Re-roll issue 1442804: SafeHtmlRenderer code gen for UiBinder (issue1453812)

2011-06-15 Thread Rodrigo Chandia
Ready! On Jun 14, 2011 8:07 PM, Ray Ryan rj...@google.com wrote: Ready for review? On Mon, Jun 13, 2011 at 8:17 AM, rchan...@google.com{subItem.from.uri} wrote: http://gwt-code-reviews.appspot.com/1453812/ http://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1453812/ --

[gwt-contrib] Add some test framework code for RequestFactory to support simple load testing. (issue1453814)

2011-06-15 Thread bobv
Reviewers: rjrjr, Description: Add some test framework code for RequestFactory to support simple load testing. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1453814/ Affected files: M

[gwt-contrib] Re: Reduce the use of old event bus classes. The only public api that (issue1446819)

2011-06-15 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/1446819/diff/3008/user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java File user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java (right):

[gwt-contrib] Re: Add some test framework code for RequestFactory to support simple load testing. (issue1453814)

2011-06-15 Thread t . broyer
http://gwt-code-reviews.appspot.com/1453814/diff/1/user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java File user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java (right):

[gwt-contrib] Re: Add some test framework code for RequestFactory to support simple load testing. (issue1453814)

2011-06-15 Thread bobv
http://gwt-code-reviews.appspot.com/1453814/diff/1/user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java File user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java (right):

[gwt-contrib] Re: Add a compile-time check against provided UiFields for RenderablePanel. I want to add the same c... (issue1454812)

2011-06-15 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1454812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread zundel
http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10338 committed - Add a compile-time check against provided UiFields for RenderablePanel...

2011-06-15 Thread codesite-noreply
Revision: 10338 Author: rdcas...@google.com Date: Wed Jun 15 06:24:57 2011 Log: Add a compile-time check against provided UiFields for RenderablePanel. I want to add the same check for HTMLPanel, but since that'll probably break a lot of people, it'd be better to do it in a

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread aizatsky
Looks good. Thanks for handling this. http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Ensure all ProxyAutoBeans not directly referenced from root object or via a shim can be garbage-... (issue1451819)

2011-06-15 Thread bobv
Reviewers: rjrjr, Message: Approach adapted from http://gwt-code-reviews.appspot.com/1401802 without having to deal with ClassLoader complications from mixing additional interfaces into Proxy (that seemed to cause weird problems with emma-enabled builds). This patch includes the changes in

[gwt-contrib] Re: A general purpose script injection class for injecting a script directly (issue1451818)

2011-06-15 Thread zundel
http://gwt-code-reviews.appspot.com/1451818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread jbrosenberg
LGTM w/some nits it looks like CfgBuild could be made such that individual visit methods are a bit more self-contained. It shouldn't be possible for a visitor to an inner loop to modify the unlabeled break/continue statements of an outer loop, etc. Removing them and replacing them at the end,

[gwt-contrib] Add compile-time check to prevent provided fields for HTMLPanels. (issue1459801)

2011-06-15 Thread rdcastro
Reviewers: rjrjr, rchandia, Description: Add compile-time check to prevent provided fields for HTMLPanels. Please review this at http://gwt-code-reviews.appspot.com/1459801/ Affected files: M user/src/com/google/gwt/uibinder/elementparsers/HTMLPanelParser.java Index:

[gwt-contrib] [google-web-toolkit] r10339 committed - create the 2.4 release branch

2011-06-15 Thread codesite-noreply
Revision: 10339 Author: mrruss...@google.com Date: Wed Jun 15 13:00:31 2011 Log: create the 2.4 release branch http://code.google.com/p/google-web-toolkit/source/detail?r=10339 Added: /releases/2.4 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add compile-time check to prevent provided fields for HTMLPanels. (issue1459801)

2011-06-15 Thread rjrjr
On 2011/06/15 18:59:32, rdcastro wrote: LGTM http://gwt-code-reviews.appspot.com/1459801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10340 committed - Add compile-time check to prevent provided fields for HTMLPanels....

2011-06-15 Thread codesite-noreply
Revision: 10340 Author: rdcas...@google.com Date: Wed Jun 15 11:05:55 2011 Log: Add compile-time check to prevent provided fields for HTMLPanels. Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10340 Modified:

[gwt-contrib] [google-web-toolkit] r10341 committed - Fix handling of unlabeled break and continue in gflow....

2011-06-15 Thread codesite-noreply
Revision: 10341 Author: gwt.mirror...@gmail.com Date: Wed Jun 15 12:44:51 2011 Log: Fix handling of unlabeled break and continue in gflow. This fixes issues: http://code.google.com/p/google-web-toolkit/issues/detail?id=6272

[gwt-contrib] Re: Add some test framework code for RequestFactory to support simple load testing. (issue1453814)

2011-06-15 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1453814/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Improve GwtAstBuilder output when stack emulation is enabled. (issue1460801)

2011-06-15 Thread scottb
Reviewers: jbrosenberg, zundel, http://gwt-code-reviews.appspot.com/1460801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right):

[gwt-contrib] Re: Reduce the use of old event bus classes. The only public api that (issue1446819)

2011-06-15 Thread rjrjr
Submitting http://gwt-code-reviews.appspot.com/1446819/diff/3008/user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java File user/src/com/google/gwt/event/shared/LegacyHandlerWrapper.java (right):

[gwt-contrib] Re: Reduce the use of old event bus classes. The only public api that (issue1446819)

2011-06-15 Thread rjrjr
http://gwt-code-reviews.appspot.com/1446819/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-roll issue 1442804: SafeHtmlRenderer code gen for UiBinder (issue1453812)

2011-06-15 Thread rjrjr
Just a couple of questions on the test http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/text/shared/UiRenderer.java File user/src/com/google/gwt/text/shared/UiRenderer.java (right):

[gwt-contrib] Re: Ensure all ProxyAutoBeans not directly referenced from root object or via a shim can be garbage-... (issue1451819)

2011-06-15 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/gwt/core/client/impl/WeakMapping.java File user/src/com/google/gwt/core/client/impl/WeakMapping.java (right):

[gwt-contrib] [google-web-toolkit] r10342 committed - Reduce the use of old event bus classes. The only public api that...

2011-06-15 Thread codesite-noreply
Revision: 10342 Author: rj...@google.com Date: Wed Jun 15 14:22:27 2011 Log: Reduce the use of old event bus classes. The only public api that still mentions the gwt EventBus explicitly at this point is the Activity interface. Not much to be done about that, and maybe DrivesWidgets

[gwt-contrib] Re: Improve GwtAstBuilder output when stack emulation is enabled. (issue1460801)

2011-06-15 Thread jbrosenberg
LGTM w/nit http://gwt-code-reviews.appspot.com/1460801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (left):