http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/gwt/core/client/impl/WeakMapping.java
File user/src/com/google/gwt/core/client/impl/WeakMapping.java (right):
http://gwt-code-reviews.appspot.com/1453814/diff/1/user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java
File
user/src/com/google/web/bindery/requestfactory/vm/testing/UrlRequestTransport.java
(right):
I didn't look thoroughly at the changes but I like the overall changes
(wait 'til all invocations are processed to resolve properties +
splitting property resolving and client peer construction), and as long
as the tests are green… ;-)
[+cc google-web-toolkit-contributors]
I don't know why I've been added as a reviewer here, but here are a few
comments. (beware, I'm not in the GWT Team)
http://gwt-code-reviews.appspot.com/1454804/diff/7002/user/src/com/google/gwt/uibinder/elementparsers/AbsolutePanelParser.java
File
Patchset #2:
Extracts isValidUriCharset from isValidUri, with a specific test.
Adds test cases to test suites.
Adds a few tests and fixes another few (including a risk of false
positives in SafeHtmlHostedModeUtilsTest).
Fixed copyright dates on a the new files.
Note that I didn't
http://gwt-code-reviews.appspot.com/1449814/diff/5/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
File user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
(right):
Just gave it a quick look.
- There should be overloads with SafeUri for (at least)
from/appendTrustedNameAndValue and for/appendBackgroundImage adding
url( and ) around the SafeUri#asString() value.
- There's a TODO in ClippedImageImplSomething about using these methods
once they're
On 2011/06/07 16:34:24, xtof wrote:
Thomas, here's a patch that adds a test case to repro the bug
FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the
testFromTrustedString_withInvalidUrl fails to throw the expected
IllegalArgumentException; which means the surrogate-pair
On 2011/06/08 14:48:12, tbroyer wrote:
On 2011/06/07 16:34:24, xtof wrote:
Thomas, here's a patch that adds a test case to repro the bug
FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the
testFromTrustedString_withInvalidUrl fails to throw the expected
Reviewers: xtof, rjrjr, jlabanca, jat, pdr,
Message:
Rewrite SafeUriHostedModeUtils#isValid without regexp to workaround what
looks like a bug in the Sun/Oracle JVM (error not reproduced with
OpenJDK).
This is a follow-up to issue
http://gwt-code-reviews.appspot.com/1443813/ so I set the same
On 2011/06/08 15:00:42, tbroyer wrote:
On 2011/06/08 14:48:12, tbroyer wrote:
On 2011/06/07 16:34:24, xtof wrote:
Thomas, here's a patch that adds a test case to repro the bug
FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the
testFromTrustedString_withInvalidUrl fails to
http://gwt-code-reviews.appspot.com/1449814/diff/1/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
File user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
(right):
On 2011/06/07 16:34:24, xtof wrote:
Thomas, here's a patch that adds a test case to repro the bug (also
changing
uses of fromTrustedString to fromSafeConstant where appropriate).
Would you be able to look into rewriting the regex? My best guess is
that
it's falling afoul of
Hi,
I think you can do this relatively simply, but it's not directly noted
in the documentation.
(warning, a little plug ahead...) We're looking at how to do this for
the 2nd edition of the GWT in Action book, and the approach below is
where we are at the moment, though we have not thought
Just a few comments on the JSNI part.
I was curious about what a PotentialElement would be, but I haven't
followed how IsRenderable work so I really don't have any opinion on the
rest of this proposal.
On 2011/06/01 04:48:04, xtof wrote:
On 2011/06/01 00:10:58, tbroyer wrote:
On 2011/05/31 23:38:17, xtof wrote:
My apologies dropping the response on this thread (I'd missed the
last
question and had assumed this was good to submit).
Also, I didn't realize that I actually need to fetch
On 2011/05/31 23:38:17, xtof wrote:
My apologies dropping the response on this thread (I'd missed the last
question and had assumed this was good to submit).
Also, I didn't realize that I actually need to fetch and submit this
patch
(I'm not part of GWT team proper and wasn't familiar with
I'll let fabbott continue the review, unless you have remarks on my
comments.
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java
File
user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java
(right):
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java
File
user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java
(right):
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/test/com/google/gwt/animation/AnimationTest.gwt.xml
File user/test/com/google/gwt/animation/AnimationTest.gwt.xml (right):
I only gave it a glance but here are a few comments:
- while I like the public requestAnimationFrame API, I don't like the
static methods
- I don't quite like the ImplMozilla/ImplWebkit extends ImplTimer
pattern
See details inline.
http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode56
LGTM too; that was indeed simple!
http://gwt-code-reviews.appspot.com/1448803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1377804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/05/03 17:51:18, rjrjr wrote:
Running ant clean dist-dev test, this appears to break the i18n suite
under
html unit.
Oops! Only tested with a -Dgwt.junit.testcase.includes (which obviously
didn't include I18N tests)
That seems weird though that simply running the JVM in a different
A sample code being worth thousands words, here are my little
findings. I'm aware that using long all the way may have got me out of
trouble, but I wanted to share these weird results that some may
consider as a bug. In hosted mode there is no pb. The comments
contains the content of the popups in
http://gwt-code-reviews.appspot.com/1401802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr, bobv,
Description:
Force locale to en_US for user unit tests
Force locale to en_US for user unit tests, otherwise validation tests
fail (use hard-coded checks on locale-dependent messages)
Please review this at http://gwt-code-reviews.appspot.com/1430801/
Affected files:
M
http://gwt-code-reviews.appspot.com/1371801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/05/03 16:11:37, xtof wrote:
http://gwt-code-reviews.appspot.com/1380806/diff/28033/user/src/com/google/gwt/safehtml/shared/SafeUri.java
File user/src/com/google/gwt/safehtml/shared/SafeUri.java (right):
I addressed the feedback (including Brian's one, adding a paragraph to
SafeUri javadoc) and formatted the files.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java
File user/src/com/google/gwt/resources/client/ImageResource.java
My 2c.
http://gwt-code-reviews.appspot.com/1428809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
File
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
(right):
I am using GWT 2.2.0 with RequestFactory and the Editor framework.
What is the recommended way to keep to 2 editors in sync with a shared
proxy object attribute (the same object attribute is displayed in 2
editors)? I tried the following but ran into a few issues:
Using
Hey, it looks like it would fix this issue, cool!
http://code.google.com/p/google-web-toolkit/issues/detail?id=4893
According to my tests at the time, it would enable pruning of most
getClass() methods (at a minimum all those for abstract classes, which
are always overridden in the concrete
I didn't address Brian's requests because I honestly didn't know what to
put (javascript: URIs? an example of data: URI with HTML or SVG
containing a script?)
http://gwt-code-reviews.appspot.com/1380806/diff/25001/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
I wrote it down yesterday evening, and the method is now gone, but
anyway:
http://gwt-code-reviews.appspot.com/1420808/diff/1/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java
File user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java
(right):
Sorry, I'm a bit late...
http://gwt-code-reviews.appspot.com/1420808/diff/6004/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java
File user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java
(right):
On 2011/04/21 19:36:37, rjrjr wrote:
LGTM
Wow. Wow. This is a very big deal, and from such a simple change!
Which to me leaves the question: is our usage described at [1] an
intended use case, that's here to stay? or simply a fortunate
unspecified behavior, and we should change our code to
On 2011/04/19 17:01:54, Daniel wrote:
Hi All,
I've uploaded another patch to Rietveld at
http://gwt-code-reviews.appspot.com/1427802/ . Could somebody please
review
this for me?
Because not everyone will see the comment in the issue tracker: I sent a
similar patch, which BobV started
I probably won't have time to update the patch before (at least) the
second half of the week, so here's my first reaction to your comments
http://gwt-code-reviews.appspot.com/1380806/diff/25001/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
File
http://gwt-code-reviews.appspot.com/1427801/diff/1/user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java
(right):
It took me a bit more time than I initially thought but I'm happy with
what I finally came up with!
Following Postel's law, we're lenient in what we're accepting as valid
URIs (using the Web Addresses character set from iri-bis, initially
coming from HTML5) but strict in what we produce from
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java#newcode108
On 2011/04/11 23:18:13, xtof wrote:
If we're both in agreement on that, I think we should change the doc
of the
SafeUri contract to be a bit more specific about that. I.e., instead
of
18 /**
19 * An object that implements this interface encapsulates a URI
that is
20 * guaranteed
See my comments here http://gwt-code-reviews.appspot.com/1384802/ and
here
http://code.google.com/p/google-web-toolkit/issues/detail?id=5807#c3
In brief:
- there has to be an annotation added to these specific RequestContext
interfaces (also, they might not extend RequestContext and they don't
I followed the approach from the SafeStyles for the checks in the
generator, with the exception that I log a warning rather than throw
when a SafeUri is used outside a URL attribute context.
I updated the ClippedImageImpl's internal SafeHtmlTemplates so it
doesn't log such a warning, and fixed a
On 2011/04/10 18:32:38, xtof wrote:
I think this is pretty much ready, except for one thing I just thought
of.
Sorry, I should have thought of that earlier :/
In ClippedImageImpl, we're using a SafeUri in the context of a url()
style
expression (background: url({3})). However, the
I introduced an IsShim interface that all AutoBean shims (whether
generated or VM proxies) implement to get the associated AutoBean back,
instead of using WeakMapping.
WeakMapping is now only used when the key is a wrapped object. This
still causes a leak if the developer fails to unwrap() the
The scenario:
I have a form where you can create a new person by entering name in a
textbox and click a button. When the user clicks the button I grab the
value from the textbox and sets it on the Person object. The Person
object validates the value and makes sure the name on the object only
Ok, I see. The problem I have right now is that I need to style all
textboxes that are disabled but I can't find any selector that will
work with this markup.
I can't use this one:
input.gwt-TextBox[disabled='disabled']
and this one doesn't work in IE (tested in IE9):
Maybe this will work :) Just tested in IE9 and it seems to work...
input.gwt-TextBox[disabled]
I'm using the X-UA-Compatible IE=8 and GWT 2.2.0 btw...
On 7 Apr, 14:13, Stephan T stephan.tern...@gmail.com wrote:
Ok, I see. The problem I have right now is that I need to style all
textboxes
When I call the method TextBox.setEnabled(false) the textbox element
does not get the correct markup.
The markup is:
input type=text class=gwt-TextBox disabled=
The markup should be:
input type=text class=gwt-TextBox disabled=disabled
Is this a bug or feature?
--
You received this message
LGTM
Now, what's the expected behavior for SafeUri?
- URL_ATTRIBUTE_ENTIRE = OK
- URL_ATTRIBUTE_START = log a warning ? throw ?
- others = OK ? log a warning ? (note that the previously mentioned
URL attributes introduced by HTML5, which include video poster= for
instance, will fall in this
Reviewers: bobv,
Message:
We've been running with this patch for 6 weeks or so and it's highly
misleading to have it logged as an error with a full stack-trace.
I'll update the patch to log a warning instead (or maybe only an info?)
and only include the exception's getLocalizedMessage (or
On 2011/04/01 21:31:53, zundel wrote:
My question on this is, why does the Editor create such long
filenames? Could
we address that in the Editor generator? If you turn on -gen, you
want to see
files and even after this patch, you won't have a way to get them.
I agree that a proper fix
Sorry, it took me some time but I went read the StreamHtmlParser code to
better understand how it works, and how it's used here in the generator.
I thus found that there's a special-case for meta refresh that this
patch doesn't handle (see comments below), and that the ATTR_TYPE.URI is
based on
On 2011/04/01 21:31:53, zundel wrote:
My question on this is, why does the Editor create such long
filenames?
Have a look at
http://code.google.com/p/google-web-toolkit/issues/detail?id=6016 which
calls for even longer names (that's how the patch at
http://gwt-code-reviews.appspot.com/1352806
);
+assertEquals(newValue, cw.getValue());
}
public void testOnBrowserEventWithKeyProvider() {
@@ -135,6 +136,7 @@ public class CellWidgetTest extends GWTTestCase {
cw.onBrowserEvent(event);
cell.assertLastEventKey(t);
cell.assertLastEventValue(test);
+assertEquals
Reviewers: rjrjr, bobv,
Description:
Issue 6193: Fix memory-leak in WeakMapping when the value holds a
reference on the key
http://code.google.com/p/google-web-toolkit/issues/detail?id=6193
Fix memory-leak in WeakMapping when the value holds a reference on the
key, which prevents the entry
On 2011/03/29 20:38:29, xtof wrote:
- Implement the public Image(String url,...) constructors in
terms of the Image(SafeUri url, ...) ones, using
fromUntrustedString.
I'm really not sure about that last one, as the getUrl would
still have to be a String for backwards compat', and
I totally agree with your analysis and ENTIRE_URL_ATTRIBUTE state (I had
similar concerns, but couldn't find a use case where it would be
problematic: I didn't think about the javascript: URLs; and there
actually are similar issues with data: URLs).
Should I wait for the ENTIRE_URL_ATTRIBUTE
http://gwt-code-reviews.appspot.com/1380806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java
File user/src/com/google/gwt/cell/client/ImageCell.java (right):
http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java#newcode58
Is the lack of a CellWidget based on a native checkbox because of the
already existing Checkbox and SimpleCheckbox widgets? and the lack of a
labelled version of the native checkbox because you can use a
CompositeCell (to add the label) and DefaultSelectionEventManager (to
handle the selection on
I have a rather large form which is taller than the visible area in
the page. The users enters search criterias in this form and when the
user executes the search I present the searchresults below the form.
because the form takes up the whole screen the user doesn't notice
that the searchresults
Disclaimer: I didn't review the test yet.
http://gwt-code-reviews.appspot.com/1386806/diff/1011/user/src/com/google/gwt/activity/Activity.gwt.xml
File user/src/com/google/gwt/activity/Activity.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1386806/diff/1/user/src/com/google/gwt/activity/client/RunAsyncActivity.java
File user/src/com/google/gwt/activity/client/RunAsyncActivity.java
(right):
http://gwt-code-reviews.appspot.com/1383807/diff/1/user/src/com/google/gwt/user/cellview/client/CellWidget.java
File user/src/com/google/gwt/user/cellview/client/CellWidget.java
(right):
I'm having a hard time integrating it with UiBinder because of the way
attributes are processed:
- foo bar='{field.ref}baz'/ produces @Template(foo bar='{0}'/)
with a field.ref() + baz argument; it would have to produce (in an
HTML context only) @Template(foo bar='{0}baz'/) so the argument
could
Reviewers: sbrubaker, jlabanca, rjrjr,
Description:
Add SafeUri type, similar to SafeHtml but for values in a URL attribute
context.
What matters most is direct support in SafeHtmlTemplates.
Also added a few overloads in c.g.g.user.client.
Note that this is a breaking change in the sense that
I tried to limit the changes to non-formatting ones. I also didn't go as
far as http://gwt-code-reviews.appspot.com/1384801 wrt error handling to
limit the amount of changes and avoid merge conflicts (or make them
easier to resolve).
http://gwt-code-reviews.appspot.com/1380806/
--
ServiceInheritanceTest is still missing from RequestContextSuite (not
Jre)
http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1384802/diff/6005/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
On 2011/03/16 16:52:48, drfibonacci wrote:
I removed the corresponding try/catch in ResolverServiceLayer also.
http://gwt-code-reviews.appspot.com/1384802/diff/6005/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
I'm trying to implement server side sorting using CellTable and
AsyncDataProvider in GWT 2.2. I've followed the example in the
documentation and have everything working with the AsyncDataProvider
only fetching ten objects at a time. But when it comes to sorting I
can't make it work.
I can't
A few more thoughts:
- resolveServiceClass would benefit from being cached at the
ServiceLayerCache level
- I know this is only about the server-side, but I wonder how it'd work
for the client-side: because this is only based on the
requestContextMethod, if you have a GenericDAORequestContext
http://gwt-code-reviews.appspot.com/1371801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thinking a bit more about it, this fix is IMO not enough: it will only
resolve properties that have not yet been resolved, which means in the
case of two methods returning the same object, if the second method
modifies some properties of the object before returning it and those
properties have
On 2011/03/10 20:49:41, bobv wrote:
EditorTest refers to a SimpleFooBarOnlyEditor. Which patch defines
that type?
It was there before r9839
http://code.google.com/p/google-web-toolkit/source/detail?r=9839
See also my mail Re: Severe regressions with editor overhaul at r9666
from Mon, Feb 28,
...@google.com wrote:
Note also that the GWT programming guide tutorials include an
internationalization section that may be affected.
Stephen.
On Tue, Mar 8, 2011 at 9:26 AM, John Tamplin j...@google.com wrote:
On Tue, Mar 8, 2011 at 6:11 AM, T tomek.maty...@gmail.com wrote:
This is just
Reviewers: rjrjr, bobv,
Description:
Issue 6115: RequestFactory: .with(propertyRefs) not always honored
http://code.google.com/p/google-web-toolkit/issues/detail?id=6115
There are many small changes due to reformats with new formatter rules,
sorry for the noise.
I've added 2 tests
[ERROR] @Generate class
com.google.gwt.i18n.rebind.format.Properties not found
I've spent one hour looking at it again and again, and I didn't
realize that the correct class name was
com.google.gwt.i18n.rebind.format.Properties*Format*.
It's just to improve documentation.
Regards,
T
Hi,
I am using eclipse(gelileo).i downloaded opencmis-gwt-client project.i
have installed GWT 1.7.
when i run gwtcmis-sample am getting follwoing error in console
Unknown argument: -codeServerPort
Google Web Toolkit 1.7.1
HostedMode [-noserver] [-port port-number | auto] [-whitelist
I ran the AnimationTest in prod mode in Chrome 9 (stable), 10 (beta) and
11 (dev), as well as Firefox 4b12, IE8, Opera 11 and Safari 5.
I also checked that the moz- (resp. webkit-) -specific implementation
was correctly stripped out of the webkit (resp. gecko1_8) permutations.
http://gwt-code-reviews.appspot.com/1355805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/animation/client/AnimationImplWebkitAnimTiming.java
File
user/src/com/google/gwt/animation/client/AnimationImplWebkitAnimTiming.java
(right):
I stumbled upon this article by Paul Irish
http://paulirish.com/2011/requestanimationframe-for-smart-animating/ a
few hours after sending this patch. There he says that Chrome 10 (beta)
doesn't pass the 'time' argument to the callback, so the
AnimationImplWebkit should probably test that and
_
Mayo Clinic | 200 First Street SW | Rochester, MN 55905 |
www.mayoclinic.org
-Original Message-
From: Hilco Wijbenga [mailto:hilco.wijbe...@gmail.com]
Sent: Tuesday, March 01, 2011 12:12 PM
To: google-web-toolkit@googlegroups.com
Cc: Dougherty, Gregory T.
Subject
Reviewers: rjrjr, bobv,
Description:
Issue 6092: Inconsistent use of classloaders in RequestFactory
http://code.google.com/p/google-web-toolkit/issues/detail?id=6092
Use the Thread.currentThread().getContextClassLoader() everytime we need
to load a class using Class.forName
Please review this
Reviewers: rjrjr, bobv,
Description:
Issue 6081: ListEditor subeditors' value is not flushed when used with a
RequestFactoryEditorDriver
http://code.google.com/p/google-web-toolkit/issues/detail?id=6081
Let RequestFactoryEditorDriver override the Initializer visitor to plug
its own
Hi all,
Is there any way to replace Enter key by Shift + Enter for a widget such as
RichTextArea?
Thanks,
ryan
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To
am, ryan T ryanro...@gmail.com wrote:
Hi all,
Is there any way to replace Enter key by Shift + Enter for a widget
such as
RichTextArea?
Thanks,
ryan
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post
/client/impl/PathCollector.java
@@ -41,8 +41,16 @@ class PathCollector extends EditorVisitor {
public T boolean visit(EditorContextT ctx) {
String path = ctx.getAbsolutePath();
-if (path.length() 0 !ValueCodex.canDecode(ctx.getEditedType())) {
- paths.add(path);
+if (path.length
+ HasEditorDelegateT {
+EditorDelegateT delegate;
+
+public SimpleEditorWithDelegate(T value) {
+ super(value);
+}
+
+@Override
+public void setDelegate(EditorDelegateT delegate) {
+ this.delegate = delegate;
+}
+ }
+
class ValueAwareAddressEditor extends
Hi All,
I donno whether I could understand the problem here completely.
but I was also facing same kinda problem. and I was not using the History
managment.
but ever since i started using it, the problem solved.
below is the code which keeps user on same page even if the user refresh the
page.
Reviewers: rjrjr, bobv,
Description:
Issue 6059: ClassCastException in AbstractRequestContext.isChanged if
you create()d a ValueProxy
http://code.google.com/p/google-web-toolkit/issues/detail?id=6059
Use BaseProxyCategory.stableId() instead of a cast to EntityProxy, so it
works with ValueProxy
Reviewers: jlabanca,
Description:
Adds {moz,webkit}RequestAnimationFrame support to animations.
Refactor Animation with different implementations, adding
mozRequestAnimationFrame and webkitRequestAnimationFrame support in
addition to the timer-based implementation.
I verified non-regression by
I noticed that JBeanMethod (and BeanMethod) treat java.lang.Boolean the
same as boolean, contrary to my first patch, hence the changes to the
unit test between the two patch sets.
http://gwt-code-reviews.appspot.com/1359804/diff/1/3
File
http://gwt-code-reviews.appspot.com/1359804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
301 - 400 of 719 matches
Mail list logo
