I must have missed something, or is it mostly about changing
serialization of proxies? (which I didn't find in the patch)
Is the goal to enable creating a RequestFactory interface for a JSON-RPC
service that's not backed by a SimpleRequestProcessor (or similar)?
Given that the JSON-RPC request
On Fri, Feb 11, 2011 at 3:00 PM, Thomas Broyer t.bro...@gmail.com wrote:
On Friday, February 11, 2011 7:26:11 AM UTC+1, Sarjith wrote:
On Fri, Feb 11, 2011 at 11:41 AM, Y2i yur...@gmail.com wrote:
There should be something like this in app's web.xml
servlet
Hi,
I was trying to follow RequestFactory concept.
and I'm still not able to solve this error. (even after adding this servlet
mapping).
--
Sarjith
On Sun, Dec 26, 2010 at 10:03 AM, Matthew Hill matt2...@gmail.com wrote:
Fixed by adding a servlet handler for
On Fri, Feb 11, 2011 at 11:41 AM, Y2i yur...@gmail.com wrote:
There should be something like this in app's web.xml
servlet
servlet-namerequestFactory/servlet-name
servlet-classcom.google.gwt.requestfactory.server.RequestFactoryServlet/servlet-class
/servlet
servlet-mapping
we say getPerson() request should call this
method in this service class?. please correct me if I'm wrong anywhere.
--
Sarjith
On Fri, Feb 11, 2011 at 11:56 AM, $ a r j i t h Pullithodi
sarji...@gmail.com wrote:
On Fri, Feb 11, 2011 at 11:41 AM, Y2i yur...@gmail.com wrote:
There should
http://gwt-code-reviews.appspot.com/1338807/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I think I'll revert the changes to the existing tests (keeping only the
changes introducing the new ones exercizing SkipInterfaceValidation),
and make a second patch about fixing them.
http://gwt-code-reviews.appspot.com/1338807/diff/1/4
File
Reviewers: bobv, rjrjr,
Message:
I initially thought about skipping validation of the
ProxyFor/ProxyForName/Service/ServiceName if the class is annotated
(i.e. don't poison the RFIV, or fail in the RequestFactoryGenerator,
if the ProxyFor/etc. annotation is absent), and allowing the annotation
Thanks buddy... donno this gonna work in my scenario, but had decided to
give it a try.
Thanks a lot.
please do share if anyone has a better idea or any alternative for this, so
that we don't miss anything.
Thanks once again...!!
--
Sarjith
On Thu, Feb 3, 2011 at 2:42 PM, Thomas Broyer
Hi All,
I'm starting with GWT module for a functionality say 'addPerson'. so ui will
have around 10-15 user inputs (in a single form) like firstname, lastname,
address, phone, etc.
From a short period of experience in gwt, I am sending these data to server
using RPC call like
http://gwt-code-reviews.appspot.com/1340802/diff/1/4
File user/src/com/google/gwt/editor/client/EditorVisitor.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/4#newcode27
user/src/com/google/gwt/editor/client/EditorVisitor.java:27: public T
void endVisit(EditorContextT ctx
I'd like to perform some operations when a user, by clicking left or
right arrow in a SimplePager, changes page in a CellTable.
Can't find any suitable callback-methods or methods to override on
SimplePager or CellTable. Any suggestions?
--
You received this message because you are subscribed
or workarounds?
I'm using the helios GWT provided from:
http://dl.google.com/eclipse/plugin/3.6
T S
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from
Reviewers: cramsdale, jgw,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4916
Remove old workaround code from DOMImplSafari for something that's been
fixed in Safari for a while makes it hard to work with optgroups in
select elements.
Assigning arbitrarily to Chris
http://gwt-code-reviews.appspot.com/1293801/diff/1/2
File
user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1293801/diff/1/2#newcode41
user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java:41:
static
Reviewers: rjrjr,
Description:
in r8817, we landed a patch that allows @Prefix(), i.e. a non-prefixed
PlaceTokenizer, and produces a separator-less history token as a
result. The token parsing however wasn't updated, and such a token would
always go the fallback route to the default place,
Reviewers: bobv, rjrjr, jlabanca,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5599
Bob suggested that It should check to see if the size of the exported
list has changed whenever create() or dispose() is called.
Reviewers: bobv, rjrjr,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5872
This is a first step in the right direction, but I suppose you'd want to
go farther. Noticeably:
- it's using UmbrellaException from c.g.g.event.shared. Maybe it should
define its own
Reviewers: ,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5563
Following my proposal (copied here from the issue tracker):
The fix should IMO be (and I believe it was in my initial patch that
introduced the handler/mapper dichotomy) to ignore classes in the
Reviewers: bobv, rjrjr,
Description:
Copied from the issue tracker:
The real issue seems to be in how
com.google.gwt.requestfactory.client.impl.RequestFactoryEditorDelegate
determines whether it shouldFlush() or not: it only deals with am I in
'read-only' mode or not (if request==null, edited
Reviewers: bobv,
Description:
There are 3 issues:
- AutoBean server code incorrectly assume the getter prefix is always
get (or rather, 3-chars long)
- same thing in the RequestFactory generator (RequestFactoryModel)
- and in RequestFactory server code (ReflectiveServiceLayer)
I've also
http://gwt-code-reviews.appspot.com/1272801/diff/1/3
File user/src/com/google/gwt/autobean/server/BeanMethod.java (right):
http://gwt-code-reviews.appspot.com/1272801/diff/1/3#newcode52
user/src/com/google/gwt/autobean/server/BeanMethod.java:52: String
inferName(Method method) {
Similar to
In a word: I like it (just gave a cursory gance at the CellTable and
CellTableBasic.css changes though)
http://gwt-code-reviews.appspot.com/1263801/diff/1/12
File user/src/com/google/gwt/user/cellview/client/CellTable.java
(right):
Reviewers: bobv,
Description:
See the bug report and associated thread in GWT-Contrib for details.
http://code.google.com/p/google-web-toolkit/issues/detail?id=5795
I verified that it didn't break any other test in the EditorSuite.
Please review this at
http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001
File user/src/com/google/gwt/dom/client/DOMImplIE8.java (right):
http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001#newcode39
user/src/com/google/gwt/dom/client/DOMImplIE8.java:39: var ua =
navigator.userAgent.toLowerCase();
Is
In a CellTable I'm using a ButtonCell column. The button for each row
should show only when a condition is true. How do I achieve that?
This is my code now:
ColumnPerson, String myColumn = new ColumnPerson, String(new
ButtonCell()) {
@Override
public String getValue(Person
I'm using the new CellTable from GWT 2.1 and have a ClickableTextCell.
I want the clickable text to have the same style as an a-element and
the cursor should be a pointer when hovering the clickable text.
How do I achieve this?
--
You received this message because you are subscribed to the
I have a CellTable and a ButtonCell column. The button for each row
should show only when a condition is true. How do I achieve that?
This is my code now:
ColumnPerson, String myColumn = new ColumnPerson, String(new
ButtonCell()) {
@Override
public String getValue(Person
Reviewers: rjrjr, jat,
Description:
This is critical for us; could you please include it in 2.1.1?
I'm not sure about the test (re. i18n involved through NumberFormat) but
I'm sure about the fix!
Please review this at http://gwt-code-reviews.appspot.com/1170801/show
Affected files:
LGTM
(note that it also fixes issue 5238, which is a dupe of 5474, AIUI)
http://gwt-code-reviews.appspot.com/1158801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: bobv,
Description:
Fix for RequestFactoryServlet and unit test.
Also fixed testUserInfo in RequestFactoryTest, which was not
asynchronous (and therefore, I believe, wasn't actually testing
anything).
The tests use finishTest and not finishTestAndReset because they don't
use
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27009
File user/src/com/google/gwt/user/client/ui/DateLabel.java (right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27009#newcode25
user/src/com/google/gwt/user/client/ui/DateLabel.java:25: * A ValueLabel
that uses {...@link
http://gwt-code-reviews.appspot.com/1130801/diff/1/10
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1130801/diff/1/10#newcode146
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:146:
Locator?, ?
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27004
File
user/src/com/google/gwt/uibinder/elementparsers/DateLabelParser.java
(right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27004#newcode36
user/src/com/google/gwt/uibinder/elementparsers/DateLabelParser.java:36:
static
is ValueLabelDouble (which accepts a
Renderer? super Double argument in its ctor) but the ownerFieldClass
is the JGenericType ValueLabelT (expecting a Renderer? super T). I
tried changing the ownerFieldClass to uiField.getType() (when uiField is
not null *and* its getType().getRawType() is more specific than
http://gwt-code-reviews.appspot.com/1099801/diff/1/8
File user/src/com/google/gwt/user/client/ui/NumberLabel.java (right):
http://gwt-code-reviews.appspot.com/1099801/diff/1/8#newcode34
user/src/com/google/gwt/user/client/ui/NumberLabel.java:34: }
On 2010/11/11 19:06:31, jat wrote:
On
Reviewers: bobv,
Description:
This patch:
- reuses editors in every IsEditor widget (issue 5479)
- adds a ValueLabel widget, and DateLabel and NumberLabel subclasses
(issue 5507), introduces a NumberFormatRenderer (similar to the existing
DateTimeFormatRenderer) for use in NumberLabel (this
Thanks for the quick feedback!
http://gwt-code-reviews.appspot.com/1099801/diff/1/8
File user/src/com/google/gwt/user/client/ui/NumberLabel.java (right):
http://gwt-code-reviews.appspot.com/1099801/diff/1/8#newcode22
user/src/com/google/gwt/user/client/ui/NumberLabel.java:22: * A
ValueLabel
http://gwt-code-reviews.appspot.com/1082801/diff/1/4
File user/src/com/google/gwt/html5/canvas/client/CanvasElement.java
(right):
http://gwt-code-reviews.appspot.com/1082801/diff/1/4#newcode42
user/src/com/google/gwt/html5/canvas/client/CanvasElement.java:42:
public final native Context
http://gwt-code-reviews.appspot.com/1082801/diff/1/10
File user/src/com/google/gwt/html5/canvas/client/CssColor.java (right):
http://gwt-code-reviews.appspot.com/1082801/diff/1/10#newcode23
user/src/com/google/gwt/html5/canvas/client/CssColor.java:23: public
class CssColor implements
http://gwt-code-reviews.appspot.com/1082801/diff/1/7
File user/src/com/google/gwt/html5/canvas/client/CanvasPixelArray.java
(right):
http://gwt-code-reviews.appspot.com/1082801/diff/1/7#newcode41
user/src/com/google/gwt/html5/canvas/client/CanvasPixelArray.java:41:
return this[i];
On 2010/11/07
http://gwt-code-reviews.appspot.com/1082801/diff/1/3
File user/src/com/google/gwt/html5/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1082801/diff/1/3#newcode52
user/src/com/google/gwt/html5/canvas/client/Canvas.java:52: * @return
the height, in pixels
Are they really
why you'd be running
into problems against an Eclipse 3.5 version of an older incarnation of STS.
Did you have the Google Plugin for Eclipse installed previously? Was this an
upgrade?
On Wed, Nov 3, 2010 at 5:06 AM, Stephan T stephan.tern...@gmail.com wrote:
Sometimes I also get this error
of the plugins in there that start with com.google.gdt.*?
Also, do you see any errors in your Error Log (Window - Show View - Error
Log)?
On Tue, Nov 2, 2010 at 11:12 AM, Stephan T stephan.tern...@gmail.comwrote:
I can't compile my gwt application in Eclipse. Works in Maven outside
Eclipse though
)
at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
... 37 more
On 3 Nov, 09:52, Stephan T stephan.tern...@gmail.com wrote:
Yes, it's the Unhandledeventloopexception that shows up in the
Error log.
In my plugin folder:
com.google.gdt.eclipse.core_1.4.0.v201010280047.jar
http://gwt-code-reviews.appspot.com/1076801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/1076801/diff/1/2#newcode676
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:676: //
TODO(jgw): Not sure if
I can't compile my gwt application in Eclipse. Works in Maven outside
Eclipse though. I'm getting an error related to IPixelConverter (see
below for full stacktrace). The version of Eclipse is 3.5.1
(SpringSource Tool Suite2.3.0) and version 2.1.0 of GWT Plugin
installed from the 3.5 update site.
http://gwt-code-reviews.appspot.com/1062801/diff/1/75
File
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1062801/diff/1/75#newcode77
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java:77:
return
http://gwt-code-reviews.appspot.com/1062801/diff/1/78
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):
http://gwt-code-reviews.appspot.com/1062801/diff/1/78#newcode947
Hi,
I am trying to figure out how to organize my project so i figured I
would try to make a simple project with multiple modules to see how it
works.
I got the starter project running just fine and i can get any
modifications to the existing module to work as well. (I can't find
any tutorial
Isn't that duplicating the functionnality of the ResizeComposite?
http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/user/client/ui/ResizeComposite.html
Should it then be deprecated? At least it should itself implement
ResizeComposite, as it would now inherit the behavior
Not sure, but maybe you forgot to add the style? It sounds like you
are using the ProgressBar from the incubator. It needs a style to be
displayed properly. A working css style definition can be found in the
java doc, iirc.
--
You received this message because you are subscribed to the Google
Reviewers: rjrjr,
Description:
See one use-case in point 3 of
http://groups.google.fr/group/google-web-toolkit-contributors/msg/af8578d95692aff5
Another use case: edit and details of a proxy is based on the proxy
itself (it has an isReadOnly() property, and if it isn't read-only it's
always in
On 2010/10/08 21:55:30, jgw wrote:
On 2010/09/23 14:32:37, tbroyer wrote:
LGTM. Committed at r8982.
Thanks!
http://gwt-code-reviews.appspot.com/887804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/946802/diff/8001/9005
File user/src/com/google/gwt/app/place/CreateAndEditProxy.java (right):
http://gwt-code-reviews.appspot.com/946802/diff/8001/9005#newcode54
user/src/com/google/gwt/app/place/CreateAndEditProxy.java:54:
display.setWidget(null);
Er, really
On 2010/09/27 23:49:02, rjrjr wrote:
Point taken on the view contention front. I think Thomas is right that
setting and clearing the view delegate should happen in start() and
stop(),
not in the constructor. Thanks, Thomas.
You're welcome ;-)
Sounds like the javadoc should say so.
+1
http://gwt-code-reviews.appspot.com/925801/diff/1/2
File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
(right):
http://gwt-code-reviews.appspot.com/925801/diff/1/2#newcode256
user/src/com/google/gwt/app/place/AbstractProxyListActivity.java:256: if
(view == null) {
Isn't the
Looks like there's a regression in IconCellDecorator (re. valign)
http://gwt-code-reviews.appspot.com/912801/diff/1/2
File user/src/com/google/gwt/cell/client/IconCellDecorator.java (right):
http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode53
Reviewers: jgw,
Description:
also fixes issue 5076 (add ToggleButton(upText,downText,handler)
constructor) and a few nits in the CheckBox javadoc (referring to text
box, and bad doc re. null value handling in setValue)
Assigning to Joel as per
http://gwt-code-reviews.appspot.com/902801/diff/20001/21013
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/902801/diff/20001/21013#newcode147
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:147:
stableId =
LGTM (FWIW, and speaking only about the API)
http://gwt-code-reviews.appspot.com/864801/diff/3001/4034
File user/test/com/google/gwt/user/client/ui/SimplePanelTest.java
(right):
http://gwt-code-reviews.appspot.com/864801/diff/3001/4034#newcode35
Are all these ForIsWidget interfaces (and method overloads) really
needed? (and actually useful?)
For completeness, TabLayoutPanel and TabPanel don't have IsWidget
overloads for their add, getTabWidget and selectTab methods.
(if you ask me, I'd only keep HasOneWidget, without the getWidget
Reviewers: bruce, scottb,
Description:
Similar to getOverridableMethods but includes final methods as well.
This would make it easier to fix ROO-1297 and in general work with
factories (such as the code generator for ActivityMapper I proposed in
the Activity design Wave)
I think I've spotted the reason for the test failure: it's actually a
bug in the current getOverridableMethods, and a bug in JEnumTypeTest (it
should have really expected 4 methods instead of 7).
Reported as issue 5270:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5270
Reviewers: bruce, scottb,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5270
Description copied from the issue:
In c.g.g.core.ext.typeinfo.AbstractMembers, final methods are simply
ignored instead of being treated as possible overrides of already seen
methods. A
Reviewers: rjrjr,
Description:
Following up on https://jira.springsource.org/browse/ROO-1276, here's
the proposed alternate design, separating the keep history and places
in sync and map places to/from history tokens concerns into a
concrete PlaceHistoryHandler class and a PlaceHistoryMapper
I don't quite understand what this change in RemoteServiceServlet has to
do with UrlBuilder...
http://gwt-code-reviews.appspot.com/754803/diff/21001/22002
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
(right):
In brief: URIs (RFC 3986) is a mess, and back to URL.encode for the path
in UrlBuilder? (with a second pass though)
http://gwt-code-reviews.appspot.com/754803/diff/21001/22002
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
(right):
Reviewers: rjrjr,
Description:
Fixes https://jira.springsource.org/browse/ROO-1276
First, the anonymous-class implementation of Historian is moved into a
public static DefaultHistorian nested class that's GWT.create()d to
allow pluggability via a replace-with rule in a gwt.xml file (similar
to
Reviewers: ,
Description:
This is a major refactor of
PlaceHistoryHandlerGenerator/PlaceHistoryGeneratorContext to address
various issues with the current implementation:
- place types should be ordered from most-derived to least-derived in
the generated getPrefixAndToken (see
http://gwt-code-reviews.appspot.com/754803/diff/1/2
File user/src/com/google/gwt/http/client/UrlBuilder.java (right):
http://gwt-code-reviews.appspot.com/754803/diff/1/2#newcode69
user/src/com/google/gwt/http/client/UrlBuilder.java:69: for (String
segment : path.split(/)) {
It'd probably be
http://gwt-code-reviews.appspot.com/771801/diff/28002/6006
File
user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java
(right):
http://gwt-code-reviews.appspot.com/771801/diff/28002/6006#newcode32
http://gwt-code-reviews.appspot.com/771801/diff/11002/15007
File
user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java
(right):
http://gwt-code-reviews.appspot.com/771801/diff/11002/15007#newcode38
On 2010/08/17 23:23:39, xtof wrote:
On 2010/08/17 23:05:06, tbroyer wrote:
Looking at the code more closely it would merely fail by overly
rejecting tags that are whitelisted: i.e. b foo=ishould be
bold would be sanitized to lt;b foo=ishould be bold and the
end part would be italicized
LGTM, though I'm puzzled by Hyperlink implementing
HasDoubleClickHandlers, given that addClickHandler is deprecated on that
class.
http://gwt-code-reviews.appspot.com/774801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/08/17 20:19:04, xtof wrote:
On 2010/08/17 18:39:28, jat wrote:
On 2010/08/16 23:39:47, tbroyer wrote:
The HtmlSanitizer is a good idea, but the implementation is very
weak [2].
Note that the API is what is important, and SimpleHtmlSanitizer is
just that,
a
simple
dane.molo...@gmail.com wrote:
Have you thought about using themaven-assembly-plugin to generate a
secondary end-state? Just an idea.
On Aug 12, 6:23 am, Stephan T stephan.tern...@gmail.com wrote:
I need to build two war files with different web.xml files becuase of
different servlet filter
I really like the interface/generator idea but not really the
implementation (XML parsing –even though I could live with this–,
generating XML –the HTML5 serialization algorithm [1] is fortunately
easy enough and interoperable–)
The HtmlSanitizer is a good idea, but the implementation is very
HI All,
I am a beginner in GWT, I was trying to develop an application through UI
Binder way. but it found really difficult to integrate designers (html) code
to gwt widgets. is it possible to use g:widgets inside html tag and vice
versa?. I can't use complete html as ui binder xml since its
I only quickly read through the list of added files and some of the
files' content, but I can say I really like it the way it is (with
PlaceTokenizer instead of the static fromToken method described in the
Wave)
There's a nit though, which should be probably fixed rather sooner than
later ;-)
. Your composite would then delegate to the POJO,
which could be reused server-side.
And if you wish to push further towards great design, embrace MVP !
On 5 août, 14:42, Stephan T stephan.tern...@gmail.com wrote:
For several reasons I need to instansiate a Composite on the server
side
I'm using the GWT-plugin for Maven to build my application. I want to
build two war-files where the only difference is that I want to use a
different web.xml.
How do I achieve that?
Here's my pom.xml:
?xml version=1.0 encoding=UTF-8?
project xmlns=http://maven.apache.org/POM/4.0.0;
For several reasons I need to instansiate a Composite on the server
side that is in the client package. Is it possible? Now I think I'm
getting class not found exception when trying...
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post
LGTM
(awesome! next step: integration with History ;-) )
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002
File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62
How is this better than existing JSON libraries, such as Google GSON?
http://code.google.com/p/google-gson/
Moreover, GSON's use of reflection (JsonDeserializatonVisitor
ObjectNavigator) might make it possible to use it for RequestFactory
(both servlet, and client-side code generation) with
http://gwt-code-reviews.appspot.com/642801/diff/1/3
File
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
(right):
http://gwt-code-reviews.appspot.com/642801/diff/1/3#newcode62
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:62:
LGTM overall.
As a side note, where is the c.g.g.dom.client.EventListener defined?
Could it be made generic? I like how the WebSocket proposal added a base
Event class mimicking the DOM Event interface, with NativeEvent (and
other WebSocket-specific events) extending it. EventListener could
In a few words: everything's in c.g.g.dom, bringing a dependency from
c.g.g.dom to c.g.g.event and breaking the assumption that an
EventHandler is coupled with a GwtEvent (rather than a JSO-derivative),
and it starts to refactor event handling at the low-level, while Joel is
working on it (see
On 2010/06/29 21:56:58, jlabanca wrote:
I think all of the doTestParseUnescaped loops in JSONTest are causing
the tests
to timeout. We'll have to break these tests down so they don't
timeout.
How about taking advantage of being in a GWTTestCase and use a
Scheduler.RepeatingCommand?
Reviewers: ,
Description:
Make Float.parseFloat/valueOf and Double.parseDouble/valueOf accept
strings with a float type suffix, such as 1.0f or 1.0d.
Please review this at http://gwt-code-reviews.appspot.com/647802/show
Affected files:
user/super/com/google/gwt/emul/java/lang/Number.java
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001
File user/src/com/google/gwt/core/client/JsonUtils.java (right):
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001#newcode89
user/src/com/google/gwt/core/client/JsonUtils.java:89: out[0xad] =
'\\u00ad'; // Soft hyphen
On
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001
File user/src/com/google/gwt/core/client/JsonUtils.java (right):
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001#newcode76
user/src/com/google/gwt/core/client/JsonUtils.java:76: return typeof
JSON == object typeof JSON.parse
Conclusion: Safari 5 is half-baked :-(
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001
File user/src/com/google/gwt/core/client/JsonUtils.java (right):
http://gwt-code-reviews.appspot.com/659801/diff/9001/10001#newcode76
user/src/com/google/gwt/core/client/JsonUtils.java:76: return
Reviewers: Ray Ryan,
Description:
UiBinderWriter#escapeTextForJavaStringLiteral correctly escapes \n and
, but forgets \.
Also, I couldn't see a reason for using replaceAll instead of replace.
Please review this at http://gwt-code-reviews.appspot.com/620804/show
Affected files:
by apostrophes while
JSON mandates quotes, numbers in JSON have a stricter syntax than JS
number literals, whitespace in JSON is limited to \u0020\t\r\n whereas
JavaScript allows \v\f\uFEFF and any character from the Unicode Zs
category, etc.)
http://gwt-code-reviews.appspot.com/659801/show
--
http
Sorry to step in without being invited (though I was earlier told that
it should be expected when developing in the open), but... (see below)
http://gwt-code-reviews.appspot.com/619803/diff/1/2
File user/src/com/google/gwt/user/tools/RpcServerTemplate.javasrc
(right):
Reviewers: Ray Ryan,
Description:
Uses the java.beans.Introspector#decapitalize instead of manual
decapitalization of setter-method names to attribute names.
This means setHTML() can be set using an all-caps HTML= attribute,
instead of hTML=. This applies to all all-caps setters (actually,
Reviewers: jlabanca,
Description:
As a result of r7692, NativeEvent#getKeyCode no longer returns the
charCode for KeyPress events. This leads to better accuracy in handling
keyboard-related events, but some widgets still use getKeyCode on
KeyPress events, which in some (many? most?) browsers
How do I disable the DatePicker widget programatically? Can't find any
suitable setEnabled-method...
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe
How do I achieve this code this using UI Bindings?
label for=someUniqueFieldIdFirst name/label
input type=text id=someUniqueFieldId name=firstname/
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to
401 - 500 of 719 matches
Mail list logo
