[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-12 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding DoNotRunWith annotation to failing JUnit test; possible HtmlUnit bug. (issue1472804)

2011-07-11 Thread codefu
Reviewers: conroy, Description: Adding DoNotRunWith annotation to failing JUnit test; possible HtmlUnit bug. Review by: con...@google.com Please review this at http://gwt-code-reviews.appspot.com/1472804/ Affected files: M plugins/npapi/JavaObject.cpp M plugins/npapi/LocalObjectTable.h A

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-11 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-07 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-07 Thread codefu
Added support for dynamically checking the browser for identity, which includes Chromium 12, 13, and some versions of 14. Responsibility for the expando was packaged in to the LocalObjects. The new NPVariantUtil.h is simply all the static NPVariant utilities from NPVariantProxy that strictly

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-07 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h File plugins/npapi/LocalObjectTable.h (right): http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h#newcode166 plugins/npapi/LocalObjectTable.h:166: set( id, jsObject ); On

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-07 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
Reviewers: jat, conroy, Description: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), adds a second map in LocalObjects. Please review this at http://gwt-code-reviews.appspot.com/1469803/ Affected files: M plugins/npapi/LocalObjectTable.h M

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
On 2011/07/01 18:31:43, conroy wrote: On 2011/07/01 18:28:32, codefu wrote: We can't rip out the ID hack quite yet-- we'd have to wait until the fixes roll out to stable users. We need to add some version checking of chrome to decide if it's safe to do this. Is windows still on Chrome12

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h File plugins/npapi/LocalObjectTable.h (right): http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h#newcode100 plugins/npapi/LocalObjectTable.h:100: NPObject* get(int id) { On

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-01 Thread codefu
= localObjects.get(obj); On 2011/07/01 19:00:48, jat wrote: On 2011/07/01 18:50:17, codefu wrote: On 2011/07/01 18:38:17, jat wrote: So how does this fix the identity problem? The reason this was added was to avoid the identity problem, since the same JS object passed to the plugin twice

[gwt-contrib] Re: Add mac support to the FF50 plugin and package a candidate xpi. (issue1467809)

2011-06-27 Thread codefu
On 2011/06/27 16:22:34, conroy wrote: LGTM http://gwt-code-reviews.appspot.com/1467809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: In the chrome.manifest, list binary components in ascending version order so that the right choi... (issue1465806)

2011-06-24 Thread codefu
On 2011/06/24 16:03:14, conroy wrote: LGTM! http://gwt-code-reviews.appspot.com/1465806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding FF50 VC project files and libraries; updated manifest (issue1468803)

2011-06-24 Thread codefu
Reviewers: conroy, Description: Adding FF50 VC project files and libraries; updated manifest Review by: con...@google.com Please review this at http://gwt-code-reviews.appspot.com/1468803/ Affected files: M plugins/xpcom/VisualStudio/FirefoxPlugins.sln A

[gwt-contrib] Re: Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) (issue1449810)

2011-06-02 Thread codefu
On 2011/06/01 21:11:48, codefu wrote: Included are the binary files: gwt-dev-plugin.crx gwt-dev-plugin.xpi gwt-dev-plugin.dmg gwt-dev-plugin-x86.msi gwt-dev-plugin-x64.msi http://gwt-code-reviews.appspot.com/1449810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) (issue1449810)

2011-06-02 Thread codefu
Reviewers: jat, conroy, fabiomfv, Description: Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) -Chrome Tweak: old entries will show localhost for codeserver Please review this at http://gwt-code-reviews.appspot.com/1449810/ Affected files: M

[gwt-contrib] Re: Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) (issue1449810)

2011-06-02 Thread codefu
http://gwt-code-reviews.appspot.com/1449810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) (issue1449810)

2011-06-02 Thread codefu
On 2011/06/01 22:05:56, conroy wrote: On 2011/06/01 21:14:56, codefu wrote: On 2011/06/01 21:11:48, codefu wrote: Included are the binary files: gwt-dev-plugin.crx gwt-dev-plugin.xpi gwt-dev-plugin.dmg gwt-dev-plugin-x86.msi gwt-dev-plugin-x64.msi While you're tweaking the Chrome