What happens when you use "prototype" or "length" or "name" as keys? I
remember a FastStringMap somewhere in GWT that prepends each key with
a colon to avoid collision.
On Sep 5, 5:45 am, "Emily Crutcher" <[EMAIL PROTECTED]> wrote:
> Ah, I see what happened, when tortoise makes a branch of the
I'm in favor of something much less designed. The extra object (i.e. the
internal JSO) seems unnecessarily costly, considering that we're not trying
to comply with an existing API such as the JRE Map interface.
Why not avoid an abstract base class that necessitates polymorphism, adapter
objects, et
Ah, I see what happened, when tortoise makes a branch of the working
directory it, logically enough, does not include files which have not been
officially added to trunk. The files should be there now.
On Thu, Sep 4, 2008 at 7:36 PM, Folke <[EMAIL PROTECTED]> wrote:
>
> Hi Emily
>
> Did you commi
On Thu, Sep 4, 2008 at 7:53 PM, Bruce Johnson <[EMAIL PROTECTED]> wrote:
> 1) Is there anything about the structure of these tables that could
> unusually affect performance, especially startup time (e.g. forcing unusual
> parsing code paths in the JS engine, putting unreasonable pressure on the
>
On Thu, Sep 4, 2008 at 7:53 PM, Bruce Johnson <[EMAIL PROTECTED]> wrote:
> 2) Have you discussed with Lex and Scott how amenable your scheme is to
> GWT.runAsync()? If you can ensure that it's designed such that you could
> download the decompression/parsing code and data tables after the startup
On Thu, Sep 4, 2008 at 6:46 PM, Toby Reyelts <[EMAIL PROTECTED]> wrote:
> FWIW, I agree with Bob here. I don't really believe this strategy is
> specifically related to emma at all, rather than just being a good citizen
> and integrating with other tool sets.
>
Fair enough. I'm more than happy t
On Thu, Sep 4, 2008 at 9:32 AM, Scott Blum <[EMAIL PROTECTED]> wrote:
> I think this is a general problem with URL.openConnection() where you don't
> explicitly grab the input stream and close it. I think my change should be
> safe since ultimately I'm reading lastModified from File and ZipEntry,
Nice writeup!
Two questions:
1) Is there anything about the structure of these tables that could
unusually affect performance, especially startup time (e.g. forcing unusual
parsing code paths in the JS engine, putting unreasonable pressure on the
GC)? I wouldn't expect that to be the case, but it'
The existing Character.isLowerCase/etc and String.toLowerCase/toUpperCase do
not work for Unicode characters in general. This is not acceptable for a
fully internationalized app that cares about character attributes, such as a
word processor.
I have implemented a compression scheme which uses a c
Hi Emily
Did you commit the files? I'm really interested in your
implementation. This directory is empty:
http://code.google.com/p/google-web-toolkit-incubator/source/browse/branches/ecc/collectionsReview/src/com/google/gwt/gen2/collection
Folke
On Sep 5, 12:28 am, "Emily Crutcher" <[EMAIL PRO
FWIW, I agree with Bob here. I don't really believe this strategy is
specifically related to emma at all, rather than just being a good citizen
and integrating with other tool sets.
I believe I was the one who originally pointed out that reading bytecode
from disk at all times would be bad and slow
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 15:38:41 2008
New Revision: 3622
Added:
trunk/dev/core/src/com/google/gwt/dev/shell/EmmaStrategy.java
(contents, props changed)
Modified:
trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
trunk/dev/core/src/com/google/
Thanks, committed as r3622.
2008/9/4 BobV <[EMAIL PROTECTED]>
> LGTM.
>
> --
> Bob Vawter
> Google Web Toolkit Team
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
John, master of JRE collections, Could you review this?
For big applications, map's performance can end up being a bottleneck. This
code review introduces the AbstractJsMap, which is a slightly modified API
so that we can create faster map implementations.
The code contains new directories, s
I'll bite I guess
RPC-Auth:
No specific comments, but the design looks sound, and should be easy
enough to tie in to authentication schemes on the server side.
+1
oh, in your simple login scenario, you have svc.login("foo", "foo",
someCallback); then your variable magically ch
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 15:12:50 2008
New Revision: 3621
Modified:
trunk/dev/core/src/com/google/gwt/dev/asm/MethodWriter.java
Log:
Fixes a bug in ASM where invalid input LVT entries can translate into
negative length output LVT entries, which causes a ClassFormatError w
Is anyone up for a review?
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 14:06:36 2008
New Revision: 3620
Added:
changes/jat/ucd/user/src/com/google/gwt/i18n/client/impl/ucd/CharTableImpl_UCD.java
(contents, props changed)
changes/jat/ucd/user/test/com/google/gwt/emultest/EmulSuiteUCD.gwt.xml
changes/jat/
LGTM.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Thu, Sep 4, 2008 at 4:52 PM, BobV <[EMAIL PROTECTED]> wrote:
> Why build support for Emma specifically? It seems like loading the
> class bytes from the classpath if they're at least as new as the
> source is a reasonable thing to do in the general case.
It's slower. We've already got the b
Why build support for Emma specifically? It seems like loading the
class bytes from the classpath if they're at least as new as the
source is a reasonable thing to do in the general case. Also, I think
that EmmaStrategy could be extracted into a general escape mechanism
for accessing external cla
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 13:20:00 2008
New Revision: 3619
Modified:
trunk/user/src/com/google/gwt/user/client/ui/MenuBar.java
trunk/user/src/com/google/gwt/user/client/ui/SuggestBox.java
trunk/user/test/com/google/gwt/user/client/ui/MenuBarTest.java
Log:
MenuBar foc
This approach makes sense to me overall. I do have one question, though. Is
there any particular reason for separating beginAttach() and finishAttach()
in VirtualPanel? From what I see here, it looks like you could simply do all
of it at once in onInfoWindowOpen(), onMaximizeEnd(), and onResroteEnd
LGTM.
You got that figured out really fast, nicely done!
On Thu, Sep 4, 2008 at 4:10 PM, John LaBanca <[EMAIL PROTECTED]> wrote:
> Alex -
> More review fun.
> Description:
> =
> A recent change in MenuBar causes the MenuBar to focus on itself when the
> user highlights a MenuItems with t
Hello Miguel,
I would like for you to review the attached patch that converts
MarkerOptions to a JavaScript overlay. Following the convention in
Josh Bloch's Effective Java, I've named the factory method
'getInstance()'. I had to modify several demos to get rid of using hte
constructor.
M m
Alex -
More review fun.
Description:
=
A recent change in MenuBar causes the MenuBar to focus on itself when the
user highlights a MenuItems with the mouse (or programatically). This makes
sense from the perspective of the MenuBar because it means that a user can
seamlessly switch between
Emily seems to have just committed this at r930, but LGTM too.
On Thu, Sep 4, 2008 at 2:45 PM, Jaime Yap <[EMAIL PROTECTED]> wrote:
> This patch taken against Incubator trunk r.927 adds some comments to :
> com.google.gwt.widgetideas.graphics.client.impl.GWTCanvasImplIE6.java
> for some funky flo
Previously, if you put "google-web-toolkit" in docreader, it gave you
an old "Under Construction" page as the only option in the
TableOfContents. This way, people will be able to get to the
documentation.
2008/9/4 <[EMAIL PROTECTED]>:
>
> Author: [EMAIL PROTECTED]
> Date: Thu Sep 4 11:47:17 200
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 11:47:17 2008
New Revision: 3618
Modified:
wiki/TableOfContents.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/TableOfContents.wiki
==
--- wiki/Table
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 11:46:33 2008
New Revision: 3617
Modified:
wiki/WikiWelcome.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/WikiWelcome.wiki
==
--- wiki/WikiWelcome.w
This patch taken against Incubator trunk r.927 adds some comments to :
com.google.gwt.widgetideas.graphics.client.impl.GWTCanvasImplIE6.java
for some funky flooring trick that needed some explanation.
Also includes a fix for ImageLoader, where in IE the "onLoad" event would
fire before we get don
Freeland, did you actually try this out? You're killing the desk-rebuild
experience here, because when you force gwt-dev to rebuild every time, that
trickles down into a rebuild of user, samples, the whole nine yards.
Adding gwt.svnrev into the name of the sentinel file would be a much better
alt
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 09:25:06 2008
New Revision: 3616
Added:
changes/jat/ucd/user/src/com/google/gwt/i18n/client/impl/CharTableImpl.java
Modified:
changes/jat/ucd/user/super/com/google/gwt/emul/java/lang/Character.java
changes/jat/ucd/user/super/com/google/gwt/
Joel,
Would you please review the attached patch that solves a problem related
when widgets need to be attached/detached from panels for the Maps
InfoWindow.
It addresses issue 156 in gwt-google-apis:
http://code.google.com/p/gwt-google-apis/issues/detail?id=156
M maps/maps/src/com/google/g
I think this is a general problem with URL.openConnection() where you don't
explicitly grab the input stream and close it. I think my change should be
safe since ultimately I'm reading lastModified from File and ZipEntry, not
URLConnection.
BTW: I think URLConnection actually does reclaim the FD i
Author: [EMAIL PROTECTED]
Date: Thu Sep 4 01:40:53 2008
New Revision: 3615
Added:
changes/jat/ucd/eclipse/user/CharacterTableTest.launch
changes/jat/ucd/eclipse/user/GenerateCharTables.launch
Log:
Temporary commit of launch configs.
Added: changes/jat/ucd/eclipse/user/CharacterTableTe
That's as good a cause for a -1 as any, I suppose... attached no longer uses
non-static "this" in static context, and also untangles (by removal) the
creation of a sentinel file to gate the filtering. I believe the sentinel
exists so that a change in gwt.version will cause the extant file to be
co
37 matches
Mail list logo
