[gwt-contrib] [google-web-toolkit commit] r3660 - in changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs: . ast impl

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 20:34:47 2008 New Revision: 3660 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/ast/JVariable.java changes/spoon/runAsync/dev

[gwt-contrib] [google-web-toolkit commit] r3659 - in changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs: . impl

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 19:18:10 2008 New Revision: 3659 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java changes/spoon

[gwt-contrib] [google-web-toolkit commit] r3658 - in trunk/distro-source: . linux mac windows

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 18:38:38 2008 New Revision: 3658 Modified: trunk/distro-source/common.ant.xml trunk/distro-source/linux/build.xml trunk/distro-source/mac/build.xml trunk/distro-source/windows/build.xml Log: Remove special casing for sentinals in distro

[gwt-contrib] [google-web-toolkit commit] r3657 - changes/spoon/runAsync/user/src/com/google/gwt/core/client

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 18:38:30 2008 New Revision: 3657 Modified: changes/spoon/runAsync/user/src/com/google/gwt/core/client/RunAsyncCallback.java Log: Fixed a Javadoc link. Modified: changes/spoon/runAsync/user/src/com/google/gwt/core/client/RunAsyncCallback.java ==

[gwt-contrib] Re: one-word review for trivial patch in About.java

2008-09-16 Thread Scott Blum
Thanks, committed as r3658. I'd already removed the echo in my local. On Mon, Sep 15, 2008 at 8:53 PM, Freeland Abbott <[EMAIL PROTECTED] > wrote: > -- Forwarded message -- > Date: Thu, Sep 11, 2008 at 12:52 PM > Subject: Re: [gwt-contrib] Re: one-word review for trivial patch in

[gwt-contrib] [google-web-toolkit commit] r3656 - in trunk: dev/core/src/com/google/gwt/dev/cfg dev/core/src/com/google/gwt/dev/shell user/...

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 18:30:47 2008 New Revision: 3656 Modified: trunk/dev/core/src/com/google/gwt/dev/cfg/StaticPropertyOracle.java trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpacePropertyOracle.java trunk/user/test/com/google/gwt/i18n/I18N2Test.gwt.xml

[gwt-contrib] Re: RR: timezone support and updates to DateTimeFormat

2008-09-16 Thread Alex Rudnick
Hey Rajeev :) Thanks for the review! Responses inline. The upshot: OK, fixed, committed r3655. On Tue, Sep 16, 2008 at 2:48 PM, Rajeev Dayal <[EMAIL PROTECTED]> wrote: > TimeZoneConstants.java > 24: should read "..the actual data is defined in property files named > TimeZoneConstants_xx.properti

[gwt-contrib] [google-web-toolkit commit] r3653 - changes/spoon/runAsync/user/src/com/google/gwt/core/client

2008-09-16 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Sep 16 14:34:31 2008 New Revision: 3653 Modified: changes/spoon/runAsync/user/src/com/google/gwt/core/client/GWT.java Log: By default, have GWT.runAsync() run the callback with no questions asked. This allows calling runAsync in code that might or might n

[gwt-contrib] Re: RR: timezone support and updates to DateTimeFormat

2008-09-16 Thread Rajeev Dayal
Hey Alex, Good job with this. Generally, looks good, with a bunch of nits (many related to doc). I've mentioned them on a per-file basis below. If you could take care of these nits (provided that you agree with them), go ahead and commit; there's no need to iterate again on this patch unless you m

[gwt-contrib] Code Review: gwt-google-apis Maps issue 170 - InfoWindow should be Overlay subclass

2008-09-16 Thread Eric Ayers
Hello Miguel, I would like you to review the attached patch. This patch addresses issue 170 http://code.google.com/p/gwt-google-apis/issues/detail?id=170 This change makes InfoWindow extend the ConcreteOverlay class. It also adds the methods isInfoWindow(), isPolyline(), isPolygon(), and isM

[gwt-contrib] Re: RR : Three new RPC design docs

2008-09-16 Thread BobV
> 1) Avoiding slow-script warnings (SSWs) during RPC response deserialization > - directly-evalable responses is one approach, to the extent that the > response is written to be "break-up-able" (i.e. amenable to incremental > commands); in the design doc, it does not appear that this crucial probl

[gwt-contrib] Re: Collection of core JS overlay types

2008-09-16 Thread Thomas Broyer
On 15 sep, 23:23, "Folke Behrens" <[EMAIL PROTECTED]> wrote: > > With all the conversions to JSOs/overlay types going on I was > wondering if it makes sense to provide implementions of the core > JavaScript objects as well. I've already submitted RegExp (issue > 1727)? (Granted, Math and Date are

[gwt-contrib] Re: RR : Three new RPC design docs

2008-09-16 Thread Bruce Johnson
Bob, this is a great first step (three, actually) towards taking RPC to the next level. Here are my notes on deRPC specifically. On Mon, Sep 1, 2008 at 8:09 PM, BobV <[EMAIL PROTECTED]> wrote: > This document is more about how we might revamp the RPC payload format > to improve deserialization spe

[gwt-contrib] Re: Code Review: gwt-google-apis Maps update the DirectionsTest

2008-09-16 Thread Eric Ayers
I updated issue 171 - the 1.5.2 release is broken on this unit test, but has been subsequently fixed. See GWT issue 2841 http://code.google.com/p/google-web-toolkit/issues/detail?id=2841 On Mon, Sep 15, 2008 at 4:30 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > Hello Miguel, > > This resolves issu