[gwt-contrib] Comment on TableOfContents in google-web-toolkit

2008-11-07 Thread codesite-noreply
Comment by derekypp: sss For more information: http://code.google.com/p/google-web-toolkit/wiki/TableOfContents --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r3994 - branches/1_6_clean_events/user/src/com/google/gwt/user/client

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 15:04:46 2008 New Revision: 3994 Modified: branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java Log: Using short type var names. Modified: branches/1_6_clean_events/user/src/com/google/gwt/user/client/Window.java

[gwt-contrib] [google-web-toolkit commit] r3993 - branches/1_6_clean_events/user/test/com/google/gwt/event/dom/client

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 15:03:36 2008 New Revision: 3993 Modified: branches/1_6_clean_events/user/test/com/google/gwt/event/dom/client/DomEventTest.java Log: Making handler manager private. Modified: branches/1_6_clean_events/user/test/com/google/gwt/event/dom/client/

[gwt-contrib] [google-web-toolkit commit] r3992 - branches/1_6_clean_events/user/src/com/google/gwt/event/shared

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 15:01:37 2008 New Revision: 3992 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java Log: changing generic type to one letter. Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/shared/Han

[gwt-contrib] [google-web-toolkit commit] r3991 - branches/1_6_clean_events/user/src/com/google/gwt/event

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 15:00:29 2008 New Revision: 3991 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/Event.gwt.xml Log: Removing bad source path. Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/Event.gwt.xml ==

[gwt-contrib] [google-web-toolkit commit] r3990 - in branches/1_6_clean_events/eclipse: reference/code-museum samples/DynaTable samples/Hel...

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 14:36:51 2008 New Revision: 3990 Modified: branches/1_6_clean_events/eclipse/reference/code-museum/.classpath branches/1_6_clean_events/eclipse/samples/DynaTable/.project branches/1_6_clean_events/eclipse/samples/Hello/.classpath branches

[gwt-contrib] [google-web-toolkit] ray.ryan commented on revision r3979.

2008-11-07 Thread codesite-noreply
[google-web-toolkit] ray.ryan commented on revision r3979. Details are at http://code.google.com/p/google-web-toolkit/source/detail?r=3979 Score: Positive General Comment: How can it? Ints default to 0, I was just making it a bit more explicit. Respond to these comments at http://code.googl

[gwt-contrib] [google-web-toolkit] EmilyCrutcher commented on revision r3979.

2008-11-07 Thread codesite-noreply
[google-web-toolkit] EmilyCrutcher commented on revision r3979. Details are at http://code.google.com/p/google-web-toolkit/source/detail?r=3979 General Comment: LGTM, only questions is if you checked that setting eventsToSink to 0 ended up creating an extra widget constructor? Respond to th

[gwt-contrib] [google-web-toolkit commit] r3988 - releases/1.6/dev/core/src/com/google/gwt/dev

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 11:13:01 2008 New Revision: 3988 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/GWTHosted.java releases/1.6/dev/core/src/com/google/gwt/dev/GWTShell.java Log: Adds GWTHosted -server selection, which allows the server to be specified on

[gwt-contrib] [google-web-toolkit commit] r3986 - changes/kprobst/soyc-vis/src/com/google/gwt/soyc

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 10:44:41 2008 New Revision: 3986 Modified: changes/kprobst/soyc-vis/src/com/google/gwt/soyc/CodeCollection.java Log: Updated html outputter to use google visualization api table. Modified: changes/kprobst/soyc-vis/src/com/google/gwt/soyc/CodeCol

[gwt-contrib] [google-web-toolkit commit] r3987 - in branches/1_6_clean_events: reference/code-museum/src/com/google/gwt/museum/client/comm...

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 10:59:17 2008 New Revision: 3987 Added: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/HandlesAllFocusEvents.java (contents, props changed) - copied, changed from r3979, /branches/1_6_clean_events/user/src/com/goog

[gwt-contrib] [google-web-toolkit commit] r3985 - changes/kprobst/soyc-vis/src/com/google/gwt/soyc

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 10:44:21 2008 New Revision: 3985 Modified: changes/kprobst/soyc-vis/src/com/google/gwt/soyc/LiteralsCollection.java Log: Updated html outputter to use google api table. Much nicer. Modified: changes/kprobst/soyc-vis/src/com/google/gwt/soyc/Lite

[gwt-contrib] Re: RR: eager upref

2008-11-07 Thread Scott Blum
Okay, I'll review the patch as-is for trunk then. On Fri, Nov 7, 2008 at 1:58 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > On Fri, Nov 7, 2008 at 12:54 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > > Two qq: > > 1) Is this for trunk or 1.6? > > It's against trunk, which was my initial impression of w

[gwt-contrib] Re: RR: eager upref

2008-11-07 Thread Lex Spoon
On Fri, Nov 7, 2008 at 12:54 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Two qq: > 1) Is this for trunk or 1.6? It's against trunk, which was my initial impression of where it would probably end up going. It can easily go against 1.6, though, if desired. Just note that the patch will have to be

[gwt-contrib] [google-web-toolkit commit] r3984 - in branches/1_6_clean_events: eclipse/reference/code-museum eclipse/samples/DynaTable ecl...

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 09:25:58 2008 New Revision: 3984 Modified: branches/1_6_clean_events/eclipse/reference/code-museum/.classpath branches/1_6_clean_events/eclipse/samples/DynaTable/.project branches/1_6_clean_events/eclipse/samples/Hello/.classpath branches

[gwt-contrib] Re: [google-web-toolkit] kellegous commented on branch /branches/1_6_clean_events.

2008-11-07 Thread Emily Crutcher
> > > Line 32: public static FocusHandler> void addHandlers( > > --- > I definitely see the naming issue. It's hard to name without confusing > handler instances with handler types. This doesn't fix that issue, but it >

[gwt-contrib] Re: IE Nonsecure popup in connection with cache/nocache iframe

2008-11-07 Thread Jen
Upon LOTS of additional tracking I now believe this is not an iframe issue, but rather an image issue. It also seems to be a race condition of some sort. When I attempt to use an image object, particularly when I try to set it to url("images/clear.cache.gif"), which is a single pixel image we us

[gwt-contrib] Re: [google-web-toolkit] kellegous commented on branch /branches/1_6_clean_events.

2008-11-07 Thread Emily Crutcher
> > > > --- > At lunch, we talked about introducing a GwtEvent here instead of an > AbstractEvent. My primary objection is that AbstractX tends to suggest that > you are using the inheritance chain to pull in shared impleme

[gwt-contrib] Re: RR: eager upref

2008-11-07 Thread Scott Blum
Two qq: 1) Is this for trunk or 1.6?2) Does this do anything to fix issue #3064? Seems like that bug is highly related, and might be a compelling enough reason to put this into 1.6. Scott On Fri, Nov 7, 2008 at 10:35 AM, Lex Spo

[gwt-contrib] [google-web-toolkit commit] r3983 - trunk/dev/core/src/com/google/gwt/dev/jjs/impl

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 07:14:22 2008 New Revision: 3983 Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java trunk/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScrip

[gwt-contrib] RR: eager upref

2008-11-07 Thread Lex Spoon
The attached patch tweaks ControlFlowAnalyzer to do its upref visiting eagerly. This results in 1-permutation Showcase compiling about 1-2 seconds faster for me, an improvement of 3-6%. The reason for upref visiting at all is that if you rescue a virtual method, you also need rescue any overridin

[gwt-contrib] [google-web-toolkit commit] r3980 - branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 06:57:32 2008 New Revision: 3980 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/MouseEvent.java Log: Switched the enum to integers for mouse buttons. Boo hoo. Modified: branches/1_6_clean_events/user/src/com/google

[gwt-contrib] [google-web-toolkit commit] r3982 - branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 06:58:25 2008 New Revision: 3982 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java Log: Doc tweak. Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java =

[gwt-contrib] [google-web-toolkit commit] r3981 - branches/1_6_clean_events/user/src/com/google/gwt/event/shared

2008-11-07 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Nov 7 06:57:54 2008 New Revision: 3981 Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java Log: Whitespace error. Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java ==