Heads up guys,
I just profiled my app trying to squeeze every last drop of
performance out for speedups on the iPhone which has slow Javascript,
and I noticed that the canCastUnsafe/dynamicCast functions are
collectively eating up 8.5% of the total runtime. It seems that the
sole purpose of dynam
hosted.html expects the querystring to contain only the module strongName
where as it curently contains strongName + ".cache.html"
IFrameTemplate.js in maybeInjectFrame() appends .cache.html to the
strongName (line 298).
Either IFrameTemplate.js needs to not append .cache.html for hostedmode, or
John,
I wanted to run this one-liner by you before committing. I'm seeing
the JSE below in hosted mode when the body of my PagingScrollTable is
empty and has 0 height. The headerHeight is positive and (totalHeight
- headerHeight - footerHeight) comes out to a negative number. The
patch following
(Reviving the old Response Requested meaning of RR--there is no patch here,
but rather a design question.)
Take a look at the new TabWrapper getTabWrapper(int index) method on TabBar
in the 1_6_clean_events branch:
http://code.google.com/p/google-web-toolkit/source/browse/branches/1_6_clean_event
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:50:32 2008
New Revision: 4011
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/CompileArgProcessor.java
releases/1.6/dev/core/src/com/google/gwt/dev/CompileTaskOptions.java
releases/1.6/dev/core/src/com/google/gwt/dev/CompileTaskOpti
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:52:26 2008
New Revision: 4012
Added:
releases/1.6/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDir.java
(contents, props changed)
releases/1.6/dev/core/src/com/google/gwt/dev/util/arg/OptionWorkDir.java
(contents, props c
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:34:10 2008
New Revision: 4010
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/GWTHosted.java
releases/1.6/dev/core/src/com/google/gwt/dev/shell/ServletContainerLauncher.java
releases/1.6/dev/core/src/com/google/gwt/dev/shell/jet
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:02:39 2008
New Revision: 4009
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JsHandlerRegistry.java
branches/1_6_clean_events/user/test/com/google/gwt/event/EventSuite.java
Log:
dead method snipped, whitespace twea
Yeah, I tested the patch. Commited as r4008. Thanks!
On Mon, Nov 10, 2008 at 6:47 PM, Scott Blum <[EMAIL PROTECTED]> wrote:
> I'm assuming you did this correctly. :) Just commit it since we discussed
> the semantics of the change.
>
> 2008/11/10 Amit Manjhi <[EMAIL PROTECTED]>
>
> Hi Scott,
>>
>
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 15:58:45 2008
New Revision: 4008
Modified:
releases/1.6/user/src/com/google/gwt/user/tools/AppHtml.htmlsrc
releases/1.6/user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc
Log:
Moves the CSS reference from the module file to the html file. Cons
I'm assuming you did this correctly. :) Just commit it since we discussed
the semantics of the change.
2008/11/10 Amit Manjhi <[EMAIL PROTECTED]>
> Hi Scott,
>
> Please review the attached change.
>
> Regards,
> Amit
>
--~--~-~--~~~---~--~~
http://groups.google.c
On Mon, Nov 10, 2008 at 6:02 PM, Lex Spoon <[EMAIL PROTECTED]> wrote:
> I think of generators as making content, and linkers as deciding where
> that content should be located. Typically you can take the same
> program and swap in different linkers if you like. The same is not
> true of generato
Here is the result of our live desk review.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
eagerUpRef-r4007.patch
Description: Binary data
Hi Scott,
Please review the attached change.
Regards,
Amit
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: user/src/com/google/gwt/user/tools/AppHtml.htmlsrc
===
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 15:16:01 2008
New Revision: 4007
Modified:
branches/1_6_clean_events/user/test/com/google/gwt/i18n/client/I18N2Test.java
branches/1_6_clean_events/user/test/com/google/gwt/i18n/client/I18NTest.java
Log:
Reverting local changes ti I18N from br
On Mon, Nov 10, 2008 at 2:33 PM, Kelly Norton <[EMAIL PROTECTED]> wrote:
> For iframe loading, Cameron's change is correct. We should be loading
> code into the document corresponding to our code context and not the
> host page context.
Can I consider that an LGTM?
> However, I am wondering how
I have a linker for my Syndroid prototype which generates complete
Android applications. It does this by generating bootstrap code to
load up a WebKit container on Android, and load the GWT app into it.
This is one example where the linker generates executable code,
however it does preserve swappa
> On Sat, Nov 8, 2008 at 10:41 AM, Toby Reyelts <[EMAIL PROTECTED]> wrote:
>> Are there not larger issues here that need to also be resolved? For
>> example, don't generators need to be able to generate server code? I'm also
>> confused as to what really separates generators and linkers in terms o
[google-web-toolkit] [EMAIL PROTECTED] commented on revision r3979.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=3979
General Comment:
The sure way to test is to add this to the compilation command:
-Dgwt.jjs.traceMethods="Widget.*"
Ray is right that being expli
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:47:35 2008
New Revision: 4006
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JsHandlerRegistry.java
Log:
Docs explaining enqueueA
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:31:09 2008
New Revision: 4005
Modified:
releases/1.6/eclipse/samples/DynaTable2/build.xml
Log:
Updates DynaTable2 build file as per the recent updates to support a WAR
structure.
Patch by: amitmanjhi
Review by: scottb
Modified: releases/1.6/e
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:23:10 2008
New Revision: 4004
Added:
releases/1.6/user/src/com/google/gwt/user/tools/RpcAsyncClientTemplate.javasrc
releases/1.6/user/src/com/google/gwt/user/tools/RpcClientTemplate.javasrc
releases/1.6/user/src/com/google/gwt/user/tools
Ray, for your delectation...
Removing onBeforeFire, adding a few comments, and converting enqueueRemove
to private.
Here is the review link:
http://code.google.com/p/google-web-toolkit/source/detail?r=4003
--
"There are only 10 types of people in the world: Those who understand
binary, and those
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 12:57:12 2008
New Revision: 4003
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
Log:
Removing onBeforeFire, adding comments, and converting enqueueRemove to
private.
Modified:
branches/1_6_clean_e
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 12:42:53 2008
New Revision: 4002
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/HasHandlers.java
Log:
Fix HasHandlers#getHandler javadoc--may return null
Modified:
branches/1_6_clean_events/user/src/com/google/
Deleted the two dom handler benchmarks causing 1.5 javac errors. Added
separate tracker item to figure out why. In the meantime, deleting them so
we can continue to compile using ant 1.5.
--
"There are only 10 types of people in the world: Those who understand
binary, and those who don't"
--~--~
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 11:44:43 2008
New Revision: 4001
Removed:
branches/1_6_clean_events/user/test/com/google/gwt/user/client/ui/DomEventBenchmark.java
branches/1_6_clean_events/user/test/com/google/gwt/user/client/ui/DomHandlerBenchmark.java
Log:
Removed benchm
For iframe loading, Cameron's change is correct. We should be loading
code into the document corresponding to our code context and not the
host page context. However, I am wondering how this is going to work
in the xs case where the code is loaded into an anonymous function in
the host page contex
+1 for the above patch working (and without it runAsync fragments not
loading in IE)
//Adam
On 10 Nov, 19:23, Lex Spoon <[EMAIL PROTECTED]> wrote:
> John,
>
> Do I remember correctly that you have looked at script-loading
> gymnastics in the HTML host pages before?
>
> The attached one-line patc
Committed as r4000
On Wed, Nov 5, 2008 at 8:13 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
> Ah! makes perfect sense, sorry for the confusion.
>
> On Wed, Nov 5, 2008 at 6:30 PM, Ray Ryan <[EMAIL PROTECTED]> wrote:
>
>> Because it tests the 1.5 api. If we want to run it again, it will be
>> sim
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 11:12:57 2008
New Revision: 4000
Added:
releases/1.5/reference/dispatch/
releases/1.5/reference/dispatch/Dispatch.gwt.xml
releases/1.5/reference/dispatch/client/
releases/1.5/reference/dispatch/client/Dispatch.java
releases/1.5/refere
http://code.google.com/p/google-web-toolkit/source/detail?r=3999
These three tests fail in webkit when run headless. I've added messages to
their asserts to explain that this is the case.
rjrjr
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolki
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 11:03:59 2008
New Revision: 3999
Modified:
branches/1_6_clean_events/user/test/com/google/gwt/user/client/WindowTest.java
branches/1_6_clean_events/user/test/com/google/gwt/user/client/ui/AbsolutePanelTest.java
branches/1_6_clean_events
Forgive me, I'm not sure if I was clear enough. When I said:
What I'm trying to get to here, is that it seems like, as the options get
> more complex about what files you can generate and where, it might make
> sense to unify that interface for generators and linkers
"that interface" I was refer
The problem I think with trying to unify generators and linkers is
coming up with a mechanism to order them. Linkers operate on output
artifacts, which means every generator for every permutation must have
been run before the linker. Linkers can be ordered, generators
currently cannot. Generators
John,
Do I remember correctly that you have looked at script-loading
gymnastics in the HTML host pages before?
The attached one-line patch fixes a problem with loading runAsync
fragments on IE. Can you review it for me? Cameron Braid reports
that without the fix, he can't load, and with it, he
+bobv and gwtc
This discussion needs broader distribution, guys.
On Sat, Nov 8, 2008 at 10:41 AM, Toby Reyelts <[EMAIL PROTECTED]> wrote:
> I don't know much about the details of linkers, but yes, things that you
> want to be able to read by your webapp, but not servable by your client,
> should
On Nov 10, 3:36 pm, [EMAIL PROTECTED] wrote:
> I added some code to have a callback from GWT to javascript, to make
> sure the GWT visualization is loaded before using it.
>
I am wondering what is the preferred way to make sure a GWT
application is loaded before some other javascript (non GWT) i
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 08:52:11 2008
New Revision: 3998
Modified:
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/gwt/core/linker/soyc/SoycReportLinker.java
Log:
Getting html escaping right.
Modified:
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 08:22:50 2008
New Revision: 3997
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
Log:
Fixing -port auto for JettyLauncher.
Found by: rdayal
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/shell/jett
LGTM
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 07:18:35 2008
New Revision: 3996
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/client/DomEvent.java
Log:
Adding guard against null registered map.
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/dom/cli
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 07:02:34 2008
New Revision: 3995
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
Log:
Adding onBeforeFire event to handler manager and making the fire event
final.
Modified:
branches/1_6_clean_even
[google-web-toolkit] EmilyCrutcher commented on revision r3979.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=3979
General Comment:
This has been true for statics in the past. However, it may/may not apply
to instance variables.
Respond to these comments at
htt
http://galgwt-reviews.appspot.com/401/diff/1/2
File
visualization/src/com/google/gwt/visualization/client/AbstractVisualization.java
(right):
http://galgwt-reviews.appspot.com/401/diff/1/2#newcode28
Line 28: * them to javascript.
On 2008/11/10 13:29:40, zundel wrote:
> What would be the effect i
I added some code to have a callback from GWT to javascript, to make
sure the GWT visualization is loaded before using it.
On 2008/11/10 13:56:48, zundel wrote:
> LGTM.
>
> I am not all that taken with the name 'MyVisualization', I would
prefer
> something like "CustomVisualization" instead. No
46 matches
Mail list logo
