Author: [EMAIL PROTECTED]
Date: Tue Dec 9 21:27:59 2008
New Revision: 4292
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/TabBar.java
releases/1.6/user/test/com/google/gwt/user/client/ui/TabBarTest.java
Log:
TabBar.setTabText(text) now sets wordWrap to false. TabBar.Tab
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 21:31:06 2008
New Revision: 4293
Added:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue2318.java
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 18:22:07 2008
New Revision: 4291
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java
Log:
Type fix.
Modified: releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java
==
On Tue, Dec 9, 2008 at 9:48 PM, John Tamplin <[EMAIL PROTECTED]> wrote:
> On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum <[EMAIL PROTECTED]> wrote:
>
>> We deal with this problem now by asserting that hosted mode will generally
>> not overwrite web mode artifacts unless they are newer. For the specif
On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum <[EMAIL PROTECTED]> wrote:
> We deal with this problem now by asserting that hosted mode will generally
> not overwrite web mode artifacts unless they are newer. For the specific
> case of the selection script, we give the hosted mode generated selection
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 18:09:48 2008
New Revision: 4290
Removed:
releases/1.6/user/src/com/google/gwt/core/public/
Log:
Deleting history.html.
Review by: jgw
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contrib
Submitted; the ant dependency would explain why the builds succeeded
On Tue, Dec 9, 2008 at 4:27 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote:
> LGTM.
>
> I had to make this change myself. (Apparently, this does not happen with
> ant 1.7+)
>
>
> On Tue, Dec 9, 2008 at 11:55 AM, Freeland Abbott <
LGTM
http://gwt-code-reviews.appspot.com/809
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Hey Bob,
This is just a bit of maintenance to bring XS in line with IFRAME (there's
no more __gwt_initHandlers); and also to bring SS more inline with XS. I
don't think there's any real substantive change here, but I wanted to verify
I wasn't screwing anything up undoing the whole anonymous functi
Ah, I see, the normal add(String) already sets word-wrap to false.
In that case LGTM.
On Tue, Dec 9, 2008 at 6:05 PM, <[EMAIL PROTECTED]> wrote:
> insertTab(String text, boolean asHTML, int beforeIndex) already disabled
> wordWrap, and we want insertTab() and setTabText() to be consistent.
> se
Yes, we need to implement this method in our implementations, but then not
actually call the method anywhere ourselves.
On Tue, Dec 9, 2008 at 1:33 PM, Lex Spoon <[EMAIL PROTECTED]> wrote:
> On Fri, Dec 5, 2008 at 12:28 PM, BobV <[EMAIL PROTECTED]> wrote:
> > - Several classes in user/test/.../s
insertTab(String text, boolean asHTML, int beforeIndex) already disabled
wordWrap, and we want insertTab() and setTabText() to be consistent.
setTabText() actually unwraps the text because it replaces the element.
I think its too late to change the fact that we set wordWrap to false in
insertTab,
The expansion of the tab interface looks great. Don't quite understand
the change to the default word wrapping...
http://gwt-code-reviews.appspot.com/604/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):
http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488
Line 48
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 13:07:05 2008
New Revision: 4287
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Reviewers: jlabanca,
Description:
Allows collapsible panel to have it state controlled via code.
Please review this at http://gwt-code-reviews.appspot.com/809
Affected files:
src-demo/com/google/gwt/widgetideas/demo/collapsiblepanel/client/CollapsiblePanelDemo.java
src-demo/com/google
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 13:10:39 2008
New Revision: 4288
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 12:48:14 2008
New Revision: 4281
Added:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Created wiki page through web user interface.
Added: wiki/GwtJavaApiCompatibilityChecker.wiki
Seems reasonable to me!
On Tue, Dec 9, 2008 at 3:46 PM, John LaBanca <[EMAIL PROTECTED]> wrote:
> Frames are used to load external sites, so the src is likely an actual URL,
> whereas NamedFrames are used locally and in FormPanels. While NamedFrames
> can be used for external sites and vice vers
Reviewers: ecc,
Description:
Description:
TabBar.insertTab(text) adds a Label with wordWrap set to false.
TabBar.setTabText(text) adds a Label without setting wordWrap (defaults
to true). Also, there is no way to change wordWrap programatically on a
tab.
Fix:
TabBar.setTabTex
LGTM.
I had to make this change myself. (Apparently, this does not happen with ant
1.7+)
On Tue, Dec 9, 2008 at 11:55 AM, Freeland Abbott <[EMAIL PROTECTED]
> wrote:
> Another patch-review for you, sorry: I'm actually a bit surprised that the
> prior built, which it did, but I just got a local b
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 13:13:01 2008
New Revision: 4289
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 12:52:36 2008
New Revision: 4283
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 13:02:03 2008
New Revision: 4285
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 12:49:24 2008
New Revision: 4282
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
In gwt-incubator, we want to be able to tag widgets/libaries
"alpha/beta/releaseCandidate". However, this implies an extra level of
support for releaseCandidate libraries/widgets. Specifically, between each
incubator drop, if we had to break the API, which we will occasionally need
to do, we wan
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 13:04:40 2008
New Revision: 4286
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 12:58:53 2008
New Revision: 4284
Modified:
wiki/GwtJavaApiCompatibilityChecker.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/GwtJavaApiCompatibilityChecker.wiki
===
Why is this a problem for NamedFrames but not Frames?
Other then that, LGTM.
On Tue, Dec 9, 2008 at 3:10 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: ecc,
>
> Description:
> Description:
>
> The iframe created in a NamedFrame does not have a src, so
> it throws a mixed content warnin
Frames are used to load external sites, so the src is likely an actual URL,
whereas NamedFrames are used locally and in FormPanels. While NamedFrames
can be used for external sites and vice versa, that isn't the default use
case. Also, people can change the URL of a NamedFrame via setUrl(), and
t
The diff didn't go through for DefaultMuseum.java. Here is that part of
the patch:
Index:
reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum.java
===
---
reference/code-museum/src/com/google/gwt/museu
Reviewers: ecc,
Description:
Description:
The iframe created in a NamedFrame does not have a src, so
it throws a mixed content warning in IE6 on an SSL-secured website.
Fix:
Setting the source to "javascript:''" fixes the problem, and we've used
the same trick on all other ifra
Comment by danigb:
this looks amazing! go ahead!
For more information:
http://code.google.com/p/google-web-toolkit/wiki/DesignOOPHM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~
Comment by danigb:
great!! i really like this!
For more information:
http://code.google.com/p/google-web-toolkit/wiki/WAR_Design_1_6
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~---
On Fri, Dec 5, 2008 at 12:28 PM, BobV <[EMAIL PROTECTED]> wrote:
> - Several classes in user/test/.../server/rpc do not compile against
> Jetty given the difference in the servlet API in Jetty versus Tomcat.
> This is problematic when using an Eclipse project structure that isn't
> hamstrung by l
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 10:14:21 2008
New Revision: 4280
Modified:
wiki/WAR_Design_1_6.wiki
Log:
Removed the whole module-session idea due to it creating too many issues.
Modified: wiki/WAR_Design_1_6.wiki
==
LGTM
http://gwt-code-reviews.appspot.com/603
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 07:17:36 2008
New Revision: 4276
Added:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue3172.java
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 07:24:19 2008
New Revision: 4277
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/public/SingleIssue.html
Log:
I accidentally changed the doc type of SingleIssue.html before submitting
r4276. The doctype should have been c
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 08:28:08 2008
New Revision: 4279
Modified:
releases/1.6/user/test/com/google/gwt/user/client/ui/TreeTest.java
Log:
Removing test that should have been removed with last commit.
TBA:jlabanca
Modified: releases/1.6/user/test/com/google/gwt/user/clien
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 07:43:57 2008
New Revision: 4278
Modified:
releases/1.6/eclipse/README.txt
Log:
Forgot to commit the updated eclipse/README.txt when I was removing
references
to projectCreator.
Modified: releases/1.6/eclipse/README.txt
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 06:27:26 2008
New Revision: 4274
Modified:
releases/1.6/build.xml
releases/1.6/tools/api-checker/config/gwt15_16userApi.conf
Log:
Updating api-checker config.
Modified: releases/1.6/build.xml
Reviewers: jlabanca,
Description:
John,
Could you review this fix for the assertion error that happens in
some circumstances when you remove Window listeners? Also included are
two new test cases to ensure we don't have a regression on this issue.
As a side note, I think this situation is
Another patch-review for you, sorry: I'm actually a bit surprised that the
prior built, which it did, but I just got a local build error complaining
about occurring inside a for the windows build... dangers
of too much cut-n-paste.
Patch in-line, as it's so short:
Index: distro-source/windows/
[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4279.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4279
Score: Positive
General Comment:
LGTM
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4279
--
You rece
committed as r4276
$wnd.screen.deviceXDPI / $wnd.screen.logicalXDPI didn't seem to work
(they returned the same value even when zoomed in). Reading through the
MSDN docs, it looks deviceXDPI changes when you change your screen
resolution, not when you zoom in.
http://gwt-code-reviews.appspot.co
Author: [EMAIL PROTECTED]
Date: Tue Dec 9 06:31:36 2008
New Revision: 4275
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/Tree.java
releases/1.6/user/test/com/google/gwt/user/client/ui/TreeTest.java
Log:
Removing deprecated setImageBase method from tree.
Modified: releas
Committed as 4274.
On Mon, Dec 8, 2008 at 8:25 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote:
> LGTM
>
>
> On Mon, Dec 8, 2008 at 6:40 PM, <[EMAIL PROTECTED]> wrote:
>
>> Reviewers: amitmanjhi,
>>
>> Description:
>> Amit,
>>
>> This patch changes the gwt build.xml file to use value rather then
>> lo
On Tue, Dec 9, 2008 at 12:42 AM, John LaBanca <[EMAIL PROTECTED]> wrote:
> Internet Explorer now works the same as Firefox. That is, with real zoom,
> absolute positions do not change even though the widget appears further from
> the left or top. I was going to put that info in the review request
On 9 déc, 07:16, Kelly Norton <[EMAIL PROTECTED]> wrote:
>
> Chrome: 4ms (fairly recent change)
> Safari (mac): 10ms
> Safari (win): 15ms
> Firefox: 15ms (or 10ms if flash is running)
> IE: 15ms
> Opera: I have no clue.
>
> So, that's just a really long way of saying that there is no danger in
>
On 8 déc, 21:58, [EMAIL PROTECTED] wrote:
>
> The DOCTYPE actually makes a difference. The following DOCTYPE (default
> in AppHtml.htmlsrc) works fine:
>
>
> However, adding the loose.dtd makes body.parentElement return the same
> size as body.element. The following DOCTYPE was used in the
> c
How about using the screen.deviceXDPI and related properties?
See:
-
http://msdn.microsoft.com/en-us/library/cc849094(VS.85).aspx#DetectViaJava
- http://msdn.microsoft.com/en-us/library/ms537625(VS.85).aspx
- http://msdn.microsoft.com/en-us/library/ms533721(VS.85).aspx
Something like (untest
51 matches
Mail list logo
