Hi,
Why don't you use code generation to generate the interfaces based on the
resource bundle properties files ?
That is what we do. Developers only need to define the properties and
through a Builder config in Eclipse we auto generate
the interfaces for GWT (and you could do the same to generate
Author: sco...@google.com
Date: Thu Dec 11 22:48:48 2008
New Revision: 4328
Modified:
wiki/WAR_Design_1_6.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/WAR_Design_1_6.wiki
==
--- wiki/WAR_Des
Author: sco...@google.com
Date: Thu Dec 11 22:39:05 2008
New Revision: 4327
Added:
releases/1.6/dev/core/src/com/google/gwt/dev/ArgProcessorBase.java
(contents, props changed)
releases/1.6/dev/core/test/com/google/gwt/dev/ArgProcessorTestBase.java
(contents, props changed)
r
Author: sco...@google.com
Date: Thu Dec 11 22:53:52 2008
New Revision: 4329
Modified:
wiki/WAR_Design_1_6.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/WAR_Design_1_6.wiki
==
--- wiki/WAR_Des
Thanks!
On Fri, Dec 12, 2008 at 1:08 AM, Ray Ryan wrote:
> This broke incubator for non-committers, as it was tied to
> https://google-web-toolkit.googlecode.com/svn/trunk/build-tools (https,
> not http). Should be fixed by r1306.
> Mmmm, copy/paste errors,rjrjr
>
> On Fri, Dec 12, 2008 at 10:24
http://gwt-code-reviews.appspot.com/606/diff/1/7
File user/src/com/google/gwt/event/logical/shared/HasNativeEvent.java
(right):
http://gwt-code-reviews.appspot.com/606/diff/1/7#newcode32
Line 32: }
Should this interface be in gwt.event.dom.client instead?
http://gwt-code-reviews.appspot.com/60
> how about we narrow the scope of this conversation to
> CheckBox api repair. How about this:
>
> Deprecate CheckBox#isChecked and CheckBox#setChecked
> Introduce CheckBox#setFormValue
> Add copious javadoc to compare and contrast the two set...Value methods
No objections here. While we're being
Reviewers: ecc,
Description:
If you create a PopupPanel and display it by calling its center()
method, its onLoad() method will be called twice. This is because the
center() method shows the popup with animation disabled to do its
calculations, hides it, and then reshows it with animation enable
Looks like it didn't like the diff. You can see the changes by clicking
the "Download" link in the "Patch" column.
http://gwt-code-reviews.appspot.com/811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~
On 2008/12/12 15:08:02, jlabanca wrote:
> Looks like it didn't like the diff. You can see the changes by
clicking the
> "Download" link in the "Patch" column.
Oh, and I tested this manually and added a unit test.
http://gwt-code-reviews.appspot.com/811
--~--~-~--~~~
Reviewers: jlabanca,
Description:
Issue details
at:http://code.google.com/p/google-web-toolkit/issues/detail?id=3194&q=owner:ecc&sort=priority
Please review this at http://gwt-code-reviews.appspot.com/607
Affected files:
user/src/com/google/gwt/user/client/ui/FiresDisclosureEvents.java
us
LGTM - just fix the one comment
http://gwt-code-reviews.appspot.com/607/diff/1/20
File user/src/com/google/gwt/user/client/ui/SourcesKeyboardEvents.java
(right):
http://gwt-code-reviews.appspot.com/607/diff/1/20#newcode21
Line 21: * instead.
Looks like you deleted a line by accident.
http://gw
Reviewers: ecc,
Description:
Description:
=
Calling Widget#removeFromParent() on the content of a DisclosurePanel
physically removes the content, but DisclosurePanel#getContent() still
returns the widget. This is because DisclosurePanel stores its content
as a private field AND wraps
I think we want to modify the DisclosurePanel comment, but other then
that, LGTM.
http://gwt-code-reviews.appspot.com/608/diff/1/3
File user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
(right):
http://gwt-code-reviews.appspot.com/608/diff/1/3#newcode264
Line 264: * The second child w
LGTM
http://gwt-code-reviews.appspot.com/811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Can we reference a private field in a comment on a private field? I
don't see any problem with this.
http://gwt-code-reviews.appspot.com/608/diff/1/3
File user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
(right):
http://gwt-code-reviews.appspot.com/608/diff/1/3#newcode264
Line 264:
Ah, so it is javadoc that will never be read by our users, no problems then
:-).
On Fri, Dec 12, 2008 at 11:05 AM, wrote:
> Can we reference a private field in a comment on a private field? I
> don't see any problem with this.
>
>
> http://gwt-code-reviews.appspot.com/608/diff/1/3
> File user/s
Author: e...@google.com
Date: Fri Dec 12 07:54:38 2008
New Revision: 4333
Added:
releases/1.6/user/src/com/google/gwt/event/shared/HasHandlers.java
Removed:
releases/1.6/user/src/com/google/gwt/event/shared/HasHandlerManager.java
Modified:
releases/1.6/user/src/com/google/gwt/event/
Author: sco...@google.com
Date: Fri Dec 12 08:23:34 2008
New Revision: 4334
Removed:
releases/1.6/dev/core/src/com/google/gwt/dev/ArgProcessorBase.java
releases/1.6/dev/core/test/com/google/gwt/dev/ArgProcessorTestBase.java
releases/1.6/dev/core/test/com/google/gwt/dev/CompilerTest.ja
Author: e...@google.com
Date: Fri Dec 12 07:43:05 2008
New Revision: 4331
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/FiresDisclosureEvents.java
releases/1.6/user/src/com/google/gwt/user/client/ui/FiresFormEvents.java
releases/1.6/user/src/com/google/gwt/user/cli
Author: e...@google.com
Date: Fri Dec 12 07:47:28 2008
New Revision: 4332
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/SourcesKeyboardEvents.java
Log:
Using gwt formatter on deprecated message for SourcesKeyboardEvents.
Modified:
releases/1.6/user/src/com/google/gwt/use
Author: fabb...@google.com
Date: Fri Dec 12 11:19:25 2008
New Revision: 4335
Modified:
releases/1.6/branch-info.txt
Log:
Added notes about the test from c4263 accidentally included in the merge of
c4298; make sure the merge of c4263 does reassert that test.
Modified: releases/1.6/branch-i
Author: jlaba...@google.com
Date: Fri Dec 12 12:45:07 2008
New Revision: 4337
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/PopupPanel.java
releases/1.6/user/test/com/google/gwt/user/client/ui/PopupTest.java
Log:
PopupPanel#center() no longer calls show() twice. We now c
Author: jlaba...@google.com
Date: Fri Dec 12 12:41:07 2008
New Revision: 4336
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
releases/1.6/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Log:
Removed the private content field from Dis
So, I've got these JSON formats that I use both in my Android code and
my GWT code. I originally implemented them as Overlay JSOs, and there
are classes that consume these OverlayJSOs to configure other parts of
the app. However, this makes the consumption code (which is really
quite generic and p
Ray, great timing. Bob was just talking about having started a patch to
allow this.
@Bob: care to comment?
On Fri, Dec 12, 2008 at 6:01 PM, Ray Cromwell wrote:
>
> So, I've got these JSON formats that I use both in my Android code and
> my GWT code. I originally implemented them as Overlay JSOs,
Sounds awesome. Here's the existing code we are using which shows the problem:
The portable (non-GWT) interface
http://code.google.com/p/gwt-chronoscope/source/browse/trunk/chronoscope/src/main/java/org/timepedia/chronoscope/client/data/json/JsonDataset.java
The wrapper
http://code.google.com/p/
Reviewers: jlabanca,
Description:
Adding Happy event to javadoc in order to be able to refer to it in the
events wiki design doc.
Please review this at http://gwt-code-reviews.appspot.com/813
Affected files:
user/javadoc/com/google/gwt/examples/events/HappyEvent.java
user/javadoc/com/goog
Looks cute to me
http://gwt-code-reviews.appspot.com/813
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: ecc,
Description:
The latest version of this patch introduces
PopupPanel.setAlwaysAutoHide(). Unlike autoHide, alwaysAutoHide
indicates that the PopupPanel should autoHide even if it isn't at the
top of the stack. The only time it does not autoHide is if a modal
popup is open above i
Hi Bob,
This is related to testing that the WAR design doc is being correctly
followed for options.
http://code.google.com/p/google-web-toolkit/wiki/WAR_Design_1_6
The change to the main classes are to make them testable. Then I added some
test code.
Thanks!
Scott
--~--~-~--~~-
What about having two forms of the Jso class a regular .java which
would be read by javac another under a super source source directory
which would actually be used during a gwt compile aka like emulated
JDk / junit etc classes. Any superclasses of jso would also need the
same treatment.
Author: sco...@google.com
Date: Fri Dec 12 16:26:51 2008
New Revision: 4339
Added:
releases/1.6/dev/core/src/com/google/gwt/dev/ArgProcessorBase.java
- copied unchanged from r4327,
/releases/1.6/dev/core/src/com/google/gwt/dev/ArgProcessorBase.java
Modified:
releases/1.6/dev/core
Author: sco...@google.com
Date: Fri Dec 12 16:20:45 2008
New Revision: 4338
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/GWTMain.java
Log:
GWTMain uses new entry points now.
Modified: releases/1.6/dev/core/src/com/google/gwt/dev/GWTMain.java
===
Author: sco...@google.com
Date: Fri Dec 12 16:45:06 2008
New Revision: 4340
Modified:
releases/1.6/eclipse/samples/DynaTable2/DynaTable2 compile.launch
releases/1.6/eclipse/samples/DynaTable2/DynaTable2 hosted.launch
releases/1.6/eclipse/samples/DynaTable2/DynaTable2Legacy compile.lau
Great news!
This will allow a faster implementation of com.google.gwt.dom.client.*
On 12 dic, 20:05, Bruce Johnson wrote:
> Ray, great timing. Bob was just talking about having started a patch to
> allow this.
> @Bob: care to comment?
>
> On Fri, Dec 12, 2008 at 6:01 PM, Ray Cromwell wrote:
>
>
Or even, implementing org.w3c.dom.* natively ;-)
On 13 dic, 00:21, Andrés Testi wrote:
> Great news!
> This will allow a faster implementation of com.google.gwt.dom.client.*
>
> On 12 dic, 20:05, Bruce Johnson wrote:
>
> > Ray, great timing. Bob was just talking about having started a patch to
37 matches
Mail list logo
