On Wed, May 20, 2009 at 3:13 PM, Ray Cromwell wrote:
> As a practical example, ClientBundle can already generate deep
> expressions for Css resource injection that exhaust the stack space of
> the JVM when compiling. You end up with something like:
>
> var cssText = a + b + c + . (hundreds)
>
Author: b...@google.com
Date: Thu May 21 06:43:38 2009
New Revision: 5451
Modified:
wiki/CssResource.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/CssResource.wiki
==
--- wiki/CssResource.wik
Author: b...@google.com
Date: Thu May 21 06:53:08 2009
New Revision: 5452
Added:
wiki/StyleInjector.wiki
Log:
Copy StyleInjector wiki page from incubator and update with current
information.
Added: wiki/StyleInjector.wiki
==
Author: b...@google.com
Date: Thu May 21 06:55:33 2009
New Revision: 5453
Modified:
wiki/StyleInjector.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/StyleInjector.wiki
==
--- wiki/StyleInject
Committed revision 5454.
I'll be patching this into the 1.6 branch as well.
On Wed, May 20, 2009 at 9:33 PM, wrote:
> LGTM
>
>
> http://gwt-code-reviews.appspot.com/34817
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--
Author: rj...@google.com
Date: Thu May 21 08:03:33 2009
New Revision: 5454
Modified:
trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
RadioButtons were not sinking click events
Issue: 3679
Reviewer: scottb
Modified: trunk/user/src/com/google/gwt/user/client/ui/RadioButton
Author: rj...@google.com
Date: Thu May 21 08:06:03 2009
New Revision: 5455
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Cherry pick of trunk r5454
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/RadioButton.java
===
Author: rj...@google.com
Date: Thu May 21 08:06:34 2009
New Revision: 5456
Modified:
releases/1.6/branch-info.txt
Log:
Record cherry pick of 5454
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/branch-in
Author: rj...@google.com
Date: Thu May 21 08:19:10 2009
New Revision: 5457
Modified:
releases/1.6/branch-info.txt
releases/1.6/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Rollback cherry pick of broken 5454
Modified: releases/1.6/branch-info.txt
===
Author: rj...@google.com
Date: Thu May 21 08:20:41 2009
New Revision: 5458
Modified:
trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Rollback of 5454 (missing an import line?)
Modified: trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java
===
Thanks, Joel. Committed at r5459.
http://gwt-code-reviews.appspot.com/33826
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: sp...@google.com
Date: Thu May 21 08:48:10 2009
New Revision: 5459
Added:
trunk/dev/core/src/com/google/gwt/dev/js/JsBreakUpLargeVarStatements.java
(contents, props changed)
trunk/user/src/com/google/gwt/core/CompilerParameters.gwt.xml
(contents, props changed)
Modified:
http://gwt-code-reviews.appspot.com/33826/diff/1/4
File user/src/com/google/gwt/core/CompilerParameters.gwt.xml (right):
http://gwt-code-reviews.appspot.com/33826/diff/1/4#newcode25
Line 25:
Okay, I'll change it to half.
http://gwt-code-reviews.appspot.com/33826
--~--~-~--~~--
Author: rj...@google.com
Date: Thu May 21 08:59:40 2009
New Revision: 5460
Modified:
trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Resubmitting radio button fix to sink click events, this time
with required import line.
Issue: 3679
Reviewer: scottb
Modified: trunk/use
Author: rj...@google.com
Date: Thu May 21 09:27:18 2009
New Revision: 5461
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Cherry pick of trunk c5460
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/RadioButton.java
==
Author: rj...@google.com
Date: Thu May 21 09:27:58 2009
New Revision: 5462
Modified:
releases/1.6/branch-info.txt
Log:
Record cherry pick of trunk c5460
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/br
Some more simple inline comments.
http://gwt-code-reviews.appspot.com/33815/diff/9/1007
File user/super/com/google/gwt/emul/java/util/BitSet.java (right):
http://gwt-code-reviews.appspot.com/33815/diff/9/1007#newcode176
Line 176: }-*/;
avoid using Log?
http://gwt-code-reviews.appspot.com/33815
[+gwtc]
-- Forwarded message --
From:
Date: Thu, May 21, 2009 at 11:37 AM
Subject: Re: Patch for issue 3279
To: dannydaemo...@gmail.com
Hi Danny,
How about refactoring BitSet.java as follows. I have introduced 3
private methods to do the handling and I have included sample
impl
Thanks for taking the time to listen, and for reviewing the code. If I
come across as overly defensive, it's only due to the amount of time
I've invested in this code. It's not due to any dislike for you, or
illusions of grandeur. I appreciate the patience you've shown me.
> How about refactor
O(N) temporary memory usage, which having the three native methods
approach (getWordPositions, setWord, getWord) is likely to have, is a
reasonable tradeoff to make since it will greatly enhance readability.
Your approach of using array indexing already saves a lot of memory as
it only uses O(N) m
> Using nextSetBit() repeatedly is a non-starter since compared to the
> integer-by-integer approach, every operation will be bit-by-bit. This
will be
> x-times slower, where x is the average number of bits set in an
integer.
I guess I wasn't clear in this regard, I was talking about just
refacto
Reviewers: rjrjr, jgw,
Description:
This patch adds support for bundling ClientBundle resources into a
single mhtml document to reduce the total number of round trips required
in IE6. It furthermore enables the use of data: urls for IE8.
Specifics:
- The mhtml format is defined in rfc 2557;
22 matches
Mail list logo
