Glanced over it, but I'm sure it's fine so I didn't fine-tooth it.
http://gwt-code-reviews.appspot.com/34836
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
I agree, although I find having a wiki with inline response rather
convenient. Here is what I have so far from the Wave, at the end, there is
a possible to solution to the problem of optimizing away the builder pattern
using general purpose optimizations.
-Ray
Advanced GWT Compiler Optimizations
I am getting this error after downloading the latest rev from the trunk
(5568?). I get the same error in Hosted Browser and OOPHM.
java.lang.NoSuchMethodError:
com.google.gwt.dev.shell.StandardGeneratorContext.(Lcom/google/
gwt/dev/javac/CompilationState;Lcom/google/gwt/dev/cfg/
PublicOracle;Lja
@Scott,
Per our IM conversation, I've renamed the new concept to
"GwtScriptOnly". Could you check this over once more before I commit it?
@John,
Thanks for the review.
http://gwt-code-reviews.appspot.com/34836
--~--~-~--~~~---~--~~
http://groups.google.com
Re: Wave access, I was really mostly just being playful, but I'll most
certainly beg and plead to get this group early in the line if at all
possible.
Meanwhile, I agree with Cameron that we should make sure to discuss the
major ideas here on the mailing list, even if some of the initial specifics
Unfortunately I wasn't able to attend Google I/O, however I did watch a few
of the sessions online.
I signed up for the sandbox, but it appears that google aren't going to
grant access to non IO attendees for a little while yet.
I'd appreciate an invite, but I understand if that's not feasible.
Matt,
I created a Wave "Advanced GWT Compiler Optimizations" and invited
you to it. Anyone who sends me their sandbox ID, I will invite. I am
using it to collect non-trivial optimizations in an outline draft
where we can discuss them. As a first pass, I entered the idea of
Hybrid-SSA/Tree-SSA/Ex
On Tue, Jun 16, 2009 at 6:29 PM, Scott Blum wrote:
> Instant hosted mode should really change the game, right? We will no
> longer be speculatively compiling anything for TypeOracle since we'll be
> using class files that should already exist.
The problem is that if there is no class file, we
Comment by tamplinjohn:
Are you trying to use it with GWT 1.6? That isn't going to work.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~---
Comment by googelybear:
When I try to start it (Main class=com.google.gwt.dev.HostedMode) I get:
Exception in thread "main" java.lang.NoSuchMethodError:
com.google.gwt.core.ext.ServletContainerLauncher.getName()Ljava/lang/String;
at com.google.gwt.dev.HostedMode.getWebServerName(HostedM
That would be marvelous. I hadn't thought through the implications of IHM,
but it seems like it might solve the problem.
What about types that aren't IHM compatible, such as those containing JSNI?
Could those still cause spurious errors?
On Tue, Jun 16, 2009 at 6:29 PM, Scott Blum wrote:
> Insta
LGTM
http://gwt-code-reviews.appspot.com/39805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Instant hosted mode should really change the game, right? We will no longer
be speculatively compiling anything for TypeOracle since we'll be using
class files that should already exist.
On Mon, Jun 15, 2009 at 11:21 PM, John Tamplin wrote:
> On Mon, Jun 15, 2009 at 11:11 PM, Bruce Johnson wro
Cameron, were you at Google I/O or did you sign up for the sandbox? I can
ask a Googler to invite you if not.
-Ray
On Mon, Jun 15, 2009 at 6:21 PM, Cameron Braid wrote:
>
> 2009/6/16 Bruce Johnson
>
>> I'm starting to make a bit o' progress on this. I'll send out a design doc
>> "real soon now
Author: fabb...@google.com
Date: Tue Jun 16 14:20:27 2009
New Revision: 5568
Added:
trunk/dev/core/test/com/google/gwt/core/ext/linker/impl/
trunk/dev/core/test/com/google/gwt/core/ext/linker/impl/StandardSelectionPropertyTest.java
Modified:
trunk/dev/core/src/com/google/gwt/core/ex
LGTM with nits.
http://gwt-code-reviews.appspot.com/34836/diff/1001/2002
File dev/core/src/com/google/gwt/dev/shell/rewrite/HasAnnotation.java
(right):
http://gwt-code-reviews.appspot.com/34836/diff/1001/2002#newcode29
Line 29: * a type.
Should mention the annotation has to be directly on the t
Author: b...@google.com
Date: Tue Jun 16 12:25:57 2009
New Revision: 5567
Modified:
trunk/user/test/com/google/gwt/resources/rg/CssTestCase.java
Log:
Fix missing file in r5566.
Modified: trunk/user/test/com/google/gwt/resources/rg/CssTestCase.java
===
A very interesting idea, a sort of hybrid AST/SSA (hmm, I recall GCC
now has some kind of 'Tree SSA' too) although I think the real win
wouldn't come until you could replace conditionals like
JWhile/JIf/JFor with their SSA equivalents.The reason being, you'd be
limited from doing intra-block flow
Author: b...@google.com
Date: Tue Jun 16 10:53:48 2009
New Revision: 5566
Modified:
trunk/user/src/com/google/gwt/resources/ext/ResourceContext.java
trunk/user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java
trunk/user/src/com/google/gwt/resources/rebind/context/Abstract
Author: fabb...@google.com
Date: Tue Jun 16 10:17:46 2009
New Revision: 5565
Modified:
wiki/DefaultLocaleBinding.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/DefaultLocaleBinding.wiki
==
---
Comment by poornimachandran123:
@Strict annotation will prove to boon and an error free system.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/CssResource
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributor
Could we build out SSA incrementally (brainstorming a bit here)?
Maybe start by replacing the Java and JS expressions with their SSA
equivalent in the tree? The consecutive JExpressionStatements in a
JBlock or JsBlock could be extracted into SSA form and inserted as a
new type of stateme
Thanks for the review. Committed at r5566.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
I prototyped a piece of this a couple of months ago in an attempt to
work out how to build an immediate dominator tree so as to perfectly
prune clinits. The problem is, you'd have to practically rewrite the
entire compiler. I think at this point, it's a little too much, maybe
something for GWT 3.0
I've been pondering an SSA structure for the compiler that would make
some of this stuff a lot easier to deal with. Instead of keeping the
AST for the Java and JS trees around, we'd put everything into a
unified data flow graph in memory (with appropriate side-effect
barriers), optimize t
I am definitely for this kind of optimization, since GQuery is
effectively nothing but chained calls. However, I think the issue is
more complicated than just rewriting.
First, whether or not the optimization is an improvement depends on
subsequently whether or not the methods can be inlined. Thu
LGTM
http://gwt-code-reviews.appspot.com/40804/diff/1/5
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):
http://gwt-code-reviews.appspot.com/40804/diff/1/5#newcode43
Line 43: private static final Map>
CACHES = new WeakHashMap>();
long line?
http://gwt
Author: fabb...@google.com
Date: Tue Jun 16 08:37:30 2009
New Revision: 5564
Modified:
trunk/doc/build.xml
Log:
Missed file from r5563
Review by: bobv
Modified: trunk/doc/build.xml
==
--- trunk/doc/build.xml (origi
Even before the inliner gets it, a JSO chained expression like
a().b().c() is going to look like c(b(a())) so the inliner can only
inline the first call.
Automatically introducing temporaries would seem a lot harder. You'd
have to teach the compiler that 'this' is effectively final, and
therefore
As I said, I hadn't looked at all into how feasible this was... but I was
hoping to do it by jiggering the Java AST, really, and not the JS one. That
is, I was looking to rewrite the Java from a chained
builder.setA().setB().setC() to multi-statement
builder.setA();builder.setB();builder.setC(), e
Author: fabb...@google.com
Date: Tue Jun 16 08:28:58 2009
New Revision: 5563
Modified:
trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java
trunk/build.xml
trunk/samples/common.ant.xml
trunk/tools/api-checker/build.xml
trunk/tools/soyc-vis/build.xml
I was talking to Scott about the same optimization, recognizing chains of
methods returning this and inlining them as a block. I haven't looked into
what's involved, though, and promise not to until Thursday at least
On Mon, Jun 15, 2009 at 9:11 PM, Brian Stoler wrote:
>
> Hi gwtc,
>
> I
wave id on the sandbox: eighty
On Mon, Jun 15, 2009 at 7:09 PM, Matt Mastracci wrote:
>
> I do as well - I'm mmastrac.
>
> On 15-Jun-09, at 8:02 PM, Ray Cromwell wrote:
>
>>
>> I do, cromwellian is my id on the sandbox.
>>
>> -Ray
>>
>>
>> On Mon, Jun 15, 2009 at 6:14 PM, Bruce Johnson
>> wrote:
Thanks. Submit @r5563; as usual, shout if there are other problems.
This should have accelerated the dist-dev case (by not needing tools), but
is really a bugfix patch.
On Tue, Jun 16, 2009 at 10:27 AM, BobV wrote:
> On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbott
> wrote:
> > Ping. Bob,
Reviewers: scottb,
Description:
Issue 3710 is caused by the Java inliner failing to take into account an
implicit cast to long in Integer::longValue(). The inliner already adds
explicit casts to the parameters of inlined methods. This patch has it
do so for return values as well.
If we run int
On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbott wrote:
> Ping. Bob, I think you had special interest in this one. ;-)
ant clear dist-dev && cd user && ant test
does the right thing.
LGTM.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://gr
Hi gwtc,
I was playing with using super-source to emulate some existing code
that uses a builder pattern and make it efficient in GWT as a
JavaScriptObject. I was hoping that the I could make the Builder just
compile away, but that doesn't seem to be happening. I started
debugging in JsInliner bu
Dear contributors,
We would like to interest you in a new extracting feature to GWT.
We add a sample application which using this feature and a short
documentation
(E1.rar and Extracting library and ITM.txt) .
We would be happy to hear your comments.
Thanks,
Elad and Osnat.
--~--~-~--
Using the logging module with a gwt build from trunk (since the last
week) I get the following error during the gwt compile:
...
[java] Loading inherited module
'com.google.gwt.gen2.logging.Logging'
[java] Loading inherited module
'com.google.gwt.gen2.logging.CoreLogging'
39 matches
Mail list logo
