[gwt-contrib] gwt incubator logging with gwt from trunk doesn't compile anymore.

2009-06-16 Thread ma
Using the logging module with a gwt build from trunk (since the last week) I get the following error during the gwt compile: ... [java] Loading inherited module 'com.google.gwt.gen2.logging.Logging' [java] Loading inherited module 'com.google.gwt.gen2.logging.CoreLogging'

[gwt-contrib] Optimizing away the builder pattern

2009-06-16 Thread Brian Stoler
Hi gwtc, I was playing with using super-source to emulate some existing code that uses a builder pattern and make it efficient in GWT as a JavaScriptObject. I was hoping that the I could make the Builder just compile away, but that doesn't seem to be happening. I started debugging in JsInliner

[gwt-contrib] Extracting library and ITM

2009-06-16 Thread Elad and Osnat
Dear contributors, We would like to interest you in a new extracting feature to GWT. We add a sample application which using this feature and a short documentation (E1.rar and Extracting library and ITM.txt) . We would be happy to hear your comments. Thanks, Elad and Osnat.

[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:

2009-06-16 Thread BobV
On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbottfabb...@google.com wrote: Ping.  Bob, I think you had special interest in this one. ;-) ant clear dist-dev cd user ant test does the right thing. LGTM. -- Bob Vawter Google Web Toolkit Team

[gwt-contrib] inliner handles implicit long cast at method return

2009-06-16 Thread spoon
Reviewers: scottb, Description: Issue 3710 is caused by the Java inliner failing to take into account an implicit cast to long in Integer::longValue(). The inliner already adds explicit casts to the parameters of inlined methods. This patch has it do so for return values as well. If we run

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-16 Thread Aaron Steele
wave id on the sandbox: eighty On Mon, Jun 15, 2009 at 7:09 PM, Matt Mastraccimatt...@mastracci.com wrote: I do as well - I'm mmastrac. On 15-Jun-09, at 8:02 PM, Ray Cromwell wrote: I do, cromwellian is my id on the sandbox. -Ray On Mon, Jun 15, 2009 at 6:14 PM, Bruce

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Freeland Abbott
I was talking to Scott about the same optimization, recognizing chains of methods returning this and inlining them as a block. I haven't looked into what's involved, though, and promise not to until Thursday at least On Mon, Jun 15, 2009 at 9:11 PM, Brian Stoler bsto...@google.com wrote:

[gwt-contrib] [google-web-toolkit commit] r5563 - Ant fixes for platform independence, for dist-dev not needing tools, and

2009-06-16 Thread codesite-noreply
Author: fabb...@google.com Date: Tue Jun 16 08:28:58 2009 New Revision: 5563 Modified: trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java trunk/build.xml trunk/samples/common.ant.xml trunk/tools/api-checker/build.xml trunk/tools/soyc-vis/build.xml

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Freeland Abbott
As I said, I hadn't looked at all into how feasible this was... but I was hoping to do it by jiggering the Java AST, really, and not the JS one. That is, I was looking to rewrite the Java from a chained builder.setA().setB().setC() to multi-statement builder.setA();builder.setB();builder.setC(),

[gwt-contrib] [google-web-toolkit commit] r5564 - Missed file from r5563

2009-06-16 Thread codesite-noreply
Author: fabb...@google.com Date: Tue Jun 16 08:37:30 2009 New Revision: 5564 Modified: trunk/doc/build.xml Log: Missed file from r5563 Review by: bobv Modified: trunk/doc/build.xml == --- trunk/doc/build.xml

[gwt-contrib] Re: RR : Make ClientBundle and CssResource generators faster

2009-06-16 Thread rice
LGTM http://gwt-code-reviews.appspot.com/40804/diff/1/5 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/40804/diff/1/5#newcode43 Line 43: private static final MapTypeOracle, MapString, Object CACHES = new

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Ray Cromwell
I am definitely for this kind of optimization, since GQuery is effectively nothing but chained calls. However, I think the issue is more complicated than just rewriting. First, whether or not the optimization is an improvement depends on subsequently whether or not the methods can be inlined.

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Matt Mastracci
I've been pondering an SSA structure for the compiler that would make some of this stuff a lot easier to deal with. Instead of keeping the AST for the Java and JS trees around, we'd put everything into a unified data flow graph in memory (with appropriate side-effect barriers), optimize

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Ray Cromwell
I prototyped a piece of this a couple of months ago in an attempt to work out how to build an immediate dominator tree so as to perfectly prune clinits. The problem is, you'd have to practically rewrite the entire compiler. I think at this point, it's a little too much, maybe something for GWT

[gwt-contrib] Re: RR : Make ClientBundle and CssResource generators faster

2009-06-16 Thread BobV
Thanks for the review. Committed at r5566. -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Comment on CssResource in google-web-toolkit

2009-06-16 Thread codesite-noreply
Comment by poornimachandran123: @Strict annotation will prove to boon and an error free system. For more information: http://code.google.com/p/google-web-toolkit/wiki/CssResource --~--~-~--~~~---~--~~

[gwt-contrib] [google-web-toolkit commit] r5565 - Edited wiki page through web user interface.

2009-06-16 Thread codesite-noreply
Author: fabb...@google.com Date: Tue Jun 16 10:17:46 2009 New Revision: 5565 Modified: wiki/DefaultLocaleBinding.wiki Log: Edited wiki page through web user interface. Modified: wiki/DefaultLocaleBinding.wiki ==

[gwt-contrib] Re: Optimizing away the builder pattern

2009-06-16 Thread Ray Cromwell
A very interesting idea, a sort of hybrid AST/SSA (hmm, I recall GCC now has some kind of 'Tree SSA' too) although I think the real win wouldn't come until you could replace conditionals like JWhile/JIf/JFor with their SSA equivalents.The reason being, you'd be limited from doing intra-block flow

[gwt-contrib] [google-web-toolkit commit] r5567 - Fix missing file in r5566.

2009-06-16 Thread codesite-noreply
Author: b...@google.com Date: Tue Jun 16 12:25:57 2009 New Revision: 5567 Modified: trunk/user/test/com/google/gwt/resources/rg/CssTestCase.java Log: Fix missing file in r5566. Modified: trunk/user/test/com/google/gwt/resources/rg/CssTestCase.java

[gwt-contrib] Re: RR : Allow user-provided bridge classes in hosted mode

2009-06-16 Thread jat
LGTM with nits. http://gwt-code-reviews.appspot.com/34836/diff/1001/2002 File dev/core/src/com/google/gwt/dev/shell/rewrite/HasAnnotation.java (right): http://gwt-code-reviews.appspot.com/34836/diff/1001/2002#newcode29 Line 29: * a type. Should mention the annotation has to be directly on the

[gwt-contrib] [google-web-toolkit commit] r5568 - Changes to make GWT i18n support real default locales. Introduces a .gwt.xml tag set-...

2009-06-16 Thread codesite-noreply
Author: fabb...@google.com Date: Tue Jun 16 14:20:27 2009 New Revision: 5568 Added: trunk/dev/core/test/com/google/gwt/core/ext/linker/impl/ trunk/dev/core/test/com/google/gwt/core/ext/linker/impl/StandardSelectionPropertyTest.java Modified:

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-16 Thread Ray Cromwell
Cameron, were you at Google I/O or did you sign up for the sandbox? I can ask a Googler to invite you if not. -Ray On Mon, Jun 15, 2009 at 6:21 PM, Cameron Braid came...@braid.com.au wrote: 2009/6/16 Bruce Johnson br...@google.com I'm starting to make a bit o' progress on this. I'll send

[gwt-contrib] Re: inliner handles implicit long cast at method return

2009-06-16 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/39805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Reducing noise in GWT compiler output

2009-06-16 Thread Bruce Johnson
That would be marvelous. I hadn't thought through the implications of IHM, but it seems like it might solve the problem. What about types that aren't IHM compatible, such as those containing JSNI? Could those still cause spurious errors? On Tue, Jun 16, 2009 at 6:29 PM, Scott Blum

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-06-16 Thread codesite-noreply
Comment by googelybear: When I try to start it (Main class=com.google.gwt.dev.HostedMode) I get: Exception in thread main java.lang.NoSuchMethodError: com.google.gwt.core.ext.ServletContainerLauncher.getName()Ljava/lang/String; at

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-06-16 Thread codesite-noreply
Comment by tamplinjohn: Are you trying to use it with GWT 1.6? That isn't going to work. For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Reducing noise in GWT compiler output

2009-06-16 Thread John Tamplin
On Tue, Jun 16, 2009 at 6:29 PM, Scott Blum sco...@google.com wrote: Instant hosted mode should really change the game, right? We will no longer be speculatively compiling anything for TypeOracle since we'll be using class files that should already exist. The problem is that if there is no

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-16 Thread Ray Cromwell
Matt, I created a Wave Advanced GWT Compiler Optimizations and invited you to it. Anyone who sends me their sandbox ID, I will invite. I am using it to collect non-trivial optimizations in an outline draft where we can discuss them. As a first pass, I entered the idea of

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-16 Thread Cameron Braid
Unfortunately I wasn't able to attend Google I/O, however I did watch a few of the sessions online. I signed up for the sandbox, but it appears that google aren't going to grant access to non IO attendees for a little while yet. I'd appreciate an invite, but I understand if that's not feasible.

[gwt-contrib] Re: RR : Allow user-provided bridge classes in hosted mode

2009-06-16 Thread bobv
@Scott, Per our IM conversation, I've renamed the new concept to GwtScriptOnly. Could you check this over once more before I commit it? @John, Thanks for the review. http://gwt-code-reviews.appspot.com/34836 --~--~-~--~~~---~--~~

[gwt-contrib] NoSuchMethodError with latest build of Trunk

2009-06-16 Thread Travis
I am getting this error after downloading the latest rev from the trunk (5568?). I get the same error in Hosted Browser and OOPHM. java.lang.NoSuchMethodError: com.google.gwt.dev.shell.StandardGeneratorContext.init(Lcom/google/ gwt/dev/javac/CompilationState;Lcom/google/gwt/dev/cfg/

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-16 Thread Ray Cromwell
I agree, although I find having a wiki with inline response rather convenient. Here is what I have so far from the Wave, at the end, there is a possible to solution to the problem of optimizing away the builder pattern using general purpose optimizations. -Ray Advanced GWT Compiler Optimizations

[gwt-contrib] Re: RR : Allow user-provided bridge classes in hosted mode

2009-06-16 Thread scottb
Glanced over it, but I'm sure it's fine so I didn't fine-tooth it. http://gwt-code-reviews.appspot.com/34836 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---