[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit

2009-07-13 Thread codesite-noreply
Comment by brett.wooldridge: As far as I can tell, my launch configuration has only those things. Including use of the automatic GWT SDK classpath entry. So here's my next question. When you speak of launch configurations, and not allowing the eclipse plugin to manage them, you are

[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit

2009-07-13 Thread codesite-noreply
Comment by brett.wooldridge: As far as I can tell, my launch configuration has only those things. Including use of the automatic GWT SDK classpath entry. So here's my next question. When you speak of launch configurations, and not allowing the eclipse plugin to manage them, you are talking

[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit

2009-07-13 Thread codesite-noreply
Comment by brett.wooldridge: BTW, I do have FF3.5 present on my system, but it is not the default browser. However, I note that OOPHM will automatically try to launch firefox, is this going to be a problem? For more information:

[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit

2009-07-13 Thread codesite-noreply
Comment by brett.wooldridge: To answer my own question, and for other users having the same issue, this worked: I created a standard Java Application launch configuration, using com.google.gwt.dev.HostedMode as the Main class, and the above recommended classpath. You'll have to get the

[gwt-contrib] [google-web-toolkit commit] r5721 - Fixes so apichecker works on Windows, by making the refJar path an ant path arg and s...

2009-07-13 Thread codesite-noreply
Author: fabb...@google.com Date: Mon Jul 13 05:30:55 2009 New Revision: 5721 Modified: trunk/build.xml trunk/tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java Log: Fixes so apichecker works on Windows, by making the refJar path an ant path arg and

[gwt-contrib] Resolve issue 3826

2009-07-13 Thread bobv
Reviewers: scottb, Message: Request review. Description: This patch ensures that a define-linker after an add-linker will correctly replace the previously-defined implementation. Please review this at http://gwt-code-reviews.appspot.com/47813 Affected files: M

[gwt-contrib] Issue 3822: TextBox.getselectedText() : bug on IE

2009-07-13 Thread jlabanca
Reviewers: jgw, Description: Description: TextBoxImplIE6#getSelectionLength() uses some hacks to figure out how many /r/n appear in a TextArea. The loop works for a TextArea but can result in an infinite loop in a TextBox. Fix: This patch splits the implementations for a

[gwt-contrib] Reverting API changes to RichTextArea#getExtendedFormatter()

2009-07-13 Thread jlabanca
Reviewers: kathrin, Description: Description: === While enhancing the RichTextArea, I added three methods to the public ExtendedFormatter interface in RichTextArea without thinking that users may implement the interface. Fix: === This patch removes the API additions. I already created

[gwt-contrib] Re: Reverting API changes to RichTextArea#getExtendedFormatter()

2009-07-13 Thread jlabanca
FYI - the changes in reference occured at r5630 and r5631. http://gwt-code-reviews.appspot.com/47814 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Resolve issue 3826

2009-07-13 Thread scottb
Another (cleaner?) solution would be to make activeLinkers a ListString and activePrimaryLinker String, as a pure reflection of add-linker statements. Meanwhile linkerTypesByName remains as pure reflection of define-linker statements. Then just generate the appropriate answers via the map on

[gwt-contrib] Re: Reverting API changes to RichTextArea#getExtendedFormatter()

2009-07-13 Thread John LaBanca
Its a double edged sword, but since these changes aren't in google3 current yet, I think its safe to revert them. Thanks, John LaBanca jlaba...@google.com On Mon, Jul 13, 2009 at 12:21 PM, kpro...@google.com wrote: On 2009/07/13 16:17:00, jlabanca wrote: FYI - the changes in reference

[gwt-contrib] DOM#eventGetCurrentEvent returns null in UncaughtExceptionHandler

2009-07-13 Thread jlabanca
Reviewers: jgw, Description: Description: === Under the current implementation, DOM#eventGetCurrentEvent() returns null in an UncaughtExceptionHandler if an error occurs in a user defined event handler. This is because we clear the current event before calling the

[gwt-contrib] [google-web-toolkit commit] r5722 - Rolling back c5720 because it broke the build.

2009-07-13 Thread codesite-noreply
Author: amitman...@google.com Date: Mon Jul 13 10:39:35 2009 New Revision: 5722 Removed: trunk/user/src/com/google/gwt/junit/BatchingStrategy.java Modified: trunk/common.ant.xml trunk/user/src/com/google/gwt/junit/JUnitMessageQueue.java

[gwt-contrib] [google-web-toolkit commit] r5723 - Removing RichTextArea API additions introduced in r5630 and r5631 because some people may...

2009-07-13 Thread codesite-noreply
Author: jlaba...@google.com Date: Mon Jul 13 13:17:21 2009 New Revision: 5723 Modified: trunk/user/src/com/google/gwt/user/client/ui/RichTextArea.java Log: Removing RichTextArea API additions introduced in r5630 and r5631 because some people may be extending these interfaces, which makes

[gwt-contrib] [google-web-toolkit commit] r5724 - Merged /tr...@r5723 into snapshot-2009.07.07 branch.

2009-07-13 Thread codesite-noreply
Author: jlaba...@google.com Date: Mon Jul 13 13:26:53 2009 New Revision: 5724 Modified: branches/snapshot-2009.07.07-r5687/branch-info.txt branches/snapshot-2009.07.07-r5687/user/src/com/google/gwt/user/client/ui/RichTextArea.java Log: Merged /tr...@r5723 into snapshot-2009.07.07

[gwt-contrib] [google-web-toolkit commit] r5725 - HTMLPanel now allows an arbitrary element to be set as its root, via

2009-07-13 Thread codesite-noreply
Author: rj...@google.com Date: Mon Jul 13 14:05:32 2009 New Revision: 5725 Added: trunk/user/src/com/google/gwt/junit/FakeMessagesMaker.java trunk/user/test/com/google/gwt/junit/FakeMessagesMakerTest.java trunk/user/test/com/google/gwt/junit/JUnitSuite.java Modified:

[gwt-contrib] [google-web-toolkit commit] r5726 - Adding -da flag to disable assertions, and flipping the default for tests

2009-07-13 Thread codesite-noreply
Author: fabb...@google.com Date: Mon Jul 13 14:17:58 2009 New Revision: 5726 Added: trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableAssertions.java Modified: trunk/dev/core/src/com/google/gwt/dev/GWTShell.java

[gwt-contrib] Re: Issue 3822: TextBox.getselectedText() : bug on IE

2009-07-13 Thread Yoshiki Shibata
Hi John, Thank you for quick response. It is interesting to know the right fix. Yoshiki jlaba...@google.com さんは書きました: Reviewers: jgw, Description: Description: TextBoxImplIE6#getSelectionLength() uses some hacks to figure out how many /r/n appear in a TextArea. The loop

[gwt-contrib] Re: Resolve issue 3826

2009-07-13 Thread bobv
I've changed ModuleDef to track the string names internally. This makes all of the added code in defineLinker() sanity-checking code. http://gwt-code-reviews.appspot.com/47813/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):

[gwt-contrib] Re: Resolve issue 3826

2009-07-13 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/47813 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r5727 - Ensure that a define-linker after an add-linker will correctly replace the previously...

2009-07-13 Thread codesite-noreply
Author: b...@google.com Date: Mon Jul 13 16:05:32 2009 New Revision: 5727 Added: trunk/dev/core/test/com/google/gwt/dev/cfg/ trunk/dev/core/test/com/google/gwt/dev/cfg/ModuleDefTest.java Modified: trunk/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java

[gwt-contrib] [google-web-toolkit commit] r5728 - Merge r5727 from trunk.

2009-07-13 Thread codesite-noreply
Author: b...@google.com Date: Mon Jul 13 16:12:31 2009 New Revision: 5728 Added: branches/snapshot-2009.07.07-r5687/dev/core/test/com/google/gwt/dev/cfg/ - copied from r5727, /trunk/dev/core/test/com/google/gwt/dev/cfg/

[gwt-contrib] [google-web-toolkit commit] r5729 - Update branch info to reflect r5728.

2009-07-13 Thread codesite-noreply
Author: b...@google.com Date: Mon Jul 13 16:13:40 2009 New Revision: 5729 Modified: branches/snapshot-2009.07.07-r5687/branch-info.txt Log: Update branch info to reflect r5728. Modified: branches/snapshot-2009.07.07-r5687/branch-info.txt

[gwt-contrib] GWT 1.7 Now Available

2009-07-13 Thread Bruce Johnson
Hi everyone, GWT 1.7 is a minor update that adds better support for Internet Explorer 8, Firefox 3.5, and Safari 4. Each of these new browser versions introduced at least one change that negatively impacted compiled GWT modules, so we recommend that you do update to GWT 1.7 and recompile your

[gwt-contrib] Re: Yet more Data Binding and Validation Thoughts

2009-07-13 Thread Andrew Pietsch
I've updated the document on PresentationModel thoughts with experiences from an initial prototype. On the whole the guice style builder approach has been very nice and significantly reduces the effort in learning and remembering the api. You can read it at: