Peanut gallery sez: Can we use an ant "outofdate" to just generically guard
rerunning this rule?
On Fri, Oct 23, 2009 at 3:01 PM, wrote:
>
> Reviewers: Ray Ryan,
>
> Description:
> Description:
> ===
> Our ant test targets run in parallel, and they all depend on compile and
> compile.tes
Revision: 6461
Author: kpro...@google.com
Date: Fri Oct 23 19:19:09 2009
Log: Rolling back r6449 (Soyc test).
http://code.google.com/p/google-web-toolkit/source/detail?r=6461
Deleted:
/trunk/dev/core/test/com/google/gwt/dev/SoycTest.java
Modified:
/trunk/dev/build.xml
=
One or two questions, and I can't really answer most of the FIXME
issues--some or all of the others will need to pick those up.
Thanks for this!
http://gwt-code-reviews.appspot.com/86801/diff/1/9
File dev/core/src/com/google/gwt/dev/generator/ast/MethodCall.java
(right):
http://gwt-code-review
Revision: 6460
Author: jlaba...@google.com
Date: Fri Oct 23 16:28:56 2009
Log: Adding properties to the user test targets to prevent parallel
compiles, as we already did with the main test target.
Patch by: jlabanca
Review by: rjrjr (TBR)
http://code.google.com/p/google-web-toolkit/source/det
I submitted this TBR because its breaking the build:
http://code.google.com/p/google-web-toolkit/source/detail?r=6460
http://gwt-code-reviews.appspot.com/86802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~
Revision: 6459
Author: jlaba...@google.com
Date: Fri Oct 23 16:25:03 2009
Log: r6458 causes CssProperty to add a space before the first part of a CSS
expression. This patch only adds spaces after the first part.
Patch by: jlabanca
Review by: bobv (TBR)
http://code.google.com/p/google-web-too
Revision: 6458
Author: jlaba...@google.com
Date: Fri Oct 23 15:25:47 2009
Log: Adding a TokenValue to CssProperty to handle CSS components that
should not be wrapped with spaces. This fixes a bug in the generated css
for WidgetUiDemo that affects IE.
Patch by: jlabanca
Review by: bobv
http
LGTM
http://gwt-code-reviews.appspot.com/87802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Ray Ryan,
Description:
Description:
===
Our ant test targets run in parallel, and they all depend on compile and
compile.tests. Ant is not smart enough to only run the depends targets
once, so its possible to compile these targets multiple times, even in
parallel. This can le
LGTM
http://gwt-code-reviews.appspot.com/83801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Yes. It should be deleted.
Thanks,
John LaBanca
jlaba...@google.com
On Fri, Oct 23, 2009 at 5:48 PM, Ray Ryan wrote:
> We're backing away from this change, right?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--
Revision: 6457
Author: jlaba...@google.com
Date: Fri Oct 23 14:47:52 2009
Log: Adding DoNotRunWith(HtmlUnit) to
ListBoxTest/StackPanelTest#testDebugId because they fail fairly often in
HtmlUnit.
Patch by: jlabanca
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=
We're backing away from this change, right?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Nice sleuthing John!
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
Thanks, John.
http://gwt-code-reviews.appspot.com/87804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Good job on diagnosing the problem. Instead of hacking up IdentValue,
introduce another Value subtype (call it "TokenValue") that has this
alternate printing behavior.
http://gwt-code-reviews.appspot.com/87802
--~--~-~--~~~---~--~~
http://groups.google.com/group/
Revision: 6456
Author: jlaba...@google.com
Date: Fri Oct 23 14:26:17 2009
Log: JUnitShell will wait indefinitely for a remote web test to start
because BrowserManagerServer might queue the test for a while.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/d
On Fri, Oct 23, 2009 at 2:23 PM, John LaBanca wrote:
> RunStyleRemoteWeb#launchModule will detect if the test cannot start, and
> #doKeepAlives will detect communication errors. If BrowserManager is stuck
> running a test, then presumably the JUnitShell that opened it will timeout
> the test aft
RunStyleRemoteWeb#launchModule will detect if the test cannot start, and
#doKeepAlives will detect communication errors. If BrowserManager is stuck
running a test, then presumably the JUnitShell that opened it will timeout
the test after 20 minutes and kill the test, so I think we're covered all
a
On Fri, Oct 23, 2009 at 1:38 PM, wrote:
> RunStyleRemoteWeb now takes a similar path as RunStyleManual, giving
> clients unlimited time to start the test. RunStyleRemoteWeb already
> handles communication errors with JUnitShell, so we just check for
> wasInterrupted.
>
My concern is that it will
Incubator trunk is *already incompatible* with 1.7. Don't waste your time.
On Fri, Oct 23, 2009 at 11:52 AM, Freeland Abbott wrote:
> Well, the dual-mode isn't a big deal... updated, and I can go either way on
> submission. (But I agree that trunk-tracks-trunk is sane, and
> trunk-tracks-many is
Reviewers: jat,
Description:
Description:
JUnitShell fails tests after 60s, but BrowserManagerServer may have a
queue much longer than that if multiple JUnitShell instances are using
it. For example, our own build runs in parallel, and some tests take
2-5 minutes to complete, so oth
Revision: 6455
Author: kpro...@google.com
Date: Fri Oct 23 13:15:54 2009
Log: Reduces some compiler spew.
Review by: spoon, scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=6455
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
/t
Revision: 6454
Author: fabb...@google.com
Date: Fri Oct 23 12:30:47 2009
Log: Updated with c6451, Fix a fatal error when asserts are enabled and a
locale specified in
@DefaultLocale is not in the current list of locales.
Patch by: jat
Review by: jlabanca
Merge by: fabbott
http://code.google.c
Reviewers: Ray Ryan,
Description:
Description:
Both of these tests use a DeferredCommand and do similar things. They
fail in HtmlUnit fairly often on our build system, even with long
timeouts.
Fix:
Disable the tests on HtmlUnit.
Please review this at http://gwt-code-reviews.
Well, the dual-mode isn't a big deal... updated, and I can go either way on
submission. (But I agree that trunk-tracks-trunk is sane, and
trunk-tracks-many is less so.)
On Fri, Oct 23, 2009 at 2:46 PM, Ray Ryan wrote:
> No, we changed that last month, discussed the change on GWT-C, and updated
No, we changed that last month, discussed the change on GWT-C, and updated
the Incubator wiki accordingly. This is okay.
On Fri, Oct 23, 2009 at 11:43 AM, Freeland Abbott wrote:
> Grr. You're right, but it's supposed to work with *either* the trunk *or* the
> most current, so I'll have to revisi
I thought incubator policy was that it tracks with trunk. We usually
provide a jar to support the previously released version. We abandoned the
idea of supported the previous release and trunk after gwt 1.6 because
nearly impossible to do so.
Thanks,
John LaBanca
jlaba...@google.com
On Fri, Oc
Grr. You're right, but it's supposed to work with *either* the trunk *or* the
most current, so I'll have to revisit that patch...
On Fri, Oct 23, 2009 at 2:39 PM, wrote:
> I thought incubator policy was it needed to operate with the most recent
> official release, which is currently 1.7.1 and w
I thought incubator policy was it needed to operate with the most recent
official release, which is currently 1.7.1 and will fail after this
change.
http://gwt-code-reviews.appspot.com/87803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-C
Revision: 6453
Author: j...@google.com
Date: Fri Oct 23 11:37:32 2009
Log: Merge r6451 from trunk to the release branch.
Fixes a fatal error on @DefaultLocale("foo") when foo is not in the locale
list
svn merge --ignore-ancestry -c6451 \
https://google-web-toolkit.googlecode.com/sv
Reviewers: jlabanca,
Description:
let it compile!
Please review this at http://gwt-code-reviews.appspot.com/87803
Affected files:
common.ant.xml
Index: common.ant.xml
===
--- common.ant.xml (revision 1733)
+++ common.ant.
Revision: 6452
Author: jlaba...@google.com
Date: Fri Oct 23 11:30:55 2009
Log: Suppress spurious JSNI ref warnings inside EmmaClassLoadingTest.
Submitting on Keith's behalf.
Patch by: kplatfoot
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6452
Modified:
Revision: 6451
Author: j...@google.com
Date: Fri Oct 23 11:29:07 2009
Log: Fix a fatal error when asserts are enabled and a locale specified in
@DefaultLocale is not in the current list of locales.
Patch by: jat
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6451
Thanks, committed to trunk at r6451.
http://gwt-code-reviews.appspot.com/87801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
http://gwt-code-reviews.appspot.com/87801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Ray Ryan,
Description:
Description:
===
CssProperty.ListValue#getExpression() joins IdentValues in a single CSS
expression, adding a space between them. Example:
border: 1px solid red;
However, spaces are not required in all cases, and in one case, they
cause a parsing error
Revision: 6450
Author: kpro...@google.com
Date: Fri Oct 23 11:09:22 2009
Log: Cleans up SOYC options: -compileReport is now preferred way to
generate SOYC reports, -soyc is now undocumented, and getting detailed SOYC
report now automatically implies the regular SOYC report also.
Review by: sp
Reviewers: jlabanca,
Description:
If asserts are enabled, having @DefaultLocale("foo") is a fatal error if
foo is not in the current list of locales.
Please review this at http://gwt-code-reviews.appspot.com/87801
Affected files:
user/src/com/google/gwt/i18n/rebind/AbstractLocalizableImplCre
Revision: 6449
Author: kpro...@google.com
Date: Fri Oct 23 09:55:33 2009
Log: Adds basic test case for SOYC.
http://code.google.com/p/google-web-toolkit/source/detail?r=6449
Added:
/trunk/dev/core/test/com/google/gwt/dev/SoycTest.java
Modified:
/trunk/dev/build.xml
Revision: 6448
Author: fabb...@google.com
Date: Fri Oct 23 09:31:50 2009
Log: Adding branch-info.txt
http://code.google.com/p/google-web-toolkit/source/detail?r=6448
Added:
/branches/snapshot-2009.10.23-r6446/branch-info.txt
===
--- /dev/null
+++ /branches/
Revision: 6447
Author: fabb...@google.com
Date: Fri Oct 23 09:04:26 2009
Log: Created ms2-equivalent snapshot via:
svn copy -r6446 https://google-web-toolkit.googlecode.com/svn/trunk
https://google-web-toolkit.googlecode.com/svn/branches/snapshot-2009.10.23-r6446
http://code.google.com/p/go
Reviewers: jat, Ray Ryan, Lex, scottb,
Description:
Fix some cases of the following classes of warnings:
1) (Obviously correctly) unused variables
2) Redundant interface inheritance
3) Redundant null checks
4) Redundant casts
5) Hidden variables
6) Deprecation
6) (Only in HandlerClassInfo.java)
43 matches
Mail list logo
