[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit

2009-11-18 Thread codesite-noreply
Comment by brunabasseio: good article For more information: http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r6979 committed - tr...@6968 was merged into this branch...

2009-11-18 Thread codesite-noreply
Revision: 6979 Author: jlaba...@google.com Date: Wed Nov 18 05:37:52 2009 Log: tr...@6968 was merged into this branch Accounting for time difference between host and client in CookieTest#testExpires svn merge --ignore-ancestry -c 6968 https://google-web-toolkit.googlecode.com/svn/trunk .

Re: [gwt-contrib] Reusing CssResource's @def (within e.g. UiBinder)

2009-11-18 Thread BobV
> @bobv, will anything pathological happen to the generated code if lots of > ui.xml files all do this? Remember that each ui.xml defines its own > ClientBundle. The common css will be duplicated every time you do this, but this may be what you want, depending on whether or not the common css shou

[gwt-contrib] [google-web-toolkit] r6980 committed - Edited wiki page through web user interface.

2009-11-18 Thread codesite-noreply
Revision: 6980 Author: b...@google.com Date: Wed Nov 18 06:09:49 2009 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=6980 Modified: /wiki/CssResource.wiki === --- /wiki/CssResource.wiki Mon N

[gwt-contrib] Re: NPE during Serialization in deRPC

2009-11-18 Thread BobV
> com.google.gwt.rpc.server.WebModePayloadSink.getBytes(WebModePayloadSink.java:860) > at > com.google.gwt.rpc.server.WebModePayloadSink$PayloadVisitor.constructorFunction(WebModePayloadSink.java:607) Can you run your server code with assertions enabled? This should have tripped the assertion on

[gwt-contrib] [google-web-toolkit] r6981 committed - Reduce log levels for DevMode startup and remove stderr logging of sta...

2009-11-18 Thread codesite-noreply
Revision: 6981 Author: j...@google.com Date: Wed Nov 18 06:54:16 2009 Log: Reduce log levels for DevMode startup and remove stderr logging of startup URL. Patch by: jat Review by: bruce http://code.google.com/p/google-web-toolkit/source/detail?r=6981 Modified: /trunk/dev/core/src/com/google/

[gwt-contrib] Re: Reduce log levels, remove stderr launch URL message

2009-11-18 Thread jat
On 2009/11/17 23:38:18, bruce wrote: > LGTM Committed to trunk at r6981, will merge to releases/2.0 shortly. http://gwt-code-reviews.appspot.com/104801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Reduce log levels, remove stderr launch URL message

2009-11-18 Thread John Tamplin
On 11/17/09, Thomas Matthijs wrote: > There used to be a copy-pasteable URL in the DevMode log window of the > app you started (removed in 6559), I found this hugely helpfull when i > was new to devmode and could not remember the the ?gwt.codesrv or the > magical path/directory it put the project

Re: [gwt-contrib] [google-web-toolkit] r6973 committed - Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up t...

2009-11-18 Thread דניאל רייס
Window.setIconImages was introduced in Java 1.6. This doesn't compile on 1.5. Dan On Tue, Nov 17, 2009 at 5:52 PM, wrote: > Revision: 6973 > Author: j...@google.com > Date: Tue Nov 17 14:51:47 2009 > Log: Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up > the 16x16 > icon

Re: [gwt-contrib] [google-web-toolkit] r6973 committed - Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up t...

2009-11-18 Thread John Tamplin
Sigh, thanks for catching that. Any suggestions for setting more than one icon in JDK 1.5? If not, I guess I can reflectively call setIconImages if it is there and fallback to the old behavior on JDK 1.5. On 11/18/09, Daniel Rice (דניאל רייס) wrote: > Window.setIconImages was introduced in Ja

Re: [gwt-contrib] Re: Reduce log levels, remove stderr launch URL message

2009-11-18 Thread Thomas Matthijs
> > You should see a log message "Waiting for browser connection to ..." > with the URL, and a "Launch default browser" link there.  Does that > not meet your needs? Maybe i'm doing it wrong, but that's not what i get. http://imgur.com/uWqfx If you go to http://localhost:/ you get an alert err

[gwt-contrib] [google-web-toolkit] r6982 committed - Fix XHR memory leak one more time by re-using a static null function....

2009-11-18 Thread codesite-noreply
Revision: 6982 Author: b...@google.com Date: Wed Nov 18 07:47:46 2009 Log: Fix XHR memory leak one more time by re-using a static null function. Patch by: bobv Review by: jgw http://code.google.com/p/google-web-toolkit/source/detail?r=6982 Modified: /trunk/user/src/com/google/gwt/xhr/client/XML

[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues

2009-11-18 Thread jat
http://gwt-code-reviews.appspot.com/97812/diff/1/2 File user/src/com/google/gwt/i18n/client/NumberFormat.java (right): http://gwt-code-reviews.appspot.com/97812/diff/1/2#newcode1323 Line 1323: String digits = Double.toString(number); On 2009/11/17 22:14:49, jat wrote: > This essentially reduces t

[gwt-contrib] [google-web-toolkit] r6983 committed - Ensure server info from superclasses doesn't stomp on subclass info....

2009-11-18 Thread codesite-noreply
Revision: 6983 Author: r...@google.com Date: Wed Nov 18 07:57:10 2009 Log: Ensure server info from superclasses doesn't stomp on subclass info. This fixes external issue 3969 (http://code.google.com/p/google-web-toolkit/issues/detail?id=3969). When a class with superclasses was being serialized, t

[gwt-contrib] Fix JDK 1.6+ dependency for setting multiple icons in Swing UI

2009-11-18 Thread jat
Reviewers: bobv, Dan Rice, Description: r6973 broke JDK 1.5, and this fixes it by making the call reflectively and falling back to the old behavior if that fails. Please review this at http://gwt-code-reviews.appspot.com/103807 Affected files: dev/core/src/com/google/gwt/dev/SwingUI.java --

[gwt-contrib] Re: Fix JDK 1.6+ dependency for setting multiple icons in Swing UI

2009-11-18 Thread bobv
Don't ignore the exceptions that are actual errors. http://gwt-code-reviews.appspot.com/103807/diff/1/2 File dev/core/src/com/google/gwt/dev/SwingUI.java (right): http://gwt-code-reviews.appspot.com/103807/diff/1/2#newcode86 Line 86: protected interface TabPanelCollection { Is this change relate

Re: [gwt-contrib] Re: Reduce log levels, remove stderr launch URL message

2009-11-18 Thread John Tamplin
Are you including a host page in your DevMode launch config? You should be using -startupUrl Foo.html to tell GWT which host page you want to use, and then it will generate a complete URL for you. On 11/18/09, Thomas Matthijs wrote: >> >> You should see a log message "Waiting for browser connect

Re: [gwt-contrib] Re: Reduce log levels, remove stderr launch URL message

2009-11-18 Thread Thomas Matthijs
On Wed, Nov 18, 2009 at 17:15, John Tamplin wrote: > Are you including a host page in your DevMode launch config?  You > should be using -startupUrl Foo.html to tell GWT which host page you > want to use, and then it will generate a complete URL for you. > Ah much better indeed: "00:00:05.309 [IN

[gwt-contrib] [google-web-toolkit] r6984 committed - Reduce unnecessary public visibility, add javadoc....

2009-11-18 Thread codesite-noreply
Revision: 6984 Author: j...@google.com Date: Wed Nov 18 08:26:08 2009 Log: Reduce unnecessary public visibility, add javadoc. Patch by: jat Review by: bobv http://code.google.com/p/google-web-toolkit/source/detail?r=6984 Modified: /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java ==

[gwt-contrib] Re: Fix JDK 1.6+ dependency for setting multiple icons in Swing UI

2009-11-18 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/103807 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r6985 committed - Fix breakage against JDK 1.5 due to r6973....

2009-11-18 Thread codesite-noreply
Revision: 6985 Author: j...@google.com Date: Wed Nov 18 08:39:41 2009 Log: Fix breakage against JDK 1.5 due to r6973. Patch by: jat Review by: bobv http://code.google.com/p/google-web-toolkit/source/detail?r=6985 Modified: /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java ==

[gwt-contrib] Re: Fix JDK 1.6+ dependency for setting multiple icons in Swing UI

2009-11-18 Thread jat
On 2009/11/18 16:30:20, bobv wrote: > LGTM Thanks, committed to trunk at r6985, will merge to releases/2.0 shortly. http://gwt-code-reviews.appspot.com/103807 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r6986 committed - Merge trunk r6981, r6984-6985 into this branch...

2009-11-18 Thread codesite-noreply
Revision: 6986 Author: j...@google.com Date: Wed Nov 18 08:54:38 2009 Log: Merge trunk r6981, r6984-6985 into this branch Cleanup logging, reduce visibility of SwingUI internals, fix JDK 1.5 breakage svn merge --ignore-ancestry -c6981 \ https://google-web-toolkit.googlecode.com/svn/

[gwt-contrib] [google-web-toolkit] r6987 committed - Add support for calling into OS X's Application class to set the Dock ...

2009-11-18 Thread codesite-noreply
Revision: 6987 Author: b...@google.com Date: Wed Nov 18 08:54:53 2009 Log: Add support for calling into OS X's Application class to set the Dock icon and clean up the application menu. Patch by: bobv Review by: jat, bruce http://code.google.com/p/google-web-toolkit/source/detail?r=6987 Modified

[gwt-contrib] [google-web-toolkit] r6988 committed - Merge tr...@6982 to fix XHR memory leak....

2009-11-18 Thread codesite-noreply
Revision: 6988 Author: b...@google.com Date: Wed Nov 18 09:04:51 2009 Log: Merge tr...@6982 to fix XHR memory leak. $ svn merge --ignore-ancestry -c6982 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/detail?r=6988 Modified: /releases/

[gwt-contrib] [google-web-toolkit] r6989 committed - Separated HtmlUnit layout issue from GPE issue.

2009-11-18 Thread codesite-noreply
Revision: 6989 Author: to...@google.com Date: Wed Nov 18 09:08:21 2009 Log: Separated HtmlUnit layout issue from GPE issue. http://code.google.com/p/google-web-toolkit/source/detail?r=6989 Modified: /wiki/GWT_2_0_RC.wiki === --- /wiki/GWT_2_0_RC.wiki Tu

[gwt-contrib] [google-web-toolkit] r6990 committed - Merge tr...@6987 to make Development Mode UI integrate with OS X UI be...

2009-11-18 Thread codesite-noreply
Revision: 6990 Author: b...@google.com Date: Wed Nov 18 09:09:47 2009 Log: Merge tr...@6987 to make Development Mode UI integrate with OS X UI better. $ svn merge --ignore-ancestry -c6987 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source

[gwt-contrib] [google-web-toolkit] r6991 committed - Operations like i += d where i is an int and d is a double are not pro...

2009-11-18 Thread codesite-noreply
Revision: 6991 Author: sp...@google.com Date: Wed Nov 18 09:31:51 2009 Log: Operations like i += d where i is an int and d is a double are not properly truncated (narrowed) to the LHS type. This patch forces i += d to be written as i = i + d, and applies a narrowing cast as needed, e.g. i = (in

[gwt-contrib] Re: Adds parsers for LayoutPanel and Length attributes.

2009-11-18 Thread rjrjr
Pretty cool. I wonder, though, if this really is a 2.0 gating feature. Do we really want this big a change on the release branch? http://gwt-code-reviews.appspot.com/103806/diff/1010/1012 File user/src/com/google/gwt/uibinder/attributeparsers/LengthAttributeParser.java (right): http://gwt-code-r

[gwt-contrib] Fix for CssNameConverter.convertSet missing reverse collisions

2009-11-18 Thread rjrjr
Reviewers: Jason Parekh, Message: Review requested. Please review this at http://gwt-code-reviews.appspot.com/104808 Affected files: M user/src/com/google/gwt/uibinder/attributeparsers/CssNameConverter.java M user/test/com/google/gwt/uibinder/attributeparsers/CssNameConverterTest.java

[gwt-contrib] Remove startOnFirstThread references from webAppCreator

2009-11-18 Thread amitmanjhi
Reviewers: jat, Description: Remove the no longer necessary startOnFirstThread hacks for mac. Please review this at http://gwt-code-reviews.appspot.com/103808 Affected files: user/src/com/google/gwt/user/tools/App.launchsrc user/src/com/google/gwt/user/tools/WebAppCreator.java user/src/

[gwt-contrib] Re: Remove startOnFirstThread references from webAppCreator

2009-11-18 Thread jat
LGTM, but I haven't tested it http://gwt-code-reviews.appspot.com/103808 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove startOnFirstThread references from webAppCreator

2009-11-18 Thread Amit Manjhi
I tested it on Mac and on Linux. On Wed, Nov 18, 2009 at 11:28 AM, wrote: > LGTM, but I haven't tested it > > > http://gwt-code-reviews.appspot.com/103808 > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: allow prefetching of runAsync code

2009-11-18 Thread spoon
Committed at r6992. http://gwt-code-reviews.appspot.com/102801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r6993 committed - Remove the now unnecessary reference to -XstartOnFirstThread argument....

2009-11-18 Thread codesite-noreply
Revision: 6993 Author: amitman...@google.com Date: Wed Nov 18 11:33:25 2009 Log: Remove the now unnecessary reference to -XstartOnFirstThread argument. Patch by: amitmanjhi Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=6993 Modified: /trunk/user/src/com/google/gwt

[gwt-contrib] [google-web-toolkit] r6994 committed - Merged tr...@6993 into this branch...

2009-11-18 Thread codesite-noreply
Revision: 6994 Author: amitman...@google.com Date: Wed Nov 18 11:37:52 2009 Log: Merged tr...@6993 into this branch Patch by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=6994 Modified: /releases/2.0/branch-info.txt /releases/2.0/user/src/com/google/gwt/user/tools/

[gwt-contrib] Re: Remove startOnFirstThread references from webAppCreator

2009-11-18 Thread Amit Manjhi
thanks! commited as r6993 (trunk) and r6994 (2.0). On Wed, Nov 18, 2009 at 11:31 AM, Amit Manjhi wrote: > I tested it on Mac and on Linux. > > > On Wed, Nov 18, 2009 at 11:28 AM, wrote: > >> LGTM, but I haven't tested it >> >> >> http://gwt-code-reviews.appspot.com/103808 >> > > -- http://gro

[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit

2009-11-18 Thread codesite-noreply
Comment by alexande...@gmail.com: I'm working with SVN builds of GWT prior2.0RC and would recommend you to use Ant for GWT development. Eclipse, its plugins and everything else depends on Eclipse causes just pain in your... Use Ant if you want to build something beyond a "Hello World!" and "

[gwt-contrib] [google-web-toolkit] r6995 committed - The IE plugin installer fails on Windows 7 machines because it tries t...

2009-11-18 Thread codesite-noreply
Revision: 6995 Author: jlaba...@google.com Date: Wed Nov 18 11:39:09 2009 Log: The IE plugin installer fails on Windows 7 machines because it tries to install for all users. Patch by: jlabanca Review by: cramsdale http://code.google.com/p/google-web-toolkit/source/detail?r=6995 Modified: /tru

[gwt-contrib] Make JsonpRequest[Builder] Extensible

2009-11-18 Thread jarrod
First off, I love thata GWT 2.0 includes native support for JSON-P requests! However, I can't quite dump my own JSONP implementation in favor of the new GWT counterpart. Reason: my JSON-P web service requires OAuth signatures. Details: Unfortunately, neither the (HTTP) RequestBuilder nor the Json

[gwt-contrib] Proposals for mechanisms to "strip stack information" from compiled output

2009-11-18 Thread Ray Cromwell
Greetings guys, As part of my work on reducing the output size of compiled permutations, I've created a new polymorphic method inlining patch that changes the way that GWT sets up methods on Javascript objects. (see the patch here: http://gwt-code-reviews.appspot.com/89810/show) The old way, lo

[gwt-contrib] [google-web-toolkit] r6996 committed - Pin modules in DevMode/DevModeBase until they are actually invoked....

2009-11-18 Thread codesite-noreply
Revision: 6996 Author: r...@google.com Date: Wed Nov 18 11:51:07 2009 Log: Pin modules in DevMode/DevModeBase until they are actually invoked. Keep an effective-to-physical name mapping around in ModuleDefLoader if a module needs to be reloaded after a GC. Review by: jat, scottb http://code.goog

Re: [gwt-contrib] Make JsonpRequest[Builder] Extensible

2009-11-18 Thread John Tamplin
On Wed, Nov 18, 2009 at 2:47 PM, jarrod wrote: > However, I can't quite dump my own JSONP implementation in favor of > the new GWT counterpart. Reason: my JSON-P web service requires OAuth > signatures. > Please create an issue with your details to make sure we don't lose it. At this point, I d

[gwt-contrib] Re: Adds parsers for LayoutPanel and Length attributes.

2009-11-18 Thread rjrjr
http://gwt-code-reviews.appspot.com/103806/diff/1010/1012 File user/src/com/google/gwt/uibinder/attributeparsers/LengthAttributeParser.java (right): http://gwt-code-reviews.appspot.com/103806/diff/1010/1012#newcode28 Line 28: public class LengthAttributeParser implements AttributeParser { Oh, of

[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit

2009-11-18 Thread codesite-noreply
Comment by jbrosenberg: what about maven? For more information: http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] fix WindowTest.testGetClientSize when clientHeight is less than 49

2009-11-18 Thread jlabanca
http://gwt-code-reviews.appspot.com/103805/diff/1/3 File src/com/google/gwt/user/client/Window.java (right): http://gwt-code-reviews.appspot.com/103805/diff/1/3#newcode607 Line 607: return $wnd.navigator.userAgent; window.navigator has a lot of other fields. I think we should create a static Win

[gwt-contrib] [google-web-toolkit] r6997 committed - tr...@6938,6995 was merged into this branch...

2009-11-18 Thread codesite-noreply
Revision: 6997 Author: jlaba...@google.com Date: Wed Nov 18 11:57:11 2009 Log: tr...@6938,6995 was merged into this branch Updates IE plugin installer to install for current user only. svn merge --ignore-ancestry -c6938,6995 https://google-web-toolkit.googlecode.com/svn/trunk . Patch by:

[gwt-contrib] [google-web-toolkit] r6998 committed - Revert "Fix XHR memory leak one more time by re-using a static null fu...

2009-11-18 Thread codesite-noreply
Revision: 6998 Author: rj...@google.com Date: Wed Nov 18 12:14:35 2009 Log: Revert "Fix XHR memory leak one more time by re-using a static null function." This reverts commit tr...@6982 http://code.google.com/p/google-web-toolkit/source/detail?r=6998 Modified: /trunk/user/src/com/google/gwt/

[gwt-contrib] Dynatable still refers to hosted mode instead of development mode

2009-11-18 Thread jlabanca
Reviewers: cramsdale, Description: DynaTable has a reference to hosted mode. Fix: Changed the word hosted to development. Testing: === Verified that these directions no longer lie to me. Please review this at http://gwt-code-reviews.appspot.com/103809 Affected files: samples/dyn

[gwt-contrib] [google-web-toolkit] r6999 committed - Revert "Operations like i += d where i is an int and d is a double are...

2009-11-18 Thread codesite-noreply
Revision: 6999 Author: rj...@google.com Date: Wed Nov 18 12:17:07 2009 Log: Revert "Operations like i += d where i is an int and d is a double are not properly" due to failing tests. This reverts tr...@6991 http://code.google.com/p/google-web-toolkit/source/detail?r=6999 Deleted: /trunk/dev

[gwt-contrib] Re: Dynatable still refers to hosted mode instead of development mode

2009-11-18 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/103809 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7000 committed - Merges tr...@6998 into releases/2.0...

2009-11-18 Thread codesite-noreply
Revision: 7000 Author: rj...@google.com Date: Wed Nov 18 12:55:34 2009 Log: Merges tr...@6998 into releases/2.0 Revert "Fix XHR memory leak one more time by re-using a static null function." svn merge --ignore-ancestry -c 6998 https://google-web-toolkit.googlecode.com/svn/trunk . http:/

[gwt-contrib] Renamed portHosted to codeServerPort

2009-11-18 Thread mmendez
Reviewers: rdayal, jat, Please review this at http://gwt-code-reviews.appspot.com/103810 Affected files: M dev/core/src/com/google/gwt/dev/DevModeBase.java M user/src/com/google/gwt/junit/JUnitShell.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tweak log levels; don't log launch URLs if using remote UI

2009-11-18 Thread mmendez
Reviewers: rdayal, jat, Please review this at http://gwt-code-reviews.appspot.com/104810 Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/shell/BrowserListener.java M dev/core/src/com/

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread jat
LGTM, might want to ping Bruce about naming http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode263 Line 263: private static final String CODE_SERVER_PORT_TAG = "-codeServerP

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode272 Line 272: return new String[] {CODE_SERVER_PORT_TAG, "9997"}; Could extract a constant for this, since you use i

[gwt-contrib] Re: Tweak log levels; don't log launch URLs if using remote UI

2009-11-18 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/104810 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Tweak log levels; don't log launch URLs if using remote UI

2009-11-18 Thread jat
Ok except where commented. http://gwt-code-reviews.appspot.com/104810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/104810/diff/1/2#newcode323 Line 323: "Loading modules"); Loading the modules can take significant time, such as with large

[gwt-contrib] [google-web-toolkit] r7001 committed - Renamed the portHosted option to codeServerPort and associated types.

2009-11-18 Thread codesite-noreply
Revision: 7001 Author: mmen...@google.com Date: Wed Nov 18 13:24:48 2009 Log: Renamed the portHosted option to codeServerPort and associated types. http://code.google.com/p/google-web-toolkit/source/detail?r=7001 Modified: /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java /trunk/user/src

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread mmendez
Thanks guys. http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode263 Line 263: private static final String CODE_SERVER_PORT_TAG = "-codeServerPort"; Actually, the name change

[gwt-contrib] rearrange module logging

2009-11-18 Thread jat
Reviewers: rdayal, mmendez, Description: This is not ready to submit, just wanted to get feedback before finishing it up. Please review this at http://gwt-code-reviews.appspot.com/103811 Affected files: dev/core/src/com/google/gwt/dev/DevMode.java dev/core/src/com/google/gwt/dev/DevModeBas

[gwt-contrib] Re: rearrange module logging

2009-11-18 Thread jat
http://gwt-code-reviews.appspot.com/103811/diff/1/12 File dev/core/src/com/google/gwt/dev/ui/CloseModuleCallback.java (right): http://gwt-code-reviews.appspot.com/103811/diff/1/12#newcode19 Line 19: Fixed blank line. http://gwt-code-reviews.appspot.com/103811/diff/1/12#newcode32 Line 32: * {

[gwt-contrib] Re: Tweak log levels; don't log launch URLs if using remote UI

2009-11-18 Thread mmendez
Thanks guys. http://gwt-code-reviews.appspot.com/104810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/104810/diff/1/2#newcode323 Line 323: "Loading modules"); I can understand that, but is logging the best way to deal with this? On 2009/

[gwt-contrib] [google-web-toolkit] r7002 committed - Improve NumberFormat.format to avoid weird rounding issues...

2009-11-18 Thread codesite-noreply
Revision: 7002 Author: r...@google.com Date: Wed Nov 18 13:48:28 2009 Log: Improve NumberFormat.format to avoid weird rounding issues Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7002 Modified: /trunk/user/src/com/google/gwt/i18n/client/NumberFormat.java /trunk

[gwt-contrib] Fix XHR memory leak on IE6 and make HtmlUnit not die

2009-11-18 Thread bobv
Reviewers: Ray Ryan, Message: Review requested Description: HtmlUnit dies if the the same function object is used repeatedly as an onreadystatechange callback. Using a function(){} literal leaks memory on IE. It looks like calling the Function constructor satisfies both constraints, although it

[gwt-contrib] [google-web-toolkit] r7003 committed - Tweak log levels and don't launchURLs if we are using the RemoteUI.

2009-11-18 Thread codesite-noreply
Revision: 7003 Author: mmen...@google.com Date: Wed Nov 18 13:50:42 2009 Log: Tweak log levels and don't launchURLs if we are using the RemoteUI. http://code.google.com/p/google-web-toolkit/source/detail?r=7003 Modified: /trunk/dev/core/src/com/google/gwt/dev/DevMode.java /trunk/dev/core/src/c

[gwt-contrib] Re: Fix XHR memory leak on IE6 and make HtmlUnit not die

2009-11-18 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/104811/diff/1/2 File user/src/com/google/gwt/xhr/client/XMLHttpRequest.java (right): http://gwt-code-reviews.appspot.com/104811/diff/1/2#newcode118 Line 118: self.onreadystatechange = new Function(); Out of curiosity, why can't you set onreadystatechange

[gwt-contrib] [google-web-toolkit] r7004 committed - tr...@7001 was merged into this branch...

2009-11-18 Thread codesite-noreply
Revision: 7004 Author: mmen...@google.com Date: Wed Nov 18 14:04:15 2009 Log: tr...@7001 was merged into this branch Revert "Renamed the portHosted option to codeServerPort and associated types." svn merge --ignore-ancestry -c 7001 https://google-web-toolkit.googlecode.com/svn/trunk . h

[gwt-contrib] Code Review Request: Drop Request/Response Logging Levels down to TRACE

2009-11-18 Thread rdayal
Reviewers: jat, mmendez, Description: Drop Request/Response Logging Levels down to TRACE. Please review this at http://gwt-code-reviews.appspot.com/103812 Affected files: M dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java Index: dev/core/src/com/google/gwt/dev/shell/jetty/Jett

[gwt-contrib] [google-web-toolkit] r7005 committed - tr...@7003 was merged into this branch...

2009-11-18 Thread codesite-noreply
Revision: 7005 Author: mmen...@google.com Date: Wed Nov 18 14:09:08 2009 Log: tr...@7003 was merged into this branch Revert "Tweak log levels and don't launchURLs if we are using the RemoteUI." svn merge --ignore-ancestry -c 7003 https://google-web-toolkit.googlecode.com/svn/trunk . htt

[gwt-contrib] Re: Fix XHR memory leak on IE6 and make HtmlUnit not die

2009-11-18 Thread bobv
Thanks. > Out of curiosity, why can't you set onreadystatechange to null, or delete it? Discussion: http://code.google.com/p/google-web-toolkit/issues/detail?id=1610 Original code: http://code.google.com/p/google-web-toolkit/source/detail?r=1260 A comment indicates that setting it to nul

[gwt-contrib] [google-web-toolkit] r7006 committed - Fix the XHR memory leak in a way that doesn't cause HtmlUnit to crash....

2009-11-18 Thread codesite-noreply
Revision: 7006 Author: b...@google.com Date: Wed Nov 18 14:14:10 2009 Log: Fix the XHR memory leak in a way that doesn't cause HtmlUnit to crash. Patch by: bobv Review by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=7006 Modified: /trunk/user/src/com/google/gwt/xhr/client/

[gwt-contrib] Fixes checkstyle issues introduced by r7001.

2009-11-18 Thread mmendez
Reviewers: rdayal, jat, Please review this at http://gwt-code-reviews.appspot.com/103813 Affected files: M dev/core/src/com/google/gwt/dev/DevModeBase.java Index: dev/core/src/com/google/gwt/dev/DevModeBase.java diff --git a/dev/core/src/com/google/gwt/dev/DevModeBase.java b/dev/core/src

[gwt-contrib] Re: fix WindowTest.testGetClientSize when clientHeight is less than 49

2009-11-18 Thread jlabanca
LGTM - Nice additions Assuming that you ran the test case this against FF, IE, Safari, and Chrome. http://gwt-code-reviews.appspot.com/103805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7007 committed - Adding Window.Navigator api....

2009-11-18 Thread codesite-noreply
Revision: 7007 Author: jlaba...@google.com Date: Wed Nov 18 14:56:30 2009 Log: Adding Window.Navigator api. Patch by: kjin Review by: jlabanca http://code.google.com/p/google-web-toolkit/source/detail?r=7007 Modified: /trunk/eclipse/samples/Hello/.classpath /trunk/eclipse/samples/Hello/.pro

[gwt-contrib] [google-web-toolkit] r7008 committed - Replacing "hosted mode" with "development mode" in DynaTable....

2009-11-18 Thread codesite-noreply
Revision: 7008 Author: jlaba...@google.com Date: Wed Nov 18 14:57:40 2009 Log: Replacing "hosted mode" with "development mode" in DynaTable. Patch by: jlabanca Review by: cramsdale http://code.google.com/p/google-web-toolkit/source/detail?r=7008 Modified: /trunk/samples/dynatable/src/com/go

[gwt-contrib] [google-web-toolkit] r7009 committed - Properly sorts the get/setCodeServerPort methods...

2009-11-18 Thread codesite-noreply
Revision: 7009 Author: br...@google.com Date: Wed Nov 18 15:02:16 2009 Log: Properly sorts the get/setCodeServerPort methods Change by: bruce Review by: rjrjr (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=7009 Modified: /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.ja

[gwt-contrib] Re: Code Review Request: Drop Request/Response Logging Levels down to TRACE

2009-11-18 Thread jat
http://gwt-code-reviews.appspot.com/103812/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java (right): http://gwt-code-reviews.appspot.com/103812/diff/1/2#newcode89 Line 89: logStatus = TreeLogger.TRACE; I still object to requiring anyone who wants to see the HTTP logs h

[gwt-contrib] [google-web-toolkit] r7010 committed - Accidentally committed too many files in r7007. Reverting the files t...

2009-11-18 Thread codesite-noreply
Revision: 7010 Author: jlaba...@google.com Date: Wed Nov 18 15:07:08 2009 Log: Accidentally committed too many files in r7007. Reverting the files that weren't supposed to be committed. Patch by: jlabanca http://code.google.com/p/google-web-toolkit/source/detail?r=7010 Modified: /trunk/ecl

Re: [gwt-contrib] [google-web-toolkit] r7007 committed - Adding Window.Navigator api....

2009-11-18 Thread John LaBanca
I accidentally committed some changes to my eclipse files. r7010 reverts the files that I didn't mean to commit. Thanks, John LaBanca jlaba...@google.com On Wed, Nov 18, 2009 at 5:57 PM, wrote: > Revision: 7007 > Author: jlaba...@google.com > Date: Wed Nov 18 14:56:30 2009 > Log: Adding Windo

[gwt-contrib] [google-web-toolkit] r7011 committed - tr...@7009 was merged into this branch: Sorts set/getCodeServerPort pr...

2009-11-18 Thread codesite-noreply
Revision: 7011 Author: br...@google.com Date: Wed Nov 18 15:09:17 2009 Log: tr...@7009 was merged into this branch: Sorts set/getCodeServerPort properly http://code.google.com/p/google-web-toolkit/source/detail?r=7011 Modified: /releases/2.0/branch-info.txt /releases/2.0/dev/core/src/com/g

[gwt-contrib] [google-web-toolkit] r7012 committed - tr...@7007,7008,7010 was merged into this branch...

2009-11-18 Thread codesite-noreply
Revision: 7012 Author: jlaba...@google.com Date: Wed Nov 18 15:11:38 2009 Log: tr...@7007,7008,7010 was merged into this branch Adds Window.Navigator API Removes hosted mode reference in DynaTable svn merge --ignore-ancestry -c7007,7008,7010 https://google-web-toolkit.googlecode.com/svn/

[gwt-contrib] [google-web-toolkit] r7013 committed - Fixes problem in CssNameConverter where .fooBar followed by .foo-bar...

2009-11-18 Thread codesite-noreply
Revision: 7013 Author: rj...@google.com Date: Wed Nov 18 15:20:56 2009 Log: Fixes problem in CssNameConverter where .fooBar followed by .foo-bar wouldn't fail, leading to bad code gen. Review by: jasonparekh http://code.google.com/p/google-web-toolkit/source/detail?r=7013 Modified: /trunk/use

[gwt-contrib] Re: Code Review Request: Drop Request/Response Logging Levels down to TRACE

2009-11-18 Thread Rajeev Dayal
Based on some recent discussions, we're going to make a change where we modify the log levels depending on what UI the user is using. I'll send out a CL for this shortly. On Wed, Nov 18, 2009 at 6:07 PM, wrote: > > http://gwt-code-reviews.appspot.com/103812/diff/1/2 > File dev/core/src/com/googl

[gwt-contrib] [google-web-toolkit] r7014 committed - One-line fix to building with Precompile/CompilePerms/Link....

2009-11-18 Thread codesite-noreply
Revision: 7014 Author: sp...@google.com Date: Wed Nov 18 15:35:54 2009 Log: One-line fix to building with Precompile/CompilePerms/Link. The code should be serializing an AST, not serializing an output stream onto itself. Review by scottb (TBR), jat http://code.google.com/p/google-web-toolkit/sour

[gwt-contrib] [google-web-toolkit] r7015 committed - Add missing import to DevModeBase...

2009-11-18 Thread codesite-noreply
Revision: 7015 Author: rj...@google.com Date: Wed Nov 18 15:59:44 2009 Log: Add missing import to DevModeBase tbr bruce http://code.google.com/p/google-web-toolkit/source/detail?r=7015 Modified: /releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java ==

[gwt-contrib] Re: Code Review Request: Drop Request/Response Logging Levels down to TRACE when using the Remote UI

2009-11-18 Thread rdayal
Updated this issue based on our face-to-face descriptions. Please re-read the description and check out patch set #2. http://gwt-code-reviews.appspot.com/103812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7016 committed - Merges tr...@7013 into releases/2.0...

2009-11-18 Thread codesite-noreply
Revision: 7016 Author: rj...@google.com Date: Wed Nov 18 16:31:56 2009 Log: Merges tr...@7013 into releases/2.0 Fixes problem in CssNameConverter svn merge --ignore-ancestry -c 7013 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/de

[gwt-contrib] Re: Code Review Request: Drop Request/Response Logging Levels down to TRACE when using the Remote UI

2009-11-18 Thread jat
Mostly LGTM http://gwt-code-reviews.appspot.com/103812/diff/5/1003 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/103812/diff/5/1003#newcode234 Line 234: public static boolean isUsingRemoteUI() { Why isn't this in DevModeBase, since that is where t

[gwt-contrib] [google-web-toolkit] r7018 committed - Merge tr...@7006 for XHR fix that doesn't break HtmlUnit....

2009-11-18 Thread codesite-noreply
Revision: 7018 Author: b...@google.com Date: Wed Nov 18 17:12:01 2009 Log: Merge tr...@7006 for XHR fix that doesn't break HtmlUnit. $ svn merge --ignore-ancestry -c 7006 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/detail?r=7018 Modi

[gwt-contrib] [google-web-toolkit] r7019 committed - Rolled junitCreator into webAppCreator....

2009-11-18 Thread codesite-noreply
Revision: 7019 Author: amitman...@google.com Date: Wed Nov 18 17:52:02 2009 Log: Rolled junitCreator into webAppCreator. Patch by: amitmanjhi Review by: rjrjr (desk review) http://code.google.com/p/google-web-toolkit/source/detail?r=7019 Added: /trunk/user/src/com/google/gwt/user/tools/JUnit-

[gwt-contrib] Make emitted Compile Report artifacts private

2009-11-18 Thread kprobst
Reviewers: Lex, Description: Hi Lex, could you review this patch for me? It makes all Compile Reports artifacts private as follows: 1. If the user specifies the "-extra dir" option, the files will be written to the "dir" directory, under soycReport. 2. If the user does *not* specify the "-extra

[gwt-contrib] [google-web-toolkit] r7020 committed - Adding the .classpath template that was accidentally deleted (instead ...

2009-11-18 Thread codesite-noreply
Revision: 7020 Author: amitman...@google.com Date: Wed Nov 18 17:59:53 2009 Log: Adding the .classpath template that was accidentally deleted (instead of modified) by the previous commit. Patch by: amitmanjhi Review by: rjrjr (desk review) http://code.google.com/p/google-web-toolkit/source/det

[gwt-contrib] [google-web-toolkit] r7021 committed - Merged tr...@7019, tr...@7020 into this branch....

2009-11-18 Thread codesite-noreply
Revision: 7021 Author: amitman...@google.com Date: Wed Nov 18 18:11:58 2009 Log: Merged tr...@7019, tr...@7020 into this branch. Roll junitCreator into webAppCreator. Patch by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=7021 Added: /releases/2.0/user/src/com/googl

[gwt-contrib] Use 1-based counting for permutations in Compile Report

2009-11-18 Thread kprobst
Reviewers: Lex, Description: Hi Lex, could you review this patch for me? As it turns out that we were using 0-based counting for permutations, but 1-based counting for split points. This patch fixes that inconsistency. Thanks, kathrin Please review this at http://gwt-code-reviews.appspot.com/

Re: [gwt-contrib] Use 1-based counting for permutations in Compile Report

2009-11-18 Thread Scott Blum
The CS geek in me wants to know why not make split points count from 0. :P On Wed, Nov 18, 2009 at 9:33 PM, wrote: > Reviewers: Lex, > > Description: > Hi Lex, > > could you review this patch for me? > > As it turns out that we were using 0-based counting for permutations, > but 1-based counting

Re: [gwt-contrib] Use 1-based counting for permutations in Compile Report

2009-11-18 Thread Scott Blum
(Joking, if that wasn't clear, since the compiler logs report perms 1-based also.) On Wed, Nov 18, 2009 at 10:35 PM, Scott Blum wrote: > The CS geek in me wants to know why not make split points count from 0. :P > > > On Wed, Nov 18, 2009 at 9:33 PM, wrote: > >> Reviewers: Lex, >> >> Descriptio