Thanks for the review.
My only question is anything required for STOB to handle declared
RuntimeExceptions, or is this only for deRPC?
ProxyCreator.addRemoteServiceRootTypes() iterates over the declared
exception types for any given RPC method. It imposes a constraint
that they're derived
All,
I've noticed that the Swing UI for dev mode is missing horizontal
scroll bars. That is, if you have an item in the log tree or details
in the panel below that exceed the width of the window, there's no way
to scroll over and read the text. I've tested this in MS2. Can anyone
verify if this
Revision: 7053
Author: j...@google.com
Date: Fri Nov 20 06:21:44 2009
Log: Fixes issue where unit measurement divs could create document-level
scrollbars on a small window.
Review: jlabanca (desk check)
http://code.google.com/p/google-web-toolkit/source/detail?r=7053
Modified:
Revision: 7054
Author: jlaba...@google.com
Date: Fri Nov 20 06:32:19 2009
Log: Window.Navigator#isCookieEnabled now sets and retrieves a cookie
instead of relying on navigator.cookieEnabled, which is sometimes
inaccurate and can result in a security dialog.
Patch by: jlabanca
Review by: jgw
Revision: 7056
Author: j...@google.com
Date: Fri Nov 20 06:39:25 2009
Log: Merging trunk c5073 into this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=7056
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/layout/client/LayoutImpl.java
Consistency is good, but this patch breaks a different consistency!
Specifically, the symbolMaps files count permutations from 0. So
permutation 3 in the compile report would be permutation 2 in the
symbolMaps files. I think that consistency is more important than
that the permutation counting
Reviewers: scottb, jat,
Description:
Also fixing a similar potential issue in Dictionary.
Please review this at http://gwt-code-reviews.appspot.com/107801
Affected files:
user/src/com/google/gwt/i18n/client/Dictionary.java
user/src/com/google/gwt/json/client/JSONObject.java
Index:
Isaac,
I'll see if I can reproduce this using RC1 and get back to you shortly.
- Chris
On Fri, Nov 20, 2009 at 9:14 AM, Isaac Truett itru...@gmail.com wrote:
All,
I've noticed that the Swing UI for dev mode is missing horizontal
scroll bars. That is, if you have an item in the log tree or
On Fri, Nov 20, 2009 at 10:15 AM, Chris Ramsdale cramsd...@google.comwrote:
I'll see if I can reproduce this using RC1 and get back to you shortly.
There have been no changes in RC1 for that.
On Fri, Nov 20, 2009 at 9:14 AM, Isaac Truett itru...@gmail.com wrote:
I've noticed that the Swing
Revision: 7057
Author: jlaba...@google.com
Date: Fri Nov 20 07:22:26 2009
Log: Revert r7040 because it breaks the build. Browsers are not running
tests in dev mode.
Patch by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=7057
Modified:
Revision: 7058
Author: rice+leg...@google.com
Date: Fri Nov 20 07:37:58 2009
Log: Reinstate the help string and comment changes from r7040.
Leave the gwt.hosted url alone for now.
TBR: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=7058
Modified:
Hi Lex,
you make a good point. There are a couple of counter-arguments, however:
the logging output already uses 1-based counting, and for end users 1-based
counting is probably more intuitive.
Are permutation IDs used in any other artifacts produced by the compiler
(other than symbol maps)
Strawman proposal: how about we internally continue to count permutations
from 0; but any time we produce a user facing message, we add 1 to make it
1-based instead?
The only real reason for suggesting this is-- I think it already works that
way in 90% of the cases. So maybe we just have to
LVGTM
http://gwt-code-reviews.appspot.com/107801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Gracias.
http://gwt-code-reviews.appspot.com/106805
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7059
Author: rice+leg...@google.com
Date: Fri Nov 20 08:51:25 2009
Log: Fix javadoc typo (external issue 4252).
TBR: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=7059
Modified:
/trunk/user/src/com/google/gwt/dom/client/Element.java
On Fri, Nov 20, 2009 at 11:45 AM, Scott Blum sco...@google.com wrote:
Strawman proposal: how about we internally continue to count permutations
from 0; but any time we produce a user facing message, we add 1 to make it
1-based instead?
This already happens when it comes to compiler logging
Revision: 7060
Author: rice+leg...@google.com
Date: Fri Nov 20 08:57:58 2009
Log: Simplify FF workaround for 'hasOwnProperty' String keys
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7060
Modified:
/trunk/user/src/com/google/gwt/i18n/client/Dictionary.java
Revision: 7061
Author: kpro...@google.com
Date: Fri Nov 20 09:04:47 2009
Log: Compile report artifacts are now printed to the extras directory
rather than the public war directory.
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7061
Modified:
After Kathrin and I talked this over, it's become clear that we simply don't
have time to do 1-based counting, correctly, everywhere. Importantly, there
is symbolMaps code in google3 that absolutely depends on 0-based counting.
Looking at the whole situation, I think the wisest course of action
Revision: 7062
Author: sco...@google.com
Date: Fri Nov 20 09:15:40 2009
Log: Unify DevMode's startupModules and alreadySeen modules to simplify
code.
Review by: rice
http://code.google.com/p/google-web-toolkit/source/detail?r=7062
Modified:
/trunk/dev/core/src/com/google/gwt/dev/DevMode.java
Revision: 7063
Author: rice+leg...@google.com
Date: Fri Nov 20 09:21:21 2009
Log: Simplify FF workaround for 'hasOwnProperty' String keys
(missed a file the first time)
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7063
Modified:
Revision: 7064
Author: kpro...@google.com
Date: Fri Nov 20 09:21:32 2009
Log: Merging trunk r7061 into this branch.
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7064
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/Compiler.java
Revision: 7065
Author: b...@google.com
Date: Fri Nov 20 09:36:38 2009
Log: Allow declared RuntimeExceptions to be propagated correctly.
Patch by: bobv
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7065
Modified:
/trunk/user/src/com/google/gwt/rpc/server/RPC.java
Revision: 7066
Author: jlaba...@google.com
Date: Fri Nov 20 09:49:22 2009
Log: Updating the IE plugin installer to not require admin privileges.
Patch by: jlabanca
Review by: cramsdale
http://code.google.com/p/google-web-toolkit/source/detail?r=7066
Modified:
Revision: 7067
Author: jlaba...@google.com
Date: Fri Nov 20 09:51:31 2009
Log: tr...@7066 was merged into this branch
Update IE installer to run without admin privileges
svn merge --ignore-ancestry -c7066
https://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
ping
http://gwt-code-reviews.appspot.com/105808
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi Matt,
I need more information, because on the face of it, I don't see how we can
be pulling in all types in all cases. We have specific type oracle tests
that check how many types total end up in type oracle. If it was a
fundamental problem, these tests should be blowing up. Example:
Revision: 7068
Author: fabb...@google.com
Date: Fri Nov 20 10:15:16 2009
Log: Merge of 7061, more soyc privatization
http://code.google.com/p/google-web-toolkit/source/detail?r=7068
Modified:
/branches/snapshot-2009.10.23-r6446/branch-info.txt
Revision: 7069
Author: b...@google.com
Date: Fri Nov 20 10:37:09 2009
Log: Merge tr...@7049,7065 to better handle RuntimeExceptions throw by
deRPC service methods.
$ svn merge --ignore-ancestry -c7049,7065
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 7070
Author: kpro...@google.com
Date: Fri Nov 20 10:46:56 2009
Log: Rolling back 7064 temporarily - Error in merge from trunk.
http://code.google.com/p/google-web-toolkit/source/detail?r=7070
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/Compiler.java
LGTM
http://gwt-code-reviews.appspot.com/107801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Nov 20, 2009 at 9:01 AM, BobV b...@google.com wrote:
Thanks for the review.
My only question is anything required for STOB to handle declared
RuntimeExceptions, or is this only for deRPC?
ProxyCreator.addRemoteServiceRootTypes() iterates over the declared
exception types for any
On Fri, Nov 20, 2009 at 1:59 PM, Lex Spoon sp...@google.com wrote:
That looks like an accident. It looks like the intent was never to
serialize an unchecked exception.
When John and I talked about this issue previously, we couldn't come
up with an example where you'd really need to
Including declared RTE's has been there since 1.5. Since the user has
explicitly asked for those throwable types, I'm thinking that it's no
worse than any other exception type. What we should do as a
sanity-check is to explicitly disallow
void serviceMethod() throws Exception;
void
On Fri, Nov 20, 2009 at 2:08 PM, BobV b...@google.com wrote:
Including declared RTE's has been there since 1.5. Since the user has
explicitly asked for those throwable types, I'm thinking that it's no
worse than any other exception type.
Okay, I suppose we are stuck with it, then. I don't
I can't repro this on a smaller scale. I created small project with
two modules and TypeOracle was populated correctly (GWT 2.0-RC1 and
trunk), even when compiling both modules together or running DevMode
with both modules specified.
I'll keep trying to reproduce this, sorry for the false
Revision: 7071
Author: rice+leg...@google.com
Date: Fri Nov 20 11:47:11 2009
Log: Merge a bunch of changes to the release branch.
tr...@6929 was merged into this branch
Fix formatting of milliseconds in pre-1970 (i.e., negative) dates
svn merge --ignore-ancestry -c6929
Reviewers: jat,
Description:
HostedModeTemplate.js requires a patch to recognize gwt.codesvr as a
synonym for gwt.hosted.
Please review this at http://gwt-code-reviews.appspot.com/108801
Affected files:
dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js
LGTM
http://gwt-code-reviews.appspot.com/108801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7072
Author: rice+leg...@google.com
Date: Fri Nov 20 12:04:08 2009
Log: Use gwt.codesvr instead of gwt.hosted in JUnitShell
Ensure the two are truly synonymous
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=7072
Modified:
LGTM
http://gwt-code-reviews.appspot.com/108801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7073
Author: rice+leg...@google.com
Date: Fri Nov 20 12:14:17 2009
Log: Merge tr...@7072 into this branch
Use gwt.codesvr instead of gwt.hosted in JUnitShell
svn merge --ignore-ancestry -c7072
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 7074
Author: sp...@google.com
Date: Fri Nov 20 12:23:47 2009
Log: Merging tr...@7014 into releases/2.0 . Merge command used:
svn merge -c 7014 --ignore-ancestry
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7074
Revision: 7075
Author: fabb...@google.com
Date: Fri Nov 20 12:51:04 2009
Log: Created new snapshot branch via:
svn cp -r7061 https://google-web-toolkit.googlecode.com/svn/trunk \
https://google-web-toolkit.googlecode.com/svn/branches/snapshot-2009.11.20-r7061
Revision: 7076
Author: kpro...@google.com
Date: Fri Nov 20 13:00:58 2009
Log: Merging trunk r7061 into this branch.
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7076
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/Compiler.java
Revision: 7077
Author: j...@google.com
Date: Fri Nov 20 13:07:53 2009
Log: Fix for nested TabLayoutPanel visibility bug.
Review: jlabanca (desk check)
http://code.google.com/p/google-web-toolkit/source/detail?r=7077
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
Reviewers: kplatfoot, mmendez,
Message:
Tweaks to get restart server up and running. We now always indicate that
we support the RESTART_SERVER capability (checking it was problematic,
because it had not been registered at the time of capability exchange).
Fixed an issue in MessageTransport where
Revision: 7078
Author: rjrjr+perso...@google.com
Date: Fri Nov 20 13:09:39 2009
Log: Fixes camel case field refs sometimes not matching dashed counterparts.
E.g., this should work:
ui:style type='com.google.gwt.sample.mail.client.Contacts.Style'
.contacts-break {
padding: 0.5em;
}
tr...@r7078, still need to merge to releases/2.0
http://gwt-code-reviews.appspot.com/105808
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7079
Author: j...@google.com
Date: Fri Nov 20 13:11:54 2009
Log: Merging trunk c7077 into this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=7079
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
LGTM
http://gwt-code-reviews.appspot.com/109801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7080
Author: b...@google.com
Date: Fri Nov 20 13:17:07 2009
Log: Fix @example formatting.
Patch by: bobv
Review by: jlabanca (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=7080
Modified:
/trunk/user/src/com/google/gwt/user/server/rpc/RPC.java
Revision: 7081
Author: b...@google.com
Date: Fri Nov 20 13:22:49 2009
Log: Merge tr...@7080 to fix ant doc target.
$ svn merge --ignore-ancestry -c7077
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7081
Modified:
Reviewers: Lex,
Description:
Hi Lex,
could you review this patch for me? The dashboard now enumerates all
permutation descriptions, even when two permutations collapse into one.
Thanks,
kathrin
Please review this at http://gwt-code-reviews.appspot.com/110801
Affected files:
releases/2...@7082
http://gwt-code-reviews.appspot.com/106801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7082
Author: rj...@google.com
Date: Fri Nov 20 14:07:49 2009
Log: Merges tr...@7032 into releases/2.0
Makes UiFactory work with parameterized return types
svn merge --ignore-ancestry -c 7032
https://google-web-toolkit.googlecode.com/svn/trunk .
ping
On Thu, Nov 19, 2009 at 12:04 PM, Amit Manjhi amitman...@google.com wrote:
[Somehow, I got an error from the mail delivery system the first time.
Apologies if you have already received it]
Description:
Remove distro-source/windows, distro-source/linux and distro-source/mac
dirs and
mozilla-hosted-browser.conf is definitely not needed any more. I don't
believe libswt is needed for Mac either, but then I am not sure why it
was ever here in the first place rather than in jni/mac.
http://gwt-code-reviews.appspot.com/105803
--
Kelly and Scott are the only ones that have touched this file. Please
comment if it is still necessary.
On Fri, Nov 20, 2009 at 2:41 PM, j...@google.com wrote:
mozilla-hosted-browser.conf is definitely not needed any more. I don't
believe libswt is needed for Mac either, but then I am not
Revision: 7084
Author: b...@google.com
Date: Fri Nov 20 14:48:25 2009
Log: Merge tr...@7083 to update the location of the missing plugin app.
$ svn merge --ignore-ancestry -c 7083
https://google-web-toolkit.googlecode.com/svn/trunk .
Strange, I'd have thought we'd have pulled that file from /tools. Anyway,
please kill it.
On Fri, Nov 20, 2009 at 5:48 PM, Amit Manjhi amitman...@google.com wrote:
Kelly and Scott are the only ones that have touched this file. Please
comment if it is still necessary.
On Fri, Nov 20, 2009
Revision: 7085
Author: amitman...@google.com
Date: Fri Nov 20 14:56:52 2009
Log: Removed the obsolete platform dirs.
Patch by: amitmanjhi
Review by: jat, scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7085
Deleted:
/trunk/distro-source/linux
/trunk/distro-source/mac
Thanks! commited at r7085 (trunk) and r7086 (2.0)
On Fri, Nov 20, 2009 at 2:52 PM, Scott Blum sco...@google.com wrote:
Strange, I'd have thought we'd have pulled that file from /tools. Anyway,
please kill it.
On Fri, Nov 20, 2009 at 5:48 PM, Amit Manjhi amitman...@google.comwrote:
Kelly
Revision: 7086
Author: amitman...@google.com
Date: Fri Nov 20 15:02:24 2009
Log: tr...@7085 was merged into this branch -- remove the obsolete platform
dirs and
their contents.
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=7086
Deleted:
Revision: 7087
Author: rj...@google.com
Date: Fri Nov 20 15:09:17 2009
Log: Merges tr...@7078 into releases/2.0
Fix consistency problem between camel case and normal field refs
svn merge --ignore-ancestry -c 7078
https://google-web-toolkit.googlecode.com/svn/trunk .
Index: distro-source/mac/src/libswt-webkit-carbon-3235.jnilib
That was a prebuilt version of the modified swt library we built. It can
definitely go.
/kel
On Fri, Nov 20, 2009 at 5:52 PM, Scott Blum sco...@google.com wrote:
Strange, I'd have thought we'd have pulled that file from /tools.
releases/2...@7087
http://gwt-code-reviews.appspot.com/105808
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7088
Author: amitman...@google.com
Date: Fri Nov 20 15:31:48 2009
Log: Updated the README.txt file to make the instructions independent of
the eclemma
version they download.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Revision: 7089
Author: rda...@google.com
Date: Fri Nov 20 15:40:44 2009
Log: Tweaks to get restart server up and running. We now always indicate
that we
support the RESTART_SERVER capability (checking it was problematic, because
it
had not been registered at the time of capability exchange).
Revision: 7090
Author: rda...@google.com
Date: Fri Nov 20 15:46:40 2009
Log: Merging tr...@r7089 into releases/2.0. The merge was performed with
the following command:
svn merge --ignore-ancestry -c 7089
http://google-web-toolkit.googlecode.com/svn/trunk .
Thanks for the review. Committed as tr...@r7089 and cherry-picked into
releases/2.0 at r7090.
http://gwt-code-reviews.appspot.com/109801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7091
Author: rda...@google.com
Date: Fri Nov 20 15:48:57 2009
Log: Updated branch-info.txt to reflect merge of tr...@r7089 into
releases/2.0 at r7090.
http://code.google.com/p/google-web-toolkit/source/detail?r=7091
Modified:
/releases/2.0/branch-info.txt
Revision: 7092
Author: jlaba...@google.com
Date: Fri Nov 20 16:10:50 2009
Log: Ensures that onload events are fired for images even if the browser
fires the onload event synchronously while the image is not attached.
Patch by: jlabanca
Review by: jgw (Partial TBR)
Revision: 7093
Author: jlaba...@google.com
Date: Fri Nov 20 16:14:24 2009
Log: tr...@7092 was merged into this branch
Fired onload events for images that are cached.
svn merge --ignore-ancestry -c 7092
https://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
Reviewers: jat,
Description:
This function is to be called from the GWT dev plugin.
Also removes legacy support from hosted.html.
Please review this at http://gwt-code-reviews.appspot.com/109802
Affected files:
dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
--
This is much easier to view as two separate patches, or without whitespace
diffs. Sorry!
On Fri, Nov 20, 2009 at 8:38 PM, sco...@google.com wrote:
Reviewers: jat,
Description:
This function is to be called from the GWT dev plugin.
Also removes legacy support from hosted.html.
Please
LGTM
http://gwt-code-reviews.appspot.com/109802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7094
Author: j...@google.com
Date: Fri Nov 20 18:59:36 2009
Log: Fix handling of onModuleLoad errors, handle HelpInfo with null URLs,
reduce log levels of method invocations, minor cleanups.
Patch by: jat
Review by: rdayal
Revision: 7095
Author: j...@google.com
Date: Fri Nov 20 19:14:08 2009
Log: Merge trunk r7094 into this branch
Handle onModuleLoad errors, misc devmode bug fixes and cleanups
svn merge --ignore-ancestry -c7094 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Reviewers: ,
Description:
When gwt application loads, it looks for the user language in
url-params, meta-tags, and $wnd.__gwt_Locale.
However, it is possible to know the browser's locale in client side.
Although it is not the locale configured by the user in the browser's
preferences window
Revision: 7096
Author: sco...@google.com
Date: Fri Nov 20 23:49:42 2009
Log: Remove legacy support from hosted.html.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7096
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Revision: 7097
Author: sco...@google.com
Date: Fri Nov 20 23:49:53 2009
Log: Adds a __gwt_disconnected function to hosted.html, which glasses the
screen and puts up a disconnect message.
This function is to be called from the GWT dev plugin.
Review by: jat
83 matches
Mail list logo
