Comment by neo.huma...@gmail.com:
Oh ya, I also have a 1.2 release candidate of the google plugin installed.
It's mentioned somewhere above, and I deinstalled the old one before
dropping the new one in... But it didn't fully uninstall so I'm not really
sure. If you still have issues after
Comment by a.revolution.ultra.blue:
YES! You CANNOT use the google g-icon "web app run menu", you need a plain
jane java application runner, with main class com.google.gwt.dev.DevMode?
Make sure you have the usual program arguments for a gwt project; mine are:
-port -startupUrl / ai.yx.x
Comment by neo.huma...@gmail.com:
YES! You CANNOT use the google g-icon "web app run menu", you need a plain
jane java application runner, with main class com.google.gwt.dev.DevMode
Make sure you have the usual program arguments for a gwt project; mine are:
-port
-startupUrl /
ai.yx.xSeed
Revision: 7152
Author: rda...@google.com
Date: Mon Nov 23 21:26:14 2009
Log: Updated branch-info.txt to reflect merge of tr...@r7150 into
releases/2.0 at r7151.
http://code.google.com/p/google-web-toolkit/source/detail?r=7152
Modified:
/releases/2.0/branch-info.txt
==
Thanks for the review.
Committed as tr...@r7150 and cherry-picked into releases/2.0 at r7151.
http://gwt-code-reviews.appspot.com/111807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the clarification.
2009/11/24 Rajeev Dayal
> Ok, I did confirm it - check out the documentation on
> DevModeUI.setStartupURLs - that defines the values in the map.
>
> 2009/11/24 Miguel Méndez
>
>
>>
>> On Tue, Nov 24, 2009 at 12:17 AM, wrote:
>>
>>> Thanks for the review!
>>>
>>>
>
Revision: 7151
Author: rda...@google.com
Date: Mon Nov 23 21:23:36 2009
Log: Merging tr...@r7150 into releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=7151
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/DevMode.java
/releases/2.0/dev/core/src/com/google/gwt/d
Ok, I did confirm it - check out the documentation on
DevModeUI.setStartupURLs - that defines the values in the map.
2009/11/24 Miguel Méndez
>
>
> On Tue, Nov 24, 2009 at 12:17 AM, wrote:
>
>> Thanks for the review!
>>
>>
>>
>> http://gwt-code-reviews.appspot.com/111807/diff/1/5
>> File dev/co
Revision: 7150
Author: rda...@google.com
Date: Mon Nov 23 21:20:12 2009
Log: Got rid of port-guessing logic. We now use setStartupURLs as our init
hook. We no longer send over the dev mode query params. We send over the
startup URLs.
Review by: mmendez
http://code.google.com/p/google-web-toolk
On Tue, Nov 24, 2009 at 12:17 AM, wrote:
> Thanks for the review!
>
>
>
> http://gwt-code-reviews.appspot.com/111807/diff/1/5
> File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
> (right):
>
> http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
> Line 169: public void s
Thanks for the review!
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(Map urls) {
On 2009/11/24 05:14:07, mmendez wr
LGTM
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(Map urls) {
Nit: why was this a Map again?
http://gwt-code-revi
Reviewers: jat, mmendez,
Description:
Send startup URLs over the wire to GPE. The initialization code has now
been moved from RemoteUI.initialize to RemoteUI.setStartupURLs.
Please review this at http://gwt-code-reviews.appspot.com/111807
Affected files:
M dev/core/src/com/google/gwt/dev/DevM
Revision: 7149
Author: j...@google.com
Date: Mon Nov 23 19:54:09 2009
Log: Merge trunk r7148 into this branch
DevMode UI improvements
svn merge --ignore-ancestry -c7148 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?
Reviewers: jat, jlabanca, amitmanjhi,
Description:
Hi John,
Please review, commit, merge if you can. This fixes a problem where
clients are seen to have unstable IP addresses when coming through a
proxy. Also fixes a problem where two browsers with the same user agent
string look like the same
Revision: 7148
Author: j...@google.com
Date: Mon Nov 23 18:34:09 2009
Log: Improve the DevMode UI, both for GPE and Swing:
- startup URLs are specified separately from launching them, allowing them
to be displayed earlier
- if no startup URLs are supplied, they are inferred from the content
Updated based on feedback, and added HasHorizontalAlignment and
HasVerticalAlignment
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7147
Author: sco...@google.com
Date: Mon Nov 23 16:38:01 2009
Log: Updating Chrome, IE, and Firefox plugin installers with
glasspanel-on-disconnect feature.
- gwtdmp.crx is updated also, but we should delete it later
- Also deleted old files.
Review by: jat
http://code.google.com/p/go
http://gwt-code-reviews.appspot.com/111805/diff/1/5
File user/src/com/google/gwt/user/client/ui/CellPanel.java (right):
http://gwt-code-reviews.appspot.com/111805/diff/1/5#newcode29
Line 29: *
Oh, yes it is. :-)
http://gwt-code-reviews.appspot.com/111805
--
http://groups.google.com/group/Googl
http://gwt-code-reviews.appspot.com/111805/diff/1/4
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (left):
http://gwt-code-reviews.appspot.com/111805/diff/1/4#oldcode923
Line 923: // automagically, according to http://b/issue?id=1867118
Yes, that's why I deleted it.
http://gwt-
Revision: 7146
Author: sco...@google.com
Date: Mon Nov 23 16:21:36 2009
Log: Nukes svn:merginfo over all of trunk.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7146
Modified:
/trunk
/trunk/dev/core/src/com/google/gwt/core/ext/ServletContainer.java
/trunk/dev/
Revision: 7145
Author: j...@google.com
Date: Mon Nov 23 16:17:33 2009
Log: Update Mac FF shared libraries.
Patch by: jat
Unreviewed
http://code.google.com/p/google-web-toolkit/source/detail?r=7145
Modified:
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib
Revision: 7144
Author: j...@google.com
Date: Mon Nov 23 15:41:57 2009
Log: Update Fedora/etc shared libraries.
Patch by: jat
Unreviewed
http://code.google.com/p/google-web-toolkit/source/detail?r=7144
Modified:
/trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.s
Revision: 7143
Author: j...@google.com
Date: Mon Nov 23 15:38:51 2009
Log: Improve debug logging to help track down crash.
Patch by: jat
Review by: scottb (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=7143
Modified:
/trunk/plugins/xpcom/ExternalWrapper.cpp
/trunk/plugins/
Revision: 7142
Author: j...@google.com
Date: Mon Nov 23 15:06:45 2009
Log: Merge trunk r7141 into this branch
Remove TODOs from hosted.html
svn merge --ignore-ancestry -c7141 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/d
Reviewers: fabbott,
Description:
ImageResourceTest#testDedup sometimes fails because the timeout is only
1 second.
Fix:
Increased timeout to 10s, in line with other tests.
Please review this at http://gwt-code-reviews.appspot.com/112807
Affected files:
user/test/com/google/gwt/resource
Revision: 7141
Author: j...@google.com
Date: Mon Nov 23 15:04:10 2009
Log: Remove TODOs from hosted.html, captured in issues instead.
Patch by: jat
Review by: bruce
http://code.google.com/p/google-web-toolkit/source/detail?r=7141
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/imp
Revision: 7140
Author: sco...@google.com
Date: Mon Nov 23 14:42:20 2009
Log: tr...@7139 was merged into this branch
Disconnected plugin glasspanel lightened to 75% opacity.
svn merge --ignore-ancestry -c7139
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/go
Revision: 7139
Author: sco...@google.com
Date: Mon Nov 23 14:39:18 2009
Log: Disconnected plugin glasspanel lightened to 75% opacity.
Review by: bruce, abowers
http://code.google.com/p/google-web-toolkit/source/detail?r=7139
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/host
LGTM
http://gwt-code-reviews.appspot.com/112806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Message:
John, can you take point on this?
And, everybody, this is how I'm planning to document UiBinder's custom
parsing. There will be similar changes for the layout panels,
CustomButton, MenuBar, DisclosurePanel, DialogBox, and perhaps others.
Are we good with the general
Revision: 7138
Author: sco...@google.com
Date: Mon Nov 23 14:19:49 2009
Log: tr...@7137 was merged into this branch
Use a css expression for hosted.html's disconnect screen in IE6 standards
mode.
svn merge --ignore-ancestry -c7137
http://google-web-toolkit.googlecode.com/svn/trunk .
htt
Revision: 7137
Author: sco...@google.com
Date: Mon Nov 23 14:17:52 2009
Log: Use a css expression for hosted.html's disconnect screen in IE6
standards mode.
We can't set a resize handler from the inner frame, and it's a minute
enough case that it's not worth adding in extra plumbing just to we
Revision: 7136
Author: sco...@google.com
Date: Mon Nov 23 14:00:51 2009
Log: Plugins: update prebuilt binaries to r7135 (graceful disconnect).
Patch by: me, bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=7136
Added:
/trunk/plugins/webkit/prebuilt/gwt-dev-plugin.dmg
Deleted:
Revision: 7135
Author: b...@google.com
Date: Mon Nov 23 13:36:41 2009
Log: Add support for disconnection glass panel in Safari plugin.
Patch by: bobv
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7135
Modified:
/trunk/plugins/webkit/Core/WebScriptSessionHandler.c
Revision: 7134
Author: b...@google.com
Date: Mon Nov 23 13:36:18 2009
Log: A variety of build and cosmetic updates to the Safari plugin.
Patch by: bobv
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7134
Deleted:
/trunk/plugins/webkit/oophm.pmdoc/01oophm-contents.
Revision: 7133
Author: r...@google.com
Date: Mon Nov 23 13:35:16 2009
Log: Merge tr...@7132 into this branch
Fix PrefixTree implementation on Chrome
svn merge --ignore-ancestry -c 7132
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail
Revision: 7132
Author: r...@google.com
Date: Mon Nov 23 13:33:14 2009
Log: Fix PrefixTree implementation on Chrome
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7132
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/PrefixTree.java
=
Revision: 7131
Author: r...@google.com
Date: Mon Nov 23 13:20:43 2009
Log: Merged tr...@7121 into this branch
Remove obsolete documentation.
svn merge --ignore-ancestry -c 7121
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7131
LGTM, thanks
http://gwt-code-reviews.appspot.com/111804
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7130
Author: r...@google.com
Date: Mon Nov 23 13:19:22 2009
Log: Merged tr...@7122 into this branch
Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
svn merge --ignore-ancestry -c 7122
http://google-web-toolkit.googlecode.com/svn/trunk .
http:
Revision: 7129
Author: sco...@google.com
Date: Mon Nov 23 13:18:40 2009
Log: IE, Chrome, Firefox plugins: gracefully disconnect when server
connection drops.
1) Plugins fails gracefully in the face of a disconnect, returning
undefined instead of making lots of noise.
2) Plugins invokes hosted
Revision: 7127
Author: jlaba...@google.com
Date: Mon Nov 23 13:01:27 2009
Log: Fixing an NPE in StackPanel that occurs very rarely in IE.
Patch by: jlabanca
Review by: jat (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=7127
Modified:
/trunk/user/src/com/google/gwt/user/cli
Filed a bug on this:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4268
On 23-Nov-09, at 12:40 PM, Bruce Johnson wrote:
> let's remember to talk about this more for the release after 2.0
>
> On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett
> wrote:
> +1 deprecate and warn.
>
> On
Revision: 7126
Author: j...@google.com
Date: Mon Nov 23 12:44:09 2009
Log: Merge trunk r7125 into this branch.
Revert r7119.
svn merge --ignore-ancestry -c7125 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7126
M
Revision: 7125
Author: j...@google.com
Date: Mon Nov 23 12:40:55 2009
Log: Reverting r7119 due to test failure, will investigate later.
http://code.google.com/p/google-web-toolkit/source/detail?r=7125
Modified:
/trunk/user/super/com/google/gwt/emul/java/util/Arrays.java
/trunk/user/test/com/g
Revision: 7124
Author: kpro...@google.com
Date: Mon Nov 23 12:38:56 2009
Log: Merging trunk revision 7123 into this branch: Adds deprecation warning
to direct use of SoycDashboard. Review by: spoon
svn merge --ignore-ancestry -c 7123
https://google-web-toolkit.googlecode.com/svn/trunk .
http
Done, and thanks, committed to trunk at r7123.
On 2009/11/23 19:34:16, Lex wrote:
> LGTM
> http://gwt-code-reviews.appspot.com/111803/diff/1/2
> File dev/core/src/com/google/gwt/soyc/SoycDashboard.java (right):
> http://gwt-code-reviews.appspot.com/111803/diff/1/2#newcode74
> Line 74: Thread.sle
Revision: 7123
Author: kpro...@google.com
Date: Mon Nov 23 12:28:27 2009
Log: Adds deprecation warning to direct use of SoycDashboard. Review by:
spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7123
Modified:
/trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
Revision: 7122
Author: r...@google.com
Date: Mon Nov 23 12:05:34 2009
Log: Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
Review by: jlabanca, jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7122
Modified:
/trunk/user/build.xml
/tr
Revision: 7121
Author: r...@google.com
Date: Mon Nov 23 12:01:25 2009
Log: Remove obsolete documentation.
Review by: bruce
http://code.google.com/p/google-web-toolkit/source/detail?r=7121
Deleted:
/trunk/doc/src/com/google/gwt/doc/DeveloperGuide.java
===
-
let's remember to talk about this more for the release after 2.0
On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett wrote:
> +1 deprecate and warn.
>
> On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan wrote:
> > FWIW, this confusion is exactly why webAppCreator no longer generates
> > projects that use the
Revision: 7120
Author: j...@google.com
Date: Mon Nov 23 11:42:02 2009
Log: Merge trunk r7119 into this branch
Fix Arrays.equals(Object[], Object[]) for nulls.
svn merge --ignore-ancestry -c7119 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-
Revision: 7119
Author: j...@google.com
Date: Mon Nov 23 11:36:05 2009
Log: Fix Arrays.equals(Object[], Object[]) to handle nulls.
Patch by: hhc...@google.com
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7119
Modified:
/trunk/user/super/com/google/gwt/emul/java/uti
LGTM
http://gwt-code-reviews.appspot.com/111803/diff/1/2
File dev/core/src/com/google/gwt/soyc/SoycDashboard.java (right):
http://gwt-code-reviews.appspot.com/111803/diff/1/2#newcode74
Line 74: Thread.sleep(1000);
One second is very short. Maybe 5?
http://gwt-code-reviews.appspot.com/111803
-
+1 deprecate and warn.
On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan wrote:
> FWIW, this confusion is exactly why webAppCreator no longer generates
> projects that use the implicit include. I wonder if we shouldn't flat out
> deprecate it--in which case a warning would be the right thing.
>
> --
> ht
FWIW, this confusion is exactly why webAppCreator no longer generates
projects that use the implicit include. I wonder if we shouldn't flat out
deprecate it--in which case a warning would be the right thing.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: bruce,
Description:
These have been moved to bug entries.
Please review this at http://gwt-code-reviews.appspot.com/112806
Affected files:
dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Reviewers: Lex,
Description:
Users should no longer use the SoycDashboard directly, because the
compiler option -compileReport will already cause all compile report
files to be written to the extras directory. This patch adds a simple
warning to users of the dashboard.
For people who use -soyc,
Maybe not a warning, but maybe an INFO-level log entry, or perhaps a
TRACE-level one. I think the default introduction of source path="client" is
net confusing. Forcing people to specify it would have helped (forced?)
people to understand what is going on.
On Mon, Nov 23, 2009 at 1:40 PM, John Tam
Revision: 7118
Author: jlaba...@google.com
Date: Mon Nov 23 10:40:40 2009
Log: tr...@7117 was merged into this branch
Allows spaces in test targets in user/build.xml.
svn merge --ignore-ancestry -c 7117
http://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
http://code.g
On Mon, Nov 23, 2009 at 1:33 PM, Matt Mastracci wrote:
> I'll work around the implicit source path issue for now by using fake
> source paths in modules that don't have any additional source
> imports. If possible, it would be useful if there were a log warning
> explaining that the source path i
Revision: 7117
Author: jlaba...@google.com
Date: Mon Nov 23 10:39:00 2009
Log: Wrapping selenium hosts in quotes so we can use spaces in the host
names.
Patch by: jlabanca
Review by: fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=7117
Modified:
/trunk/user/build.xml
==
On Mon, Nov 23, 2009 at 1:29 PM, Daniel Rice (דניאל רייס)
wrote:
> Yes, project.ant.xmlsrc is already included.
>
Doh. Nevermind that part of the comment.
LGTM with the other change.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://groups.google.com/group/Google-Web-Toolkit-Con
I'm getting closer to figuring out exactly what happened here. The
extra classes that were getting included were all under /
client. I've restructured our half-dozen GWT modules so that they all
inherit source paths and imports from a basic set of root modules.
For modules that differ onl
Also need to update things produced by webAppCreator, such as the
template project.ant.xmlsrc
http://gwt-code-reviews.appspot.com/112805/diff/1/2
File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/112805/diff/1/2#newcode180
Line 180: return true;
Also
Revision: 7116
Author: kpro...@google.com
Date: Mon Nov 23 09:21:44 2009
Log: Merges trunk revision 7115 into this branch: Make compiler log start
counting permutations at 0 (again). This makes it consistend with
everything else.
Review by: scottb
http://code.google.com/p/google-web-toolkit
Revision: 7115
Author: kpro...@google.com
Date: Mon Nov 23 09:14:03 2009
Log: Make compiler log start counting permutations at 0 (again). This
makes it consistend with everything else.
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7115
Modified:
/trunk/dev/c
Revision: 7114
Author: rda...@google.com
Date: Mon Nov 23 09:06:36 2009
Log: Updating branch-info.txt to reflect merge of tr...@r7112 into
releases/2.0 at r7113.
http://code.google.com/p/google-web-toolkit/source/detail?r=7114
Modified:
/releases/2.0/branch-info.txt
=
On 2009/11/23 16:40:11, scottb wrote:
> LVGTM
Thanks, committed to trunk at r7115.
http://gwt-code-reviews.appspot.com/112803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7113
Author: rda...@google.com
Date: Mon Nov 23 09:05:16 2009
Log: Merged tr...@r7112 into releases/2.0. Merge was performed with the
following command:
svn merge --ignore-ancestry -c 7112
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-tool
Thanks for the review.
Committed as tr...@r7112 and cherry-picked into releases/2.0 at r7113.
http://gwt-code-reviews.appspot.com/111802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7112
Author: rda...@google.com
Date: Mon Nov 23 09:03:48 2009
Log: Improved error handling of failure to connect to remote UI.
Review by: mmendez
http://code.google.com/p/google-web-toolkit/source/detail?r=7112
Modified:
/trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java
===
Revision: 7111
Author: rda...@google.com
Date: Mon Nov 23 09:00:15 2009
Log: Updated branch-info.txt to reflect merge of tr...@r7109 into
releases/2.0 at r7110.
http://code.google.com/p/google-web-toolkit/source/detail?r=7111
Modified:
/releases/2.0/branch-info.txt
==
Committed as tr...@r7109 and cherry-picked into releases/2.0 at r7110.
http://gwt-code-reviews.appspot.com/112802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7110
Author: rda...@google.com
Date: Mon Nov 23 08:58:37 2009
Log: Merged tr...@r7109 into releases/2.0. Merge was performed with the
following command:
svn merge --ignore-ancestry -c 7105
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-too
Revision: 7109
Author: rda...@google.com
Date: Mon Nov 23 08:55:43 2009
Log: Adds an info message to indicate when a module has loaded successfully.
Review by: mmendez, jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7109
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/Oo
Ended up going with "Module xxx has been loaded." John, I agree with
your point, but I think those other messages should be changed to be
more specific.
http://gwt-code-reviews.appspot.com/112802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LVGTM
http://gwt-code-reviews.appspot.com/112803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/112802/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
(right):
http://gwt-code-reviews.appspot.com/112802/diff/1/2#newcode186
Line 186: "Module " + moduleName + " loaded");
Lets go with "Module xxx has been started.". Truly, that i
Thanks for your answer Thomas.
Actually I was interested in having the GlassPanel as a separate widget and
with the possibility of applying it to any absolutePanel. I already
implemented my own widget for that based on the patch I mentioned before but
wanted to know if those features would make it
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
In the event that no -startupURLs were provided cou
Reviewers: scottb,
Description:
Scott,
could you review this simple patch for me? It reverts an earlier
change, so that the compiler log starts counting permutations at 0
again. While less pretty, it's consistent with everything else.
Thanks,
kathrin
Please review this at http://gwt-code-revi
Revision: 7108
Author: kpro...@google.com
Date: Mon Nov 23 07:38:58 2009
Log: Merges trunk revision 7104 into this branch: Makes compile report
handle collapsed permutations (rather than swallowing them).
svn merge --ignore-ancestry -c 7104
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 7107
Author: jasonpar...@google.com
Date: Mon Nov 23 07:19:24 2009
Log: Updated branch-info.txt to reflect merge of tr...@r7105 into this
branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=7107
Modified:
/releases/2.0/branch-info.txt
==
Revision: 7106
Author: jasonpar...@google.com
Date: Mon Nov 23 07:17:28 2009
Log: Merge from tr...@r7105 to release/gwt-2.0:
svn merge --ignore-ancestry -c 7105
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7106
Modified:
Revision: 7105
Author: jasonpar...@google.com
Date: Mon Nov 23 07:12:55 2009
Log: Update the gwt-user widgets XSD to support LayoutPanel
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=7105
Modified:
/trunk/user/src/com/google/gwt/uibinder/resources/com.google.gwt
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
On 2009/11/23 14:57:09, mmendez wrote:
> If no star
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
If no startupURLs are specified on the command line
Revision: 7104
Author: kpro...@google.com
Date: Mon Nov 23 06:46:03 2009
Log: Makes compile report handle collapsed permutations (rather than
swallowing them)
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7104
Modified:
/trunk/dev/core/src/com/google/gwt/core/
LGTM
http://gwt-code-reviews.appspot.com/112802/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
(right):
http://gwt-code-reviews.appspot.com/112802/diff/1/2#newcode185
Line 185: moduleHandle.getLogger().log(TreeLogger.INFO,
Nit: Should this be "Module XXX was loaded"
LGTM
http://gwt-code-reviews.appspot.com/111802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
92 matches
Mail list logo
