[gwt-contrib] Re: Refactor SessionHandler and BrowserChannelClient to allow other OOPHM clients than HtmlUnit

2009-11-28 Thread Amit Manjhi
Thanks for the patch. I agree with John that this is way too late for 2.0 at this point. I will get back to this for 2.1. Please file a public issue for this refactoring and attach the patch to that. Regards, Amit On Sat, Nov 28, 2009 at 6:41 PM, wrote: > I really think this is too big a change

[gwt-contrib] Re: Refactor SessionHandler and BrowserChannelClient to allow other OOPHM clients than HtmlUnit

2009-11-28 Thread jat
I really think this is too big a change to make between the RC and the final release. I would rather wait until after we ship 2.0 and spend a bit more time on it to clean up some of the other rough edges before getting it into trunk. http://gwt-code-reviews.appspot.com/114801 -- http://groups.

[gwt-contrib] Re: Adds manual user tests (-runStyle Manual) targets to user/build.xml

2009-11-28 Thread t . broyer
OK, ignore this one; I was patiently waiting for the "Please navigate X browsers to this URL" when I realized the stdout was redirected. So back to remote and selenium tests :-( http://gwt-code-reviews.appspot.com/114802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds manual user tests (-runStyle Manual) targets to user/build.xml

2009-11-28 Thread t . broyer
Reviewers: jat, Description: This patch adds "-runStyle Manual" test targets to user/build.xml; the number of clients is set in the ${gwt.hosts.web.manual} and ${gwt.hosts.dev.manual} properties. This is a follow-up to our discussion at http://groups.google.fr/group/google-web-toolkit-contributor

[gwt-contrib] Re: Fix for issue 3388

2009-11-28 Thread t . broyer
Ping! will it make it into GWT 2.0? seems unlikely unfortunately, whereas the patch was "LGTM" three months ago :-( I'm submitting an updated patch, just in case, as the tests were changed due to FF3.5 supporting CORS (i.e. not throwing an exception in the cross-origin test) http://gwt-code-revi

Re: [gwt-contrib] com.google.gwt.junit.RunStyle is package-protected, wasn't it rather meant to be public?

2009-11-28 Thread Thomas Broyer
On Sat, Nov 28, 2009 at 8:08 PM, John Tamplin wrote: > On Sat, Nov 28, 2009 at 12:05 PM, Thomas Broyer wrote: >> >> Do you think HtmlUnit integration is stable enough so this refactoring >> could happen before 2.0 ship? (I could –try to– contribute the >> refactoring in time, if needed) > > Such a

[gwt-contrib] Refactor SessionHandler and BrowserChannelClient to allow other OOPHM clients than HtmlUnit

2009-11-28 Thread t . broyer
Reviewers: amitmanjhi, Description: There's a TODO(amitmanjhi) in HtmlUnitSessionHandler to refactor SessionHandler, and the current situation makes it impossible for me to implement OOPHM in Adobe AIR (well, unless I write a full-fledged OOPHM client). So here's a patch that factors out a Sessio

[gwt-contrib] Re: Fix for issue 3528

2009-11-28 Thread t . broyer
On 2009/09/03 19:48:25, jgw wrote: > On 2009/08/26 15:21:26, t.broyer wrote: > > > Just so you know, I haven't forgotten about this, but I'm really swamped this > week. I'm out next week, but will have a look at this as soon as I get back > (unless someone else beats me to it). Just so you know ;

Re: [gwt-contrib] com.google.gwt.junit.RunStyle is package-protected, wasn't it rather meant to be public?

2009-11-28 Thread John Tamplin
On Sat, Nov 28, 2009 at 12:05 PM, Thomas Broyer wrote: > Well, actually, it wouldn't change much things for me at the moment > 'cause HtmlUnit is too deeply nested into GWT's internals (many direct > references to HtmlUnitSessionHandler instead of e.g. a factored-out > SessionHandlerClient, whic

Re: [gwt-contrib] com.google.gwt.junit.RunStyle is package-protected, wasn't it rather meant to be public?

2009-11-28 Thread Thomas Broyer
On Sat, Nov 28, 2009 at 4:16 PM, John Tamplin wrote: > On Sat, Nov 28, 2009 at 10:14 AM, Thomas Broyer wrote: >> >> I don't think that's what you really want though; it seems like >> RunStyle was meant to be public so you can extend it in any package >> you like, and then pass the FQN of your cla

Re: [gwt-contrib] question about GWT RichTextArea

2009-11-28 Thread John LaBanca
Try this: richTextArea.getFormatter().setJustification(Justification.FULL); The RichTextArea uses execCommand() to modify the currently selected contents of the editable area. Some of the inputs to execCommand() do not match similar CSS style names exactly. Thanks, John LaBanca jlaba...@google.c

Re: [gwt-contrib] Re: Avira is showing warning when accessing gwt-generated files

2009-11-28 Thread Ray Ryan
Does one app make heavier use of CssResource than the other? A bell is ringing about mhtml security concerns. Or did we back out our mhtml use? On Nov 28, 2009 7:22 AM, "Thomas Broyer" wrote: On 28 nov, 12:29, dflorey wrote: > Thanks for your suggestion! I've uplo... My boss is using Avira on h

[gwt-contrib] Re: Avira is showing warning when accessing gwt-generated files

2009-11-28 Thread Thomas Broyer
On 28 nov, 12:29, dflorey wrote: > Thanks for your suggestion! I've uploaded a generated file and will > post the response to this thread. > I was wondering if all gwt-generated files will be classified as > malware by Avira or if it depends on some generated javascript > snippets. My boss is u

Re: [gwt-contrib] com.google.gwt.junit.RunStyle is package-protected, wasn't it rather meant to be public?

2009-11-28 Thread John Tamplin
On Sat, Nov 28, 2009 at 10:14 AM, Thomas Broyer wrote: > the -runStyle argument documentation from JUnitShell says you can pass > the fully qualified name of a class. What it doesn't say, first, > thought that's somehow implicit, is that this class has to extend > RunStyle. > But RunStyle is pack

[gwt-contrib] com.google.gwt.junit.RunStyle is package-protected, wasn't it rather meant to be public?

2009-11-28 Thread Thomas Broyer
Hi all, the -runStyle argument documentation from JUnitShell says you can pass the fully qualified name of a class. What it doesn't say, first, thought that's somehow implicit, is that this class has to extend RunStyle. But RunStyle is package-protected, forcing you to put your class in the com.go

[gwt-contrib] Re: Avira is showing warning when accessing gwt-generated files

2009-11-28 Thread dflorey
Thanks for your suggestion! I've uploaded a generated file and will post the response to this thread. I was wondering if all gwt-generated files will be classified as malware by Avira or if it depends on some generated javascript snippets. On Nov 24, 4:58 pm, Matt Mastracci wrote: > The best appr