Re: [gwt-contrib] GWT RC2 - Events are being hid by Layout layers in UIBinder

2009-12-01 Thread Stuart Moffatt
Thanks Joel. My current workaround is to use the "old" Horizontal/VerticalPanel widgets, so "no harm, no foul". Looking forward to more examples! Stuart On Mon, Nov 30, 2009 at 12:20 PM, Joel Webber wrote: > Stuart, > > Hiding/showing layers is slightly tricky (or at least non-obvious). I'm >

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Lex Spoon
On Mon, Nov 30, 2009 at 10:28 PM, Matt Mastracci wrote: > 2.  onerror works some of the time in some of the browsers. It fails on > various combinations of resolve errors, error status codes and other failure > conditions. For all browsers (except Opera) that don't support it directly, > It can be

[gwt-contrib] Re: More UiBinder javadoc

2009-12-01 Thread jgw
On 2009/12/01 06:34:15, Ray Ryan wrote: > Joel, can you review this? In fact, can you submit it for me, since it seems > like you early rising Atlantoids may roll GA before I get in? > Also, I haven't doc'd LayoutPanel itself, because I don't quite understand its > constraints. Have it in you? LG

[gwt-contrib] Removes the use of FinallyCommand in StackLayoutPanel.

2009-12-01 Thread jgw
Reviewers: Ray Ryan, Please review this at http://gwt-code-reviews.appspot.com/115804 Affected files: M user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java Index: user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java diff --git a/user/src/com/google/gwt/user/client/ui/Stack

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Matt Mastracci
On 1-Dec-09, at 7:51 AM, Lex Spoon wrote: > On Mon, Nov 30, 2009 at 10:28 PM, Matt Mastracci > wrote: >> 2. onerror works some of the time in some of the browsers. It >> fails on >> various combinations of resolve errors, error status codes and >> other failure >> conditions. For all browser

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Matt Mastracci
Ray/Lex, I'm starting to think that the dynamic iframe might not be a bad first approach to this problem either. A single linker would be able to provide cross-domain-capable, multi-module-safe code that doesn't require any additional post-processing to support loading of fragments. It a

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Lex Spoon
Thanks for the test code and data, Matt! It sounds like enough browsers are covered that error reporting is no longer a major decider between XHR vs. script tags. Regarding iframes, be aware that some GWT users can't use them. I don't know all the reasons why, but one example reason is that ifra

[gwt-contrib] Re: Removes the use of FinallyCommand in StackLayoutPanel.

2009-12-01 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/115804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] get RPC policy name from Java code

2009-12-01 Thread spoon
Reviewers: robertvawter_google.com, Description: Some GWT users want to build GWT RPC requests themselves, e.g. via building a raw HTML form. To do this, they need to supply the RPC policy name as part of the request, just like GWT RPC normally does. How shall they get the policy name? This patc

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Joel Webber
To be clear, I don't know of any cases where people *can't* use iframes. There are some cases where teams have chosen to use

[gwt-contrib] [google-web-toolkit] r7218 committed - Cherry picking trunk c7178, c7185 into 2009.11.20 snapshot....

2009-12-01 Thread codesite-noreply
Revision: 7218 Author: sco...@google.com Date: Tue Dec 1 09:29:17 2009 Log: Cherry picking trunk c7178, c7185 into 2009.11.20 snapshot. - Fixes CustomButton's ability to have a text body - UiBinder AttributeParsers can now distinguish "" from null http://code.google.com/p/google-web-toolkit/sourc

Re: [gwt-contrib] Revisiting the script-via- default linkage

2009-12-01 Thread Matt Mastracci
For clarification, I've included an approximation of what I meant by dynamic iframe. The idea is to create the iframe using src='javascript:;' to keep it in the same domain as the parent iframe, use document.write() to initialize a full HTML document inside of it, and finally, add scripts

[gwt-contrib] Re: get RPC policy name from Java code

2009-12-01 Thread bobv
Access to the strong name isn't available anywhere else. LGTM, but add a test to RemoteServiceServletTest to at least assert that the return value is non-null. http://gwt-code-reviews.appspot.com/115805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Flow analysis framework definition and solver.

2009-12-01 Thread spoon
LGTM. Aside from documentation and naming, there is one question about which nodes are re-added to the worklist in the solver. Can you post a large enough set of code to include an actual analysis and optimization? I don't think we should commit any of this code until there it is causing at leas

[gwt-contrib] GPE 2.0-RC2 and GWTShell

2009-12-01 Thread Matt Mastracci
Hey all, I installed the GPE 2.0-RC2 build (after cleaning out the old one) and I'm running into some issues. The plugin thinks that we're using the old-style layout, so it's attempting to launch GWTShell which won't initialize a local Jetty w/war.xml. I've worked around it by creating a lo

Re: [gwt-contrib] GPE 2.0-RC2 and GWTShell

2009-12-01 Thread Joel Webber
@Miguel: I've hit this before when upgrading projects, and I keep forgetting what the trick was. I seem to recall the plugin was making the project layout determination at the time the GWT nature is added, but I'm not 100% certain. On Tue, Dec 1, 2009 at 3:55 PM, Matt Mastracci wrote: > Hey all,

Re: [gwt-contrib] GPE 2.0-RC2 and GWTShell

2009-12-01 Thread Matt Mastracci
Ahh - there's a webAppNature in .project that gets set when you enable GWT. I disabled GWT support, re-added it and now the .project has a "com.google.gdt.eclipse.core.webAppNature". This seems to be the trigger for enabling DevMode vs. GWTShell. Thanks, Matt. On 1-Dec-09, at 1:57 PM, Joel

Re: [gwt-contrib] GPE 2.0-RC2 and GWTShell

2009-12-01 Thread Miguel Méndez
That is right, at the time that the project is GWT-enabled it checks for the existence of a war/WEB-INF/web.xml. If that exists it will think that it is dealing with a war-style project and then it will use the HostedMode if it is available or DevMode when launching the application. With that ver

Re: [gwt-contrib] GPE 2.0-RC2 and GWTShell

2009-12-01 Thread Miguel Méndez
One correction: When launching web apps, we use DevMode if the SDK supports it and HostedMode otherwise. 2009/12/1 Miguel Méndez > That is right, at the time that the project is GWT-enabled it checks for > the existence of a war/WEB-INF/web.xml. If that exists it will think that > it is dealing

[gwt-contrib] [google-web-toolkit] r7219 committed - Javadoc fixes....

2009-12-01 Thread codesite-noreply
Revision: 7219 Author: j...@google.com Date: Tue Dec 1 13:59:12 2009 Log: Javadoc fixes. Patch by: jat Review by: jgw (desk) http://code.google.com/p/google-web-toolkit/source/detail?r=7219 Modified: /trunk/user/src/com/google/gwt/i18n/client/DateTimeFormat.java /trunk/user/src/com/google/g

[gwt-contrib] [google-web-toolkit] r7220 committed - Merge trunk r7219 into this branch...

2009-12-01 Thread codesite-noreply
Revision: 7220 Author: j...@google.com Date: Tue Dec 1 14:05:14 2009 Log: Merge trunk r7219 into this branch Javadoc fixes. svn merge --ignore-ancestry -c7219 \ https://google-web-toolkit.googlecode.com/svn/trunk/ . http://code.google.com/p/google-web-toolkit/source/detail?r=7220

[gwt-contrib] Fwd: Flow analysis framework definition and solver.

2009-12-01 Thread Mike Aizatsky
Forwarding since I wasn't member of the group. -- Forwarded message -- From: Date: Tue, Dec 1, 2009 at 1:52 PM Subject: Re: Flow analysis framework definition and solver. To: sp...@google.com, google-web-toolkit-contributors@googlegroups.com, cromwell...@google.com Reviewers:

[gwt-contrib] Re: Flow analysis framework definition and solver.

2009-12-01 Thread Lex Spoon
On Tue, Dec 1, 2009 at 4:52 PM, wrote: > I can create a separate CFG changelist + CFG-based analyses changelist. > I just worry that I will have to maintain several changelist branches + > main branch with all the code together. I would certainly prefer to land > this code into SVN even before it

[gwt-contrib] Re: Flow analysis framework definition and solver.

2009-12-01 Thread Mike Aizatsky
> Well, it would be sitting in svn and not being tested in any way > except that it compiles. If you want to commit the pieces somewhere, > why don't we make an svn branch? I don't think svn branch will help much. It will only add headaches. What do you say if I would merge all LGTM'ed changes to

[gwt-contrib] Increase Java stack size for JUnit tests

2009-12-01 Thread jlabanca
Reviewers: jgw, Description: UiBinderTest requires >256k stack size. This patch increases the stack size to 512k. Please review this at http://gwt-code-reviews.appspot.com/115806 Affected files: common.ant.xml Index: common.ant.xml ==

[gwt-contrib] [google-web-toolkit] r7221 committed - Fix for hosted.html missing plugin warning in IE7+ quirks mode....

2009-12-01 Thread codesite-noreply
Revision: 7221 Author: j...@google.com Date: Tue Dec 1 15:17:53 2009 Log: Fix for hosted.html missing plugin warning in IE7+ quirks mode. Found by: cramsdale Patch by: scottb Review by: jgw (desk check) http://code.google.com/p/google-web-toolkit/source/detail?r=7221 Modified: /trunk/dev/core/s

[gwt-contrib] Re: More UiBinder javadoc

2009-12-01 Thread jgw
On 2009/12/01 15:32:21, jgw wrote: > On 2009/12/01 06:34:15, Ray Ryan wrote: > > Joel, can you review this? In fact, can you submit it for me, since it seems > > like you early rising Atlantoids may roll GA before I get in? > > > > Also, I haven't doc'd LayoutPanel itself, because I don't quite und

[gwt-contrib] [google-web-toolkit] r7222 committed - Increasing the stack size when running JUnit tests because UiBinderTes...

2009-12-01 Thread codesite-noreply
Revision: 7222 Author: jlaba...@google.com Date: Tue Dec 1 15:21:09 2009 Log: Increasing the stack size when running JUnit tests because UiBinderTest requires more than 256k. Patch by: jlabanca Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7222 Modified: /trunk

[gwt-contrib] [google-web-toolkit] r7223 committed - Adding UiBinder doc for widgets that require it....

2009-12-01 Thread codesite-noreply
Revision: 7223 Author: j...@google.com Date: Tue Dec 1 15:21:10 2009 Log: Adding UiBinder doc for widgets that require it. Review: http://gwt-code-reviews.appspot.com/116803 http://code.google.com/p/google-web-toolkit/source/detail?r=7223 Modified: /trunk/user/src/com/google/gwt/user/client/ui/

[gwt-contrib] [google-web-toolkit] r7224 committed - tr...@7222 was merged into this branch...

2009-12-01 Thread codesite-noreply
Revision: 7224 Author: jlaba...@google.com Date: Tue Dec 1 15:25:46 2009 Log: tr...@7222 was merged into this branch Increase stack size of JUnit tests. svn merge --ignore-ancestry -c7222 https://google-web-toolkit.googlecode.com/svn/trunk/ . Patch by: jlabanca http://code.google.com/p

[gwt-contrib] Re: Flow analysis framework definition and solver.

2009-12-01 Thread Lex Spoon
On Tue, Dec 1, 2009 at 5:59 PM, Mike Aizatsky wrote: >> Well, it would be sitting in svn and not being tested in any way >> except that it compiles.  If you want to commit the pieces somewhere, >> why don't we make an svn branch? > > I don't think svn branch will help much. It will only add headac

[gwt-contrib] [google-web-toolkit] r7225 committed - Removes the use of FinallyCommand in StackLayoutPanel. This works arou...

2009-12-01 Thread codesite-noreply
Revision: 7225 Author: j...@google.com Date: Tue Dec 1 15:35:53 2009 Log: Removes the use of FinallyCommand in StackLayoutPanel. This works around a Scheduler bug that's causing StackLayoutPanel to misbehave slightly. Review: http://gwt-code-reviews.appspot.com/115804 http://code.google.com/p/go

[gwt-contrib] Re: Removes the use of FinallyCommand in StackLayoutPanel.

2009-12-01 Thread jgw
On 2009/12/01 16:45:14, Ray Ryan wrote: > LGTM Committed at r7225. http://gwt-code-reviews.appspot.com/115804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Increase Java stack size for JUnit tests

2009-12-01 Thread jat
LGTM http://gwt-code-reviews.appspot.com/115806 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Flow analysis framework definition and solver.

2009-12-01 Thread Mike Aizatsky
> Sounds good. Git is optional; please do if it's easy, but don't worry > if it's not. I can patch in multiple patches just fine. I use git for development anyway. On Tue, Dec 1, 2009 at 3:32 PM, Lex Spoon wrote: > On Tue, Dec 1, 2009 at 5:59 PM, Mike Aizatsky wrote: >>> Well, it would be sit

[gwt-contrib] [google-web-toolkit] r7226 committed - Fixes issues 2907, 4277 and 4278....

2009-12-01 Thread codesite-noreply
Revision: 7226 Author: j...@google.com Date: Tue Dec 1 16:25:52 2009 Log: Fixes issues 2907, 4277 and 4278. Also fixes mail icon showing up in front of the about dialog. Review: http://gwt-code-reviews.appspot.com/113801 http://code.google.com/p/google-web-toolkit/source/detail?r=7226 Modified:

[gwt-contrib] Re: Comment on UiBinder in google-web-toolkit

2009-12-01 Thread codesite-noreply
Comment by vincent.case: I found these UiBinder use cases very helpful in understanding the APIs. However, I am unable to determine if UIBinder addresses the gwt 1.7 issues I have with formatting my app layout using CSS. Specifically, * HTML generated by gwt layout widgets is not transparen

[gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-01 Thread Stuart Moffatt
All, I found myself needing band-aids (read: bleeding edge) while trying out TabLayoutPanel. 1) The javadocs and code for TabLayoutPanel suggest that the gwt- TabLayoutPanel(*) css selectors exist: http://code.google.com/p/google-web-toolkit/source/browse/releases/2.0/user/src/com/google/gwt/use

[gwt-contrib] Re: Comment on UiBinder in google-web-toolkit

2009-12-01 Thread codesite-noreply
Comment by j...@google.com: @vincent.case: It's not clear precisely what you're referring to when you reference the "gwt layout widgets". Are you referring to the new *LayoutPanel structures or the existing panels such as DockPanel, Horizontal/VerticalPanel and such? The existing panels deri

[gwt-contrib] Re: Make UiBinder handle custom subclasses of DialogBox

2009-12-01 Thread rjrjr
Ping. This is fairly urgent. http://gwt-code-reviews.appspot.com/115803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7227 committed - Merging /trunk c7221, c7223, c7225, c7226 into this branch.

2009-12-01 Thread codesite-noreply
Revision: 7227 Author: j...@google.com Date: Tue Dec 1 21:26:37 2009 Log: Merging /trunk c7221, c7223, c7225, c7226 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7227 Modified: /releases/2.0/branch-info.txt /releases/2.0/dev/core/src/com/google/gwt/core/ext/li

Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-01 Thread Joel Webber
The following CSS rules should work fine with the TabLayoutPanel as checked in: .gwt-TabLayoutPanel { } .gwt-TabLayoutPanelTabs { } .gwt-TabLayoutPanelTab { } .gwt-TabLayoutPanelTab .gwt-TabLayoutPanelTabInner { } .gwt-TabLayoutPanelTab-selected { } .gwt-TabLayoutPanelTab-selected .gwt-TabLayoutPa

[gwt-contrib] [google-web-toolkit] r7228 committed - Fixing TabLayoutPanel tab stacking (float -> cssFloat)....

2009-12-01 Thread codesite-noreply
Revision: 7228 Author: j...@google.com Date: Tue Dec 1 22:01:22 2009 Log: Fixing TabLayoutPanel tab stacking (float -> cssFloat). Review: jlabanca (tbr) http://code.google.com/p/google-web-toolkit/source/detail?r=7228 Modified: /trunk/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java

[gwt-contrib] TBR: float -> cssFloat in TabLayoutPanel

2009-12-01 Thread Joel Webber
http://code.google.com/p/google-web-toolkit/source/detail?r=7228 This was a mistake on my part. Some browsers (e.g., Firefox) won't accept elem.style['float'], but rather require elem.style['cssFloat']. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-01 Thread Stuart Moffatt
Joel, Is there something "special" that I need to do in my ui.xml in order to get these CSS rules applied to my TabLayoutPanel? http://google-web-toolkit.googlecode.com/files/xhtml.ent";> ... ui style ... src? type? empty? do I add {style.*} styles to the XML below? First Tabfirst tab c

[gwt-contrib] [google-web-toolkit] r7229 committed - Merging /trunk r7228 into this branch.

2009-12-01 Thread codesite-noreply
Revision: 7229 Author: j...@google.com Date: Tue Dec 1 22:03:38 2009 Log: Merging /trunk r7228 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7229 Modified: /releases/2.0/branch-info.txt /releases/2.0/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java

Re: [gwt-contrib] question about GWT RichTextArea

2009-12-01 Thread Nicolas Job
Dear John, I would like to thank you for your response. We were working with GWT 1.7 and now we have to upgrade to 2.0. Thanks, Nicolas 2009/11/28 John LaBanca > Try this: > richTextArea.getFormatter().setJustification(Justification.FULL); > > The RichTextArea uses execCommand() to modify the cu