Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-02 Thread BobV
> [...@rjrjr, bobv: Is there some easy way to put plain, unobfuscated CSS rules > in a .ui.xml file?] Yes. Declare those class selectors to be @external in the CSS block. @external gwt-TabLayoutPanelTabs gwt-TabLayoutPanelTabInner; Now that ui:style allows users to specify a src attribute as we

[gwt-contrib] Re: Make UiBinder handle custom subclasses of DialogBox

2009-12-02 Thread BobV
On Tue, Dec 1, 2009 at 11:57 PM, wrote: > Ping. This is fairly urgent. I'm looking at this now. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-02 Thread Stuart Moffatt
Thanks. Will give @external a try. Stuart On Wed, Dec 2, 2009 at 8:59 AM, BobV wrote: >> [...@rjrjr, bobv: Is there some easy way to put plain, unobfuscated CSS rules >> in a .ui.xml file?] > > Yes.  Declare those class selectors to be @external in the CSS block. > > @external gwt-TabLayoutPane

Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-02 Thread Ray Ryan
The @external mention is just the thing for that CSS page. On Dec 2, 2009 5:59 AM, "BobV" wrote: > [...@rjrjr, bobv: Is there some easy way to put plain, unobfuscated CSS rules > in a .ui.xml file?] Yes. Declare those class selectors to be @external in the CSS block. @external gwt-TabLayoutPan

Re: [gwt-contrib] GWT RC2: TabPanelLayout -- no supporting CSS?

2009-12-02 Thread Ray Ryan
I don't think we should thaw 2.0 for the externalized CSS file (though it's tempting), but it would be a good add for the downloads page. Or a tool that externalizes CSS files, similar to the one that generates java interfaces from them. On Dec 2, 2009 5:59 AM, "BobV" wrote: > [...@rjrjr, bobv:

[gwt-contrib] Re: Make UiBinder handle custom subclasses of DialogBox

2009-12-02 Thread Ray Ryan
They can provide a constructor with @UiConstructor on it. On Wed, Dec 2, 2009 at 6:11 AM, wrote: > How can custom subclasses respond to autoHide and modal attributes? > > > http://gwt-code-reviews.appspot.com/115803 > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Pass IE Plugin installer version into build file

2009-12-02 Thread jlabanca
committed as r7230 Did not specify the date on the version per our email conversation. http://gwt-code-reviews.appspot.com/116801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7230 committed - Updating the build script for the IE dev mode plugin to require a vers...

2009-12-02 Thread codesite-noreply
Revision: 7230 Author: jlaba...@google.com Date: Wed Dec 2 08:16:54 2009 Log: Updating the build script for the IE dev mode plugin to require a version number. Also adding useful fail messages when Wix is not installed. Patch by: jlabanca Review by: scottb http://code.google.com/p/google-web

[gwt-contrib] [google-web-toolkit] r7231 committed - tr...@7230 was merged into this branch...

2009-12-02 Thread codesite-noreply
Revision: 7231 Author: jlaba...@google.com Date: Wed Dec 2 08:20:40 2009 Log: tr...@7230 was merged into this branch Build file for IE plugin now requires a version parameter. svn merge --ignore-ancestry -c7230 https://google-web-toolkit.googlecode.com/svn/trunk/ . Patch by: jlabanca h

[gwt-contrib] Remove image.onload fix from release notes

2009-12-02 Thread jlabanca
Reviewers: scottb, Description: The image.onload fix was reverted from the gwt 2.0 branch because it caused HtmlUnit errors, but the release notes have not been updated. Fix: Update the release notes. Please review this at http://gwt-code-reviews.appspot.com/118801 Affected files: distr

[gwt-contrib] Re: Remove image.onload fix from release notes

2009-12-02 Thread Scott Blum
LGTM. Don't forget to change the status on Issue 863 to reflect its notfixedness. On Wed, Dec 2, 2009 at 11:25 AM, wrote: > Reviewers: scottb, > > Description: > The image.onload fix was reverted from the gwt 2.0 branch because it > caused HtmlUnit errors, but the release notes have not been up

[gwt-contrib] Re: Remove image.onload fix from release notes

2009-12-02 Thread John LaBanca
I marked it as FixedNotReleased for NextRelease instead of gwt 2.0 and added a comment to that effect. Thanks, John LaBanca jlaba...@google.com On Wed, Dec 2, 2009 at 11:42 AM, Scott Blum wrote: > LGTM. Don't forget to change the status on Issue 863 to reflect its > notfixedness. > > On Wed,

[gwt-contrib] [google-web-toolkit] r7232 committed - Removing image.onload fix from gwt 2.0 release notes because it was re...

2009-12-02 Thread codesite-noreply
Revision: 7232 Author: jlaba...@google.com Date: Wed Dec 2 08:45:48 2009 Log: Removing image.onload fix from gwt 2.0 release notes because it was reverted. Patch by: jlabanca Review by: scottb http://code.google.com/p/google-web-toolkit/source/detail?r=7232 Modified: /trunk/distro-source/c

Re: [gwt-contrib] Re: Remove image.onload fix from release notes

2009-12-02 Thread John Tamplin
On Wed, Dec 2, 2009 at 11:45 AM, John LaBanca wrote: > I marked it as FixedNotReleased for NextRelease instead of gwt 2.0 and > added a comment to that effect. I thought 2.0 was NextRelease -- shouldn't it be Planned instead? -- John A. Tamplin Software Engineer (GWT), Google -- http://grou

[gwt-contrib] [google-web-toolkit] r7233 committed - tr...@7232 was merged into this branch...

2009-12-02 Thread codesite-noreply
Revision: 7233 Author: jlaba...@google.com Date: Wed Dec 2 08:47:36 2009 Log: tr...@7232 was merged into this branch Removing image.onload fix from release notes. svn merge --ignore-ancestry -c7232 https://google-web-toolkit.googlecode.com/svn/trunk/ . Patch by: jlabanca http://code.go

Re: [gwt-contrib] Re: Remove image.onload fix from release notes

2009-12-02 Thread John LaBanca
Moved to Planned Thanks, John LaBanca jlaba...@google.com On Wed, Dec 2, 2009 at 11:48 AM, John Tamplin wrote: > On Wed, Dec 2, 2009 at 11:45 AM, John LaBanca wrote: > >> I marked it as FixedNotReleased for NextRelease instead of gwt 2.0 and >> added a comment to that effect. > > > I thought

[gwt-contrib] [google-web-toolkit] r7234 committed - Make UiBinder handle custom subclasses of DialogBox...

2009-12-02 Thread codesite-noreply
Revision: 7234 Author: rj...@google.com Date: Wed Dec 2 10:02:31 2009 Log: Make UiBinder handle custom subclasses of DialogBox Reviewed by bobv http://code.google.com/p/google-web-toolkit/source/detail?r=7234 Added: /trunk/user/test/com/google/gwt/uibinder/test/client/FooDialog.java Modified:

[gwt-contrib] Re: Make UiBinder handle custom subclasses of DialogBox

2009-12-02 Thread rjrjr
Committed r7234 http://gwt-code-reviews.appspot.com/115803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7235 committed - Cherry picking trunk c7234 into 2009.11.20 snapshot....

2009-12-02 Thread codesite-noreply
Revision: 7235 Author: sco...@google.com Date: Wed Dec 2 10:28:11 2009 Log: Cherry picking trunk c7234 into 2009.11.20 snapshot. - Make UiBinder handle custom subclasses of DialogBox http://code.google.com/p/google-web-toolkit/source/detail?r=7235 Added: /branches/snapshot-2009.11.20-r7061/u

[gwt-contrib] [google-web-toolkit] r7236 committed - Fixes pseudo-memory-leak caused by adding a new window resize handler...

2009-12-02 Thread codesite-noreply
Revision: 7236 Author: j...@google.com Date: Wed Dec 2 11:27:43 2009 Log: Fixes pseudo-memory-leak caused by adding a new window resize handler every time a popup is shown, but not removing it. This was causing particularly bad behavior on IE, where a translucent glass element allocates a signific

[gwt-contrib] [google-web-toolkit] r7237 committed - Merging /trunk c7236 into this branch.

2009-12-02 Thread codesite-noreply
Revision: 7237 Author: j...@google.com Date: Wed Dec 2 11:33:05 2009 Log: Merging /trunk c7236 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7237 Modified: /releases/2.0/branch-info.txt /releases/2.0/user/src/com/google/gwt/user/client/ui/PopupPanel.java

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

2009-12-02 Thread jat
http://gwt-code-reviews.appspot.com/118802/diff/1/3 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/118802/diff/1/3#newcode819 Line 819: return new NumberFormatException("Expected type '" + type + "' but received

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

2009-12-02 Thread jat
http://gwt-code-reviews.appspot.com/118802/diff/1/3 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/118802/diff/1/3#newcode819 Line 819: return new NumberFormatException("Expected type '" + type + "' but received

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

2009-12-02 Thread rice
http://gwt-code-reviews.appspot.com/118802/diff/1/3 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/118802/diff/1/3#newcode819 Line 819: return new NumberFormatException("Expected type '" + type + "' but received

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

2009-12-02 Thread rice
http://gwt-code-reviews.appspot.com/118802/diff/1/3 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/118802/diff/1/3#newcode819 Line 819: return new NumberFormatException("Expected type '" + type + "' but received

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

2009-12-02 Thread jat
Ok, LGTM http://gwt-code-reviews.appspot.com/118802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7238 committed - Make RPC failures due to bad numerical values clearer (external issue ...

2009-12-02 Thread codesite-noreply
Revision: 7238 Author: r...@google.com Date: Wed Dec 2 13:26:39 2009 Log: Make RPC failures due to bad numerical values clearer (external issue 4263). Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7238 Modified: /trunk/user/src/com/google/gwt/user/server/rpc/

[gwt-contrib] [google-web-toolkit] r7239 committed - Adds ServiceDefTarget.getSerializationPolicyName(). This allows...

2009-12-02 Thread codesite-noreply
Revision: 7239 Author: sp...@google.com Date: Wed Dec 2 14:20:27 2009 Log: Adds ServiceDefTarget.getSerializationPolicyName(). This allows browser code to query the RPC policy name it will be using for a particular RPC service. Review by: bobv http://code.google.com/p/google-web-toolkit/source/

[gwt-contrib] [google-web-toolkit] r7240 committed - Sorting a test file.

2009-12-02 Thread codesite-noreply
Revision: 7240 Author: sp...@google.com Date: Wed Dec 2 14:22:51 2009 Log: Sorting a test file. http://code.google.com/p/google-web-toolkit/source/detail?r=7240 Modified: /trunk/user/test/com/google/gwt/user/client/rpc/RemoteServiceServletTest.java === --

[gwt-contrib] [google-web-toolkit] r7241 committed - Have the policy name of RpcServiceProxy be the same as...

2009-12-02 Thread codesite-noreply
Revision: 7241 Author: sp...@google.com Date: Wed Dec 2 15:06:59 2009 Log: Have the policy name of RpcServiceProxy be the same as the permutation's strong name. Review by: bobv http://code.google.com/p/google-web-toolkit/source/detail?r=7241 Modified: /trunk/user/src/com/google/gwt/rpc/client

[gwt-contrib] [google-web-toolkit] r7242 committed - Fix incorrect delimiter in Chinese Showcase translation....

2009-12-02 Thread codesite-noreply
Revision: 7242 Author: j...@google.com Date: Wed Dec 2 15:21:05 2009 Log: Fix incorrect delimiter in Chinese Showcase translation. Patch by: jat Review by: jlabanca (desk) http://code.google.com/p/google-web-toolkit/source/detail?r=7242 Modified: /trunk/samples/showcase/src/com/google/gwt/s