Comment by jeffvictor:
Is anyone else experiencing *extremely* slow DevMode on a mac? I'm using
Leopard 10.5.8 with all of the updates and running DevMode with 64 bit Java
6. I experience the same slowness when using 32 bit Java 5 as well. I'm
using 2.0 RC 2 and experience the problem
Reviewers: jat,
Description:
Simple fix in NumberFormat JavaDoc.
Please review this at http://gwt-code-reviews.appspot.com/118805
Affected files:
user/src/com/google/gwt/i18n/client/NumberFormat.java
Index: user/src/com/google/gwt/i18n/client/NumberFormat.java
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
The Mail sample doesn't resize the table containing the mail list to the
number of emails on the last page. This results in a vertical scroll
bar that doesn't go away when it isn't needed.
Fix:
We now resize the table dynamically.
Testing:
Verified
No, what do I need to do for that?
Dan
On Thu, Dec 3, 2009 at 11:09 AM, robertvaw...@google.com wrote:
Did you test this case with the deRPC code base?
http://gwt-code-reviews.appspot.com/118802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
This patch tweaks a couple of minor issues in showcase.
1. In the StackPanel example, the tree in the first stack should be open
by default.
2. In the DatePicker sample, the DateBox should only include the date
component. The time component of the date has very
Please make the test do something more real than assertTrue(true),
something actually involving the app.
http://gwt-code-reviews.appspot.com/118807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Great, I'm glad that worked out ok. Just for the record, we very much want
to do better than having to mix @external and obfuscated CSS like this. We
fully intend to revisit how styles and themes are applied, both to make it
easier and more efficient, as soon as we get 2.0 out the door.
On Thu,
On 2009/12/03 16:36:33, jlabanca wrote:
LGTM.
http://gwt-code-reviews.appspot.com/118806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
@jgw,
Now that my TabLayoutPanel is working (thanks, btw), I want to go back
to using LayoutPanel and g:layer. The problem is, my UI requires a
few layers that nest nicely together like the old VerticalPanel (one
above the other as you go down the page). Using a LayoutPanel with
layers, my UI
On 2009/12/03 21:11:22, Ray Ryan wrote:
Please make the test do something more real than assertTrue(true),
something
actually involving the app.
LGTM.
http://gwt-code-reviews.appspot.com/118807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2009/12/03 22:20:58, jgw wrote:
On 2009/12/03 21:11:22, Ray Ryan wrote:
Please make the test do something more real than assertTrue(true),
something
actually involving the app.
LGTM.
(Assuming you do something like Ray suggestd)
http://gwt-code-reviews.appspot.com/118807
--
VerticalPanel and HorizontalPanel are not dead yet, for exactly this reason.
But they're still table based.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
What Ray said. Mostly. The table-based HorizontalPanel is practically
impossible to reproduce in CSS. You can use all kinds of inline-block
hackery (since its cross-browser support is poor), but even that breaks down
under various circumstances.
VerticalPanel, on the other hand, is less useful (I
Revision: 7244
Author: jlaba...@google.com
Date: Thu Dec 3 14:30:41 2009
Log: Resizing MailList to avoid unneccessary vertical scroll bar.
Patch by: jlabanca
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=7244
Modified:
After talking to jgw, I'm going to commit this change so its available
in the 2.0 branch asap and create another bug to update the generated
test case.
http://gwt-code-reviews.appspot.com/118807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7245
Author: jlaba...@google.com
Date: Thu Dec 3 14:31:29 2009
Log: Minor tweaks to Showcase.
Patch by: jlabanca
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=7245
Modified:
Revision: 7246
Author: jlaba...@google.com
Date: Thu Dec 3 14:35:35 2009
Log: Adding src to the classpath of generated test.dev and test.prod
targets. We also need to improve the generated test to actually do
something with code in src.
Patch by: jlabanca
Review by: jgw
@jgw, rjrjr,
You can use all kinds of inline-block
hackery (since its cross-browser support is poor), but even that breaks down
under various circumstances.
Which is what I was trying to avoid by going completely table-less.
VerticalPanel, on the other hand, is less useful (I find, anyway).
Revision: 7247
Author: jlaba...@google.com
Date: Thu Dec 3 14:37:30 2009
Log: tr...@7244 was merged into this branch
Resize MailList in Mail sample.
svn merge --ignore-ancestry -c7244
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
..ah, let me restate that.
This ui.xml makes the tab panel layout in the center of the dock panel
disappear:
g:DockLayoutPanel unit='EM'
g:north size='5'
g:HTMLdivnorth/div/g:HTML
/g:north
g:east size='2'
g:HTMLdiveast/div/g:HTML
Revision: 7248
Author: jlaba...@google.com
Date: Thu Dec 3 14:38:45 2009
Log: tr...@7245 was merged into this branch
Showcase sample tweaks.
svn merge --ignore-ancestry -c7245
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
Revision: 7249
Author: jlaba...@google.com
Date: Thu Dec 3 14:43:23 2009
Log: tr...@7246 was merged into this branch
Adding src to classpath of generated test targets.
svn merge --ignore-ancestry -c7246
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
On 2009/12/03 16:20:53, jlabanca wrote:
LGTM.
http://gwt-code-reviews.appspot.com/117804
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Caught it: the height of the TabLayoutPanel must be explicitly set,
either programmatically or via a {style.*} setting in the ui.xml, or
else the content in the tabs cannot be seen.
So V/H panels survive the day.
My apologies for the traffic.
sfm
On Thu, Dec 3, 2009 at 5:44 PM, Stuart Moffatt
25 matches
Mail list logo
