I spent an hour or so re-reading http://unixpapa.com/js/key.html and
it's quite clear that we actually need deferred-binding to gets things
OK more easily, pretending that eventGetCharCode can only be called on a
KeyPress event and eventGetKeyCode can only be called on KeyDown and
KeyUp events
+1 for deferred binding. We've tried too many creative solutions to
event.getKeyCode. Its time to bite the bullet and use deferred
bindings.
http://gwt-code-reviews.appspot.com/142801/diff/1/2
File user/src/com/google/gwt/dom/client/DOMImpl.java (right):
Reviewers: jgw,
Description:
Add overload HTMLPanel.addAndReplaceElement(Widget, Element), marked
final so that anyone actually overriding these methods does so on the
only one that works.
Deprecated HTMLPanel.addAndReplaceElement(Widget,
gwt.user.client.Element)
Please review this at
LGTM.
I like the idea of disallowing JsNameRef to not have a name, so as to
avoid problems like this one. This patch is a fine thing to do for now,
though.
http://gwt-code-reviews.appspot.com/144805
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7591
Author: jlaba...@google.com
Date: Wed Feb 17 08:29:33 2010
Log: tr...@7590 was merged into this branch
Updated release notes for Opera History fix.
svn merge -c7590 --ignore-ancestry
https://google-web-toolkit.googlecode.com/svn/trunk
Revision: 7590
Author: jlaba...@google.com
Date: Wed Feb 17 05:14:44 2010
Log: Updating release notes to include Opera history fix.
http://code.google.com/p/google-web-toolkit/source/detail?r=7590
Modified:
/trunk/distro-source/core/src/release_notes.html
Reviewers: jat,
Please review this at http://gwt-code-reviews.appspot.com/146801
Affected files:
user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java
user/super/com/google/gwt/emul/java/util/Collections.java
--
LGTM, other than it needs a test to verify the serialization works.
http://gwt-code-reviews.appspot.com/146801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/02/17 15:29:45, jgw wrote:
Forgot to mention that it LGTM. Just want to make sure no one else sees
problems.
http://gwt-code-reviews.appspot.com/144806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/146801/diff/1/3
File user/super/com/google/gwt/emul/java/util/Collections.java (right):
http://gwt-code-reviews.appspot.com/146801/diff/1/3#newcode44
Line 44: private Object readResolve() {
We generally don't implement Java serialization semantics in our JRE,
Reviewers: jgw,
Description:
Fixes http://code.google.com/p/google-web-toolkit/issues/detail?id=4486
where Chrome DevMode injects a property onto a JS object literal defined
in the outer page. We override hasOwnProperty to fix this, but the
outer page has a different Object.
This fix simply
Revision: 7592
Author: k...@google.com
Date: Wed Feb 17 10:37:18 2010
Log: check null moduleName for PreCompileStrategy; this can happen when
there are pure Java GWTTestCases.
http://code.google.com/p/google-web-toolkit/source/detail?r=7592
Modified:
On Tue, Feb 16, 2010 at 3:32 PM, Scott Blum sco...@google.com wrote:
On Fri, Feb 12, 2010 at 7:00 PM, Lex Spoon sp...@google.com wrote:
On Fri, Feb 12, 2010 at 9:50 AM, Alex Moffat alex.mof...@gmail.comwrote:
Where can I read a description of what -XshardPrecompile, or see the
code for it,
Bit petty but shouldn't Collections be final. Many (most) Collections
inner classes can also be private rather than package private which
should make life for the compiler that bit easier.
Hth
On 18/02/2010, at 6:14 AM, sco...@google.com wrote:
14 matches
Mail list logo
