Yeah.. just remember someone might also do funky things with the passed-in
class literal, like .getName() or == Foo.class. So most likely it needs to
wrap the real class object and generate "unbox" code if you use the literal
itself.
On Thu, Mar 11, 2010 at 2:28 AM, Ray Cromwell wrote:
> On Wed
On Wed, Mar 10, 2010 at 7:17 PM, wrote:
> LGTM on this quick and dirty solution. Eventually, we do want something
> like John suggests -- it is mostly up to you to either go with this or
> the general solution.
I feel the same way. A quick and dirty solution would be very valuable so
that I ca
yeah the implementation looks fine
On Mar 11, 2010 8:32 AM, "Lex Spoon" wrote:
On Wed, Mar 10, 2010 at 7:17 PM, wrote:
>
> LGTM on this quick and dirty sol...
I feel the same way. A quick and dirty solution would be very valuable so
that I can add tests for the cross-site linker. However, it
Reviewers: Dan Rice,
Description:
The emul version of java.util.Date can add an extra hour to the day
before daylight savings time if setMinutes() or setSeconds is called.
The problem is that we compare the new javascript hours to the expected
hours to see if the hours are equal, but the expected
Reviewers: fabbott,
Description:
DO NOT SUBMIT
Please review this at http://gwt-code-reviews.appspot.com/175801
Affected files:
A hello.txt
Index: hello.txt
===
--- hello.txt (revision 0)
+++ hello.txt (revision 0)
@@ -0,0
http://gwt-code-reviews.appspot.com/161801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/03/11 16:45:34, kathrin wrote:
Hi Amit,
after a lengthy discussion with Joel, we decided to get rid of the
CrawlableHyperlink widget. The issue is that it doesn't add enough
useful functionality, because the app writer still needs to handle the
"!" when actually "navigating" the app to
LGTM -- I assume you have checked that it still works correctly. The
only minor comment I have is extracting out the string constant "!" used
at two places.
http://gwt-code-reviews.appspot.com/161801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Thu, Mar 11, 2010 at 11:48 AM, wrote:
> after a lengthy discussion with Joel, we decided to get rid of the
> CrawlableHyperlink widget. The issue is that it doesn't add enough
> useful functionality, because the app writer still needs to handle the
> "!" when actually "navigating" the app to
Reviewers: cramsdale, doog,
Description:
Some packages appear in JavaDoc but do not have descriptions. This
patch adds descriptions.
Please review this at http://gwt-code-reviews.appspot.com/176801
Affected files:
dev/core/src/com/google/gwt/core/linker/package.html
user/src/com/google/gwt
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
Re-add the check that was removed in r5731, but allow the behavior to be
overridden.
Please review this at http://gwt-code-reviews.appspot.com/179801
Affected files:
M user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.ja
LGTM
http://gwt-code-reviews.appspot.com/179801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/176801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
Fixing gflow nested switch CFG generation
Added couple of tostrings to aid in debugging.
Please review this at http://gwt-code-reviews.appspot.com/180801
Affected files:
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/AnalysisSolver.java
dev/core/src/com/google/g
LGTM
http://gwt-code-reviews.appspot.com/177801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Dan Rice, jat, jlabanca,
Message:
This also fixes the division-resulting-in-float issues.
Please review this at http://gwt-code-reviews.appspot.com/181801
Affected files:
M user/super/com/google/gwt/emul/java/util/Date.java
--
http://groups.google.com/group/Google-Web-Toolkit-C
LGTM
http://gwt-code-reviews.appspot.com/180801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with nits. Thanks for doing this!
http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode285
Line 285: return (int) (time ^ (getTime() >>> 32));
'getTime()' can be chan
http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode27
Line 27: static class JsDate extends JavaScriptObject {
This would be a handy public type. Especially if I could do s
Sorry for the patch spam. v4 should be good to go!
http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode27
Line 27: static class JsDate extends JavaScriptObject {
Hehe, le
Can you add the new test in DateTest from this patch:
http://gwt-code-reviews.appspot.com/174801/show
http://gwt-code-reviews.appspot.com/181801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Just submit yours first. I'll merge in your changes.
On Thu, Mar 11, 2010 at 3:05 PM, wrote:
> Can you add the new test in DateTest from this patch:
> http://gwt-code-reviews.appspot.com/174801/show
>
>
>
> http://gwt-code-reviews.appspot.com/181801
>
--
http://groups.google.com/group/Google-
http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode27
Line 27: static class JsDate extends JavaScriptObject {
On 2010/03/11 19:38:08, Ray Ryan wrote:
This would be a hand
Actually, I'm at an impasse
Right now, I'm getting a security exception in hosted mode trying to load up
java.util.Date$JsDate. So either I need to move this to a new package, or
else make some kind of infrastructure fix
Thoughts?
On Thu, Mar 11, 2010 at 3:16 PM, wrote:
>
> http://gwt
On Thu, Mar 11, 2010 at 3:21 PM, Scott Blum wrote:
> Actually, I'm at an impasse
>
> Right now, I'm getting a security exception in hosted mode trying to load
> up java.util.Date$JsDate. So either I need to move this to a new package,
> or else make some kind of infrastructure fix
>
> Th
LGTM
http://gwt-code-reviews.appspot.com/181801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Thu, Mar 11, 2010 at 3:29 PM, John Tamplin wrote:
> Why is JsDate even being referenced in devmode? In that case, you should
> be running the stock JRE j.u.Date which has no such reference (nor the
> nested class).
>
It's just has to do with how JSOs are implemented in hosted mode.
However,
Reviewers: jgw, Ray Ryan,
Message:
Okay, I went ahead and did the grunge work. :D
Please review this at http://gwt-code-reviews.appspot.com/182801
Affected files:
A user/src/com/google/gwt/core/client/JsDate.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yikes, weird how it passes we mode tests. I guess I never ran it with
emulation turned on.
On 2010/03/11 19:07:31, Lex wrote:
LGTM
http://gwt-code-reviews.appspot.com/177801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thank you!
But…I think I'm supposed to ask you for a unit test of this thing.
Especially one that would have caught the problem below.
http://gwt-code-reviews.appspot.com/182801/diff/1/2
File user/src/com/google/gwt/core/client/JsDate.java (right):
http://gwt-code-reviews.appspot.com/182801/di
http://gwt-code-reviews.appspot.com/182801/diff/1/2
File user/src/com/google/gwt/core/client/JsDate.java (right):
http://gwt-code-reviews.appspot.com/182801/diff/1/2#newcode396
Line 396: return this.setDate(dayOfMonth);
Oops, yeah. Will fix.
As far as testing, it will get somewhat testing by a
Reviewers: cromwellian,
Description:
One-line fix to SelectionScript's fallback logic for
non-shardable subclasses.
Please review this at http://gwt-code-reviews.appspot.com/183801
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Index:
dev
Can you review this, Ray? The second call to link() should start with
the results of the first call to link().
http://gwt-code-reviews.appspot.com/183801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/183801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. On a side note, is there a way to write a test case for this?
http://gwt-code-reviews.appspot.com/183801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
+1 to Ray's question. I know that you were simply doing a fix Lex, but we
need to think about how we test these "features".
On Thu, Mar 11, 2010 at 9:49 PM, wrote:
>
> LGTM. On a side note, is there a way to write a test case for this?
>
>
> http://gwt-code-reviews.appspot.com/183801
>
> --
> h
Revision: 7702
Author: r...@google.com
Date: Thu Mar 11 03:44:25 2010
Log: Checkpoint
http://code.google.com/p/google-web-toolkit/source/detail?r=7702
Added:
/trunk/bikeshed/src/com/google/gwt/bikeshed/cells/client/ProfitLossCell.java
/trunk/bikeshed/src/com/google/gwt/bikeshed/sample/stoc
Revision: 7703
Author: b...@google.com
Date: Thu Mar 11 08:37:52 2010
Log: Re-add the checkt that was removed in r5731, but allow the behavior to
be overridden.
http://gwt-code-reviews.appspot.com/179801/show
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail
Revision: 7704
Author: j...@google.com
Date: Thu Mar 11 08:39:56 2010
Log: Lots of prettier styles for the stock sample.
http://code.google.com/p/google-web-toolkit/source/detail?r=7704
Added:
/trunk/bikeshed/src/com/google/gwt/bikeshed/cells/client/EllipsisCell.java
/trunk/bikeshed/src/com/
Revision: 7705
Author: jlaba...@google.com
Date: Thu Mar 11 09:27:25 2010
Log: Date can add an hour to the day before Daylight Saving.
http://gwt-code-reviews.appspot.com/174801
Review by: r...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7705
Modified:
/trunk/user/sup
40 matches
Mail list logo
