I haven't really looked into gwt-rpc-plus (as its mainly Java), but
here are some thoughts
1. Plugging in a generic framework, whose primary goal is to provide a
reliable and secure socket (with underlying transports) for all
browsers, instead of duplicating the same effort sounds like the best
sol
Revision: 7763
Author: sp...@google.com
Date: Tue Mar 23 07:31:43 2010
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=7763
Added:
/wiki/DistributedBuilds.wiki
===
--- /dev/null
+++ /wiki/Distribu
Revision: 7764
Author: sp...@google.com
Date: Tue Mar 23 07:38:01 2010
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=7764
Modified:
/wiki/DistributedBuilds.wiki
===
--- /wiki/DistributedBuilds.wi
I can't find them documented anywhere, so I have tossed up a brief web page.
http://code.google.com/p/google-web-toolkit/wiki/DistributedBuilds
Most GWT apps build fast enough that a distributed build isn't worth the
effort, so this is a pretty specialized topic. However, an occasional
project h
Revision: 7765
Author: j...@google.com
Date: Tue Mar 23 08:23:58 2010
Log: Fixed unintended WikiWords, added comment about shared filesystem.
http://code.google.com/p/google-web-toolkit/source/detail?r=7765
Modified:
/wiki/DistributedBuilds.wiki
===
--- /wiki
Something else related to this problem: when a DockLayoutPanel is
animated to resize its children, onResize() is called *before* the
resize but my child component was expecting to examine its new size.
The JavaDoc for onResize says "This method must be called whenever the
implementor's size has b
Revision: 7766
Author: j...@google.com
Date: Tue Mar 23 08:46:54 2010
Log: Added reference to permCount.txt
http://code.google.com/p/google-web-toolkit/source/detail?r=7766
Modified:
/wiki/DistributedBuilds.wiki
===
--- /wiki/DistributedBuilds.wikiTue
Thanks, Ray.
I agree it would be helpful to factor out the mock classes somewhere
reusable.
http://gwt-code-reviews.appspot.com/183801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscri
Reviewers: kjin,
Description:
Fix flaky MessageTransport test (again).
It is possible that an IOException can occur in this test. Also, get rid
of a redundant test.
Review by: k...@google.com
Please review this at http://gwt-code-reviews.appspot.com/250802/show
Affected files:
M
dev/core/
http://gwt-code-reviews.appspot.com/232801/diff/3001/4002
File bikeshed/src/com/google/gwt/collections/Assertions.java (right):
http://gwt-code-reviews.appspot.com/232801/diff/3001/4002#newcode24
bikeshed/src/com/google/gwt/collections/Assertions.java:24: assert
(index >= 0 && index < maxExclusi
Reviewers: jat,
Description:
Checkstyle fixes
Please review this at http://gwt-code-reviews.appspot.com/258801/show
Affected files:
M bikeshed/src/com/google/gwt/sample/expenses/gen/EmployeeRequestImpl.java
M bikeshed/src/com/google/gwt/sample/expenses/gen/ReportRequestImpl.java
M
user
Reviewers: Lex,
Description:
Remove an incorrect @Override of an interface method
Please review this at http://gwt-code-reviews.appspot.com/255802/show
Affected files:
M
dev/core/test/com/google/gwt/core/ext/linker/impl/SelectionScriptJavaScriptTest.java
Index:
dev/core/test/com/googl
Revision: 7768
Author: amitman...@google.com
Date: Tue Mar 23 06:32:25 2010
Log: Got rid of the MethodName enum. This change is on way to relying
solely on RequestFactory config
Patch by: amitmanjhi
Review by: rjrjr.
Review at http://gwt-code-reviews.appspot.com/255801
http://code.google.com
LGTM
http://gwt-code-reviews.appspot.com/255801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
LGTM
http://gwt-code-reviews.appspot.com/255802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
Reviewers: amitmanjhi,
Description:
Refactors ValueStore interface into something plausible and
implementable. Check point in ongoing work to implement
it.
In particular, EntityKey is now ValuesKey, and moves to the
valuestore package from requestfactory. Also, the Id and
Version notions are n
Reviewers: robertvawter,
Description:
Adds the -XdisableGflow flag.
Please review this at http://gwt-code-reviews.appspot.com/260801/show
Affected files:
M dev/core/src/com/google/gwt/dev/Precompile.java
M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java
M dev/core/src/com/google/gwt/
http://gwt-code-reviews.appspot.com/232801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
Bob, can you review this little patch?
It adds a flag -XdisableGflow that does exactly what it sounds like.
This would provide a safety valve in case there are any problems that
arise from the new gflow optimizer.
In a month or so we could reevaluate whether we need to keep the flag or
not.
htt
Just a thought.. but instead of a new flag, what if we redefined
"aggressive optimizations" to mean just GFlow, since all the other
optimizations have a lot of miles on them now. What do you think?
http://gwt-code-reviews.appspot.com/260801/show
--
http://groups.google.com/group/Google-Web-Tool
On Tue, Mar 23, 2010 at 2:24 PM, wrote:
> Just a thought.. but instead of a new flag, what if we redefined
> "aggressive optimizations" to mean just GFlow, since all the other
> optimizations have a lot of miles on them now. What do you think?
I like the idea of updating the aggressive optimiz
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This allows you to write
@external gwt-*;
or even
@external *;
instead of manually enumerating every class selector in a CssResource
input file
Please review this at http://gwt-code-reviews.appspot.com/243803/show
Affected files:
for a native method:
private native void registerJsFunction(String moduleName) /*-{
var self = this;
$wnd[moduleName] = function(arg) {
se...@wangzx.demo.client.testapp::callback(Lcom/google/gwt/core/
client/JavaScriptObject;)(arg);
The __static object is injected into the JavaScript namespace by the
development mode plugin upon startup and is used to dispatch calls to
static methods and accesses to static fields.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To un
Thanks, John. Dan, what do you think about the blacklist parts? Also,
would "RegexFilter" be a reasonable name for the pluggable version?
http://gwt-code-reviews.appspot.com/254801/diff/1/2
File user/src/com/google/gwt/precompress/Precompress.gwt.xml (right):
http://gwt-code-reviews.appspot.c
Hi Kevin,
You're right, it is different, but I don't think the actual test goes
through a different code path. Closing the entire server socket has the same
effect as just closing the output stream. See the docs on getInputStream and
getOutputStream here:
http://java.sun.com/javase/6/docs/api/jav
On Tue, Mar 23, 2010 at 2:48 PM, 王在祥 wrote:
> My problem is: Where is the entry point of the __static method? Is it
> a JavaScript function or a C native function?
As Bob mentioned, it is set by DevMode startup. This is the JSNI method
which is loaded to set it:
function __defineStatic(__arg0
Thanks, I find it.
On Mar 23, 7:01 pm, John Tamplin wrote:
> On Tue, Mar 23, 2010 at 2:48 PM, 王在祥 wrote:
> > My problem is: Where is the entry point of the __static method? Is it
> > a JavaScript function or a C native function?
>
> As Bob mentioned, it is set by DevMode startup. This is the JS
LGTM except for two URLs being changed.
http://gwt-code-reviews.appspot.com/258801/diff/1/21
File user/test/com/google/gwt/regexp/shared/RegExpTest.java (right):
http://gwt-code-reviews.appspot.com/258801/diff/1/21#newcode533
user/test/com/google/gwt/regexp/shared/RegExpTest.java:533: *
https:/
Looks almost good to me; I think you're non-invariant (but maybe
correct) if you remove the last element, so that needs a test, and you
may have been better off with getModuleName() returning null, depending
on what you're trying to test in this increment.
Can you edit the issue, to cc br...@goog
Revision: 7769
Author: amitman...@google.com
Date: Tue Mar 23 09:22:21 2010
Log: Use instance methods on a JSO instead of static methods.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
http://code.google.com/p/google-web-toolkit/source/detail?r=7769
Modified:
/trunk/bikeshed/src/com/goo
Revision: 7770
Author: r...@google.com
Date: Tue Mar 23 09:22:21 2010
Log: Remove an incorrect @Override of an interface method
Review at http://gwt-code-reviews.appspot.com/255802
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7770
Modified:
/trunk/d
Revision: 7771
Author: sp...@google.com
Date: Tue Mar 23 09:32:47 2010
Log: One-line fix to SelectionScript's fallback logic for
non-shardable subclasses.
Review at http://gwt-code-reviews.appspot.com/183801
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/de
http://gwt-code-reviews.appspot.com/254801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
LGTM
http://gwt-code-reviews.appspot.com/254801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
Revision: 7772
Author: rda...@google.com
Date: Tue Mar 23 10:48:28 2010
Log: Fix flaky MessageTransport test (again).
It is possible that an IOException can occur in this test. Also, get rid of
a redundant test.
Review by: k...@google.com
http://code.google.com/p/google-web-toolkit/source/det
http://gwt-code-reviews.appspot.com/232801/diff/25001/26007
File bikeshed/src/com/google/gwt/collections/MutableArray.java (right):
http://gwt-code-reviews.appspot.com/232801/diff/25001/26007#newcode112
bikeshed/src/com/google/gwt/collections/MutableArray.java:112: elems =
newElems;
On 2010/03/2
http://gwt-code-reviews.appspot.com/232801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
Amit and I decided this is a bit too speculative, especially since it
fails to address cases like "all employees." Continuing work to get
something functional going, and will kick off new review then.
http://gwt-code-reviews.appspot.com/259801/show
--
http://groups.google.com/group/Google-Web-To
On 2010/03/23 19:31:39, fabbott wrote:
Can you edit the issue, to cc mailto:br...@google.com vice unqualified
bruce?
Oh, I almost forgot. I have tried to fix the cc list but whatever I
enter when I edit the issue is lost in the ether.
http://gwt-code-reviews.appspot.com/232801/show
--
http://
LGTM.
Nice idea.
http://gwt-code-reviews.appspot.com/176802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as t
LGTM
http://gwt-code-reviews.appspot.com/243803/diff/1/2
File user/src/com/google/gwt/resources/css/ExternalClassesCollector.java
(right):
http://gwt-code-reviews.appspot.com/243803/diff/1/2#newcode53
user/src/com/google/gwt/resources/css/ExternalClassesCollector.java:53:
matchAll = true;
retur
LGTM
http://gwt-code-reviews.appspot.com/201801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
Revision: 7773
Author: amitman...@google.com
Date: Tue Mar 23 12:24:31 2010
Log: 1. Removed the ServerType annotation that is not currently used.
2. Re-introduced an Enum type that specifies the domain class, domain method
and the return type of objects returned on invoking the domain method. This
Revision: 7774
Author: b...@google.com
Date: Tue Mar 23 12:35:23 2010
Log: Add tail-globs to CssResource's @external declarations.
http://gwt-code-reviews.appspot.com/243803
Suggested by: gak
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=7774
Added:
Revision: 7775
Author: sco...@google.com
Date: Tue Mar 23 12:37:23 2010
Log: Only setup prototypes on constructors which are the direct target of
new operations.
This is a simple change to removes the need to install a prototype on
constructors which are merely used as targets of super()/thi
Mostly LG, some comments. Also mostly agree with Lex's comments, too.
I called out a couple in particular that are sort of style questions
where I agree.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002
File dev/core/src/com/google/gwt/core/ext/linker/SoftPermutation.java
(right):
h
Reviewers: mmendez,
Description:
RunStyleSelenium uses Selenium.getTitle() as a keep alive to check that
the GWT host can communicate with the selenium server running on the
client. However, getTitle() sometimes returns a Permision Denied
SeleniumException in IE if we happen to request the title
Revision: 7776
Author: sco...@google.com
Date: Tue Mar 23 14:56:21 2010
Log: Allow static-dispatch style JS .call invocations to be inlined.
This is particularly relevant because super()/this() calls get translated
as .call() ops, and this patch lets us inline them into the calling
constructo
Reviewers: Ray Ryan, amitmanjhi,
Description:
Adds detail places to the scaffolding app
Please review this at http://gwt-code-reviews.appspot.com/251801/show
Affected files:
A bikeshed/src/com/google/gwt/app/place/GoToPlace.java
M bikeshed/src/com/google/gwt/app/place/PlacePicker.java
M
50 matches
Mail list logo
