http://gwt-code-reviews.appspot.com/331802/diff/9001/10001
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/331802/diff/9001/10001#newcode1266
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1266: }
else if (classNa
LGTM
http://gwt-code-reviews.appspot.com/358801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/358801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/04/17 00:33:36, unnurg wrote:
A couple of things to note about this review
Open issues
- Where should the Impl classes (and their associated gwt.xml file) go?
This is currently in gwt.logging.impl, but the JRE classes themselves
are in core, so maybe these should go somewhere in core? N
Reviewers: Dan Rice,
Description:
Beginnings of GWT implementation of java.util.logging
Review by: r...@google.com
Please review this at http://gwt-code-reviews.appspot.com/341803/show
Affected files:
M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
M samples/hello/src/com/google/gw
Submitted after desk review w/amitmanjhi, who I'm sure will chime in
with LGTM soon now.
http://gwt-code-reviews.appspot.com/344804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Apr 16, 2010 at 4:51 PM, wrote:
> Done. Basically it's a complication becuase we use different
> classloaders to load the script-only classes vs. the non script-only
> ones. I don't understand why it was chosen as it imposes extra
> constraints on how the @GwtScriptOnly class can be use
All done. Submitting.
http://gwt-code-reviews.appspot.com/318802/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
(right):
http://gwt-code-reviews.appspot.com/318802/diff/1/2#newcode619
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java:619:
CfgSw
LGTM
http://gwt-code-reviews.appspot.com/318802/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
(right):
http://gwt-code-reviews.appspot.com/318802/diff/1/2#newcode619
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java:619:
CfgSwitchGotoNode goto
Reviewers: Lex,
Description:
CFG: Always jumping to first case statement
Please review this at http://gwt-code-reviews.appspot.com/318802/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
A
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgSwit
LGTM
http://gwt-code-reviews.appspot.com/357801/diff/1/5
File user/super/com/google/gwt/emul/java/util/Collections.java (right):
http://gwt-code-reviews.appspot.com/357801/diff/1/5#newcode121
user/super/com/google/gwt/emul/java/util/Collections.java:121: return
(item == element) || (item != nul
LGTM with a couple of questions
http://gwt-code-reviews.appspot.com/331802/diff/9001/10001
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/331802/diff/9001/10001#newcode1266
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoa
Reviewers: kathrin,
Description:
Ensure static initialization is atomic (found by findbugs)
Please review this at http://gwt-code-reviews.appspot.com/341802/show
Affected files:
M user/src/com/google/gwt/user/client/Cookies.java
Index: user/src/com/google/gwt/user/client/Cookies.java
=
Reviewers: jat,
Description:
Implement RPC custom serialization for Collections.singletonList()
Please review this at http://gwt-code-reviews.appspot.com/357801/show
Affected files:
M
user/src/com/google/gwt/user/client/rpc/core/java/lang/Long_CustomFieldSerializer.java
M
user/src/com/
Reviewers: jgw,
Description:
Implement a selection column, sortable columns, and row hovering in
MailRecipe
Please review this at http://gwt-code-reviews.appspot.com/356801/show
Affected files:
A bikeshed/src/com/google/gwt/bikeshed/cells/client/ClickableTextCell.java
M bikeshed/src/com/go
Reviewers: amitmanjhi,
Description:
Dramatically simplifies public API of RequestFactory and
ValueStore. Values<> interface and ValuesKey are gone,
replaced by bean-like Record interfaces.
Also eliminates Visitor pattern, falling back on various
instanceof checks. We'll likely need something li
Ok, I'll just save you some time... :) but will first check if everything is
ok once the dependencies are replaced...
On Fri, Apr 16, 2010 at 10:46 PM, Freeland Abbott wrote:
> I think that's correct, but we historically have been pretty lazy about
> updating our dependencies...
>
>
> On Fri, Apr
I think that's correct, but we historically have been pretty lazy about
updating our dependencies...
On Fri, Apr 16, 2010 at 4:39 PM, Marko Vuksanovic wrote:
> One more question - why aren't JUnit 4 libraries used? I think junit4
> supports junit3 test style? Am I right?
>
>
> On Fri, Apr 16, 20
One more question - why aren't JUnit 4 libraries used? I think junit4
supports junit3 test style? Am I right?
On Fri, Apr 16, 2010 at 10:12 PM, Marko Vuksanovic <
markovuksano...@gmail.com> wrote:
> I like challenges :):)
>
>
> On Fri, Apr 16, 2010 at 10:09 PM, John Tamplin wrote:
>
>> On Fri,
I like challenges :):)
On Fri, Apr 16, 2010 at 10:09 PM, John Tamplin wrote:
> On Fri, Apr 16, 2010 at 3:45 PM, Marko Vuksanovic <
> markovuksano...@gmail.com> wrote:
>
>> I just noticed that there is HasAnnotations interface... I might try
>> putting that to use...
>>
>> On Apr 16, 9:38 pm, Ma
On Fri, Apr 16, 2010 at 3:45 PM, Marko Vuksanovic wrote:
> I just noticed that there is HasAnnotations interface... I might try
> putting that to use...
>
> On Apr 16, 9:38 pm, Marko Vuksanovic
> wrote:
> > Well I've been looking at the existing code and I have seen that
> > JClassType implement
I just noticed that there is HasAnnotations interface... I might try
putting that to use...
On Apr 16, 9:38 pm, Marko Vuksanovic
wrote:
> Well I've been looking at the existing code and I have seen that
> JClassType implements getMethods(). Then I would be able to check if a
> method has Annotati
Well I've been looking at the existing code and I have seen that
JClassType implements getMethods(). Then I would be able to check if a
method has Annotation applied - using isAnnotationPresent() method.
I am not sure how to check if a method has an annotation applied and
not to use the refelectio
On Fri, Apr 16, 2010 at 1:26 PM, Marko Vuksanovic wrote:
> Basically, I'm trying to figure out how to implement Junit 4 into GWT.
> For the beginning I am interested on how to apply some annotation to
> some method in GWTTestCase and somehow detect, in GWTTestCase
> translatable code, that a spec
Reviewers: jgw,
Message:
Joel,
This review isn't super high-priority and is kind of long. I got a
more than just a bit irritated at how hard it was to try to make what
should have been a simple change to ImageResourceGenerator and decided
that the code needed a rework. If you think that someo
Basically, I'm trying to figure out how to implement Junit 4 into GWT.
For the beginning I am interested on how to apply some annotation to
some method in GWTTestCase and somehow detect, in GWTTestCase
translatable code, that a specific method has some annotation applied.
The idea is to apply some
On Fri, Apr 16, 2010 at 12:05 PM, Marko Vuksanovic <
markovuksano...@gmail.com> wrote:
> Shouldn't GWTTestCase extend JClassType somehow?
>
I'm not sure what you are referring to -- GWTTestCase is for running GWT
tests, and JClassType is a TypeOracle type representing a non-primitive Java
type.
Shouldn't GWTTestCase extend JClassType somehow?
-Marko
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
http://gwt-code-reviews.appspot.com/323801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hey John, I took an initial look but I'd like you to look through this
also.
http://gwt-code-reviews.appspot.com/331802/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/331802/diff/1/2#newcode374
dev/core/src/com/google/g
30 matches
Mail list logo
