Amit, after you left I did one more not-small change,
introducing AbstractRecordEditActivity. I'm submitting this anyway, but
could you take a look at that extra bit?
On Tue, May 4, 2010 at 4:10 PM, wrote:
> From a desk review with Amit:
>
> the generated code is only using getText(), but it's s
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8048
Author: amitman...@google.com
Date: Tue May 4 15:09:04 2010
Log: The TOKEN on a Record class is now a field instead of an annotation.
The field
can be generated by a JPA-savvy tool. The TOKEN, in addition to being used
for
SYNC requests, will also be used for DeltaValueStore.
Reviewers: Ray Ryan,
Description:
The TOKEN on a Record class is now a field instead of an annotation. The
field
can be generated by a JPA-savvy tool. The TOKEN, in addition to being
used for
SYNC requests, will also be used for DeltaValueStore.create(..) method
Patch by: amitmanjhi
Review by:
LG, but having removed all the of the public API delegation makes me
slightly nervous. You're sure this is ok? If those calls are no-ops in
web mode, you could explicitly model it that way instead of letting
client code get access to the server log manager super.
http://gwt-code-reviews.appspo
From a desk review with Amit:
the generated code is only using getText(), but it's supposed to prefer
getValue()
ScaffoldMasterActivities should be made reusable
Need to verify that ScaffoldMobile hasn't been damaged. It still works,
but does it work right?
Seeing double-deregistration on onSt
Revision: 8047
Author: sp...@google.com
Date: Tue May 4 15:53:16 2010
Log: Cherry picking r8045 from trunk.
This has the constants flow analyzer use top as the default and
initial value for all variable assumptions.
http://code.google.com/p/google-web-toolkit/source/detail?r=8047
Added:
/bra
Revision: 8046
Author: sp...@google.com
Date: Tue May 4 15:52:11 2010
Log: Cherry picking r8041 from trunk.
This fixes a bug where fall though in switch statements was not
handled correctly.
http://code.google.com/p/google-web-toolkit/source/detail?r=8046
Modified:
/branches/snapshot-2010.03
http://gwt-code-reviews.appspot.com/437801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/05/04 21:59:45, unnurg wrote:
OK - it turns out that delegating to another LogManager for the server
code is not working correctly. Specifically, there's something in the
configurations that isn't getting passed on to the serverLogManager. I
spent about 3 hours trying to figure this out
http://gwt-code-reviews.appspot.com/437801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8045
Author: aizat...@google.com
Date: Tue May 4 10:40:00 2010
Log: Introducing lattice TOP for constants. Making it starting value.
Review at http://gwt-code-reviews.appspot.com/436801
http://code.google.com/p/google-web-toolkit/source/detail?r=8045
Added:
/trunk/dev/core/test/co
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003
File /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java
(right):
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode33
/dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:33:
protected static class LogMa
Revision: 8044
Author: jlaba...@google.com
Date: Tue May 4 10:22:18 2010
Log: Adding Departments to Employees and updating the ExpenseTree so it
loads employees correctly. Open icon now turns to a loading icon while
loading.
http://code.google.com/p/google-web-toolkit/source/detail?r=8044
LGTM
http://gwt-code-reviews.appspot.com/436801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/436801/diff/1/3
File
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/constants/ConstantsAssumption.java
(right):
http://gwt-code-reviews.appspot.com/436801/diff/1/3#newcode157
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/constants/ConstantsAssumption.java:157
http://gwt-code-reviews.appspot.com/436801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8043
Author: gwt.mirror...@gmail.com
Date: Tue May 4 13:12:58 2010
Log: added the validation-api jar reference in ant so that bikeshed can be
built
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Review at http://gwt-code-reviews.appspot.com/460801
http://code.google.com/p/goo
Reviewers: Ray Ryan,
Description:
added the validation-api jar reference in ant so that bikeshed can be
built
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/460801/show
Affected files:
M trunk/bikeshed/build.xml
Index: trunk/b
Revision: 8042
Author: sp...@google.com
Date: Tue May 4 08:54:13 2010
Log: Undo the collapse-all-permutations in JUnit.gwt.xml for now.
Review at http://gwt-code-reviews.appspot.com/457801
Review by: mmen...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8042
Modified:
Revision: 8041
Author: gwt.mirror...@gmail.com
Date: Tue May 4 12:28:01 2010
Log: CFG: fixing case fallthrough.
Review at http://gwt-code-reviews.appspot.com/434801
http://code.google.com/p/google-web-toolkit/source/detail?r=8041
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/gflow
Revision: 8040
Author: gwt.mirror...@gmail.com
Date: Mon May 3 10:39:37 2010
Log: Fixing division by zero while evaluating constant expression.
Review at http://gwt-code-reviews.appspot.com/435801
http://code.google.com/p/google-web-toolkit/source/detail?r=8040
Modified:
/trunk/dev/core/src
Revision: 8039
Author: bd...@google.com
Date: Mon May 3 08:11:51 2010
Log: Fix incorrect units in TabLayoutPanel example (was PX should be
EM).
Gerrit review: http://gwt-code-reviews.appspot.com/329802/show
Issue: http://code.google.com/p/google-web-toolkit/issues/detail?id=4851
Review by: j...
Revision: 8038
Author: sp...@google.com
Date: Tue May 4 12:18:57 2010
Log: Cherry picking Rietveld issue 457801 . This undoes the
permutation-collapsing of JUnit.gwt.xml for now.
http://code.google.com/p/google-web-toolkit/source/detail?r=8038
Modified:
/branches/snapshot-2010.03.29-r7809/us
Thanks, I will try that. This is a much nicer solution compared to the
one I presented.
/Marko
On 5/4/10, Lex Spoon wrote:
> On Tue, May 4, 2010 at 12:25 PM, Marko Vuksanovic > wrote:
>
>> Hi Lex,
>> The first solution seems interesting... could you please provide a code
>> snippet just to get m
On Tue, May 4, 2010 at 12:25 PM, Marko Vuksanovic wrote:
> Hi Lex,
> The first solution seems interesting... could you please provide a code
> snippet just to get me started...
> Did you mean something like
>
> Thread.currentThread().setContextClassLoader(urlClassloader);
>
>
Exactly. Where urlC
Revision: 8037
Author: jlaba...@google.com
Date: Tue May 4 08:08:32 2010
Log: Adding option to highlight a search term in text cells.
http://code.google.com/p/google-web-toolkit/source/detail?r=8037
Added:
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/highlightIcon.png
LGTM
Let's circle back on this optimization that we have undone once we
stabilize.
http://gwt-code-reviews.appspot.com/457801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: mmendez,
Description:
Undo the collapse-all-permutations in JUnit.gwt.xml for now.
Review by: mmen...@google.com
Please review this at http://gwt-code-reviews.appspot.com/457801/show
Affected files:
M user/src/com/google/gwt/junit/JUnit.gwt.xml
Index: user/src/com/google/gwt/jun
Revision: 8036
Author: unn...@google.com
Date: Tue May 4 07:54:20 2010
Log: Rollback of issue 438801 (Implement GWT logging)
Seems to be causing an error with computePropValue
http://code.google.com/p/google-web-toolkit/source/detail?r=8036
Deleted:
/branches/2.1/user/src/com/google/gwt/loggin
LGTM, just a few style nits.
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003
File /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java
(right):
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode33
/dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:33
Hi Lex,
The first solution seems interesting... could you please provide a code
snippet just to get me started...
Did you mean something like
Thread.currentThread().setContextClassLoader(urlClassloader);
List moduleNames = new ArrayList();
moduleNames.add("com.hypersimple.HyperSimple");
File work
On Mon, May 3, 2010 at 7:36 AM, Marko Vuksanovic
wrote:
> I solved the problem... This had nothing to do with the GWT. The
> problem was with adding a folder to java class path dynamically.
> Although at first I thought I had done it correctly, it turned out
> that that's a little tricky...
>
> Fo
Revision: 8035
Author: jlaba...@google.com
Date: Tue May 4 05:10:51 2010
Log: Adds the $wnd scope to calls to JSON.stringify().
http://code.google.com/p/google-web-toolkit/source/detail?r=8035
Modified:
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/client/impl/ClientRequestHelper.
Revision: 8034
Author: jlaba...@google.com
Date: Tue May 4 04:39:38 2010
Log: Work around for a GWT logging bug.
http://code.google.com/p/google-web-toolkit/source/detail?r=8034
Modified:
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ExpensesCommon.gwt.xml
=
Revision: 8033
Author: rj...@google.com
Date: Mon May 3 17:00:59 2010
Log: GWT code must be compatible with JDK 1.5, which did not allow
@Override on interface method implementations.
http://code.google.com/p/google-web-toolkit/source/detail?r=8033
Modified:
/branches/2.1/user/src/com/google/g
Revision: 8031
Author: amitman...@google.com
Date: Mon May 3 15:39:10 2010
Log: Moved the showErrors method into the generator.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Review at http://gwt-code-reviews.appspot.com/451801
http://code.google.com/p/google-web-toolkit/source/detail?r=8
Revision: 8030
Author: amitman...@google.com
Date: Mon May 3 13:28:30 2010
Log: Added server side validation using JSR 303. On the server side, one
can now do
validations before persisting an entity. Also, added a callback for sync
request so that any validation errors can be shown on the clie
Revision: 8029
Author: jlaba...@google.com
Date: Mon May 3 12:44:17 2010
Log: Fixing a bug in CellTable where it can't render specific rows in
WebKit based browsers.
http://code.google.com/p/google-web-toolkit/source/detail?r=8029
Modified:
/branches/2.1/bikeshed/src/com/google/gwt/bikesh
Reviewers: jgw,
Description:
A JS overlay type to handle heterogeneous arrays
Please review this at http://gwt-code-reviews.appspot.com/453801/show
Affected files:
A /user/src/com/google/gwt/core/client/JsArrayMixed.java
M /user/test/com/google/gwt/core/CoreSuite.java
A /user/test/com/go
40 matches
Mail list logo
