[gwt-contrib] Second attempted fix for issue 4532. This time, we revert the IE7 layout (issue628802)

2010-06-30 Thread jgw
Reviewers: jlabanca, Description: Second attempted fix for issue 4532. This time, we revert the IE7 layout implementation back all the way to IE6. IE7's just too quirky to rely directly on its implementation of top/left/right/bottom/width/height CSS layout. Please review this at

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-30 Thread rice
LGTM http://gwt-code-reviews.appspot.com/636801/diff/6001/7007 File /bikeshed/test/com/google/gwt/collections/MutableSetAdapterTest.java (right): http://gwt-code-reviews.appspot.com/636801/diff/6001/7007#newcode162 /bikeshed/test/com/google/gwt/collections/MutableSetAdapterTest.java:162:

[gwt-contrib] Re: Second attempted fix for issue 4532. This time, we revert the IE7 layout (issue628802)

2010-06-30 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/628802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8336 committed - Cleaned a stray 'This' at the end of a sentence

2010-06-30 Thread codesite-noreply
Revision: 8336 Author: rchan...@google.com Date: Wed Jun 30 08:49:35 2010 Log: Cleaned a stray 'This' at the end of a sentence http://code.google.com/p/google-web-toolkit/source/detail?r=8336 Modified: /wiki/LightweightCollections.wiki === ---

[gwt-contrib] [google-web-toolkit] r8337 committed - Edited wiki page through web user interface.

2010-06-30 Thread codesite-noreply
Revision: 8337 Author: rchan...@google.com Date: Wed Jun 30 08:54:04 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=8337 Modified: /wiki/LightweightCollections.wiki === ---

[gwt-contrib] [google-web-toolkit] r8338 committed - Edited wiki page through web user interface.

2010-06-30 Thread codesite-noreply
Revision: 8338 Author: rchan...@google.com Date: Wed Jun 30 09:07:35 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=8338 Modified: /wiki/LightweightCollections.wiki === ---

[gwt-contrib] [google-web-toolkit] r8339 committed - Second attempted fix for issue 4532. This time, we revert the IE7 layo...

2010-06-30 Thread codesite-noreply
Revision: 8339 Author: j...@google.com Date: Wed Jun 30 06:04:21 2010 Log: Second attempted fix for issue 4532. This time, we revert the IE7 layout implementation back all the way to IE6. IE7's just too quirky to rely directly on its implementation of top/left/right/bottom/width/height CSS

[gwt-contrib] Re: Optimize JsFunctionClusterer with faster edit distance algorithms (issue669801)

2010-06-30 Thread spoon
Thanks, Alex! Just nits: - Let's attribute the original author(s) in the change description - Let's put the edit-distance classes in a subpackage of com.google.gwt.dev.util. Perhaps simply com.google.gwt.dev.util.editdistance ? http://gwt-code-reviews.appspot.com/669801/diff/1/7 File

[gwt-contrib] Restore rolled-back change r8329, now with a much faster test case that runs in IE (issue654802)

2010-06-30 Thread rice
Reviewers: jat, Description: Restore rolled-back change r8329, now with a much faster test case that runs in IE Please review this at http://gwt-code-reviews.appspot.com/654802/show Affected files: M user/src/com/google/gwt/core/client/JsonUtils.java M

[gwt-contrib] Remove a JDK-1.6ism (issue670801)

2010-06-30 Thread rice
Reviewers: unnurg, Description: Remove a JDK-1.6ism Please review this at http://gwt-code-reviews.appspot.com/670801/show Affected files: M user/src/com/google/gwt/logging/client/SimpleRemoteLogHandler.java Index: user/src/com/google/gwt/logging/client/SimpleRemoteLogHandler.java

[gwt-contrib] Re: Remove a JDK-1.6ism (issue670801)

2010-06-30 Thread unnurg
LGTM Thanks! I thought that I set up my eclipse to use 1.5... will take another look. http://gwt-code-reviews.appspot.com/670801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-30 Thread rchandia
http://gwt-code-reviews.appspot.com/636801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-30 Thread rchandia
http://gwt-code-reviews.appspot.com/636801/diff/19001/17005 File /bikeshed/src/com/google/gwt/collections/MutableSet.java (right): http://gwt-code-reviews.appspot.com/636801/diff/19001/17005#newcode233 /bikeshed/src/com/google/gwt/collections/MutableSet.java:233: // TODO Consider allow

[gwt-contrib] [google-web-toolkit] r8341 committed - Remove a JDK-1.6ism...

2010-06-30 Thread codesite-noreply
Revision: 8341 Author: r...@google.com Date: Wed Jun 30 08:49:02 2010 Log: Remove a JDK-1.6ism Review at http://gwt-code-reviews.appspot.com/670801 Review by: unn...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8341 Modified:

[gwt-contrib] Re: Fix checkstyle problems (issue671801)

2010-06-30 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/671801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread rice
LGTM http://gwt-code-reviews.appspot.com/645802/diff/1/2 File user/src/com/google/gwt/user/client/ui/Tree.java (right): http://gwt-code-reviews.appspot.com/645802/diff/1/2#newcode1002 user/src/com/google/gwt/user/client/ui/Tree.java:1002: root = new TreeItem() { Is there a way to avoid

[gwt-contrib] [google-web-toolkit] r8342 committed - Set and MutableSet. Bytecode implementation....

2010-06-30 Thread codesite-noreply
Revision: 8342 Author: rchan...@google.com Date: Wed Jun 30 08:59:28 2010 Log: Set and MutableSet. Bytecode implementation. Review at http://gwt-code-reviews.appspot.com/636801 Review by: r...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8342 Added:

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread jlabanca
Updated based on rice's comments. I merged the root changes into TreeItem. http://gwt-code-reviews.appspot.com/645802/diff/1/2 File user/src/com/google/gwt/user/client/ui/Tree.java (right): http://gwt-code-reviews.appspot.com/645802/diff/1/2#newcode1002

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

2010-06-30 Thread codesite-noreply
Comment by br...@google.com: @mmoossen: As the name hints, there are significantly different design goals for these collections than for the Guava collections. These collections are meant to be the guilt-free primitives: the lightest conceivable way to implement basic collections on top of

[gwt-contrib] Another approach of HTML templating in GWT

2010-06-30 Thread Radek
I would like to present a different approach to the HTML templating: http://gwtapp.org/ It's runtime HTML templating instead of compile time like UIBinder. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] More flexibility for setting the paging size of CellList

2010-06-30 Thread Paul Schwarz
I posted this in the GWT users' group: Dynamically set page size of CellList http://groups.google.com/group/google-web-toolkit/browse_frm/thread/f1399c54613890b3 aside I had a complex data presentation scenario to handle (complex because the very left hand column contains a row span type look

[gwt-contrib] GWT 2.0.4 is now available

2010-06-30 Thread Chris Ramsdale
Recently Apple released Safari 5, which included a bug where non- integral right-shifts were not being evaluated properly. There were several reports, both internally and externally, of GWT-based applications unexpectedly crashing when running in Safari 5 (including Google Wave). Upon further

[gwt-contrib] [google-web-toolkit] r8345 committed - Update the codelab to trigger exceptions and make the section on trigg...

2010-06-30 Thread codesite-noreply
Revision: 8345 Author: unn...@google.com Date: Wed Jun 30 12:29:28 2010 Log: Update the codelab to trigger exceptions and make the section on triggering server and shared logging more clear. Also a few changes to ensure that disabling logging works correctly in the codelab, and a static

[gwt-contrib] Update sample to use the latest features (issue672801)

2010-06-30 Thread unnurg
Reviewers: fredsa, Description: Update sample to use the latest features Please review this at http://gwt-code-reviews.appspot.com/672801/show Affected files: M samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.java M

[gwt-contrib] Add WebSocket API (issue646803)

2010-06-30 Thread jat
Reviewers: jgw, markovuksanovic, Description: Add WebSocket API Patch by: markovuksanovic Review by: jat, jgw Please review this at http://gwt-code-reviews.appspot.com/646803/show Affected files: A user/src/com/google/gwt/core/client/RawWebSocket.java A

[gwt-contrib] Re: Add WebSocket API (issue646803)

2010-06-30 Thread jat
This isn't ready to submit yet, just wanted to show the changes I was making based on discussions with Joel and JohnL about how the events should work. I think the open events are broken as designed (please correct me if I am wrong), and it would be pretty expensive for us to try and work around

Re: [gwt-contrib] Another approach of HTML templating in GWT

2010-06-30 Thread Miroslav Pokorny
Hiho Taking a look at the demo its not clear what it actually does and does not do. Please elaborate. tya mP On Wed, Jun 30, 2010 at 7:27 AM, Radek r.oles...@gmail.com wrote: I would like to present a different approach to the HTML templating: http://gwtapp.org/ It's runtime HTML