Re: [gwt-contrib] Re: Adds Java classes for JSON serialization/deserialization to complement (issue696801)

2010-07-16 Thread Ray Ryan
It could still be useful to RequestFactoryServlet as-is, so landing it in gwt-servlet might be the thing to do. Ray, can you weigh in? On Jul 15, 2010 8:12 PM, Scott Blum sco...@google.com wrote: The goal of sharing a JSON lib across client-server seems great to me. I think super-source is the

[gwt-contrib] Re: small changes to AjaxSampleLoader (issue697801)

2010-07-16 Thread zundel
The SimpleAjaxloader.html file is still needed for the 'mvn install' goal - it get put inside the .war file. http://gwt-code-reviews.appspot.com/697801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread t . broyer
LGTM (awesome! next step: integration with History ;-) ) http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62

[gwt-contrib] RR: Customization of child element handling in UiBinder

2010-07-16 Thread Ray Ryan
Details in this Wave: https://wave.google.com/wave/waveref/googlewave.com/w+WIuSfOKhA rjrjr -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread bobv
Couple of questions. http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode73

[gwt-contrib] [google-web-toolkit] r8384 committed - Adds design time hooks to UiBinder for GWT Designer, or any other tool...

2010-07-16 Thread codesite-noreply
Revision: 8384 Author: rj...@google.com Date: Thu Jul 15 04:01:13 2010 Log: Adds design time hooks to UiBinder for GWT Designer, or any other tool that can find a use for them. See discussion in

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62 user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:62: deltas = null; //

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread bobv
LGTM I'm inclined to say that the multiple cancels case results in arbitrary output, since that's all we've offered internally for quite a while and no one has complained. Ok. Seems like following your GWT.create suggestion, and the existence of the delegate hook itself are enough

[gwt-contrib] Re: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the ... (issue689801)

2010-07-16 Thread jlabanca
committed as r8383 http://gwt-code-reviews.appspot.com/689801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CellTable#onBrowserEvent finds the TD element in which an event occurred, and then assumes that ... (issue695801)

2010-07-16 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/695801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds Java classes for JSON serialization/deserialization to complement (issue696801)

2010-07-16 Thread zundel
http://gwt-code-reviews.appspot.com/696801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds Java classes for JSON serialization/deserialization to complement (issue696801)

2010-07-16 Thread zundel
Here is the API moved to a new package. I updated some javadoc too. http://gwt-code-reviews.appspot.com/696801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8385 committed - CellTable#onBrowserEvent finds the TD element in which an event occurr...

2010-07-16 Thread codesite-noreply
Revision: 8385 Author: jlaba...@google.com Date: Fri Jul 16 07:18:14 2010 Log: CellTable#onBrowserEvent finds the TD element in which an event occurred, and then assumes that the TD has a parent TR and TBODY. This is normally a safe assumption because browsers only fire native events on

[gwt-contrib] Re: CellTable#onBrowserEvent finds the TD element in which an event occurred, and then assumes that ... (issue695801)

2010-07-16 Thread jlabanca
committed as r8385 http://gwt-code-reviews.appspot.com/695801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8386 committed - Puts PlaceController in the business of showing the user...

2010-07-16 Thread codesite-noreply
Revision: 8386 Author: rj...@google.com Date: Fri Jul 16 07:47:49 2010 Log: Puts PlaceController in the business of showing the user Are you sure prompts on place change cancellation, per Thomas Broyer's suggestion

[gwt-contrib] [google-web-toolkit] r8387 committed - Adds UiBinder support for Grid...

2010-07-16 Thread codesite-noreply
Revision: 8387 Author: rj...@google.com Date: Fri Jul 16 08:13:31 2010 Log: Adds UiBinder support for Grid Patch by markovuksano...@gmail.com Review by rj...@google.com http://gwt-code-reviews.appspot.com/154810 Review by: robertvaw...@google.com

[gwt-contrib] Re: UiBinder tweaks for GWT Designer (issue693801)

2010-07-16 Thread Ray Ryan
r8384 On Fri, Jul 16, 2010 at 11:59 AM, Ray Ryan rj...@google.com wrote: Yup, the svn mirror broke. We're fixing it right now. On Thu, Jul 15, 2010 at 7:48 PM, Ray Ryan rj...@google.com wrote: It was committed, and should have hit svn by now. I can't check that system right now, but can

[gwt-contrib] [google-web-toolkit] r8388 committed - Fixing CFG handling of labelled breaks inside the switch....

2010-07-16 Thread codesite-noreply
Revision: 8388 Author: gwt.mirror...@gmail.com Date: Fri Jul 16 11:42:23 2010 Log: Fixing CFG handling of labelled breaks inside the switch. Review by: sp...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8388 Modified:

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

2010-07-16 Thread Ray Ryan
r8387 On Wed, Jul 14, 2010 at 12:32 PM, rj...@google.com wrote: Looks good, will submit On 2010/07/12 20:14:38, markovuksanovic wrote: Some error checking changes... http://gwt-code-reviews.appspot.com/154810/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
r8386 http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8389 committed - Reverts r8387 Adds UiBinder support for Grid

2010-07-16 Thread codesite-noreply
Revision: 8389 Author: rj...@google.com Date: Fri Jul 16 09:26:04 2010 Log: Reverts r8387 Adds UiBinder support for Grid http://code.google.com/p/google-web-toolkit/source/detail?r=8389 Deleted: /trunk/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

2010-07-16 Thread Ray Ryan
Reverted, breaks Grid subclasses. Oops, working on the fix. On Fri, Jul 16, 2010 at 2:42 PM, Ray Ryan rj...@google.com wrote: r8387 On Wed, Jul 14, 2010 at 12:32 PM, rj...@google.com wrote: Looks good, will submit On 2010/07/12 20:14:38, markovuksanovic wrote: Some error checking