On 2010/07/22 23:42:08, scottb wrote:
I just now took a look, and was curious about the rationale for some
of the API
changes. In particular, I'm trying to figure out the value of having
to do the
extra '.get()' at all call sites, vs. having static methods that do
the '.get()'
internally.
We've tried to get rid of the document.write() tricks before, but with no
success. There's always some squirrely case that crops on (especially on IE)
that's forced us to put them back in. There are also a couple of specific
corner cases that rely on document.write(), which would need to be
The multiple files in user/test with names ending in .orig should
probably be excluded.
On 2010/07/22 22:17:53, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/710801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Gah! Where do those keep coming from!?
On Fri, Jul 23, 2010 at 10:34 AM, amitman...@google.com wrote:
The multiple files in user/test with names ending in .orig should
probably be excluded.
On 2010/07/22 22:17:53, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/710801/show
--
There is a lot of copying going here which is bad. Would this be better
done by adding just the new classes to the DynaTable sample, and having
another gwt.xml in the DynaTable sample. The two gwt.xml could then pull
just the subset of files they require.
On Fri, Jul 23, 2010 at 1:53 PM, amitman...@google.com wrote:
There is a lot of copying going here which is bad. Would this be better
done by adding just the new classes to the DynaTable sample, and having
another gwt.xml in the DynaTable sample. The two gwt.xml could then pull
just the
Are the .orig files coming from git add -A? You could add that
pattern to your .git/info/exclude.
Will the Property API be removed?
http://gwt-code-reviews.appspot.com/710801/diff/4001/5001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
LGTM
Just a couple of nits.
http://gwt-code-reviews.appspot.com/706802/diff/1/2
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/2#newcode87
I'd rather keep the two samples completely separate, even though that
entails a lot of dup code. If I have one app that does both systems, it's
really hard to look at the code and know what is relevant to you and what
isn't. And it's not like DynaTable gets a lot of changes.
On Fri, Jul 23, 2010
Working on the others, but figured I'd fire these questions back at you
while I'm working on them
http://gwt-code-reviews.appspot.com/706802/diff/1/6
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java
(right):
http://gwt-code-reviews.appspot.com/710801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ready for re-review
http://gwt-code-reviews.appspot.com/710801/diff/4001/5001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
http://gwt-code-reviews.appspot.com/710801/diff/4001/5001#oldcode50
http://gwt-code-reviews.appspot.com/706802/diff/1/2
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/2#newcode87
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java:87:
http://gwt-code-reviews.appspot.com/706802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Looks good enough for a first pass. I'll follow up with converting the
UI to UiBinder in preparation for wiring up the editor stuff.
http://gwt-code-reviews.appspot.com/710801/diff/18001/19001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
http://gwt-code-reviews.appspot.com/710801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Done, submitting.
http://gwt-code-reviews.appspot.com/710801/diff/18001/19001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
http://gwt-code-reviews.appspot.com/710801/diff/18001/19001#oldcode50
http://gwt-code-reviews.appspot.com/651803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
18 matches
Mail list logo
