http://gwt-code-reviews.appspot.com/714801/diff/3001/4001
File user/src/com/google/gwt/resources/client/ClientBundle.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001#newcode2
user/src/com/google/gwt/resources/client/ClientBundle.java:2: *
Copyright 2010 Google Inc.
Copyrig
Revision: 8405
Author: to...@google.com
Date: Thu Jul 22 05:27:33 2010
Log: Adds BinaryTypeBinding from JDT 3.4.2 in preparation for changes.
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8405
Added:
/trunk/dev/core/src/org/eclipse/jdt/internal/compi
Revision: 8406
Author: jlaba...@google.com
Date: Thu Jul 22 12:01:10 2010
Log: Fixing WindowImplIE.getQueryString to look for the first occurence of
a ? instead of the last. Similarly fixing WindowImplIE.getHash to look for
the first occurence of # instead of the last. This makes IE consiste
On Fri, Jul 23, 2010 at 7:51 AM, wrote:
> I agree that going back to static methods could save a little bit of
> typing, but nevertheless, it is a common pattern for a logging class
> (j.u.logging, log4j). Also, if it is keystrokes that bother you, you
> could save a lot of typing in the invocat
Reviewers: jat,
Description:
Fix external issue 5062 - DateTimeFormat#formatFractionalSeconds
incorrect for date before 1970 with 0 fractionalSecond
Please review this at http://gwt-code-reviews.appspot.com/715801/show
Affected files:
M user/src/com/google/gwt/i18n/client/DateTimeFormat.java
LGTM
http://gwt-code-reviews.appspot.com/715801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yes, that's a flat out bug. Would you mind filing a ticket against Roo, with
component GWT?
http://jira.springframework.org/secure/CreateIssue.jspa?pid=10340&issuetype=1
On Thu, Jul 22, 2010 at 12:15 PM, pjulien wrote:
> I understand your point about EditorSupport but I still feel one issue
>
Joel, Miguel, GWTers,
I am trying to phase in a new linker as the default GWT linker, and I could
use some feedback on how that is accomplished.
My first thought was to modify the cross-site linker in place, as was
started by this patch:
http://gwt-code-reviews.appspot.com/674802/show
After fu
Cell Tables are already all set for you, they're completely independent of
RequestFactory et al.
We're in the midst of a rewrite of EditorSupport that will make it
independent of ValueStore et al, or at least easily severable.
In parallel, we're working to pull ValueStore and Record out of the pu
SGTM as far as process.
Is the new linker designed to curtail extension, or to sanely encourage it?
The existing primary linkers ended up getting extended in brittle ways.
On Mon, Jul 26, 2010 at 12:06 PM, Lex Spoon wrote:
> Joel, Miguel, GWTers,
>
> I am trying to phase in a new linker as the
On Monday, July 26, 2010 11:53:40 am Ray Ryan wrote:
> Yes, that's a flat out bug. Would you mind filing a ticket against Roo,
> with component GWT?
done..
http://jira.springframework.org/browse/ROO-1139
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8407
Author: b...@google.com
Date: Thu Jul 22 12:08:40 2010
Log: Make the deRPC server code compatible with servlet filters that alter
the HTTP
response after the RPC payload is created.
Patch by: bobv
Review by: tms
http://code.google.com/p/google-web-toolkit/source/detail?r=8407
M
LGTM with one nit
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001
File bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001#newcode28
bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml:28:
tha
LGTM
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001
File bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001#newcode28
bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml:28:
than the system
Revision: 8409
Author: rj...@google.com
Date: Fri Jul 23 07:41:23 2010
Log: Rolls back r8394, allow RPC for unmodifiable collections, due
to increase in client size of unwitting clients, especially those that
return special empty and singleton collections.
http://code.google.com/p/google-web-tool
Revision: 8410
Author: sp...@google.com
Date: Fri Jul 23 09:44:56 2010
Log: Modifies the cross-site linker to put its code in an iframe
rather than a wrapper function.
Review at http://gwt-code-reviews.appspot.com/674802
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/sour
Well needless to say, I'm looking forward to it. :-)
On Jul 26, 2010, at 12:29 PM, Ray Ryan wrote:
> Cell Tables are already all set for you, they're completely independent of
> RequestFactory et al.
>
> We're in the midst of a rewrite of EditorSupport that will make it
> independent of Value
[+matt, who's one of the few people I know outside of Google creating custom
linkers]
I'm 100% on board with this as well. These things weren't all that carefully
designed for extension from the beginning, so it's going to be difficult to
make significant changes to them without breaking existing
Revision: 8411
Author: unn...@google.com
Date: Fri Jul 23 10:49:57 2010
Log: Add support for authentication
Review at http://gwt-code-reviews.appspot.com/706802
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8411
Added:
/trunk/bikeshed/src/com/google/
Revision: 8413
Author: sp...@google.com
Date: Fri Jul 23 11:50:52 2010
Log: Rolling back the cross-site linker using an iframe. It's not clear
this is a safe change for all apps.
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8413
Added:
/tru
Revision: 8415
Author: gwt.mirror...@gmail.com
Date: Mon Jul 26 11:12:39 2010
Log: Fix external issue 5062 - DateTimeFormat#formatFractionalSeconds
incorrect for date before 1970 with 0 fractionalSecond
Review at http://gwt-code-reviews.appspot.com/715801
Review by: j...@google.com
http://cod
LGTM with one nit
We don't update the copright date - it stays at the earliest year the
file was opened, so in this case, it should stay 2008.
On 2010/07/25 17:53:28, fredsa wrote:
http://gwt-code-reviews.appspot.com/712801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contribu
Reviewers: scottb,
Description:
Add some missing ASM classes
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/699802/show
Affected files:
A dev/core/src/com/google/gwt/dev/asm/commons/JSRInlinerAdapter.java
A dev/core/src/com/google/gwt/dev/asm/tree/Ab
Reviewers: robertvawter, mmendez,
Description:
Fixes a bug in the finally handling of doExecuteCommands which
unilaterally squashes exceptions. (Early returns from a finally block
via return statements or exceptions override pending exceptions).
Please review this at http://gwt-code-reviews.app
Reviewers: Dan Rice,
Description:
Patch from Gustav Trede (gustav.tr...@gmail.com)
Improve concurrency handling in server-side RPC
Please review this at http://gwt-code-reviews.appspot.com/716801/show
Affected files:
M dev/core/src/com/google/gwt/dev/util/HttpHeaders.java
M user/src/com/go
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001
File bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/651803/diff/3001/4001#newcode28
bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml:28:
than the system handle
LGTM.
Did we ever figure out why we're bundling this in as source instead of
using the jars in tools?
http://gwt-code-reviews.appspot.com/699802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No, I didn't investigate. Pretty sure this predates our use of jarjar
though, so it may have had something to do with that.
On Mon, Jul 26, 2010 at 4:38 PM, wrote:
> LGTM.
>
> Did we ever figure out why we're bundling this in as source instead of
> using the jars in tools?
>
>
> http://gwt-code-
http://gwt-code-reviews.appspot.com/651803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/651803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8416
Author: to...@google.com
Date: Mon Jul 26 13:13:54 2010
Log: Fixes a bug in the finally handling of doExecuteCommands which
unilaterally squashes exceptions. (Early returns from a finally block via
return statements or exceptions override pending exceptions).
Review at http://
On Mon, Jul 26, 2010 at 12:37 PM, Scott Blum wrote:
> SGTM as far as process.
>
> Is the new linker designed to curtail extension, or to sanely encourage it?
> The existing primary linkers ended up getting extended in brittle ways.
>
That's a good point. Let's make it a final class to start wit
Revision: 8418
Author: unn...@google.com
Date: Mon Jul 26 15:35:20 2010
Log: Add basic logging to Scaffold app
Review at http://gwt-code-reviews.appspot.com/651803
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8418
Added:
/trunk/user/src/com/google/g
On Mon, Jul 26, 2010 at 6:27 PM, Lex Spoon wrote:
> On Mon, Jul 26, 2010 at 12:37 PM, Scott Blum wrote:
>
>> SGTM as far as process.
>>
>> Is the new linker designed to curtail extension, or to sanely encourage
>> it? The existing primary linkers ended up getting extended in brittle ways.
>>
>
Revision: 8419
Author: fre...@google.com
Date: Mon Jul 26 17:13:37 2010
Log: Updated javadoc for Window#setStatus()
Review at http://gwt-code-reviews.appspot.com/712801
Review by: unn...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8419
Modified:
/trunk/user/src/com/g
On Jul 26, 5:56 pm, John Tamplin wrote:
>
> Well, we do know there will be other linkers, and if there aren't extension
> points defined they will be done via cut-and-paste, which is what led to the
> current state we are in.
>
> --
> John A. Tamplin
> Software Engineer (GWT), Google
The proposal
Reviewers: bobv,
Description:
Hard coded History integration for the Scaffold app. This is step zero
in the search for a general, generatable scheme. It is not intended to
be what we actually ship.
I do like that it seems to be feature complete without having required
any changes to the PlaceCon
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001
File user/src/com/google/gwt/resources/client/ClientBundle.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001#newcode2
user/src/com/google/gwt/resources/client/ClientBundle.java:2: *
Copyright 2010 Google Inc.
On 2010
39 matches
Mail list logo
