http://gwt-code-reviews.appspot.com/750801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/1/2#newcode86
dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java:86: Object
getCastableTypeMap();
What's the retu
What's about a commit to the main trunk? The patch still hasn't been
applied althout it's been accepted:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5150
http://gwt-code-reviews.appspot.com/708801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
> that would do exactly what I need, but they have default visibility
> and are indicated "for testing purposes only". Is there any reason why
> these method couldn't be made public?
Because the public API requires the use of class literals, it forces
the .class file for the annotation to be on th
http://gwt-code-reviews.appspot.com/753801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/CompilationState.java
(right):
http://gwt-code-reviews.appspot.com/753801/diff/1/3#newcode93
dev/core/src/com/google/gwt/dev/javac/CompilationState.java:93:
generatedUnitsAddEvent.addData("# new genera
LGTM
http://gwt-code-reviews.appspot.com/753801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/CompilationState.java
(right):
http://gwt-code-reviews.appspot.com/753801/diff/1/3#newcode93
dev/core/src/com/google/gwt/dev/javac/CompilationState.java:93:
generatedUnitsAddEvent.addData("# new
http://gwt-code-reviews.appspot.com/750801/diff/1/17
File user/super/com/google/gwt/emul/java/lang/Object.java (right):
http://gwt-code-reviews.appspot.com/750801/diff/1/17#newcode46
user/super/com/google/gwt/emul/java/lang/Object.java:46: * lookup
castability between types
Actually, you raise a
Reviewers: amitmanjhi,
Description:
Add @Override tags in order to be able to enable Eclipse warnings
without being drowned
Please review this at http://gwt-code-reviews.appspot.com/754801/show
Affected files:
M
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldDetailsActiviti
Revision: 8517
Author: amitman...@google.com
Date: Wed Aug 11 06:10:03 2010
Log: More DeltaValueStore cleanup.
Patch by: amitmanjhi
Review by: rice (tbr)
http://code.google.com/p/google-web-toolkit/source/detail?r=8517
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/repor
Revision: 8518
Author: gwt.mirror...@gmail.com
Date: Wed Aug 11 09:45:38 2010
Log: When dev mode fails to load a module, update the $wnd.title with a
summary of the
error, so that the error can be seen even when the browser is minimized in
task bar. This can be useful when developing by keeping
http://gwt-code-reviews.appspot.com/750801/diff/1/17
File user/super/com/google/gwt/emul/java/lang/Object.java (right):
http://gwt-code-reviews.appspot.com/750801/diff/1/17#newcode46
user/super/com/google/gwt/emul/java/lang/Object.java:46: * lookup
castability between types
I think this makes se
On Wed, Aug 11, 2010 at 12:56 PM, wrote:
> I think this makes sense, and would reduce the size of the generated
> code, e.g. "[12,35,123]" vs. "{12:1,35:1,123:1}". The Cast.canCast()
> methods would have to iterate through the array explicitly to test for
> existence though, instead of a simple
Does GWT mandate the eclipse setting that throws warnings for missing
@Override? I, for example, had it set to ignore.
On Wed, Aug 11, 2010 at 9:23 AM, wrote:
> Reviewers: amitmanjhi,
>
> Description:
> Add @Override tags in order to be able to enable Eclipse warnings
> without being drowned
>
>
My suggestion was to emit code like this makeMap([12,35,123]) which is a
routine that produces {12:1, 35:1, 123:1}. I've run into cast checks as
being an overwhelming hot-method in the past, and I'd think that a loop,
even a small one, could add significant overhead. Something like makeMap()
would
On Wed, Aug 11, 2010 at 1:14 PM, Amit Manjhi wrote:
> Does GWT mandate the eclipse setting that throws warnings for missing
> @Override? I, for example, had it set to ignore.
It is recommended and useful.
The one catch is that if you don't tell Eclipse to use JDK1.5 compatibility,
it will insi
Revision: 8519
Author: gwt.mirror...@gmail.com
Date: Wed Aug 11 07:24:43 2010
Log: Annotate the SpeedTracer log data with some extra info.
Also, remove some unused event types and fiddle with the colors to make
DevMode traces a bit more readable.
Review at http://gwt-code-reviews.appspot.com/7
I've had it off but I noticed in one of the changes this morning that an
@Override tag was (correctly) added and was curious enough to check the
setting. I would like to be able to enable warnings in my own Eclipse since
there are benefits to getting it right (namely avoiding accidental
non-over
Reviewers: bobv,
Description:
Extends DynaTableRF with a client call to Person#persist.
Review by: robertvaw...@google.com
Please review this at http://gwt-code-reviews.appspot.com/755801/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml
Amit, can you look at this? For some reason sync responses are coming
back from the server successful but empty, which means that the
PersonProxyChanged event is not being emitted. I'm stumped. Anything
jump out at you?
http://gwt-code-reviews.appspot.com/755801/show
--
http://groups.google.com/
Bob & Lex,
I just ran into an "interesting" error message while experimenting with some
JSO stuff that you might be able to shed some light on. First, here's the
error:
> InternalCompilerException: Already seen an implementing JSO subtype
(DocumentImpl) for interface (Node) while examining newly-
> At first glance, this would appear to anger the SingleJSO gods. However,
> because NodeImpl contains implementations of all Node methods, there is no
> actual ambiguity as to which method implementation to bind to. The "this is
> a bug" wording in the error also raised my eyebrows a bit :)
Is No
LGTM
We anyway recommend the 1.5 compatibility setting.
On Wed, Aug 11, 2010 at 10:49 AM, Daniel Rice (דניאל רייס)
wrote:
> I've had it off but I noticed in one of the changes this morning that an
> @Override tag was (correctly) added and was curious enough to check the
> setting. I would lik
Revision: 8520
Author: r...@google.com
Date: Wed Aug 11 09:22:23 2010
Log: Add @Override tags in order to be able to enable Eclipse warnings
without being drowned
Review at http://gwt-code-reviews.appspot.com/754801
Review by: amitman...@google.com
http://code.google.com/p/google-web-toolkit/
Reviewers: Dan Rice,
Description:
This patch allow empty row data lists that start on the pageStart to
pass through the AbstractListViewAdapter and HasDataPresenter down to
the HasData implementation (such as CellList). This ensures that Cell
Widgets clear the view when the row count goes to 0.
Oh, problem is obvious pilot error, fix in a moment.
On Wed, Aug 11, 2010 at 11:31 AM, wrote:
> Amit, can you look at this? For some reason sync responses are coming
> back from the server successful but empty, which means that the
> PersonProxyChanged event is not being emitted. I'm stumped. An
LGTM
http://gwt-code-reviews.appspot.com/756801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Le 11 août 2010 15:11, BobV a écrit :
> > At first glance, this would appear to anger the SingleJSO gods. However,
> > because NodeImpl contains implementations of all Node methods, there is
> no
> > actual ambiguity as to which method implementation to bind to. The "this
> is
> > a bug" wording
http://gwt-code-reviews.appspot.com/750801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/1/2#newcode86
dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java:86: Object
getCastableTypeMap();
Added minor cla
LGTM
http://gwt-code-reviews.appspot.com/752801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/755801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ready for review.
http://gwt-code-reviews.appspot.com/755801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
So, I've added some minor clarification in the comments describing the
castableTypeMap 'Object' (and removed some whitespace), but have not
attempted to narrow the typing on that Object (e.g. as a sub-classed
JavaScriptObject (as suggested by BobV), or as an int[] array (as
suggested by Scott/RayC)
LGTM
http://gwt-code-reviews.appspot.com/619807/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8521
Author: gwt.mirror...@gmail.com
Date: Wed Aug 11 12:24:47 2010
Log: Lazily generate LocaleInfoImpl (rebase from superdevmode)
Review at http://gwt-code-reviews.appspot.com/619807
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8521
Modified:
Reviewers: scottb,
Description:
GWT Development shell no longer cuts off the "Launch Default Browser"
and "Copy to Clipboard"
buttons when the Startup URL happens to be long. This change stacks the
"Startup URL:" and
URL dropdown above the two buttons instead of having all four live under
a singl
Revision: 8522
Author: sco...@google.com
Date: Wed Aug 11 13:59:10 2010
Log: For synthetic this refs, use params rather than fields while in
constructors
http://gwt-code-reviews.appspot.com/752801
Review by: tobyr
http://code.google.com/p/google-web-toolkit/source/detail?r=8522
Modified:
/t
Revision: 8523
Author: sco...@google.com
Date: Wed Aug 11 15:02:41 2010
Log: Rolling back r8522: For synthetic this refs, use params rather than
fields while in constructors
Cause build breaks.
http://code.google.com/p/google-web-toolkit/source/detail?r=8523
Modified:
/trunk/dev/core/src/co
Reviewers: Keith,
Message:
First patch in landing limited unit invalidation.
Description:
- CompilationState retains a full map of all units, including error
units.
- Only transitively valid units are passed into TypeOracle.
Please review this at http://gwt-code-reviews.appspot.com/759801/show
This should be jat.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
39 matches
Mail list logo
