FWIW, since we the time bounds of further optimizing this patch are not yet
clear, I'd be in favor of landing it and then doing a second round of
optimizations.
On Wed, Aug 11, 2010 at 5:39 PM, Jason Rosenberg jbrosenb...@google.comwrote:
So, I've added some minor clarification in the comments
LGTM, the comments are mostly questions to make sure that I understand
what the code is intended to do.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
@Miguel,
FWIW, since we the time bounds of further optimizing this patch are
not yet
clear, I'd be in favor of landing it and then doing a second round of
optimizations.
This patch achieves its stated goal, although there are some code style
issues that need to be addressed.
@Scott,
Do
On 2010/08/12 14:21:14, bobv wrote:
@Miguel,
FWIW, since we the time bounds of further optimizing this patch are
not yet
clear, I'd be in favor of landing it and then doing a second round
of
optimizations.
This patch achieves its stated goal, although there are some code
style issues
I'm addressing Bob's remaining comments now, new patch forthcoming
Jason
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8524
Author: con...@google.com
Date: Thu Aug 12 04:59:39 2010
Log: Rollingback r8521: Lazily generate LocaleInfoImpl (rebase from
superdevmode) since htmlunit is failing.
http://code.google.com/p/google-web-toolkit/source/detail?r=8524
Modified:
On Thu, Aug 12, 2010 at 10:21 AM, b...@google.com wrote:
@Scott,
Do you have any further input on the implementation changes to the JS
runtime in the patch as it stands (modulo any future optimizations)?
No further comments, beyond what you said.
--
LGTM
http://gwt-code-reviews.appspot.com/759801/diff/1/9
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(left):
http://gwt-code-reviews.appspot.com/759801/diff/1/9#oldcode306
dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:306: }
Is it worth asserting that
http://gwt-code-reviews.appspot.com/755801/diff/5001/6006
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java
(right):
http://gwt-code-reviews.appspot.com/755801/diff/5001/6006#newcode24
Thanks.
http://gwt-code-reviews.appspot.com/759801/diff/1/9
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(left):
http://gwt-code-reviews.appspot.com/759801/diff/1/9#oldcode306
dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:306: }
Not really, because a) that
Oops, missed some of your questions.
Applying the fixes and submitting.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
Reviewers: amitmanjhi,
Description:
Adds (unused by this patch, but needed in forthcoming history code)
RecordImpl#isFuture.
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/760801/show
Affected files:
M
Revision: 8525
Author: sco...@google.com
Date: Thu Aug 12 07:56:03 2010
Log: Removes CompilationUnit.isCompiled().
- CompilationState retains a full map of all units, including error units.
- Only transitively valid units are passed into TypeOracle.
Submitted r8526
On 2010/08/12 17:35:02, Ray Ryan wrote:
Oops, missed some of your questions.
Applying the fixes and submitting.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
Revision: 8526
Author: rj...@google.com
Date: Thu Aug 12 08:15:08 2010
Log: Extends DynaTableRF with a client call to Person#persist.
Review at http://gwt-code-reviews.appspot.com/755801
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8526
LGTM
On 2010/08/12 18:10:06, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/760801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
TypeOracle hasn't supported local types for a while, this change removes
traces of it.
Please review this at http://gwt-code-reviews.appspot.com/761801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java
M
Revision: 8527
Author: jlaba...@google.com
Date: Thu Aug 12 09:42:27 2010
Log: This patch allow empty row data lists that start on the pageStart to
pass through the AbstractListViewAdapter and HasDataPresenter down to the
HasData implementation (such as CellList). This ensures that Cell
Mostly LGTM. Several formatting nits, and one question about the JType
ctor.
http://gwt-code-reviews.appspot.com/748802/diff/1/3
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java
(right):
http://gwt-code-reviews.appspot.com/748802/diff/1/3#newcode270
Revision: 8528
Author: gwt.mirror...@gmail.com
Date: Thu Aug 12 13:14:13 2010
Log: Adds (unused by this patch, but needed in forthcoming history code)
RecordImpl#isFuture.
Review at http://gwt-code-reviews.appspot.com/760801
Review by: amitman...@google.com
LGTM
http://gwt-code-reviews.appspot.com/761801/diff/1/4
File dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/761801/diff/1/4#newcode594
dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java:594: *
@deprecated local types are
Reviewers: Ray Ryan,
Description:
Fixing capitalization of 'GWT Development Mode' in hosted.html
Please review this at http://gwt-code-reviews.appspot.com/762801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Index:
LGTM!!
On Thu, Aug 12, 2010 at 1:22 PM, fre...@google.com wrote:
Reviewers: Ray Ryan,
Description:
Fixing capitalization of 'GWT Development Mode' in hosted.html
Please review this at http://gwt-code-reviews.appspot.com/762801/show
Affected files:
M
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/750801/diff/18001/19002
File
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/18001/19002#newcode36
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java:36:
committed as r8527
http://gwt-code-reviews.appspot.com/756801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: ,
Description:
Introduce an interface for widgets that has a setEnabled method.
Please review this at http://gwt-code-reviews.appspot.com/757801/show
Affected files:
user/src/com/google/gwt/user/client/ui/FocusWidget.java
user/src/com/google/gwt/user/client/ui/HasEnabled.java
Hello all,
I am trying to upgrade gwt version of my project from 1.3 to 2.0.4. it
looks like google rocket has not released any versions since gwt
1.5.2.
Can I get rid of rocket dependency completely with this 2.x gwt
release?
Specifically, I am looking for gwt 'varients' for following 'rocket'
This approach will RPC analyze every object in your gwt source path
and take a long time. We used a similar approach but with clear base
classes (RemoteRequestEvent and RemoteReponseEvent) that can be
extended to demarcate the events that can be RPC'd within our module
(as Serializable is too
I can't use it on the JCT because I'm not looking for a specific
annotation, I'm looking for _any_ annotation who's class is annotated
with @TheAnnotationImLookingFor.
But this gave me an idea. Maybe there is a method in the oracle to get
all the annotations annotated with
On Thu, Aug 12, 2010 at 5:25 PM, PhilBeaudoin
philippe.beaud...@gmail.comwrote:
I can't use it on the JCT because I'm not looking for a specific
annotation, I'm looking for _any_ annotation who's class is annotated
with @TheAnnotationImLookingFor.
But this gave me an idea. Maybe there is a
Mostly nits, one minor concern, one major concern.
Minor: did you really man to bump up the timeout on the request factory
test?
Major: do you really need to make RecordSchema public API?
http://gwt-code-reviews.appspot.com/741801/diff/6001/7001
File
gwt doesn't have this information out of the box, though I've often wished
for it too.
You might take a look at the GWT Reflection project (
http://gwtreflection.sourceforge.net/), which I'm told provides this kind of
service. Haven't looked at it myself yet, though.
On Thu, Aug 12, 2010 at 2:25
LGTM
http://gwt-code-reviews.appspot.com/741801/diff/6001/7001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java
(right):
http://gwt-code-reviews.appspot.com/741801/diff/6001/7001#newcode110
Thanks.
http://gwt-code-reviews.appspot.com/748802/diff/1/3
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java
(right):
http://gwt-code-reviews.appspot.com/748802/diff/1/3#newcode270
dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java:270:
realParameterNames
Thanks.
http://gwt-code-reviews.appspot.com/761801/diff/1/4
File dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/761801/diff/1/4#newcode594
dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java:594: *
@deprecated local types
Revision: 8531
Author: gwt.mirror...@gmail.com
Date: Thu Aug 12 12:01:02 2010
Log: Remove stale comment in BuildTypeMap
Review by: g...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8531
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
LGTM
http://gwt-code-reviews.appspot.com/748802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I see... But it is somewhat limiting as it doesn't let you scan
annotations for a specific attribute. In my case I believe that the my
process would ensure the annotation I'm looking for has been
compiled.
What I'm trying to do here is to let the users of the GWTP framework
define custom
Reviewers: jgw,
Description:
Add mouse position information to ClickEvent and DoubleClickEvent.
Manually verified that this
information is indeed available on some older and some more modern
browsers, sampling Mac/Linux/Win
where possible:
- Chrome 5, Chrome 6
- FF 2.0.0.20, FF 3.0.19, FF 3.6.3
Reviewers: Ray Ryan,
Description:
Public: Fix gwt compile errors in javax.validation.
I changed InputStreams to Strings and Local to GwtLocale.
For the Validation class, I completely gutted it,
bootstraping validation in GWT will not use this class.
Please review this at
Reviewers: Ray Ryan,
Description:
Fixed the create bug by using the futureId field in RecordKey and
RecordImpl
Patch by: amitmanjhi
Review by: rjrjr(desk review)
Please review this at http://gwt-code-reviews.appspot.com/765801/show
Affected files:
M
LGTM
On Thu, Aug 12, 2010 at 5:25 PM, amitman...@google.com wrote:
Reviewers: Ray Ryan,
Description:
Fixed the create bug by using the futureId field in RecordKey and
RecordImpl
Patch by: amitmanjhi
Review by: rjrjr(desk review)
Please review this at
Revision: 8532
Author: amitman...@google.com
Date: Thu Aug 12 15:07:28 2010
Log: Fixed the create bug that was being caused by server ids and futureIds
by using the futureId field in RecordKey and RecordImpl
Patch by: amitmanjhi
Review by: rjrjr(desk review)
Reviewers: Ray Ryan,
Description:
Fix the equals method for RecordKey. Forgot to make this change in the
just
submitted patch. Added tests for it, and organized other tests in
suites.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Please review this at
Revision: 8533
Author: amitman...@google.com
Date: Thu Aug 12 17:13:04 2010
Log: Fix the equals method for RecordKey. Forgot to make this change in the
just
submitted patch. Added tests for it, and organized other tests in suites.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Review at
Revision: 8534
Author: f...@google.com
Date: Thu Aug 12 17:25:52 2010
Log: Upgraded HtmlUnit to 2.8.
http://code.google.com/p/google-web-toolkit/source/detail?r=8534
Modified:
/trunk/dev/build.xml
/trunk/eclipse/dev/.classpath
/trunk/eclipse/user/.classpath
Revision: 8535
Author: amitman...@google.com
Date: Thu Aug 12 22:24:28 2010
Log: Changes to tools for upgrading to HtmlUnit 2.8 (r5940). Corresponding
changing to trunk:
http://code.google.com/p/google-web-toolkit/source/detail?r=8534
Patch by: flin
Commit (and review) by: amitmanjhi
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
49 matches
Mail list logo
