http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class clazz;
On 2010/0
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Thanks, Ray. One wording nit.
http://gwt-code-reviews.appspot.com/831803/diff/1/3
File user/src/com/google/gwt/user/client/ui/HasValue.java (right):
http://gwt-code-reviews.appspot.com/831803/diff/1/3#newcode48
user/src/com/google/gwt/user/client/ui/HasValue.java:48: *
How about:
Widget
Revision: 8728
Author: rj...@google.com
Date: Tue Sep 7 14:07:00 2010
Log: Fix checkstyle error introduced at r8726
http://code.google.com/p/google-web-toolkit/source/detail?r=8728
Modified:
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java
Revision: 8727
Author: k...@google.com
Date: Tue Sep 7 14:01:53 2010
Log: rollback r8722 due to test failure on Chrome
http://code.google.com/p/google-web-toolkit/source/detail?r=8727
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java
/trunk/user/src/com/google/gwt/user/
Reviewers: kathrin,
Description:
Rolling back r8722 due to test failures
Please review this at http://gwt-code-reviews.appspot.com/851801/show
Affected files:
M user/src/com/google/gwt/user/client/ui/FocusWidget.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
M user/src/com/
LGTM
http://gwt-code-reviews.appspot.com/835802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/829801/diff/8020/24004
File user/src/com/google/gwt/user/client/ui/CheckBox.java (right):
http://gwt-code-reviews.appspot.com/829801/diff/8020/24004#newcode265
user/src/com/google/gwt/user/client/ui/CheckBox.java:265: public void
setSafeHtml(SafeHtml htm
Revision: 8726
Author: m...@google.com
Date: Tue Sep 7 12:42:09 2010
Log: Change UiBinder Message generation to use consistent examples for HTML
and Widget placeholders to facilitate sharing of messages with embedded
HTML elements or widgets.
Review at http://gwt-code-reviews.appspot.com/83
Reviewers: pdr, rice,
Description:
Add streaming HTML parser library to tools/lib, as well as the guava
library it depends on.
Use this parser to verify (in non-prod mode) that arguments to
SafeHtmlBuilder#appendHtmlConstant satisfy the SafeHtml composability
constraint.
Clarify SafeHtml type co
Make sure you are changing all the users of the interface as well.
Dan
On Tue, Sep 7, 2010 at 5:23 PM, wrote:
> In this case, setSafeHtml() is the method defined in the interface
> HasSafeHtml. I am changing this to setHTML(SafeHtml), and the interface
> as well.
>
> http://gwt-code-reviews.ap
http://gwt-code-reviews.appspot.com/849801/diff/1/2
File user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java
(right):
http://gwt-code-reviews.appspot.com/849801/diff/1/2#newcode39
user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java:39: long
millis = 100;
Perhaps test with 100
LGTM
http://gwt-code-reviews.appspot.com/847801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/847801/diff/1/2
File tools/api-checker/config/gwt20_21userApi.conf (right):
http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115
tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be:
method(SafeHtml html), etc.
On 2010/09/07 20:22:3
http://gwt-code-reviews.appspot.com/847801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
r8725
On Tue, Sep 7, 2010 at 12:20 PM, wrote:
> Only real changes in the last patch are in AbstractJsonListRequest and
> AbstractJsonObjectRequest to work around
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894
>
> Submitting.
>
>
> On 2010/09/07 19:14:54, rjrjr wrote:
>
>
>
>
> http
Reviewers: rjrjr,
Message:
Review requested.
Description:
Add ListEditor adapter implemented on top of a new CompositeEditor core
behavior.
Remove type-specific adapters in favor of interface-specific adapters.
Improve handling of generic editor interfaces.
Patch by: bobv
Review by: rjrjr
Plea
LGTM with mostly nits.
A general concern is inconsistency about naming -- most places, the
SafeHtml version is just an overload, and that makes the most sense to
me. Some places rename the method to be setSafeHtml instead of setHtml,
for example, and I don't think that difference is relevant to
I went back and removed my style nit comments to focus on the
substantive stuff. Manually tracking the number of visits in every
visitor, and how that data is used, are my primary concerns.
http://gwt-code-reviews.appspot.com/841801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCod
Reviewers: jat,
Description:
Add SafeHtml support to UI widgets (2)
This is a first-pass at adding SafeHtml support to a subset of the
widgets. In cases where the class implements HasHTML, HasSafeHtml has
been implemented as well. In constructors that accept a string that can
be parsed as Html,
Revision: 8724
Author: rj...@google.com
Date: Tue Sep 7 09:47:45 2010
Log: Snip an @Override that jdk 1.5 cannot support,
and fix an unneeded throws warning.
http://code.google.com/p/google-web-toolkit/source/detail?r=8724
Modified:
/trunk/user/test/com/google/gwt/user/client/DoubleClickEventS
Revision: 8723
Author: gwt.mirror...@gmail.com
Date: Tue Sep 7 12:33:00 2010
Log: Rolling back due load test failures.
*** Original change description ***
Add Late Loading support to xsiframe linker
Review at http://gwt-code-reviews.appspot.com/807801
http://code.google.com/p/google-web-toolkit
Only real changes in the last patch are in AbstractJsonListRequest and
AbstractJsonObjectRequest to work around
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894
Submitting.
On 2010/09/07 19:14:54, rjrjr wrote:
http://gwt-code-reviews.appspot.com/841803/show
--
http://groups.google
http://gwt-code-reviews.appspot.com/841803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
It turns out that previous patch was not enough.
In new one instead of preventing failing when no owner or field found,
we disable assigning to fields and support for event handlers at all.
However we can not disable them globally, for all UiBinder templates, we
sho
http://gwt-code-reviews.appspot.com/843801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8722
Author: fre...@google.com
Date: Tue Sep 7 06:57:03 2010
Log: Continuation of r8542. Fixes double click where it was broken and adds
tests to ensure that
events are sunk.
Fix double click in the following widgets (and their subclasses):
- com/google/gwt/user/client/ui/FocusWidge
Please!
On Tue, Sep 7, 2010 at 8:01 AM, Joel Webber wrote:
> @rjrjr: I notice you own the bug -- do you have time to look at this, or
> would you like me to take it off your hands?
>
> Le 6 septembre 2010 04:48, a écrit :
>
> Reviewers: ,
>>
>> Description:
>> Let MenuItem implement HasEnabled
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class clazz;
Could you
@rjrjr: I notice you own the bug -- do you have time to look at this, or
would you like me to take it off your hands?
Le 6 septembre 2010 04:48, a écrit :
> Reviewers: ,
>
> Description:
> Let MenuItem implement HasEnabled and update MenuBar to use this
> information when selecting items.
>
> Th
On 2010/09/04 03:36:47, fredsa wrote:
LGTM.
http://gwt-code-reviews.appspot.com/774801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8721
Author: sco...@google.com
Date: Tue Sep 7 04:40:43 2010
Log: Remove -dumpSignatures in favor of a simpler command line invocation
to get GWT's JRE support.
http://gwt-code-reviews.appspot.com/844801/show
Review by: fabb...@google.com
http://code.google.com/p/google-web-toolkit
Ok, so I did the following:
I had an Eclipse installation with the Scala Development Tools running. I
installed the GPE (Google Plugin and GWT, no GAE) and restarted Eclipse.
When starting, Eclipse hung on the boot-up screen when "Loading
org.eclipse.jdt.core" consuming one of the two CPU cores wit
34 matches
Mail list logo
