[gwt-contrib] Re: Resolves ROO-1447. (issue921801)

Partial review. I looked at the DeltaValueStore, Proxy* and AbstractRequest code in user and it looks good except one thing -- I don't think the commit method should be putting values in the deltaValueStore. We don't know for sure, if all fields have been persisted. And the entity value will be re

[gwt-contrib] Resolves ROO-1447. (issue921801)

Reviewers: rjrjr, amitmanjhi, cromwellian, Description: Resolves ROO-1447. Allow DynaTableRf to create new Person objects. Remove EditorDelegate.ensureMutable() from public API. EntityProxy equality now based on stableId + associated Request object. Implements future-to-future assignments in Requ

[gwt-contrib] Cleanup for Roo-1401. Refactored the commit method so that it is easier for it (issue920801)

Reviewers: rjrjr, robertvawter, Description: Cleanup for Roo-1401. Refactored the commit method so that it is easier for it to process additional WriteOperations. Patch by: amitmanjhi Review by: robertvawter Please review this at http://gwt-code-reviews.appspot.com/920801/show Affected files:

[gwt-contrib] [google-web-toolkit] r8861 committed - Fixed https://jira.springsource.org/browse/ROO-1429...

Revision: 8861 Author: amitman...@google.com Date: Thu Sep 23 15:15:17 2010 Log: Fixed https://jira.springsource.org/browse/ROO-1429 1. Renamed setFoo -> putFoo, isFoo -> hasFoo, getFoo -> foo() in ProxyImpl. 2. Added a bang at the beginning of all meta-data fields in the response. Patch by: amit

[gwt-contrib] [google-web-toolkit] r8860 committed - Fixing a bug with images used in CellTree, CellBrowser, and IconCellDe...

Revision: 8860 Author: jlaba...@google.com Date: Thu Sep 23 15:11:20 2010 Log: Fixing a bug with images used in CellTree, CellBrowser, and IconCellDecorator in browsers that bundle images (IE). Currently, these classes incorrectly construct an image from the ImageResource. This patch makes t

[gwt-contrib] [google-web-toolkit] r8859 committed - Passing Suggestion truncation info where SuggestionDisplay subclasses ...

Revision: 8859 Author: gwt.mirror...@gmail.com Date: Thu Sep 23 17:42:20 2010 Log: Passing Suggestion truncation info where SuggestionDisplay subclasses can get at it. Review at http://gwt-code-reviews.appspot.com/918801 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolk

[gwt-contrib] Re: Fixing a bug with images used in CellTree, CellBrowser, and IconCellDecorator in browsers that b... (issue912801)

http://gwt-code-reviews.appspot.com/912801/diff/1/2 File user/src/com/google/gwt/cell/client/IconCellDecorator.java (right): http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode53 user/src/com/google/gwt/cell/client/IconCellDecorator.java:53: @Template("http://gwt-code-reviews.appspot.com

[gwt-contrib] Re: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

committed as r8856 http://gwt-code-reviews.appspot.com/905802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8858 committed - Adds test that events can be registered and that they fire correctly....

Revision: 8858 Author: p...@google.com Date: Thu Sep 23 13:21:05 2010 Log: Adds test that events can be registered and that they fire correctly. This is a followup to ROO-1434 that implements a TODO to test the events. Review at http://gwt-code-reviews.appspot.com/878803 Review by: amitman...@g

[gwt-contrib] [google-web-toolkit] r8857 committed - Re-introduces the RpcServletUtils.readContentAsUtf8() methods for back...

Revision: 8857 Author: zun...@google.com Date: Thu Sep 23 13:16:50 2010 Log: Re-introduces the RpcServletUtils.readContentAsUtf8() methods for backwards compatibility (used by GWT Gadgets API) Review at http://gwt-code-reviews.appspot.com/887803 http://code.google.com/p/google-web-toolkit/sou

[gwt-contrib] [google-web-toolkit] r8856 committed - Element.getTabIndex() returns undefined on Safari 3 for non-focusable ...

Revision: 8856 Author: jlaba...@google.com Date: Thu Sep 23 12:26:00 2010 Log: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, which can cause our tests to hang. This patch updates Element to return -1 if tabIndex is undefined. We use a typeof

[gwt-contrib] Re: Fixes Collection of value types and proxies as parameters to RequestFactory methods. Also fixes ... (issue883802)

LGTM http://gwt-code-reviews.appspot.com/883802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove version from the public api. (issue878802)

LGTM On Thu, Sep 23, 2010 at 8:07 AM, wrote: > Reviewers: rjrjr, > > Description: > Remove version from the public api. > > Patch by: amitmanjhi > Review by: rjrjr (desk review) > > > Please review this at http://gwt-code-reviews.appspot.com/878802/show > > Affected files: > M user/src/com/goog

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

http://gwt-code-reviews.appspot.com/878803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

LGTM++ http://gwt-code-reviews.appspot.com/878803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

http://gwt-code-reviews.appspot.com/878803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-introduces the RpcServletUtils.readContentAsUtf8() methods for backwards compatibility (issue887803)

LGTM On Thu, Sep 23, 2010 at 2:50 PM, wrote: > LGTM > > > http://gwt-code-reviews.appspot.com/887803/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a bug with images used in CellTree, CellBrowser, and IconCellDecorator in browsers that b... (issue912801)

http://gwt-code-reviews.appspot.com/912801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-introduces the RpcServletUtils.readContentAsUtf8() methods for backwards compatibility (issue887803)

LGTM http://gwt-code-reviews.appspot.com/887803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Delete EditorSupportGenerator, and various tweaks on the way to making (issue912802)

LGTM http://gwt-code-reviews.appspot.com/912802/diff/7001/8013 File user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/912802/diff/7001/8013#newcode68 user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver

[gwt-contrib] [google-web-toolkit] r8855 committed - Fix what appears to be a minor typo in the shared class template...

Revision: 8855 Author: bd...@google.com Date: Thu Sep 23 11:21:29 2010 Log: Fix what appears to be a minor typo in the shared class template example code. Review at http://gwt-code-reviews.appspot.com/871802 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=

Re: [gwt-contrib] Re: If Java optimizers are not run to full completion (part of another proposed patch), (issue897803)

The original code looks like: class Foo { private int depth; void begin() { depth++; if (depth == 1) { // if (!isCondition) { bar.baz(); } } } } depth is the lhs of the expression and is should be a primitive. On Thu, Sep 23, 2010 at 5:15 PM, Chris Conroy

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

LGTM other than some nits below. http://gwt-code-reviews.appspot.com/878803/diff/1/2 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/878803/diff/1/2#newcode114 user/test/com/google/gwt/requestfactory/client/RequestFactoryT

[gwt-contrib] Re: Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

lgtm http://gwt-code-reviews.appspot.com/915801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing Suggestion truncation info where SuggestionDisplay subclasses can get at it. (issue918801)

LGTM http://gwt-code-reviews.appspot.com/918801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: If Java optimizers are not run to full completion (part of another proposed patch), (issue897803)

Comparing reference equality for Integer objects in Java is a bit of a minefield... Integer x = 1; Integer y = 1; System.out.println("1==1? " + (x==y ? "yes" : "no")); x = 127; y = 127; System.out.println("127==127? " + (x==y ? "yes" : "no")); x = 128; y = 128;

[gwt-contrib] Re: Delete EditorSupportGenerator, and various tweaks on the way to making (issue912802)

http://gwt-code-reviews.appspot.com/912802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: If Java optimizers are not run to full completion (part of another proposed patch), (issue897803)

For more information, here's the exception. Caused by: java.lang.ClassCastException: com.google.gwt.dev.jjs.ast.JPrimitiveType cannot be cast to com.google.gwt.dev.jjs.ast.JReferenceType at com.google.gwt.dev.jjs.impl.EqualityNormalizer.endVisit( EqualityNormalizer.java:85

[gwt-contrib] Adds test that events can be registered and that they fire correctly. (issue878803)

Reviewers: amitmanjhi, Description: Adds test that events can be registered and that they fire correctly. This is a followup to ROO-1434 that implements a TODO to test the events. Please review this at http://gwt-code-reviews.appspot.com/878803/show Affected files: M user/test/com/google/gw

[gwt-contrib] Re: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

LGTM http://gwt-code-reviews.appspot.com/905802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: If Java optimizers are not run to full completion (part of another proposed patch), (issue897803)

This actually gives me pause. What kind of code can leave primitives on one side but not the other? I'm concerned because in Java, I think this should be true: Integer.valueOf(1) == 1 Because the RHS gets autoboxed. If we're translating this as-is into JS triple-equals without boxing it, the t

[gwt-contrib] [google-web-toolkit] r8854 committed - Fix a corner case in getProxyId. Minor cleanup....

Revision: 8854 Author: gwt.mirror...@gmail.com Date: Thu Sep 23 10:27:34 2010 Log: Fix a corner case in getProxyId. Minor cleanup. Patch by: amitmanjhi Review by: robertvawter Review at http://gwt-code-reviews.appspot.com/914801 http://code.google.com/p/google-web-toolkit/source/detail?r=8854

Re: [gwt-contrib] Re: Adds a way to tune the optimization level in steps from (issue915802)

On Thu, Sep 23, 2010 at 4:04 PM, Chris Conroy wrote: > Out of curiosity, which optimizer improves performance with a size increase > side-effect? That might be worth exploring if the trade-off is sensible. I believe that MethodInliner (java) and JsInliner could take a one line function and stic

[gwt-contrib] Fix IncompatibleRemoteServiceException in GWTTestCases under JUnit4. (issue916801)

Reviewers: fabbott, Please review this at http://gwt-code-reviews.appspot.com/916801/show Affected files: M user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java M user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java Index: user/src/com/google/gwt/user/rebind/r

[gwt-contrib] Extract a default timeout constant in JUnitShell. (issue917801)

Reviewers: fabbott, Please review this at http://gwt-code-reviews.appspot.com/917801/show Affected files: M user/src/com/google/gwt/junit/JUnitShell.java Index: user/src/com/google/gwt/junit/JUnitShell.java diff --git a/user/src/com/google/gwt/junit/JUnitShell.java b/user/src/com/google/

Re: [gwt-contrib] Re: Adds a way to tune the optimization level in steps from (issue915802)

Out of curiosity, which optimizer improves performance with a size increase side-effect? That might be worth exploring if the trade-off is sensible. How does setting the number of passes to 3 affect optimizations that don't have an effect on code size? (I know this is harder to measure, but it's w

[gwt-contrib] Re: Adds additional keyboard support in Cell Widgets. CellList and CellTable now support page down/u... (issue906801)

committed as r8847 http://gwt-code-reviews.appspot.com/906801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Adds a way to tune the optimization level in steps from (issue915802)

On Thu, Sep 23, 2010 at 3:48 PM, Chris Conroy wrote: > Why does the compiled size increase from 8 to 9? That would seem to > indicate a bug with the optimizer in that step. > Optimizers don't just reduce code size - they also attempt to improve performance. > On Thu, Sep 23, 2010 at 3:41 PM, E

[gwt-contrib] Re: Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

updated. On Thu, Sep 23, 2010 at 12:52 PM, wrote: > http://gwt-code-reviews.appspot.com/915801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8853 committed - Add logging example to the dist...

Revision: 8853 Author: unn...@google.com Date: Thu Sep 23 09:41:08 2010 Log: Add logging example to the dist Review at http://gwt-code-reviews.appspot.com/913801 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8853 Modified: /trunk/samples/build.xml ===

[gwt-contrib] Re: Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

http://gwt-code-reviews.appspot.com/915801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Adds a way to tune the optimization level in steps from (issue915802)

Why does the compiled size increase from 8 to 9? That would seem to indicate a bug with the optimizer in that step. On Thu, Sep 23, 2010 at 3:41 PM, Eric Ayers wrote: > The attached graph shows an analysis of code size to compile time for > building a large application. The code size is the tot

[gwt-contrib] Re: Adds a way to tune the optimization level in steps from (issue915802)

The attached graph shows an analysis of code size to compile time for building a large application. The code size is the total number of bytes output for .cache.js files for all permutations added together. Somewhere between passes 2 to 4 is a "sweet spot", where further optimization passes appea

[gwt-contrib] Adds a way to tune the optimization level in steps from (issue915802)

Reviewers: scottb, fabbott, Lex, Description: Adds a way to tune the optimization level in steps from draft optimize to full optimization (the current default) Preliminary testing shows that optimization level '3' can give almost as good code size results (within 5%) as full optimization, with a

[gwt-contrib] Re: Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

One name quibble, otherwise LGTM http://gwt-code-reviews.appspot.com/915801/diff/1/4 File user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java (right): http://gwt-code-reviews.appspot.com/915801/diff/1/4#newcode110 user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java:1

[gwt-contrib] Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

Reviewers: rjrjr, Description: Fixed https://jira.springsource.org/browse/ROO-1429 1. Renamed setFoo -> putFoo, isFoo -> hasFoo, getFoo -> foo() in ProxyImpl. 2. Added a bang at the beginning of all meta-data fields in the response. Patch by: amitmanjhi Review by: rjrjr Please review this at ht

[gwt-contrib] If Java optimizers are not run to full completion (part of another proposed patch), (issue897803)

Reviewers: scottb, Lex, Description: If Java optimizers are not run to full completion (part of another proposed patch), a JPrimitiveType can sneak into one side of a binary operation and cause a ClassCastException trying to test for a String. Please review this at http://gwt-code-reviews.appsp

[gwt-contrib] Re: Fix a corner case in getProxyId. Minor cleanup. (issue914801)

LGTM http://gwt-code-reviews.appspot.com/914801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Delete EditorSupportGenerator, and various tweaks on the way to making (issue912802)

Thanks, Bob. I'll upload another patch with these changes when I have the thing going. Roo, STS and I have been arguing. http://gwt-code-reviews.appspot.com/912802/diff/1/5 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right): http://gwt-code-reviews.appspot.com/912802/

[gwt-contrib] Re: Fix a corner case in getProxyId. Minor cleanup. (issue914801)

Incorporates feedback. On Thu, Sep 23, 2010 at 11:27 AM, wrote: > http://gwt-code-reviews.appspot.com/914801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix a corner case in getProxyId. Minor cleanup. (issue914801)

http://gwt-code-reviews.appspot.com/914801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

I was calling this.tabIndex instead of elem.tabIndex in DOMImplSafari. Thats fixed, and all of UISuite now passes. http://gwt-code-reviews.appspot.com/905802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix a corner case in getProxyId. Minor cleanup. (issue914801)

http://gwt-code-reviews.appspot.com/914801/diff/1/2 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right): http://gwt-code-reviews.appspot.com/914801/diff/1/2#newcode202 user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:202: pers

[gwt-contrib] Re: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

http://gwt-code-reviews.appspot.com/905802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

Reviewers: rice, Description: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, which can cause our tests to hang. This patch updates Element to return -1 if tabIndex is undefined. We use a typeof check instead of the standard this.tabIndex || -1 tri

[gwt-contrib] [google-web-toolkit] r8852 committed - Fix NPE in TypeOracle build....

Revision: 8852 Author: sco...@google.com Date: Thu Sep 23 07:20:47 2010 Log: Fix NPE in TypeOracle build. http://gwt-code-reviews.appspot.com/910802/show Review by: con...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8852 Modified: /trunk/dev/core/src/com/google/gwt/d

[gwt-contrib] Fix a corner case in getProxyId. Minor cleanup. (issue914801)

Reviewers: robertvawter, Description: Fix a corner case in getProxyId. Minor cleanup. Patch by: amitmanjhi Review by: robertvawter Please review this at http://gwt-code-reviews.appspot.com/914801/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonI

[gwt-contrib] Add logging example to the dist (issue913801)

Reviewers: rjrjr, Description: Add logging example to the dist Please review this at http://gwt-code-reviews.appspot.com/913801/show Affected files: M samples/build.xml Index: samples/build.xml === --- samples/build.xml (rev

[gwt-contrib] Re: Fix NPE in TypeOracle build (issue910802)

http://gwt-code-reviews.appspot.com/910802/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java (right): http://gwt-code-reviews.appspot.com/910802/diff/1/2#newcode88 dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java:88: int n = method.arguments.length; Loo

[gwt-contrib] Re: Fix NPE in TypeOracle build (issue910802)

lgtm + a question http://gwt-code-reviews.appspot.com/910802/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java (right): http://gwt-code-reviews.appspot.com/910802/diff/1/2#newcode88 dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java:88: int n = method.ar

[gwt-contrib] Fix NPE in TypeOracle build (issue910802)

Reviewers: conroy, Please review this at http://gwt-code-reviews.appspot.com/910802/show Affected files: M dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java Index: dev/core/src/com/google/gwt/dev/javac/MethodArgNamesLookup.java diff --git a/dev/core/src/com/google/gwt/dev/j

[gwt-contrib] [google-web-toolkit] r8851 committed - Remove version from the public api of EntityProxy. Encodes the version...

Revision: 8851 Author: amitman...@google.com Date: Thu Sep 23 06:34:46 2010 Log: Remove version from the public api of EntityProxy. Encodes the version value into a !version field on the client side. Patch by: amitmanjhi Review by: rjrjr (desk review) Review at http://gwt-code-reviews.appspot

[gwt-contrib] [google-web-toolkit] r8850 committed - Re-roll r870801....

Revision: 8850 Author: con...@google.com Date: Thu Sep 23 06:33:21 2010 Log: Re-roll r870801. *** Original Change Description *** Reduce DevMode memory footprint by using a WeakInterner for potentially duplicated strings Review at http://gwt-code-reviews.appspot.com/870801 http://code.googl

[gwt-contrib] [google-web-toolkit] r8849 committed - Some Small logging cleanup...

Revision: 8849 Author: unn...@google.com Date: Thu Sep 23 05:32:15 2010 Log: Some Small logging cleanup - Use server error reporting in RF - Some documentation fixes - Create inherits module for projects using logging classes but not enabling loggin Review at http://gwt-code-reviews.appspot.co

[gwt-contrib] Re: Delete EditorSupportGenerator, and various tweaks on the way to making (issue912802)

http://gwt-code-reviews.appspot.com/912802/diff/1/5 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right): http://gwt-code-reviews.appspot.com/912802/diff/1/5#newcode91 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:91: public EntityProxyId getId() { See

[gwt-contrib] Remove version from the public api. (issue878802)

Reviewers: rjrjr, Description: Remove version from the public api. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/878802/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java M user/src/com/g

[gwt-contrib] Delete EditorSupportGenerator, and various tweaks on the way to making (issue912802)

Reviewers: robertvawter, Description: Delete EditorSupportGenerator, and various tweaks on the way to making addon-gwt recover from the exit of Property from the public API, and the shift to EntityProxyId. Note in particular that getProxyClass() has moved to EntityProxyId, which makes it a lot e

[gwt-contrib] Let ToggleButton implement HasValue (issue887804)

Reviewers: jgw, Description: also fixes issue 5076 (add ToggleButton(upText,downText,handler) constructor) and a few nits in the CheckBox javadoc (referring to "text box", and bad doc re. null value handling in setValue) Assigning to Joel as per http://code.google.com/p/google-web-toolkit/wiki/B

[gwt-contrib] Re: Fixes Collection of value types and proxies as parameters to RequestFactory methods. Also fixes ... (issue883802)

On Thu, Sep 23, 2010 at 10:29 AM, Ray Ryan wrote: > Array values are not a blocker. Only if they're quick, please. If they're not implemented, the system should at least reject these methods. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributo

[gwt-contrib] Re: Fixes Collection of value types and proxies as parameters to RequestFactory methods. Also fixes ... (issue883802)

Array values are not a blocker. Only if they're quick, please. On Sep 23, 2010 6:21 AM, wrote: > > http://gwt-code-reviews.appspot.com/883802/diff/1/7 > File user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java > (right): > > http://gwt-code-reviews.appspot.com/883802/diff/1/7#newc

[gwt-contrib] Re: Public: First take at GWT validation that actually validates on the client side. (issue863801)

Please take a look now. http://gwt-code-reviews.appspot.com/863801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes Collection of value types and proxies as parameters to RequestFactory methods. Also fixes ... (issue883802)

http://gwt-code-reviews.appspot.com/883802/diff/1/7 File user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java (right): http://gwt-code-reviews.appspot.com/883802/diff/1/7#newcode103 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:103: private String asJsonStrin

[gwt-contrib] Re: Fixing a bug with images used in CellTree, CellBrowser, and IconCellDecorator in browsers that b... (issue912801)

Looks like there's a regression in IconCellDecorator (re. valign) http://gwt-code-reviews.appspot.com/912801/diff/1/2 File user/src/com/google/gwt/cell/client/IconCellDecorator.java (right): http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode53 user/src/com/google/gwt/cell/client/IconCe

Re: [gwt-contrib] Re: RPC vs DeRPC in 2.1

Hi, Sounds fantastic! I hope that it will be easy to use it with something else than SpringRoo on the server side. We are mostly using JAXB/SOAP generated objects on the server side. We have our own conversion code to create GWT compatible DTOs, I guess we can accomodate there to generate the ne