[gwt-contrib] Brings history support to samples/expenses. Doesn't handle paging -- (issue1020801)

2010-10-16 Thread rjrjr
Reviewers: bobv, jlabanca, rice, Description: Brings history support to samples/expenses. Doesn't handle paging -- sorry Chris, out of time -- and doesn't separate widgets from their presenters. But still not a bad clean up, and hey! Book marks! Please review this at

[gwt-contrib] [google-web-toolkit] r9092 committed - Add javadoc to RequestFactory documenting limitations on polymorphism ...

2010-10-16 Thread codesite-noreply
Revision: 9092 Author: cromwell...@google.com Date: Fri Oct 15 21:30:48 2010 Log: Add javadoc to RequestFactory documenting limitations on polymorphism and transferrable types. Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9092 Modified:

[gwt-contrib] Re: Brings history support to samples/expenses. Doesn't handle paging -- (issue1020801)

2010-10-16 Thread Ray Ryan
Could any of the three of you take this review? John or Dan might want to look at http://code.google.com/p/google-web-toolkit/source/detail?r=9091 for context. On Sat, Oct 16, 2010 at 1:39 AM, rj...@google.com wrote: Reviewers: bobv, jlabanca, rice, Description: Brings history support to

[gwt-contrib] Re: Brings history support to samples/expenses. Doesn't handle paging -- (issue1020801)

2010-10-16 Thread jlabanca
LGTM Admittedly I gave it a quick review, but everything looks good. http://gwt-code-reviews.appspot.com/1020801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

2010-10-16 Thread Jeff Chimene
http://www.snopes.com/photos/animals/buffalobill.asp On Fri, Oct 15, 2010 at 7:31 PM, John LaBanca jlaba...@google.com wrote: Thomas - You're blog is awesome, but Sure-footed bighorn sheep take a stroll on the face of the Buffalo Bill

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

2010-10-16 Thread John Tamplin
Ok, I think all the javadoc is updated -- I had to break it into 18 pieces. Sigh. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT 2.1 RC1 javadoc

2010-10-16 Thread Thomas Broyer
On 16 oct, 21:03, John Tamplin j...@google.com wrote: Ok, I think all the javadoc is updated -- I had to break it into 18 pieces.  Sigh. There are still the files for those things that have been moved or removed, e.g.

[gwt-contrib] Make sure redundant calls to an Activity's display setWidget are OK (issue999802)

2010-10-16 Thread t . broyer
Reviewers: rjrjr, Description: See one use-case in point 3 of http://groups.google.fr/group/google-web-toolkit-contributors/msg/af8578d95692aff5 Another use case: edit and details of a proxy is based on the proxy itself (it has an isReadOnly() property, and if it isn't read-only it's always in

[gwt-contrib] Re: Brings history support to samples/expenses. Doesn't handle paging -- (issue1020801)

2010-10-16 Thread rjrjr
r9108 On 2010/10/16 15:37:03, jlabanca wrote: LGTM Admittedly I gave it a quick review, but everything looks good. http://gwt-code-reviews.appspot.com/1020801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors