[gwt-contrib] Re: Public: custom serializer and other code needed to send constraint violations (issue1040802)

2010-10-21 Thread nchalko
On 2010/10/22 00:01:25, Nick Chalko wrote: This broke the build before, because sample build.xml needed to exclude **/super/** All the samples now build. http://gwt-code-reviews.appspot.com/1040802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Public: custom serializer and other code needed to send constraint violations (issue1040802)

2010-10-21 Thread nchalko
Reviewers: bobv, Description: Public: custom serializer and other code needed to send constraint violations from the server to the client. Please review this at http://gwt-code-reviews.appspot.com/1040802/show Affected files: M samples/common.ant.xml M samples/validation/build.xml M sa

[gwt-contrib] Re: For the xpcom plugin, detect if the system linker is GNU gold. If so, try to use compat-ld instead (issue1008801)

2010-10-21 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1008801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: For the xpcom plugin, detect if the system linker is GNU gold. If so, try to use compat-ld instead (issue1008801)

2010-10-21 Thread conroy
http://gwt-code-reviews.appspot.com/1008801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread John LaBanca
Thanks, I missed that. I'm a little confused though. It seems that Composite could just implement RequiresResize without the need for the assertion, since it fails gracefully. I'll talk to Joel about it next week and see if there is a reason why we need the subclass. Thanks, John LaBanca jlaba.

[gwt-contrib] Re: Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread t . broyer
Isn't that duplicating the functionnality of the ResizeComposite? http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/user/client/ui/ResizeComposite.html Should it then be deprecated? At least it should itself implement ResizeComposite, as it would now inherit the behavior from

[gwt-contrib] Adds an -XcompilerMetrics flag to the compiler. This will (issue1045801)

2010-10-21 Thread zundel
Reviewers: jbrosenberg, scottb, Description: Adds an -XcompilerMetrics flag to the compiler. This will create a compilerMetrics.xml file that contains information about the build, such as the list of incoming java classes, the list of types that were generated by the compiler, and details about

[gwt-contrib] Removed unnecessary log message: (issue1046801)

2010-10-21 Thread rchandia
Reviewers: rjrjr, Description: Removed unnecessary log message: WARNING: Record with futureId X not persisted Please review this at http://gwt-code-reviews.appspot.com/1046801/show Affected files: M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java Index: user/src/c

Re: [gwt-contrib] Re: GWT 2.1 MVP with GIN

2010-10-21 Thread David Chandler
Moving this thread to the general GWT forum, where I've written a bit more about it: http://groups.google.com/group/google-web-toolkit/browse_thread/thread/2ed199a42c500156/b54c0c00cd73ed8f#b54c0c00cd73ed8f /dmc On Thu, Oct 21, 2010 at 12:32 PM, Aigeec wrote: > Hey guys, > > Thanks David for yo

Re: [gwt-contrib] First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-10-21 Thread BobV
Pointer to a design doc? What is this used for? -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make the following method public in StackTraceDeobfuscator, for reuse by user server side code: (issue1040801)

2010-10-21 Thread unnurg
LGTM On 2010/10/21 00:38:43, fredsa wrote: http://gwt-code-reviews.appspot.com/1040801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT 2.1 MVP with GIN

2010-10-21 Thread Aigeec
Hey guys, Thanks David for your thoughts on how it could be implemented. Perhaps you could provide an example of using the PlaceHistoryMapperWithFactory. Regards, Aodhagán On Oct 20, 7:02 pm, David wrote: > Why not include Gin in GWT 2.1 ? It could maybe be useful inside the > GWT codebase as

[gwt-contrib] First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-10-21 Thread kjin
Reviewers: jat, scottb, Description: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications Please review this at http://gwt-code-reviews.appspot.com/1043801/show Affected files: M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/

Re: [gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread John LaBanca
The JavaDoc for RequiresResize says that that instanceof check in onResize if the correct way to to it. An instanceof check should be very fast, and almost negligible compared to the cost of actually doing layout. If somebody notices a performance regression, its easy enough to use a boolean, but

Re: [gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread Andi Mullaraj
I want to remark something but mine is more a question than a suggestion: I assume OnResize would have to be quite performant. How expensive is the operator instanceof? Is it worth keeping an instance boolean when the child is initialized and check against it later? Or would that be seen more like

[gwt-contrib] Re: Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread sbrubaker
LGTM http://gwt-code-reviews.appspot.com/1041801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread jlabanca
Reviewers: sbrubaker, Description: Making Composite implement RequiresResize and ProvidesResize so that it can pass resize information to its child widget. This is useful when creating a Composite of a LayoutPanel. In general, a widget should only ProvideResize if its child widget cannot affect

[gwt-contrib] Re: Reformulate RPC generated TypeHandlers to create fewer classes. (issue1037801)

2010-10-21 Thread Scott Blum
Well, I had to pick something that wouldn't conflict with the names of the established static methods. My names are pretty lame. Suggestions? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Reformulate RPC generated TypeHandlers to create fewer classes. (issue1037801)

2010-10-21 Thread zundel
http://gwt-code-reviews.appspot.com/1037801/diff/1/2 File user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java (right): http://gwt-code-reviews.appspot.com/1037801/diff/1/2#newcode91 user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java:91: typeHandler.deserial(stream, ins