Revision: 9130
Author: cromwell...@google.com
Date: Fri Oct 22 02:16:36 2010
Log: GWT 2.1.0 r9127 committed to repo
http://code.google.com/p/google-web-toolkit/source/detail?r=9130
Added:
/2.1.0/gwt/maven/com/google/gwt/gwt/2.1.0
/2.1.0/gwt/maven/com/google/gwt/gwt/2.1.0/gwt-2.1.0.pom
/2.1.0
http://gwt-code-reviews.appspot.com/1045801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The way I was collecting heap stats had too much of an observer effect.
Originally, it doubled the time of compiling a small program (4 GCs
before taking the heap measurement). Even just doing 1 GC before taking
the heap size increased wall clock time by 25%.
I think we need more careful thought
http://gwt-code-reviews.appspot.com/1015801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Added spaces after commas in parameter lists.
Named my TODO's.
Moved EnumOrdinalizer under the isAggressivelyOptimize block, per
zundel's suggestion (and left a TODO to eventually graduate it out of
there).
http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001
File dev/core/src/com/google/g
On 2010/10/21 20:26:04, rchandia wrote:
ping
http://gwt-code-reviews.appspot.com/1046801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1045801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Lgtm
On Oct 22, 2010 6:34 AM, wrote:
> On 2010/10/21 20:26:04, rchandia wrote:
>
> ping
>
>
> http://gwt-code-reviews.appspot.com/1046801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1040802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1045801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Removing third party jars from gwt-servlet.jar.
Please review this at http://gwt-code-reviews.appspot.com/1047802/show
Affected files:
M samples/dynatablerf/build.xml
M samples/validation/build.xml
M servlet/build.xml
Index: samples/dynatablerf/build.xml
Reviewers: rjrjr, rchandia,
Description:
Fix issue 5462 where DynaTableRf explodes when favoriting a new person.
This fix hides the favorite checkbox by default, and shows it if the
person has been persisted. This is a pretty dirty hack, so please review
it to make sure it's not too dirty. The c
http://gwt-code-reviews.appspot.com/1025801/diff/1/7
File
tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode30
tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:30:
import j
LGTM
http://gwt-code-reviews.appspot.com/1043802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
It would be nice if we could have a way to favorite a new Person,
though.
http://gwt-code-reviews.appspot.com/1043802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No argument, but band-aids are the thing to do at code freeze.
Re: making favorite a property of Person, the favorite feature was done the
way it was to exercise other RequestFactory features, so we wouldn't do
that.
On Fri, Oct 22, 2010 at 10:14 AM, wrote:
> LGTM
>
> It would be nice if we co
Thanks for the review.
http://gwt-code-reviews.appspot.com/1025801/diff/1/7
File
tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode96
tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesPro
Reviewers: rice,
Message:
Review requested.
Description:
Reimplement RequestFactory client vs. domain validation using classfile
analysis to support better DevMode refresh semantics.
Patch by: bobv
Review by: rice
Please review this at http://gwt-code-reviews.appspot.com/1049801/show
Affecte
http://gwt-code-reviews.appspot.com/1047802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This patch creates gwt-servlet-deps.jar, which includes validation.jar
and json.jar for now. WebAppCreator includes gwt-servlet-deps.jar in
the libs/ folder and on the classpath unless you specify -maven, in
which case it does not include them.
http://gwt-code-reviews.appspot.com/1047802/show
-
Hi,
the RPC.java has a method public static String
invokeAndEncodeResponse which does catch an InvocationTargetException
and tries to encode the error.
Here a snippet:
catch (InvocationTargetException e) {
// Try to encode the caught exception
//
Throwable cause = e.getCause(
LGTM other than the validation sample.
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002
File samples/validation/build.xml (right):
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode23
samples/validation/build.xml:23:
Shouldn't this use gwt-servlet-deps.jar instead?
h
Validation does client side validation, so we need both sources.
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002
File samples/validation/build.xml (right):
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode23
samples/validation/build.xml:23:
It uses gwt-servlet-deps.
>
>
> http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode25
> samples/validation/build.xml:25: name="hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar"
> />
> GWT user provides super source versions of hibernate validator, which
> the sample uses, so we need the source
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002
File samples/validation/build.xml (right):
http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode23
samples/validation/build.xml:23:
On 2010/10/22 20:08:24, jlabanca wrote:
It uses gwt-servlet-deps.jar, but it also needs so
LGTM
http://gwt-code-reviews.appspot.com/1023801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1025801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The template for all samples, project.ant.xmlsrc, has a target "libs"
that copies gwt-servlet.jar and gwt-servlet-deps.jar into WEB-INF/libs
directory. gwt-servlet-deps.jar sits next to gwt-servlet.jar in the
distributable. The "eclipse.generate" target, which invokes
WebAppCreator, then adds a
On 2010/10/22 20:28:48, jlabanca wrote:
The template for all samples, project.ant.xmlsrc, has a target "libs"
that
copies gwt-servlet.jar and gwt-servlet-deps.jar into WEB-INF/libs
directory.
gwt-servlet-deps.jar sits next to gwt-servlet.jar in the
distributable. The
"eclipse.generate" ta
LGTM
http://gwt-code-reviews.appspot.com/1049801/diff/2001/3007
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):
http://gwt-code-reviews.appspot.com/1049801/diff/2001/3007#newcode163
user/src/com/google/gwt/requestfactory/server/RequestFactoryInt
My JDK says:
*Throwable java.lang.reflect.InvocationTargetException.getTargetException()*
Get the thrown target exception.
This method predates the general-purpose exception chaining facility. The
Throwable.getCause() method is now the preferred means of obtaining this
information.
Returns:
Reviewers: bobv, cromwellian,
Description:
Lock down the public api of com.google.gwt.requestfactory.server, in
anticipation of most of it being killed in 2.1.1
Please review this at http://gwt-code-reviews.appspot.com/1051801/show
Affected files:
M
user/src/com/google/gwt/requestfactory/s
Some thoughts.
http://gwt-code-reviews.appspot.com/1045801/diff/11001/12001
File
dev/core/src/com/google/gwt/core/ext/linker/CompilationMetricsArtifact.java
(right):
http://gwt-code-reviews.appspot.com/1045801/diff/11001/12001#newcode89
dev/core/src/com/google/gwt/core/ext/linker/CompilationMet
LGTM
Scott ran a few tests on a large code base which eliminated about 30
seconds off of a compile that ran for about 15 minutes or so.
http://gwt-code-reviews.appspot.com/1037801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: unnurg,
Description:
Public: Add the hibernate validator jor to the dev build.
Please review this at http://gwt-code-reviews.appspot.com/1052801/show
Affected files:
M dev/build.xml
Index: dev/build.xml
===
--- dev/
On 2010/10/23 04:12:45, Nick Chalko wrote:
This fixed the build breakage.
The test are still running on my machine. I wont submit until they
finish and pass.
http://gwt-code-reviews.appspot.com/1052801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
36 matches
Mail list logo
